[SM-244] Resolve dotnet warnings (#2283)

src/Api/Models/Request/Accounts/KdfRequestModel.cs

@@ -10,7 +10,7 @@ public class KdfRequestModel : PasswordRequestModel, IValidatableObject
     [Required]
     public int? KdfIterations { get; set; }
 
-    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
+    public override IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
     {
         if (Kdf.HasValue && KdfIterations.HasValue)
         {

src/Api/Models/Request/TwoFactorRequestModels.cs

@@ -102,7 +102,7 @@ public class UpdateTwoFactorDuoRequestModel : SecretVerificationRequestModel, IV
         return extistingOrg;
     }
 
-    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
+    public override IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
     {
         if (!Core.Utilities.Duo.DuoApi.ValidHost(Host))
         {
@@ -160,7 +160,7 @@ public class UpdateTwoFactorYubicoOtpRequestModel : SecretVerificationRequestMod
         return keyValue.Substring(0, 12);
     }
 
-    public IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
+    public override IEnumerable<ValidationResult> Validate(ValidationContext validationContext)
     {
         if (string.IsNullOrWhiteSpace(Key1) && string.IsNullOrWhiteSpace(Key2) && string.IsNullOrWhiteSpace(Key3) &&
             string.IsNullOrWhiteSpace(Key4) && string.IsNullOrWhiteSpace(Key5))

src/Core/Tokens/DataProtectorTokenFactory.cs

@@ -23,7 +23,6 @@ public class DataProtectorTokenFactory<T> : IDataProtectorTokenFactory<T> where
     /// Unprotect token
     /// </summary>
     /// <param name="token">The token to parse</param>
-    /// <typeparam name="T">The tokenable type to parse to</typeparam>
     /// <returns>The parsed tokenable</returns>
     /// <exception>Throws CryptographicException if fails to unprotect</exception>
     public T Unprotect(string token) =>

src/Core/Utilities/CoreHelpers.cs

@@ -27,7 +27,6 @@ public static class CoreHelpers
     private static readonly DateTime _epoc = new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc);
     private static readonly DateTime _max = new DateTime(9999, 1, 1, 0, 0, 0, DateTimeKind.Utc);
     private static readonly Random _random = new Random();
-    private static string _version;
     private static readonly string CloudFlareConnectingIp = "CF-Connecting-IP";
     private static readonly string RealIp = "X-Real-IP";
 

src/Core/Utilities/StrictEmailAddressAttribute.cs

@@ -31,16 +31,14 @@ public class StrictEmailAddressAttribute : ValidationAttribute
             return false;
         }
 
-        /**
+        // The regex below is intended to catch edge cases that are not handled by the general parsing check above.
-        The regex below is intended to catch edge cases that are not handled by the general parsing check above.
+        // This enforces the following rules:
-        This enforces the following rules:
+        // * Requires ASCII only in the local-part (code points 0-127)
-        * Requires ASCII only in the local-part (code points 0-127)
+        // * Requires an @ symbol
-        * Requires an @ symbol
+        // * Allows any char in second-level domain name, including unicode and symbols
-        * Allows any char in second-level domain name, including unicode and symbols
+        // * Requires at least one period (.) separating SLD from TLD
-        * Requires at least one period (.) separating SLD from TLD
+        // * Must end in a letter (including unicode)
-        * Must end in a letter (including unicode)
+        // See the unit tests for examples of what is allowed.
-        See the unit tests for examples of what is allowed.
-        **/
         var emailFormat = @"^[\x00-\x7F]+@.+\.\p{L}+$";
         if (!Regex.IsMatch(emailAddress, emailFormat))
         {

test/Api.IntegrationTest/Controllers/AccountsControllerTests.cs

@@ -25,7 +25,7 @@ public class AccountsControllerTest : IClassFixture<ApiApplicationFactory>
 
         var content = await response.Content.ReadFromJsonAsync<ProfileResponseModel>();
 
-        Assert.NotEmpty(content.Id);
+        Assert.NotEmpty(content!.Id);
         Assert.Equal("integration-test@bitwarden.com", content.Email);
         Assert.Null(content.Name);
         Assert.False(content.EmailVerified);

test/Billing.Test/Controllers/FreshdeskControllerTests.cs

@@ -71,7 +71,7 @@ public class FreshdeskControllerTests
             return Send(request, cancellationToken);
         }
 
-        public virtual Task<HttpResponseMessage> Send(HttpRequestMessage request, CancellationToken cancellationToken)
+        public new virtual Task<HttpResponseMessage> Send(HttpRequestMessage request, CancellationToken cancellationToken)
         {
             throw new NotImplementedException();
         }

test/Infrastructure.EFIntegration.Test/Repositories/CipherRepositoryTests.cs

@@ -24,14 +24,14 @@ public class CipherRepositoryTests
     }
 
     [CiSkippedTheory, EfUserCipherCustomize, BitAutoData]
-    public async void UserCipher_CreateAsync_Works_DataMatches(Cipher cipher, User user, Organization org,
+    public void UserCipher_CreateAsync_Works_DataMatches(Cipher cipher, User user, Organization org,
         CipherCompare equalityComparer, List<EfRepo.CipherRepository> suts, List<EfRepo.UserRepository> efUserRepos,
         List<EfRepo.OrganizationRepository> efOrgRepos, SqlRepo.CipherRepository sqlCipherRepo,
         SqlRepo.UserRepository sqlUserRepo, SqlRepo.OrganizationRepository sqlOrgRepo) => CreateAsync_Works_DataMatches(
             cipher, user, org, equalityComparer, suts, efUserRepos, efOrgRepos, sqlCipherRepo, sqlUserRepo, sqlOrgRepo);
 
     [CiSkippedTheory, EfOrganizationCipherCustomize, BitAutoData]
-    public async void OrganizationCipher_CreateAsync_Works_DataMatches(Cipher cipher, User user, Organization org,
+    public void OrganizationCipher_CreateAsync_Works_DataMatches(Cipher cipher, User user, Organization org,
         CipherCompare equalityComparer, List<EfRepo.CipherRepository> suts, List<EfRepo.UserRepository> efUserRepos,
         List<EfRepo.OrganizationRepository> efOrgRepos, SqlRepo.CipherRepository sqlCipherRepo,
         SqlRepo.UserRepository sqlUserRepo, SqlRepo.OrganizationRepository sqlOrgRepo) => CreateAsync_Works_DataMatches(
@@ -177,7 +177,7 @@ public class CipherRepositoryTests
         List<EfRepo.OrganizationRepository> efOrgRepos
             ) => await DeleteAsync_CipherIsDeleted(cipher, user, org, suts, efUserRepos, efOrgRepos);
     [CiSkippedTheory, EfOrganizationCipherCustomize, BitAutoData]
-    public async Task OrganizationCipher_DeleteAsync_CipherIsDeleted(
+    public Task OrganizationCipher_DeleteAsync_CipherIsDeleted(
         Cipher cipher,
         User user,
         Organization org,