From 0df2910ef72da4a8144d648fc293ecded4cd19fb Mon Sep 17 00:00:00 2001
From: Rui Tome <rtome@bitwarden.com>
Date: Fri, 22 Sep 2023 16:16:20 +0100
Subject: [PATCH] =?UTF-8?q?[AC-1637]=C2=A0Moved=20expected=20values=20on?=
 =?UTF-8?q?=20unit=20tests=20to=20the=20arrange=20phase?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../Utilities/HtmlEncodingStringConverterTests.cs    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/Core.Test/Utilities/HtmlEncodingStringConverterTests.cs b/test/Core.Test/Utilities/HtmlEncodingStringConverterTests.cs
index 0d0cffb79d..88d3ddd49e 100644
--- a/test/Core.Test/Utilities/HtmlEncodingStringConverterTests.cs
+++ b/test/Core.Test/Utilities/HtmlEncodingStringConverterTests.cs
@@ -16,6 +16,7 @@ public class HtmlEncodingStringConverterTests
             EncodedValue = "This is &lt;b&gt;bold&lt;/b&gt;",
             NonEncodedValue = "This is <b>bold</b>"
         };
+        const string expectedJsonString = "{\"EncodedValue\":\"This is <b>bold</b>\",\"NonEncodedValue\":\"This is <b>bold</b>\"}";
 
         // This is necessary to prevent the serializer from double encoding the string
         var serializerOptions = new JsonSerializerOptions
@@ -27,8 +28,7 @@ public class HtmlEncodingStringConverterTests
         var jsonString = JsonSerializer.Serialize(obj, serializerOptions);
 
         // Assert
-        const string expected = "{\"EncodedValue\":\"This is <b>bold</b>\",\"NonEncodedValue\":\"This is <b>bold</b>\"}";
-        Assert.Equal(expected, jsonString);
+        Assert.Equal(expectedJsonString, jsonString);
     }
 
     [Fact]
@@ -40,13 +40,13 @@ public class HtmlEncodingStringConverterTests
             EncodedValue = null,
             NonEncodedValue = null
         };
+        const string expectedJsonString = "{\"EncodedValue\":null,\"NonEncodedValue\":null}";
 
         // Act
         var jsonString = JsonSerializer.Serialize(obj);
 
         // Assert
-        const string expected = "{\"EncodedValue\":null,\"NonEncodedValue\":null}";
-        Assert.Equal(expected, jsonString);
+        Assert.Equal(expectedJsonString, jsonString);
     }
 
     [Fact]
@@ -54,13 +54,13 @@ public class HtmlEncodingStringConverterTests
     {
         // Arrange
         const string json = "{\"EncodedValue\":\"This is <b>bold</b>\",\"NonEncodedValue\":\"This is <b>bold</b>\"}";
+        const string expectedEncodedValue = "This is &lt;b&gt;bold&lt;/b&gt;";
+        const string expectedNonEncodedValue = "This is <b>bold</b>";
 
         // Act
         var obj = JsonSerializer.Deserialize<HtmlEncodedString>(json);
 
         // Assert
-        const string expectedEncodedValue = "This is &lt;b&gt;bold&lt;/b&gt;";
-        const string expectedNonEncodedValue = "This is <b>bold</b>";
         Assert.Equal(expectedEncodedValue, obj.EncodedValue);
         Assert.Equal(expectedNonEncodedValue, obj.NonEncodedValue);
     }