nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-01 08:02:49 -05:00
Code Activity

permission checks for cipher crud operations

Browse Source
This commit is contained in:
Kyle Spearrin
2017-03-24 09:27:15 -04:00
parent 0dae19bd4f
commit 10c72fafda
10 changed files with 78 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Api/Controllers/CiphersController.cs
View File

@ -127,7 +127,7 @@ namespace Bit.Api.Controllers
throw new NotFoundException();
}
await _cipherService.DeleteAsync(cipher);
await _cipherService.DeleteAsync(cipher, userId);
}
}
}

9
src/Api/Controllers/LoginsController.cs
View File

@ -59,7 +59,7 @@ namespace Bit.Api.Controllers
{
var userId = _userService.GetProperUserId(User).Value;
var login = model.ToCipherDetails(userId);
await _cipherService.SaveAsync(login);
await _cipherService.SaveAsync(login, userId);
var response = new LoginResponseModel(login);
return response;
@ -76,7 +76,7 @@ namespace Bit.Api.Controllers
throw new NotFoundException();
}
await _cipherService.SaveAsync(model.ToCipherDetails(login));
await _cipherService.SaveAsync(model.ToCipherDetails(login), userId);
var response = new LoginResponseModel(login);
return response;
@ -86,13 +86,14 @@ namespace Bit.Api.Controllers
[HttpPost("{id}/delete")]
public async Task Delete(string id)
{
var login = await _cipherRepository.GetByIdAsync(new Guid(id), _userService.GetProperUserId(User).Value);
var userId = _userService.GetProperUserId(User).Value;
var login = await _cipherRepository.GetByIdAsync(new Guid(id), userId);
if(login == null || login.Type != Core.Enums.CipherType.Login)
{
throw new NotFoundException();
}
await _cipherService.DeleteAsync(login);
await _cipherService.DeleteAsync(login, userId);
}
}
}