From 10fcff58b223a6b78c85bc9974e732f9de7694ac Mon Sep 17 00:00:00 2001 From: Graham Walker Date: Tue, 6 May 2025 03:48:40 -0500 Subject: [PATCH] PM-19715 & PM-19712 Move Files to DIRT ownership on Server (#5769) * PM-19715 PM-19711 moving reports to dirt directory and adding dirt as codeowners * PM-19715 creating two sub folders for reports and events * PM-19714 changing dirt paths for codeowners * PM-19714 fixing codeowners file * PM-19714 fixing codeowners * PM-19714 moving hibpController to dirt ownership * PM-19715 moving controller --- .github/CODEOWNERS | 8 ++++++++ src/Api/{Tools => Dirt}/Controllers/HibpController.cs | 0 src/Api/{Tools => Dirt}/Controllers/ReportsController.cs | 0 .../Models/PasswordHealthReportApplicationModel.cs | 0 .../Models/Response/MemberAccessReportModel.cs | 0 .../Models/Response/MemberCipherDetailsResponseModel.cs | 0 .../Reports}/Entities/PasswordHealthReportApplication.cs | 0 .../Reports}/Models/Data/MemberAccessCipherDetails.cs | 0 .../AddPasswordHealthReportApplicationCommand.cs | 0 .../DropPasswordHealthReportApplicationCommand.cs | 0 .../GetPasswordHealthReportApplicationQuery.cs | 0 .../IAddPasswordHealthReportApplicationCommand.cs | 0 .../IDropPasswordHealthReportApplicationCommand.cs | 0 .../IGetPasswordHealthReportApplicationQuery.cs | 0 .../ReportFeatures/MemberAccessCipherDetailsQuery.cs | 0 .../Interfaces/IMemberAccessCipherDetailsQuery.cs | 0 .../ReportingServiceCollectionExtensions.cs | 0 .../Requests/AddPasswordHealthReportApplicationRequest.cs | 0 .../DropPasswordHealthReportApplicationRequest.cs | 0 .../Requests/MemberAccessCipherDetailsRequest.cs | 0 .../IPasswordHealthReportApplicationRepository.cs | 0 .../PasswordHealthReportApplicationRepository.cs | 0 .../{Tools/Controllers => Dirt}/ReportsControllerTests.cs | 0 .../AddPasswordHealthReportApplicationCommandTests.cs | 0 .../DeletePasswordHealthReportApplicationCommandTests.cs | 0 .../GetPasswordHealthReportApplicationQueryTests.cs | 0 26 files changed, 8 insertions(+) rename src/Api/{Tools => Dirt}/Controllers/HibpController.cs (100%) rename src/Api/{Tools => Dirt}/Controllers/ReportsController.cs (100%) rename src/Api/{Tools => Dirt}/Models/PasswordHealthReportApplicationModel.cs (100%) rename src/Api/{Tools => Dirt}/Models/Response/MemberAccessReportModel.cs (100%) rename src/Api/{Tools => Dirt}/Models/Response/MemberCipherDetailsResponseModel.cs (100%) rename src/Core/{Tools => Dirt/Reports}/Entities/PasswordHealthReportApplication.cs (100%) rename src/Core/{Tools => Dirt/Reports}/Models/Data/MemberAccessCipherDetails.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/AddPasswordHealthReportApplicationCommand.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/DropPasswordHealthReportApplicationCommand.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/GetPasswordHealthReportApplicationQuery.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Interfaces/IAddPasswordHealthReportApplicationCommand.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Interfaces/IDropPasswordHealthReportApplicationCommand.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Interfaces/IGetPasswordHealthReportApplicationQuery.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/MemberAccessCipherDetailsQuery.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/OrganizationReportMembers/Interfaces/IMemberAccessCipherDetailsQuery.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/ReportingServiceCollectionExtensions.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Requests/AddPasswordHealthReportApplicationRequest.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Requests/DropPasswordHealthReportApplicationRequest.cs (100%) rename src/Core/{Tools => Dirt/Reports}/ReportFeatures/Requests/MemberAccessCipherDetailsRequest.cs (100%) rename src/Core/{Tools => Dirt/Reports}/Repositories/IPasswordHealthReportApplicationRepository.cs (100%) rename src/Infrastructure.Dapper/{Tools/Repositories => Dirt}/PasswordHealthReportApplicationRepository.cs (100%) rename test/Api.Test/{Tools/Controllers => Dirt}/ReportsControllerTests.cs (100%) rename test/Core.Test/{Tools => Dirt}/ReportFeatures/AddPasswordHealthReportApplicationCommandTests.cs (100%) rename test/Core.Test/{Tools => Dirt}/ReportFeatures/DeletePasswordHealthReportApplicationCommandTests.cs (100%) rename test/Core.Test/{Tools => Dirt}/ReportFeatures/GetPasswordHealthReportApplicationQueryTests.cs (100%) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 973405dea5..9f3048a340 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -43,8 +43,16 @@ src/Core/IdentityServer @bitwarden/team-auth-dev # Key Management team **/KeyManagement @bitwarden/team-key-management-dev +# Tools team **/Tools @bitwarden/team-tools-dev +# Dirt (Data Insights & Reporting) team +src/Api/Controllers/Dirt @bitwarden/team-data-insights-and-reporting-dev +src/Core/Dirt @bitwarden/team-data-insights-and-reporting-dev +src/Infrastructure.Dapper/Dirt @bitwarden/team-data-insights-and-reporting-dev +test/Api.Test/Dirt @bitwarden/team-data-insights-and-reporting-dev +test/Core.Test/Dirt @bitwarden/team-data-insights-and-reporting-dev + # Vault team **/Vault @bitwarden/team-vault-dev **/Vault/AuthorizationHandlers @bitwarden/team-vault-dev @bitwarden/team-admin-console-dev # joint ownership over authorization handlers that affect organization users diff --git a/src/Api/Tools/Controllers/HibpController.cs b/src/Api/Dirt/Controllers/HibpController.cs similarity index 100% rename from src/Api/Tools/Controllers/HibpController.cs rename to src/Api/Dirt/Controllers/HibpController.cs diff --git a/src/Api/Tools/Controllers/ReportsController.cs b/src/Api/Dirt/Controllers/ReportsController.cs similarity index 100% rename from src/Api/Tools/Controllers/ReportsController.cs rename to src/Api/Dirt/Controllers/ReportsController.cs diff --git a/src/Api/Tools/Models/PasswordHealthReportApplicationModel.cs b/src/Api/Dirt/Models/PasswordHealthReportApplicationModel.cs similarity index 100% rename from src/Api/Tools/Models/PasswordHealthReportApplicationModel.cs rename to src/Api/Dirt/Models/PasswordHealthReportApplicationModel.cs diff --git a/src/Api/Tools/Models/Response/MemberAccessReportModel.cs b/src/Api/Dirt/Models/Response/MemberAccessReportModel.cs similarity index 100% rename from src/Api/Tools/Models/Response/MemberAccessReportModel.cs rename to src/Api/Dirt/Models/Response/MemberAccessReportModel.cs diff --git a/src/Api/Tools/Models/Response/MemberCipherDetailsResponseModel.cs b/src/Api/Dirt/Models/Response/MemberCipherDetailsResponseModel.cs similarity index 100% rename from src/Api/Tools/Models/Response/MemberCipherDetailsResponseModel.cs rename to src/Api/Dirt/Models/Response/MemberCipherDetailsResponseModel.cs diff --git a/src/Core/Tools/Entities/PasswordHealthReportApplication.cs b/src/Core/Dirt/Reports/Entities/PasswordHealthReportApplication.cs similarity index 100% rename from src/Core/Tools/Entities/PasswordHealthReportApplication.cs rename to src/Core/Dirt/Reports/Entities/PasswordHealthReportApplication.cs diff --git a/src/Core/Tools/Models/Data/MemberAccessCipherDetails.cs b/src/Core/Dirt/Reports/Models/Data/MemberAccessCipherDetails.cs similarity index 100% rename from src/Core/Tools/Models/Data/MemberAccessCipherDetails.cs rename to src/Core/Dirt/Reports/Models/Data/MemberAccessCipherDetails.cs diff --git a/src/Core/Tools/ReportFeatures/AddPasswordHealthReportApplicationCommand.cs b/src/Core/Dirt/Reports/ReportFeatures/AddPasswordHealthReportApplicationCommand.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/AddPasswordHealthReportApplicationCommand.cs rename to src/Core/Dirt/Reports/ReportFeatures/AddPasswordHealthReportApplicationCommand.cs diff --git a/src/Core/Tools/ReportFeatures/DropPasswordHealthReportApplicationCommand.cs b/src/Core/Dirt/Reports/ReportFeatures/DropPasswordHealthReportApplicationCommand.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/DropPasswordHealthReportApplicationCommand.cs rename to src/Core/Dirt/Reports/ReportFeatures/DropPasswordHealthReportApplicationCommand.cs diff --git a/src/Core/Tools/ReportFeatures/GetPasswordHealthReportApplicationQuery.cs b/src/Core/Dirt/Reports/ReportFeatures/GetPasswordHealthReportApplicationQuery.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/GetPasswordHealthReportApplicationQuery.cs rename to src/Core/Dirt/Reports/ReportFeatures/GetPasswordHealthReportApplicationQuery.cs diff --git a/src/Core/Tools/ReportFeatures/Interfaces/IAddPasswordHealthReportApplicationCommand.cs b/src/Core/Dirt/Reports/ReportFeatures/Interfaces/IAddPasswordHealthReportApplicationCommand.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Interfaces/IAddPasswordHealthReportApplicationCommand.cs rename to src/Core/Dirt/Reports/ReportFeatures/Interfaces/IAddPasswordHealthReportApplicationCommand.cs diff --git a/src/Core/Tools/ReportFeatures/Interfaces/IDropPasswordHealthReportApplicationCommand.cs b/src/Core/Dirt/Reports/ReportFeatures/Interfaces/IDropPasswordHealthReportApplicationCommand.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Interfaces/IDropPasswordHealthReportApplicationCommand.cs rename to src/Core/Dirt/Reports/ReportFeatures/Interfaces/IDropPasswordHealthReportApplicationCommand.cs diff --git a/src/Core/Tools/ReportFeatures/Interfaces/IGetPasswordHealthReportApplicationQuery.cs b/src/Core/Dirt/Reports/ReportFeatures/Interfaces/IGetPasswordHealthReportApplicationQuery.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Interfaces/IGetPasswordHealthReportApplicationQuery.cs rename to src/Core/Dirt/Reports/ReportFeatures/Interfaces/IGetPasswordHealthReportApplicationQuery.cs diff --git a/src/Core/Tools/ReportFeatures/MemberAccessCipherDetailsQuery.cs b/src/Core/Dirt/Reports/ReportFeatures/MemberAccessCipherDetailsQuery.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/MemberAccessCipherDetailsQuery.cs rename to src/Core/Dirt/Reports/ReportFeatures/MemberAccessCipherDetailsQuery.cs diff --git a/src/Core/Tools/ReportFeatures/OrganizationReportMembers/Interfaces/IMemberAccessCipherDetailsQuery.cs b/src/Core/Dirt/Reports/ReportFeatures/OrganizationReportMembers/Interfaces/IMemberAccessCipherDetailsQuery.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/OrganizationReportMembers/Interfaces/IMemberAccessCipherDetailsQuery.cs rename to src/Core/Dirt/Reports/ReportFeatures/OrganizationReportMembers/Interfaces/IMemberAccessCipherDetailsQuery.cs diff --git a/src/Core/Tools/ReportFeatures/ReportingServiceCollectionExtensions.cs b/src/Core/Dirt/Reports/ReportFeatures/ReportingServiceCollectionExtensions.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/ReportingServiceCollectionExtensions.cs rename to src/Core/Dirt/Reports/ReportFeatures/ReportingServiceCollectionExtensions.cs diff --git a/src/Core/Tools/ReportFeatures/Requests/AddPasswordHealthReportApplicationRequest.cs b/src/Core/Dirt/Reports/ReportFeatures/Requests/AddPasswordHealthReportApplicationRequest.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Requests/AddPasswordHealthReportApplicationRequest.cs rename to src/Core/Dirt/Reports/ReportFeatures/Requests/AddPasswordHealthReportApplicationRequest.cs diff --git a/src/Core/Tools/ReportFeatures/Requests/DropPasswordHealthReportApplicationRequest.cs b/src/Core/Dirt/Reports/ReportFeatures/Requests/DropPasswordHealthReportApplicationRequest.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Requests/DropPasswordHealthReportApplicationRequest.cs rename to src/Core/Dirt/Reports/ReportFeatures/Requests/DropPasswordHealthReportApplicationRequest.cs diff --git a/src/Core/Tools/ReportFeatures/Requests/MemberAccessCipherDetailsRequest.cs b/src/Core/Dirt/Reports/ReportFeatures/Requests/MemberAccessCipherDetailsRequest.cs similarity index 100% rename from src/Core/Tools/ReportFeatures/Requests/MemberAccessCipherDetailsRequest.cs rename to src/Core/Dirt/Reports/ReportFeatures/Requests/MemberAccessCipherDetailsRequest.cs diff --git a/src/Core/Tools/Repositories/IPasswordHealthReportApplicationRepository.cs b/src/Core/Dirt/Reports/Repositories/IPasswordHealthReportApplicationRepository.cs similarity index 100% rename from src/Core/Tools/Repositories/IPasswordHealthReportApplicationRepository.cs rename to src/Core/Dirt/Reports/Repositories/IPasswordHealthReportApplicationRepository.cs diff --git a/src/Infrastructure.Dapper/Tools/Repositories/PasswordHealthReportApplicationRepository.cs b/src/Infrastructure.Dapper/Dirt/PasswordHealthReportApplicationRepository.cs similarity index 100% rename from src/Infrastructure.Dapper/Tools/Repositories/PasswordHealthReportApplicationRepository.cs rename to src/Infrastructure.Dapper/Dirt/PasswordHealthReportApplicationRepository.cs diff --git a/test/Api.Test/Tools/Controllers/ReportsControllerTests.cs b/test/Api.Test/Dirt/ReportsControllerTests.cs similarity index 100% rename from test/Api.Test/Tools/Controllers/ReportsControllerTests.cs rename to test/Api.Test/Dirt/ReportsControllerTests.cs diff --git a/test/Core.Test/Tools/ReportFeatures/AddPasswordHealthReportApplicationCommandTests.cs b/test/Core.Test/Dirt/ReportFeatures/AddPasswordHealthReportApplicationCommandTests.cs similarity index 100% rename from test/Core.Test/Tools/ReportFeatures/AddPasswordHealthReportApplicationCommandTests.cs rename to test/Core.Test/Dirt/ReportFeatures/AddPasswordHealthReportApplicationCommandTests.cs diff --git a/test/Core.Test/Tools/ReportFeatures/DeletePasswordHealthReportApplicationCommandTests.cs b/test/Core.Test/Dirt/ReportFeatures/DeletePasswordHealthReportApplicationCommandTests.cs similarity index 100% rename from test/Core.Test/Tools/ReportFeatures/DeletePasswordHealthReportApplicationCommandTests.cs rename to test/Core.Test/Dirt/ReportFeatures/DeletePasswordHealthReportApplicationCommandTests.cs diff --git a/test/Core.Test/Tools/ReportFeatures/GetPasswordHealthReportApplicationQueryTests.cs b/test/Core.Test/Dirt/ReportFeatures/GetPasswordHealthReportApplicationQueryTests.cs similarity index 100% rename from test/Core.Test/Tools/ReportFeatures/GetPasswordHealthReportApplicationQueryTests.cs rename to test/Core.Test/Dirt/ReportFeatures/GetPasswordHealthReportApplicationQueryTests.cs