From 13ad872f51a14ba5740f5524e2d04a19e6610b5c Mon Sep 17 00:00:00 2001
From: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Date: Tue, 27 Aug 2024 19:05:34 -0400
Subject: [PATCH] Resolve Vault and DB Warnings (#4646)

* Resolve Vault Warnings

* Resolve DB Warnings
---
 .../Collections/BulkCollectionAuthorizationHandler.cs      | 7 +++++++
 .../Models/Response/OptionalCipherDetailsResponseModel.cs  | 2 ++
 .../Migrations/20221212154007_initial.Designer.cs          | 2 ++
 util/SqliteMigrations/Migrations/20221212154007_initial.cs | 2 ++
 4 files changed, 13 insertions(+)

diff --git a/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs b/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
index add5b75a32..5d11b39ead 100644
--- a/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
+++ b/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
@@ -1,4 +1,5 @@
 #nullable enable
+using System.Diagnostics;
 using Bit.Core.Context;
 using Bit.Core.Entities;
 using Bit.Core.Enums;
@@ -98,6 +99,12 @@ public class BulkCollectionAuthorizationHandler : BulkAuthorizationHandler<BulkC
             case not null when requirement == BulkCollectionOperations.Delete:
                 authorized = await CanDeleteAsync(resources, org);
                 break;
+
+            case null:
+                // requirement isn't actually nullable but since we use the 
+                // not null when trick it makes the compiler think that requirement
+                // could actually be nullable.
+                throw new UnreachableException();
         }
 
         if (authorized)
diff --git a/src/Api/Vault/Models/Response/OptionalCipherDetailsResponseModel.cs b/src/Api/Vault/Models/Response/OptionalCipherDetailsResponseModel.cs
index 018185e04f..e610dd7dbc 100644
--- a/src/Api/Vault/Models/Response/OptionalCipherDetailsResponseModel.cs
+++ b/src/Api/Vault/Models/Response/OptionalCipherDetailsResponseModel.cs
@@ -1,6 +1,8 @@
 using Bit.Api.Vault.Models.Response;
 using Bit.Core.Models.Api;
 
+#nullable enable
+
 public class OptionalCipherDetailsResponseModel : ResponseModel
 {
     public bool Unavailable { get; set; }
diff --git a/util/SqliteMigrations/Migrations/20221212154007_initial.Designer.cs b/util/SqliteMigrations/Migrations/20221212154007_initial.Designer.cs
index 7419fbf408..108905bc86 100644
--- a/util/SqliteMigrations/Migrations/20221212154007_initial.Designer.cs
+++ b/util/SqliteMigrations/Migrations/20221212154007_initial.Designer.cs
@@ -12,7 +12,9 @@ namespace Bit.SqliteMigrations.Migrations
 {
     [DbContext(typeof(DatabaseContext))]
     [Migration("20221212154007_initial")]
+    #pragma warning disable CS8981 // We unfortunately can't rename migrations
     partial class initial
+    #pragma warning restore CS8981
     {
         protected override void BuildTargetModel(ModelBuilder modelBuilder)
         {
diff --git a/util/SqliteMigrations/Migrations/20221212154007_initial.cs b/util/SqliteMigrations/Migrations/20221212154007_initial.cs
index efb2d154e5..aa87bb8731 100644
--- a/util/SqliteMigrations/Migrations/20221212154007_initial.cs
+++ b/util/SqliteMigrations/Migrations/20221212154007_initial.cs
@@ -4,7 +4,9 @@
 
 namespace Bit.SqliteMigrations.Migrations;
 
+#pragma warning disable CS8981 // We unfortunately can't rename migrations
 public partial class initial : Migration
+#pragma warning restore CS8981
 {
     protected override void Up(MigrationBuilder migrationBuilder)
     {