Allow Resending Provider Setup Emails From The Admin Portal (#1497)

* Added a button for resending provider setup emails

* Fixed a case typo in a stored procedure

* Turned a couple lines of code into a method call

* Added service level validation against inviting users for MSP invites

* Code review improvements for provider invites

created a factory for provider user invites

wrote tests for provider invite permissions"

* changed a few exception types

src/Core/Models/Business/Provider/ProviderUserInvite.cs

@@ -1,19 +1,39 @@
+using System;
 using System.Collections.Generic;
 using Bit.Core.Enums.Provider;
 using Bit.Core.Models.Api;
-using Bit.Core.Models.Data;
 
 namespace Bit.Core.Models.Business.Provider
 {
-    public class ProviderUserInvite
+    public class ProviderUserInvite<T>
     {
-        public IEnumerable<string> Emails { get; set; }
+        public IEnumerable<T> UserIdentifiers { get; set; }
         public ProviderUserType Type { get; set; }
+        public Guid InvitingUserId { get; set; }
+        public Guid ProviderId { get; set; }
+    }
 
-        public ProviderUserInvite(ProviderUserInviteRequestModel requestModel)
+    public static class ProviderUserInviteFactory
+    {
+        public static ProviderUserInvite<string> CreateIntialInvite(IEnumerable<string> inviteeEmails, ProviderUserType type, Guid invitingUserId, Guid providerId)
         {
-            Emails = requestModel.Emails;
-            Type = requestModel.Type.Value;
+            return new ProviderUserInvite<string>
+            {
+                UserIdentifiers = inviteeEmails,
+                Type = type,
+                InvitingUserId = invitingUserId,
+                ProviderId = providerId
+            };
+        }
+
+        public static ProviderUserInvite<Guid> CreateReinvite(IEnumerable<Guid> inviteeUserIds, Guid invitingUserId, Guid providerId)
+        {
+            return new ProviderUserInvite<Guid>
+            {
+                UserIdentifiers = inviteeUserIds,
+                InvitingUserId = invitingUserId,
+                ProviderId = providerId
+            };
         }
     }
 }

src/Core/Services/IProviderService.cs

@@ -14,9 +14,8 @@ namespace Bit.Core.Services
         Task<Provider> CompleteSetupAsync(Provider provider, Guid ownerUserId, string token, string key);
         Task UpdateAsync(Provider provider, bool updateBilling = false);
 
-        Task<List<ProviderUser>> InviteUserAsync(Guid providerId, Guid invitingUserId, ProviderUserInvite providerUserInvite);
-        Task<List<Tuple<ProviderUser, string>>> ResendInvitesAsync(Guid providerId, Guid invitingUserId,
-            IEnumerable<Guid> providerUsersId);
+        Task<List<ProviderUser>> InviteUserAsync(ProviderUserInvite<string> invite);
+        Task<List<Tuple<ProviderUser, string>>> ResendInvitesAsync(ProviderUserInvite<Guid> invite);
         Task<ProviderUser> AcceptUserAsync(Guid providerUserId, User user, string token);
         Task<List<Tuple<ProviderUser, string>>> ConfirmUsersAsync(Guid providerId, Dictionary<Guid, string> keys, Guid confirmingUserId);
 
@@ -29,5 +28,7 @@ namespace Bit.Core.Services
             string clientOwnerEmail, User user);
         Task RemoveOrganizationAsync(Guid providerId, Guid providerOrganizationId, Guid removingUserId);
         Task LogProviderAccessToOrganizationAsync(Guid organizationId);
+        Task ResendProviderSetupInviteEmailAsync(Guid providerId, Guid ownerId);
     }
 }
+

src/Core/Services/NoopImplementations/NoopProviderService.cs

@@ -16,9 +16,9 @@ namespace Bit.Core.Services
 
         public Task UpdateAsync(Provider provider, bool updateBilling = false) => throw new NotImplementedException();
 
-        public Task<List<ProviderUser>> InviteUserAsync(Guid providerId, Guid invitingUserId, ProviderUserInvite providerUserInvite) => throw new NotImplementedException();
+        public Task<List<ProviderUser>> InviteUserAsync(ProviderUserInvite<string> invite) => throw new NotImplementedException();
 
-        public Task<List<Tuple<ProviderUser, string>>> ResendInvitesAsync(Guid providerId, Guid invitingUserId, IEnumerable<Guid> providerUsersId) => throw new NotImplementedException();
+        public Task<List<Tuple<ProviderUser, string>>> ResendInvitesAsync(ProviderUserInvite<Guid> invite) => throw new NotImplementedException();
 
         public Task<ProviderUser> AcceptUserAsync(Guid providerUserId, User user, string token) => throw new NotImplementedException();
 
@@ -29,9 +29,13 @@ namespace Bit.Core.Services
         public Task<List<Tuple<ProviderUser, string>>> DeleteUsersAsync(Guid providerId, IEnumerable<Guid> providerUserIds, Guid deletingUserId) => throw new NotImplementedException();
 
         public Task AddOrganization(Guid providerId, Guid organizationId, Guid addingUserId, string key) => throw new NotImplementedException();
+        
         public Task<ProviderOrganization> CreateOrganizationAsync(Guid providerId, OrganizationSignup organizationSignup, string clientOwnerEmail, User user) => throw new NotImplementedException();
 
         public Task RemoveOrganizationAsync(Guid providerId, Guid providerOrganizationId, Guid removingUserId) => throw new NotImplementedException();
+        
         public Task LogProviderAccessToOrganizationAsync(Guid organizationId) => throw new NotImplementedException();
+        
+        public Task ResendProviderSetupInviteEmailAsync(Guid providerId, Guid userId) => throw new NotImplementedException();
     }
 }