Update workflows with linter suggestions (#1562)

* Update workflows with linter suggestions

* Update workflows with linter suggestions

.github/workflows/build.yml

@@ -1,3 +1,4 @@
+---
 name: Build
 
 on:

.github/workflows/linter.yml

@@ -1,13 +1,14 @@
+---
 name: Workflow Linter
 
 on:
   push:
     branches: add-workflow-linter
-  #   branches-ignore:
+#   branches-ignore:
-  #     - 'l10n_master'
+#     - 'l10n_master'
-  #     - 'gh-pages'
+#     - 'gh-pages'
-  # workflow_dispatch:
+# workflow_dispatch:
-  #   inputs: {}
+#   inputs: {}
 
 jobs:
   cloc:
@@ -15,7 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repo
-        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
+        uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f  # v2.3.4
 
       - name: Install cloc
         run: |

.github/workflows/prod-deploy.yml

@@ -1,3 +1,4 @@
+---
 name: Prod Deploy
 
 on:
@@ -12,6 +13,7 @@ on:
 
 jobs:
   setup:
+    name: Setup
     runs-on: ubuntu-latest
     outputs:
       package_version: ${{ steps.create_tags.outputs.package_version }}
@@ -53,7 +55,7 @@ jobs:
         env:
           RELEASE_TAG_NAME_INPUT: ${{ github.event.inputs.release_tag_name_input }}
 
-      - name: test outputs
+      - name: Test outputs
         run: |
           echo "Package Version: ${{ steps.create_tags.outputs.package_version }}"
           echo "Tag Version: ${{ steps.create_tags.outputs.tag_version }}"
@@ -82,8 +84,7 @@ jobs:
           - setup
           - sso
     env:
-      PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
+      _PACKAGE_VERSION: ${{ needs.setup.outputs.package_version }}
-      TAG_VERSION: ${{ needs.setup.outputs.tag_version }}
     steps:
       - name: Print environment
         run: |
@@ -134,7 +135,7 @@ jobs:
       - name: Re-tag Docker images
         run: |
           docker tag bitwarden/${{ matrix.service_name }}:rc bitwarden/${{ matrix.service_name }}:latest
-          docker tag bitwarden/${{ matrix.service_name }}:rc bitwarden/${{ matrix.service_name }}:$PACKAGE_VERSION
+          docker tag bitwarden/${{ matrix.service_name }}:rc bitwarden/${{ matrix.service_name }}:$_PACKAGE_VERSION
 
       - name: List Docker images
         run: docker images
@@ -142,7 +143,7 @@ jobs:
       - name: Push Docker images
         run: |
           docker push bitwarden/${{ matrix.service_name }}:latest
-          docker push bitwarden/${{ matrix.service_name }}:$PACKAGE_VERSION
+          docker push bitwarden/${{ matrix.service_name }}:$_PACKAGE_VERSION
         env:
           DOCKER_CONTENT_TRUST: 1
           DOCKER_CONTENT_TRUST_REPOSITORY_PASSPHRASE: ${{ steps.retrieve-secrets.outputs.dct-delegate-2-repo-passphrase }}
@@ -152,6 +153,7 @@ jobs:
 
 
   build:
+    name: Build
     runs-on: ubuntu-latest
     needs: setup
     strategy:
@@ -178,13 +180,12 @@ jobs:
           - name: Identity
             base_path: .
     env:
-      PKG_VERSION: ${{ needs.setup.outputs.package_version }}
+      _TAG_VERSION: ${{ needs.setup.outputs.tag_version }}
-      TAG_VERSION: ${{ needs.setup.outputs.tag_version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
         with:
-          ref: ${{ env.TAG_VERSION }}
+          ref: ${{ env._TAG_VERSION }}
 
       - name: Set up Node
         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea
@@ -202,7 +203,7 @@ jobs:
           npm --version
           gulp --version
 
-      - name: load env vars
+      - name: Load env vars
         run: |
           echo "Base Path: ${BASE_PATH}"
           echo "Name: ${NAME}"
@@ -255,6 +256,7 @@ jobs:
 
 
   deploy-identity:
+    name: Deploy Identity
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -286,6 +288,7 @@ jobs:
 
 
   deploy-api:
+    name: Deploy API
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -317,6 +320,7 @@ jobs:
 
 
   deploy-billing:
+    name: Deploy Billing
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -348,6 +352,7 @@ jobs:
 
 
   deploy-events:
+    name: Deploy Events
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -379,6 +384,7 @@ jobs:
 
 
   deploy-sso:
+    name: Deploy SSO
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -410,6 +416,7 @@ jobs:
 
 
   deploy-portal:
+    name: Deploy Portal
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -441,6 +448,7 @@ jobs:
 
 
   deploy-admin:
+    name: Deploy Admin
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -469,4 +477,3 @@ jobs:
           slot-name: "staging"
           publish-profile: ${{ steps.retrieve-secrets.outputs.appservices-admin-webapp-publish-profile }}
           package: ./Admin.zip
-

.github/workflows/qa-deploy.yml

@@ -1,3 +1,4 @@
+---
 name: QA Deploy
 
 on:
@@ -12,6 +13,7 @@ on:
 
 jobs:
   build:
+    name: Build
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
@@ -158,6 +160,7 @@ jobs:
 
 
   deploy:
+    name: Deploy
     runs-on: ubuntu-latest
     if: always()
     needs:
@@ -196,7 +199,7 @@ jobs:
       - name: Retrieve secrets
         id: retrieve-secrets
         env:
-           VAULT_NAME: "bitwarden-qa-kv"
+          VAULT_NAME: "bitwarden-qa-kv"
         run: |
           webapp_name=$(az keyvault secret show --vault-name $VAULT_NAME --name appservices-${{ steps.setup.outputs.name_lower }}-webapp-name --query value --output tsv)
           echo "::add-mask::$webapp_name"

.github/workflows/release.yml

@@ -1,3 +1,4 @@
+---
 name: Release
 
 on:
@@ -13,7 +14,6 @@ jobs:
     runs-on: ubuntu-latest
     outputs:
       release_upload_url: ${{ steps.create_release.outputs.upload_url }}
-      release_version: ${{ steps.create_tags.outputs.package_version }}
       tag_version: ${{ steps.create_tags.outputs.tag_version }}
     steps:
       - name: Branch check
@@ -69,8 +69,7 @@ jobs:
     needs:
       - setup
     env:
-      RELEASE_VERSION: ${{ needs.setup.outputs.release_version }}
+      _TAG_VERSION: ${{ needs.setup.outputs.tag_version }}
-      TAG_VERSION: ${{ needs.setup.outputs.tag_version }}
     steps:
       - name: Checkout repo
         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
@@ -124,6 +123,6 @@ jobs:
             -a ./swagger.json \
             -a ./docker-stub.zip \
             -m "" \
-            $TAG_VERSION
+            $_TAG_VERSION
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}