nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-01 16:12:49 -05:00
Code Activity

Improve and refactor style, fix typo

Browse Source
This commit is contained in:
Thomas Rittson
2021-06-30 09:28:41 +10:00
parent 95fd8759de
commit 216c96a02f
2 changed files with 15 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
src/Api/Controllers/AccountsController.cs
View File

@ -285,40 +285,31 @@ namespace Bit.Api.Controllers
throw new UnauthorizedAccessException(); throw new UnauthorizedAccessException();
} }
var existingCiphers = await _cipherRepository.GetManyByUserIdAsync(user.Id);
var ciphersDict = model.Ciphers?.ToDictionary(c => c.Id.Value);
var ciphers = new List<Cipher>(); var ciphers = new List<Cipher>();
if (existingCiphers.Any() && ciphersDict != null) if (model.Ciphers.Any())
{ {
foreach (var cipher in existingCiphers.Where(c => ciphersDict.ContainsKey(c.Id))) var existingCiphers = await _cipherRepository.GetManyByUserIdAsync(user.Id);
{ ciphers = existingCiphers
ciphers.Add(ciphersDict[cipher.Id].ToCipher(cipher)); .Join(model.Ciphers, c => c.Id, c => c.Id, (existing, c) => c.ToCipher(existing))
} .ToList();
} }
var existingFolders = await _folderRepository.GetManyByUserIdAsync(user.Id);
var foldersDict = model.Folders?.ToDictionary(f => f.Id);
var folders = new List<Folder>(); var folders = new List<Folder>();
if (existingFolders.Any() && foldersDict != null) if (model.Folders.Any())
{ {
foreach (var folder in existingFolders.Where(f => foldersDict.ContainsKey(f.Id))) var existingFolders = await _folderRepository.GetManyByUserIdAsync(user.Id);
{ folders = existingFolders
folders.Add(foldersDict[folder.Id].ToFolder(folder)); .Join(model.Folders, f => f.Id, f => f.Id, (existing, f) => f.ToFolder(existing))
} .ToList();
} }
var sends = new List<Send>(); var sends = new List<Send>();
if (model.Sends?.Count() > 0) if (model.Sends?.Any() == true)
{ {
var existingSends = await _sendRepository.GetManyByUserIdAsync(user.Id); var existingSends = await _sendRepository.GetManyByUserIdAsync(user.Id);
var sendsDict = model.Sends?.ToDictionary(s => s.Id); sends = existingSends
if (existingSends.Any() && sendsDict != null) .Join(model.Sends, s => s.Id, s => s.Id, (existing, s) => s.ToSend(existing, _sendService))
{ .ToList();
foreach (var send in existingSends.Where(s => sendsDict.ContainsKey(s.Id)))
{
sends.Add(sendsDict[send.Id].ToSend(send, _sendService));
}
}
} }
var result = await _userService.UpdateKeyAsync( var result = await _userService.UpdateKeyAsync(

2
src/Core/Repositories/SqlServer/CipherRepository.cs
View File

@ -869,7 +869,7 @@ namespace Bit.Core.Repositories.SqlServer
var s = sends.FirstOrDefault(); var s = sends.FirstOrDefault();
if (s == null) if (s == null)
{ {
throw new ApplicationException("Must have some ciphers to bulk import."); throw new ApplicationException("Must have some Sends to bulk import.");
} }
var sendsTable = new DataTable("SendsDataTable"); var sendsTable = new DataTable("SendsDataTable");