From 231eb84e694814b658cf5a52e45b782d587f97e4 Mon Sep 17 00:00:00 2001 From: Justin Baur <136baur@gmail.com> Date: Wed, 29 Jun 2022 19:46:41 -0400 Subject: [PATCH] Turn On `ImplicitUsings` (#2079) * Turn on ImplicitUsings * Fix formatting * Run linter --- .editorconfig | 3 +++ Directory.Build.props | 11 ++++++----- .../src/CommCore/Services/ProviderService.cs | 6 +----- .../src/Sso/Controllers/AccountController.cs | 8 +------- .../src/Sso/Controllers/HomeController.cs | 4 +--- .../src/Sso/Controllers/InfoController.cs | 3 +-- .../src/Sso/Controllers/MetadataController.cs | 4 +--- bitwarden_license/src/Sso/Models/ErrorViewModel.cs | 3 +-- bitwarden_license/src/Sso/Program.cs | 2 -- bitwarden_license/src/Sso/Startup.cs | 9 +-------- .../src/Sso/Utilities/ClaimsExtensions.cs | 5 +---- .../src/Sso/Utilities/DiscoveryResponseGenerator.cs | 5 +---- .../src/Sso/Utilities/DynamicAuthenticationScheme.cs | 5 +---- .../Utilities/DynamicAuthenticationSchemeProvider.cs | 9 +-------- .../src/Sso/Utilities/ExtendedOptionsMonitorCache.cs | 3 +-- .../src/Sso/Utilities/IDynamicAuthenticationScheme.cs | 3 +-- .../Sso/Utilities/OpenIdConnectOptionsExtensions.cs | 7 +------ .../src/Sso/Utilities/Saml2OptionsExtensions.cs | 7 +------ .../src/Sso/Utilities/ServiceCollectionExtensions.cs | 7 +------ .../src/Sso/Utilities/SsoAuthenticationMiddleware.cs | 6 +----- .../CmmCore.Test/Services/ProviderServiceTests.cs | 6 +----- src/Admin/Controllers/HomeController.cs | 5 ----- src/Admin/Controllers/InfoController.cs | 3 +-- src/Admin/Controllers/LoginController.cs | 3 +-- src/Admin/Controllers/LogsController.cs | 6 +----- src/Admin/Controllers/OrganizationsController.cs | 7 +------ src/Admin/Controllers/ProvidersController.cs | 5 +---- src/Admin/Controllers/ToolsController.cs | 9 +-------- src/Admin/Controllers/UsersController.cs | 5 +---- .../HostedServices/AmazonSqsBlockIpHostedService.cs | 7 +------ .../HostedServices/AzureQueueBlockIpHostedService.cs | 7 +------ .../HostedServices/AzureQueueMailHostedService.cs | 9 +-------- src/Admin/HostedServices/BlockIpHostedService.cs | 10 +--------- .../HostedServices/DatabaseMigrationHostedService.cs | 7 +------ src/Admin/Jobs/AliveJob.cs | 5 +---- src/Admin/Jobs/DatabaseExpiredGrantsJob.cs | 5 +---- src/Admin/Jobs/DatabaseExpiredSponsorshipsJob.cs | 5 +---- src/Admin/Jobs/DatabaseRebuildlIndexesJob.cs | 5 +---- src/Admin/Jobs/DatabaseUpdateStatisticsJob.cs | 5 +---- src/Admin/Jobs/DeleteCiphersJob.cs | 5 +---- src/Admin/Jobs/DeleteSendsJob.cs | 8 +------- src/Admin/Jobs/JobsHostedService.cs | 8 +------- src/Admin/Models/BillingInformationModel.cs | 3 +-- src/Admin/Models/ChargeBraintreeModel.cs | 4 +--- src/Admin/Models/CreateUpdateTransactionModel.cs | 4 +--- src/Admin/Models/CursorPagedModel.cs | 4 +--- src/Admin/Models/ErrorViewModel.cs | 4 +--- src/Admin/Models/HomeModel.cs | 3 +-- src/Admin/Models/LicenseModel.cs | 4 +--- src/Admin/Models/LogModel.cs | 3 +-- src/Admin/Models/LogsModel.cs | 3 +-- src/Admin/Models/OrganizationEditModel.cs | 4 +--- src/Admin/Models/OrganizationViewModel.cs | 4 +--- src/Admin/Models/PagedModel.cs | 4 +--- src/Admin/Models/PromoteAdminModel.cs | 3 +-- src/Admin/Models/ProviderEditModel.cs | 3 +-- src/Admin/Models/ProviderViewModel.cs | 4 +--- src/Admin/Models/UserEditModel.cs | 4 +--- src/Admin/Models/UserViewModel.cs | 5 +---- src/Admin/Program.cs | 2 -- src/Admin/Startup.cs | 9 +-------- src/Admin/TagHelpers/ActivePageTagHelper.cs | 4 +--- src/Admin/TagHelpers/OptionSelectedTagHelper.cs | 3 +-- src/Api/Controllers/AccountsBillingController.cs | 4 +--- src/Api/Controllers/AccountsController.cs | 6 +----- src/Api/Controllers/CiphersController.cs | 7 +------ src/Api/Controllers/CollectionsController.cs | 6 +----- src/Api/Controllers/DevicesController.cs | 6 +----- src/Api/Controllers/EmergencyAccessController.cs | 5 +---- src/Api/Controllers/EventsController.cs | 5 +---- src/Api/Controllers/FoldersController.cs | 5 +---- src/Api/Controllers/GroupsController.cs | 6 +----- src/Api/Controllers/HibpController.cs | 6 +----- src/Api/Controllers/InfoController.cs | 5 +---- src/Api/Controllers/InstallationsController.cs | 4 +--- src/Api/Controllers/LicensesController.cs | 4 +--- src/Api/Controllers/MiscController.cs | 3 +-- .../Controllers/OrganizationConnectionsController.cs | 6 +----- .../Controllers/OrganizationSponsorshipsController.cs | 6 +----- src/Api/Controllers/OrganizationUsersController.cs | 6 +----- src/Api/Controllers/OrganizationsController.cs | 5 +---- src/Api/Controllers/PlansController.cs | 4 +--- src/Api/Controllers/PoliciesController.cs | 5 +---- .../Controllers/ProviderOrganizationsController.cs | 5 +---- src/Api/Controllers/ProviderUsersController.cs | 6 +----- src/Api/Controllers/ProvidersController.cs | 4 +--- src/Api/Controllers/PushController.cs | 6 +----- .../SelfHostedOrganizationSponsorshipsController.cs | 4 +--- src/Api/Controllers/SendsController.cs | 7 +------ src/Api/Controllers/SettingsController.cs | 4 +--- src/Api/Controllers/SyncController.cs | 6 +----- src/Api/Controllers/TwoFactorController.cs | 5 +---- src/Api/Controllers/UsersController.cs | 4 +--- src/Api/Jobs/AliveJob.cs | 4 +--- src/Api/Jobs/EmergencyAccessNotificationJob.cs | 5 +---- src/Api/Jobs/EmergencyAccessTimeoutJob.cs | 5 +---- src/Api/Jobs/JobsHostedService.cs | 8 +------- src/Api/Jobs/SelfHostedSponsorshipSyncJob.cs | 7 +------ src/Api/Jobs/ValidateOrganizationsJob.cs | 5 +---- src/Api/Jobs/ValidateUsersJob.cs | 4 +--- src/Api/Models/CipherLoginModel.cs | 5 +---- src/Api/Models/CipherPasswordHistoryModel.cs | 3 +-- .../Public/AssociationWithPermissionsBaseModel.cs | 3 +-- src/Api/Models/Public/MemberBaseModel.cs | 3 +-- src/Api/Models/Public/PolicyBaseModel.cs | 3 +-- .../Public/Request/CollectionUpdateRequestModel.cs | 3 +-- .../Models/Public/Request/EventFilterRequestModel.cs | 3 +-- .../Public/Request/GroupCreateUpdateRequestModel.cs | 4 +--- .../Models/Public/Request/MemberCreateRequestModel.cs | 3 +-- .../Models/Public/Request/MemberUpdateRequestModel.cs | 3 +-- .../Public/Request/OrganizationImportRequestModel.cs | 4 +--- .../Models/Public/Request/PolicyUpdateRequestModel.cs | 3 +-- .../Public/Request/UpdateGroupIdsRequestModel.cs | 5 +---- .../Public/Request/UpdateMemberIdsRequestModel.cs | 5 +---- .../AssociationWithPermissionsResponseModel.cs | 3 +-- .../Models/Public/Response/CollectionResponseModel.cs | 5 +---- src/Api/Models/Public/Response/ErrorResponseModel.cs | 4 +--- src/Api/Models/Public/Response/EventResponseModel.cs | 3 +-- src/Api/Models/Public/Response/GroupResponseModel.cs | 5 +---- src/Api/Models/Public/Response/ListResponseModel.cs | 3 +-- src/Api/Models/Public/Response/MemberResponseModel.cs | 5 +---- src/Api/Models/Public/Response/PolicyResponseModel.cs | 5 +---- .../Request/Accounts/ImportCiphersRequestModel.cs | 4 +--- src/Api/Models/Request/Accounts/KdfRequestModel.cs | 3 +-- .../Models/Request/Accounts/PremiumRequestModel.cs | 4 +--- .../Accounts/SecretVerificationRequestModel.cs | 3 +-- .../Models/Request/Accounts/StorageRequestModel.cs | 3 +-- .../Request/Accounts/TaxInfoUpdateRequestModel.cs | 3 +-- .../Models/Request/Accounts/UpdateKeyRequestModel.cs | 3 +-- src/Api/Models/Request/BitPayInvoiceRequestModel.cs | 4 +--- src/Api/Models/Request/CipherRequestModel.cs | 5 +---- src/Api/Models/Request/CollectionRequestModel.cs | 4 +--- src/Api/Models/Request/DeviceRequestModels.cs | 3 +-- .../Models/Request/DeviceVerificationRequestModel.cs | 3 +-- src/Api/Models/Request/FolderRequestModel.cs | 3 +-- src/Api/Models/Request/GroupRequestModel.cs | 4 +--- src/Api/Models/Request/IapCheckRequestModel.cs | 3 +-- src/Api/Models/Request/LicenseRequestModel.cs | 1 - .../ImportOrganizationCiphersRequestModel.cs | 4 +--- .../ImportOrganizationUsersRequestModel.cs | 4 +--- .../OrganizationConnectionRequestModel.cs | 3 +-- .../Organizations/OrganizationCreateRequestModel.cs | 3 +-- .../Organizations/OrganizationSeatRequestModel.cs | 3 +-- .../OrganizationSponsorshipRedeemRequestModel.cs | 3 +-- .../Organizations/OrganizationSsoRequestModel.cs | 4 +--- .../Organizations/OrganizationUserRequestModels.cs | 5 +---- src/Api/Models/Request/PolicyRequestModel.cs | 4 +--- .../Providers/ProviderOrganizationAddRequestModel.cs | 3 +-- .../Request/Providers/ProviderUserRequestModels.cs | 5 +---- .../Models/Request/SelectionReadOnlyRequestModel.cs | 3 +-- src/Api/Models/Request/SendRequestModel.cs | 3 +-- src/Api/Models/Request/TwoFactorRequestModels.cs | 3 +-- src/Api/Models/Request/UpdateDomainsRequestModel.cs | 3 +-- src/Api/Models/Response/ApiKeyResponseModel.cs | 3 +-- src/Api/Models/Response/AttachmentResponseModel.cs | 4 +--- .../Models/Response/BillingHistoryResponseModel.cs | 4 +--- src/Api/Models/Response/BillingResponseModel.cs | 5 +---- src/Api/Models/Response/CipherResponseModel.cs | 5 +---- src/Api/Models/Response/CollectionResponseModel.cs | 5 +---- src/Api/Models/Response/DeviceResponseModel.cs | 3 +-- .../Response/DeviceVerificationResponseModel.cs | 3 +-- src/Api/Models/Response/DomainsResponseModel.cs | 5 +---- .../Models/Response/EmergencyAccessResponseModel.cs | 5 +---- src/Api/Models/Response/EventResponseModel.cs | 3 +-- src/Api/Models/Response/FolderResponseModel.cs | 3 +-- src/Api/Models/Response/GroupResponseModel.cs | 5 +---- src/Api/Models/Response/KeysResponseModel.cs | 3 +-- src/Api/Models/Response/ListResponseModel.cs | 3 +-- .../OrganizationApiKeyInformationResponseModel.cs | 3 +-- .../OrganizationAutoEnrollStatusResponseModel.cs | 3 +-- .../OrganizationConnectionResponseModel.cs | 3 +-- .../Organizations/OrganizationKeysResponseModel.cs | 3 +-- .../Organizations/OrganizationResponseModel.cs | 4 +--- .../OrganizationSponsorshipSyncStatusResponseModel.cs | 3 +-- .../Organizations/OrganizationUserResponseModel.cs | 5 +---- src/Api/Models/Response/PlanResponseModel.cs | 3 +-- src/Api/Models/Response/PolicyResponseModel.cs | 4 +--- .../Response/ProfileOrganizationResponseModel.cs | 3 +-- src/Api/Models/Response/ProfileResponseModel.cs | 5 +---- .../Providers/ProviderOrganizationResponseModel.cs | 3 +-- .../Response/Providers/ProviderResponseModel.cs | 3 +-- .../Response/Providers/ProviderUserResponseModel.cs | 3 +-- .../Models/Response/SelectionReadOnlyResponseModel.cs | 3 +-- src/Api/Models/Response/SendAccessResponseModel.cs | 3 +-- src/Api/Models/Response/SendResponseModel.cs | 3 +-- src/Api/Models/Response/SubscriptionResponseModel.cs | 5 +---- src/Api/Models/Response/SyncResponseModel.cs | 5 +---- src/Api/Models/Response/TaxRateResponseModel.cs | 3 +-- .../TwoFactor/TwoFactorAuthenticatorResponseModel.cs | 3 +-- .../Response/TwoFactor/TwoFactorDuoResponseModel.cs | 3 +-- .../Response/TwoFactor/TwoFactorEmailResponseModel.cs | 3 +-- .../TwoFactor/TwoFactorProviderResponseModel.cs | 3 +-- .../TwoFactor/TwoFactorRecoverResponseModel.cs | 3 +-- .../TwoFactor/TwoFactorWebAuthnResponseModel.cs | 5 +---- .../TwoFactor/TwoFactorYubiKeyResponseModel.cs | 3 +-- src/Api/Models/Response/UserKeyResponseModel.cs | 3 +-- src/Api/Program.cs | 2 -- src/Api/Public/Controllers/CollectionsController.cs | 5 +---- src/Api/Public/Controllers/EventsController.cs | 5 +---- src/Api/Public/Controllers/GroupsController.cs | 6 +----- src/Api/Public/Controllers/MembersController.cs | 6 +----- src/Api/Public/Controllers/OrganizationController.cs | 4 +--- src/Api/Public/Controllers/PoliciesController.cs | 5 +---- src/Api/Startup.cs | 9 +-------- src/Api/Utilities/ApiHelpers.cs | 7 +------ .../DisableFormValueModelBindingAttribute.cs | 3 +-- src/Api/Utilities/ExceptionHandlerFilterAttribute.cs | 7 +------ .../Utilities/ModelStateValidationFilterAttribute.cs | 3 +-- src/Api/Utilities/MultipartFormDataHelper.cs | 6 +----- src/Api/Utilities/ServiceCollectionExtensions.cs | 6 +----- src/Billing/Controllers/AppleController.cs | 7 +------ src/Billing/Controllers/BitPayController.cs | 6 +----- src/Billing/Controllers/FreshdeskController.cs | 9 +-------- src/Billing/Controllers/FreshsalesController.cs | 11 +---------- src/Billing/Controllers/InfoController.cs | 3 +-- src/Billing/Controllers/LoginController.cs | 6 +----- src/Billing/Controllers/PayPalController.cs | 3 --- src/Billing/Controllers/StripeController.cs | 10 +--------- src/Billing/Jobs/JobsHostedService.cs | 8 +------- src/Billing/Program.cs | 2 -- src/Billing/Startup.cs | 10 +--------- src/Billing/Utilities/PayPalIpnClient.cs | 7 +------ src/Core/Context/CurrentContentOrganization.cs | 3 +-- src/Core/Context/CurrentContentProvider.cs | 4 +--- src/Core/Context/CurrentContext.cs | 6 +----- src/Core/Context/ICurrentContext.cs | 5 +---- src/Core/Entities/Cipher.cs | 4 +--- src/Core/Entities/Collection.cs | 3 +-- src/Core/Entities/CollectionCipher.cs | 4 +--- src/Core/Entities/CollectionGroup.cs | 4 +--- src/Core/Entities/CollectionUser.cs | 4 +--- src/Core/Entities/Device.cs | 3 +-- src/Core/Entities/EmergencyAccess.cs | 3 +-- src/Core/Entities/Event.cs | 3 +-- src/Core/Entities/Folder.cs | 3 +-- src/Core/Entities/Grant.cs | 3 +-- src/Core/Entities/Group.cs | 3 +-- src/Core/Entities/GroupUser.cs | 4 +--- src/Core/Entities/IReferenceable.cs | 4 +--- src/Core/Entities/IRevisable.cs | 4 +--- src/Core/Entities/ISubscriber.cs | 3 +-- src/Core/Entities/ITableObject.cs | 4 +--- src/Core/Entities/Installation.cs | 3 +-- src/Core/Entities/Organization.cs | 5 +---- src/Core/Entities/OrganizationApiKey.cs | 3 +-- src/Core/Entities/OrganizationConnection.cs | 3 +-- src/Core/Entities/OrganizationSponsorship.cs | 3 +-- src/Core/Entities/OrganizationUser.cs | 3 +-- src/Core/Entities/Policy.cs | 3 +-- src/Core/Entities/Provider/Provider.cs | 3 +-- src/Core/Entities/Provider/ProviderOrganization.cs | 3 +-- src/Core/Entities/Provider/ProviderUser.cs | 3 +-- src/Core/Entities/Send.cs | 3 +-- src/Core/Entities/SsoConfig.cs | 3 +-- src/Core/Entities/SsoUser.cs | 3 +-- src/Core/Entities/Transaction.cs | 3 +-- src/Core/Entities/User.cs | 4 +--- src/Core/Exceptions/BadRequestException.cs | 3 +-- src/Core/Exceptions/GatewayException.cs | 4 +--- src/Core/Exceptions/InvalidEmailException.cs | 4 +--- .../Exceptions/InvalidGatewayCustomerIdException.cs | 4 +--- src/Core/Exceptions/NotFoundException.cs | 4 +--- .../HostedServices/ApplicationCacheHostedService.cs | 5 +---- src/Core/Identity/AuthenticatorTokenProvider.cs | 4 +--- .../CustomIdentityServiceCollectionExtensions.cs | 4 +--- src/Core/Identity/DuoWebTokenProvider.cs | 4 +--- src/Core/Identity/EmailTokenProvider.cs | 4 +--- .../Identity/IOrganizationTwoFactorTokenProvider.cs | 3 +-- src/Core/Identity/OrganizationDuoWebTokenProvider.cs | 3 +-- src/Core/Identity/PasswordlessSignInManager.cs | 5 +---- .../Identity/ReadOnlyDatabaseIdentityUserStore.cs | 5 +---- src/Core/Identity/ReadOnlyEnvIdentityUserStore.cs | 5 +---- src/Core/Identity/ReadOnlyIdentityUserStore.cs | 5 +---- src/Core/Identity/RoleStore.cs | 5 +---- src/Core/Identity/UserStore.cs | 6 +----- src/Core/Identity/WebAuthnTokenProvider.cs | 6 +----- src/Core/Identity/YubicoOtpTokenProvider.cs | 5 +---- src/Core/IdentityServer/ApiClient.cs | 4 +--- src/Core/IdentityServer/ApiResources.cs | 3 +-- src/Core/IdentityServer/ApiScopes.cs | 3 +-- src/Core/IdentityServer/AuthorizationCodeStore.cs | 3 +-- src/Core/IdentityServer/BaseRequestValidator.cs | 6 +----- src/Core/IdentityServer/ClientStore.cs | 6 +----- .../ConfigureOpenIdConnectDistributedOptions.cs | 3 +-- .../IdentityServer/CustomTokenRequestValidator.cs | 8 +------- .../IdentityServer/DistributedCacheCookieManager.cs | 3 +-- .../DistributedCacheTicketDataFormatter.cs | 3 +-- src/Core/IdentityServer/MemoryCacheTicketStore.cs | 4 +--- src/Core/IdentityServer/OidcIdentityClient.cs | 3 +-- src/Core/IdentityServer/PersistedGrantStore.cs | 5 +---- src/Core/IdentityServer/ProfileService.cs | 8 +------- src/Core/IdentityServer/RedisCacheTicketStore.cs | 4 +--- .../IdentityServer/ResourceOwnerPasswordValidator.cs | 4 +--- src/Core/IdentityServer/StaticClientStore.cs | 4 +--- src/Core/IdentityServer/TokenRetrieval.cs | 4 +--- src/Core/IdentityServer/VaultCorsPolicyService.cs | 3 +-- src/Core/Jobs/BaseJob.cs | 4 +--- src/Core/Jobs/BaseJobsHostedService.cs | 7 +------ src/Core/Jobs/JobFactory.cs | 3 +-- src/Core/Jobs/JobListener.cs | 5 +---- .../Api/Request/Accounts/RegisterRequestModel.cs | 4 +--- .../OrganizationSponsorshipRequestModel.cs | 3 +-- .../OrganizationSponsorshipSyncRequestModel.cs | 5 +---- src/Core/Models/Api/Request/PushSendRequestModel.cs | 3 +-- src/Core/Models/Api/Request/PushUpdateRequestModel.cs | 3 +-- src/Core/Models/Api/Response/ErrorResponseModel.cs | 4 +--- .../OrganizationSponsorshipResponseModel.cs | 4 +--- .../OrganizationSponsorshipSyncResponseModel.cs | 5 +---- src/Core/Models/Api/Response/ResponseModel.cs | 3 +-- src/Core/Models/Business/AppleReceiptStatus.cs | 7 +------ src/Core/Models/Business/BillingInfo.cs | 4 +--- src/Core/Models/Business/ExpiringToken.cs | 4 +--- src/Core/Models/Business/ILicense.cs | 3 +-- src/Core/Models/Business/ImportedGroup.cs | 3 +-- src/Core/Models/Business/OrganizationLicense.cs | 4 +--- src/Core/Models/Business/OrganizationUserInvite.cs | 3 +-- .../Models/Business/Provider/ProviderUserInvite.cs | 4 +--- src/Core/Models/Business/ReferenceEvent.cs | 3 +-- src/Core/Models/Business/SubscriptionCreateOptions.cs | 3 +-- src/Core/Models/Business/SubscriptionInfo.cs | 5 +---- src/Core/Models/Business/SubscriptionUpdate.cs | 5 +---- .../Tokenables/EmergencyAccessInviteTokenable.cs | 3 +-- .../Models/Business/Tokenables/HCaptchaTokenable.cs | 3 +-- .../OrganizationSponsorshipOfferTokenable.cs | 3 +-- src/Core/Models/Business/Tokenables/SsoTokenable.cs | 4 +--- src/Core/Models/Business/UserLicense.cs | 4 +--- src/Core/Models/Data/CipherAttachment.cs | 3 +-- src/Core/Models/Data/CipherData.cs | 4 +--- src/Core/Models/Data/CipherDetails.cs | 4 +--- src/Core/Models/Data/CipherLoginData.cs | 5 +---- src/Core/Models/Data/CipherPasswordHistoryData.cs | 4 +--- src/Core/Models/Data/DictionaryEntity.cs | 4 +--- src/Core/Models/Data/EmergencyAccessNotify.cs | 5 +---- src/Core/Models/Data/EmergencyAccessViewData.cs | 3 +-- src/Core/Models/Data/EventMessage.cs | 3 +-- src/Core/Models/Data/EventTableEntity.cs | 4 +--- src/Core/Models/Data/IEvent.cs | 3 +-- src/Core/Models/Data/InstallationDeviceEntity.cs | 3 +-- .../Models/Data/Organizations/OrganizationAbility.cs | 3 +-- .../OrganizationConnectionData.cs | 5 +---- .../OrganizationSponsorshipData.cs | 3 +-- .../OrganizationSponsorshipSyncData.cs | 5 +---- .../OrganizationUsers/OrganizationUserInviteData.cs | 3 +-- .../OrganizationUserOrganizationDetails.cs | 4 +--- .../OrganizationUsers/OrganizationUserPublicKey.cs | 4 +--- .../OrganizationUserResetPasswordDetails.cs | 3 +-- .../OrganizationUsers/OrganizationUserUserDetails.cs | 4 +--- src/Core/Models/Data/PagedResult.cs | 4 +--- src/Core/Models/Data/Permissions.cs | 4 +--- src/Core/Models/Data/Provider/ProviderAbility.cs | 3 +-- .../ProviderOrganizationOrganizationDetails.cs | 5 +---- .../Data/Provider/ProviderUserOrganizationDetails.cs | 3 +-- .../Data/Provider/ProviderUserProviderDetails.cs | 3 +-- .../Models/Data/Provider/ProviderUserPublicKey.cs | 4 +--- .../Models/Data/Provider/ProviderUserUserDetails.cs | 3 +-- src/Core/Models/Data/SelectionReadOnly.cs | 4 +--- src/Core/Models/Data/SendFileData.cs | 3 +-- src/Core/Models/Data/SsoConfigurationData.cs | 5 +---- src/Core/Models/Data/UserKdfInformation.cs | 3 +-- src/Core/Models/ITwoFactorProvidersUser.cs | 4 +--- src/Core/Models/Mail/BaseMailModel.cs | 4 +--- ...iliesForEnterpriseSponsorshipRevertingViewModel.cs | 4 +--- src/Core/Models/Mail/IMailQueueMessage.cs | 4 +--- src/Core/Models/Mail/InvoiceUpcomingViewModel.cs | 5 +---- src/Core/Models/Mail/MailMessage.cs | 4 +--- src/Core/Models/Mail/MailQueueMessage.cs | 3 +-- .../Mail/OrganizationSeatsAutoscaledViewModel.cs | 4 +--- .../Mail/OrganizationSeatsMaxReachedViewModel.cs | 4 +--- .../Models/Mail/OrganizationUserAcceptedViewModel.cs | 4 +--- .../Models/Mail/OrganizationUserInvitedViewModel.cs | 4 +--- src/Core/Models/Mail/VerifyDeleteModel.cs | 4 +--- src/Core/Models/Mail/VerifyEmailModel.cs | 4 +--- .../BillingSyncConfig.cs | 4 +--- src/Core/Models/PushNotification.cs | 4 +--- src/Core/Models/StaticStore/SponsoredPlan.cs | 3 +-- src/Core/Models/TwoFactorProvider.cs | 4 +--- .../GetOrganizationApiKeyCommand.cs | 5 +---- .../Interfaces/IGetOrganizationApiKeyCommand.cs | 4 +--- .../Interfaces/IRotateOrganizationApiKeyCommand.cs | 3 +-- .../RotateOrganizationApiKeyCommand.cs | 4 +--- .../CreateOrganizationConnectionCommand.cs | 3 +-- .../DeleteOrganizationConnectionCommand.cs | 3 +-- .../ICreateOrganizationConnectionCommand.cs | 3 +-- .../IDeleteOrganizationConnectionCommand.cs | 3 +-- .../IUpdateOrganizationConnectionCommand.cs | 3 +-- .../UpdateOrganizationConnectionCommand.cs | 4 +--- .../FamiliesForEnterprise/CancelSponsorshipCommand.cs | 4 +--- .../Cloud/CloudRevokeSponsorshipCommand.cs | 3 +-- .../Cloud/CloudSyncSponsorshipsCommand.cs | 6 +----- .../Cloud/OrganizationSponsorshipRenewCommand.cs | 4 +--- .../Cloud/RemoveSponsorshipCommand.cs | 3 +-- .../Cloud/SendSponsorshipOfferCommand.cs | 4 +--- .../Cloud/SetUpSponsorshipCommand.cs | 4 +--- .../Cloud/ValidateBillingSyncKeyCommand.cs | 5 +---- .../Cloud/ValidateRedemptionTokenCommand.cs | 3 +-- .../Cloud/ValidateSponsorshipCommand.cs | 4 +--- .../FamiliesForEnterprise/CreateSponsorshipCommand.cs | 4 +--- .../Interfaces/ICreateSponsorshipCommand.cs | 3 +-- .../IOrganizationSponsorshipRenewCommand.cs | 5 +---- .../Interfaces/IRemoveSponsorshipCommand.cs | 3 +-- .../Interfaces/IRevokeSponsorshipCommand.cs | 3 +-- .../Interfaces/ISendSponsorshipOfferCommand.cs | 4 +--- .../Interfaces/ISetUpSponsorshipCommand.cs | 3 +-- .../ISyncOrganizationSponsorshipsCommand.cs | 5 +---- .../Interfaces/IValidateBillingSyncKeyCommand.cs | 4 +--- .../Interfaces/IValidateRedemptionTokenCommand.cs | 3 +-- .../Interfaces/IValidateSponsorshipCommand.cs | 5 +---- .../SelfHosted/SelfHostedRevokeSponsorshipCommand.cs | 3 +-- .../SelfHosted/SelfHostedSyncSponsorshipsCommand.cs | 7 +------ src/Core/Repositories/ICipherRepository.cs | 5 +---- src/Core/Repositories/ICollectionCipherRepository.cs | 5 +---- src/Core/Repositories/ICollectionRepository.cs | 5 +---- src/Core/Repositories/IDeviceRepository.cs | 5 +---- src/Core/Repositories/IEmergencyAccessRepository.cs | 5 +---- src/Core/Repositories/IEventRepository.cs | 5 +---- src/Core/Repositories/IFolderRepository.cs | 5 +---- src/Core/Repositories/IGrantRepository.cs | 5 +---- src/Core/Repositories/IGroupRepository.cs | 5 +---- .../Repositories/IInstallationDeviceRepository.cs | 4 +--- src/Core/Repositories/IInstallationRepository.cs | 3 +-- src/Core/Repositories/IMaintenanceRepository.cs | 5 +---- src/Core/Repositories/IMetaDataRepository.cs | 5 +---- .../Repositories/IOrganizationApiKeyRepository.cs | 5 +---- .../Repositories/IOrganizationConnectionRepository.cs | 5 +---- src/Core/Repositories/IOrganizationRepository.cs | 5 +---- .../IOrganizationSponsorshipRepository.cs | 5 +---- src/Core/Repositories/IOrganizationUserRepository.cs | 5 +---- src/Core/Repositories/IPolicyRepository.cs | 6 +----- .../Repositories/IProviderOrganizationRepository.cs | 5 +---- src/Core/Repositories/IProviderRepository.cs | 5 +---- src/Core/Repositories/IProviderUserRepository.cs | 5 +---- src/Core/Repositories/IRepository.cs | 4 +--- src/Core/Repositories/ISendRepository.cs | 5 +---- src/Core/Repositories/ISsoConfigRepository.cs | 5 +---- src/Core/Repositories/ISsoUserRepository.cs | 4 +--- src/Core/Repositories/ITaxRateRepository.cs | 4 +--- src/Core/Repositories/ITransactionRepository.cs | 5 +---- src/Core/Repositories/IUserRepository.cs | 5 +---- .../Repositories/Noop/InstallationDeviceRepository.cs | 4 +--- src/Core/Repositories/Noop/MetaDataRepository.cs | 5 +---- src/Core/Repositories/TableStorage/EventRepository.cs | 6 +----- .../TableStorage/InstallationDeviceRepository.cs | 5 +---- .../Repositories/TableStorage/MetaDataRepository.cs | 5 +---- src/Core/Resources/SharedResources.cs | 4 +--- src/Core/Services/IAppleIapService.cs | 4 +--- src/Core/Services/IApplicationCacheService.cs | 5 +---- src/Core/Services/IAttachmentStorageService.cs | 5 +---- src/Core/Services/IBlockIpService.cs | 5 +---- src/Core/Services/ICaptchaValidationService.cs | 3 +-- src/Core/Services/ICipherService.cs | 6 +----- src/Core/Services/ICollectionService.cs | 5 +---- src/Core/Services/IDeviceService.cs | 3 +-- src/Core/Services/IEmergencyAccessService.cs | 5 +---- src/Core/Services/IEventService.cs | 5 +---- src/Core/Services/IEventWriteService.cs | 4 +--- src/Core/Services/IGroupService.cs | 5 +---- src/Core/Services/ILicensingService.cs | 4 +--- src/Core/Services/IMailDeliveryService.cs | 3 +-- src/Core/Services/IMailEnqueuingService.cs | 5 +---- src/Core/Services/IMailService.cs | 5 +---- src/Core/Services/IOrganizationService.cs | 5 +---- src/Core/Services/IPaymentService.cs | 4 +--- src/Core/Services/IPolicyService.cs | 4 +--- src/Core/Services/IProviderService.cs | 5 +---- src/Core/Services/IPushNotificationService.cs | 5 +---- src/Core/Services/IPushRegistrationService.cs | 4 +--- src/Core/Services/IReferenceEventService.cs | 3 +-- src/Core/Services/ISendService.cs | 5 +---- src/Core/Services/ISendStorageService.cs | 5 +---- src/Core/Services/ISsoConfigService.cs | 3 +-- src/Core/Services/IStripeAdapter.cs | 5 +---- src/Core/Services/IStripeSyncService.cs | 4 +--- src/Core/Services/IUserService.cs | 5 +---- .../Implementations/AmazonSesMailDeliveryService.cs | 6 +----- .../Implementations/AmazonSqsBlockIpService.cs | 4 +--- src/Core/Services/Implementations/AppleIapService.cs | 7 +------ .../Implementations/AzureAttachmentStorageService.cs | 6 +----- .../Implementations/AzureQueueBlockIpService.cs | 4 +--- .../Implementations/AzureQueueEventWriteService.cs | 6 +----- .../Services/Implementations/AzureQueueMailService.cs | 6 +----- .../AzureQueuePushNotificationService.cs | 5 +---- .../AzureQueueReferenceEventService.cs | 4 +--- .../Services/Implementations/AzureQueueService.cs | 5 +---- .../Implementations/AzureSendFileStorageService.cs | 6 +----- .../Implementations/BaseIdentityClientService.cs | 6 +----- .../Implementations/BlockingMailQueueService.cs | 6 +----- src/Core/Services/Implementations/CipherService.cs | 7 +------ .../Services/Implementations/CollectionService.cs | 5 +---- src/Core/Services/Implementations/DeviceService.cs | 4 +--- .../Implementations/EmergencyAccessService.cs | 6 +----- src/Core/Services/Implementations/EventService.cs | 6 +----- src/Core/Services/Implementations/GroupService.cs | 5 +---- .../Implementations/HCaptchaValidationService.cs | 6 +----- .../Services/Implementations/HandlebarsMailService.cs | 8 +------- src/Core/Services/Implementations/I18nService.cs | 3 +-- .../Services/Implementations/I18nViewLocalizer.cs | 5 +---- .../InMemoryApplicationCacheService.cs | 6 +----- .../InMemoryServiceBusApplicationCacheService.cs | 4 +--- src/Core/Services/Implementations/LicensingService.cs | 7 +------ .../Implementations/LocalAttachmentStorageService.cs | 5 +---- .../Implementations/LocalSendStorageService.cs | 6 +----- .../Implementations/MailKitSmtpMailDeliveryService.cs | 4 +--- .../MultiServiceMailDeliveryService.cs | 4 +--- .../MultiServicePushNotificationService.cs | 6 +----- .../NotificationHubPushNotificationService.cs | 5 +---- .../NotificationHubPushRegistrationService.cs | 6 +----- .../NotificationsApiPushNotificationService.cs | 6 +----- .../Services/Implementations/OrganizationService.cs | 7 +------ src/Core/Services/Implementations/PolicyService.cs | 5 +---- .../Implementations/RelayPushNotificationService.cs | 6 +----- .../Implementations/RelayPushRegistrationService.cs | 6 +----- .../Implementations/RepositoryEventWriteService.cs | 4 +--- .../Implementations/SendGridMailDeliveryService.cs | 5 +---- src/Core/Services/Implementations/SendService.cs | 6 +----- src/Core/Services/Implementations/SsoConfigService.cs | 5 +---- src/Core/Services/Implementations/StripeAdapter.cs | 5 +---- .../Services/Implementations/StripePaymentService.cs | 6 +----- .../Services/Implementations/StripeSyncService.cs | 3 +-- src/Core/Services/Implementations/UserService.cs | 7 +------ .../NoopAttachmentStorageService.cs | 5 +---- .../NoopImplementations/NoopBlockIpService.cs | 4 +--- .../NoopCaptchaValidationService.cs | 3 +-- .../Services/NoopImplementations/NoopEventService.cs | 5 +---- .../NoopImplementations/NoopEventWriteService.cs | 4 +--- .../NoopImplementations/NoopLicensingService.cs | 4 +--- .../NoopImplementations/NoopMailDeliveryService.cs | 3 +-- .../Services/NoopImplementations/NoopMailService.cs | 5 +---- .../NoopImplementations/NoopProviderService.cs | 5 +---- .../NoopPushNotificationService.cs | 5 +---- .../NoopPushRegistrationService.cs | 4 +--- .../NoopImplementations/NoopReferenceEventService.cs | 3 +-- .../NoopImplementations/NoopSendFileStorageService.cs | 5 +---- src/Core/Settings/GlobalSettings.cs | 4 +--- src/Core/Settings/IInstallationSettings.cs | 4 +--- src/Core/Sso/SamlSigningAlgorithms.cs | 4 +--- src/Core/Tokens/BadTokenException.cs | 4 +--- src/Core/Tokens/ExpiringTokenable.cs | 3 +-- src/Core/Tokens/IBillingSyncTokenable.cs | 4 +--- src/Core/Utilities/BillingHelpers.cs | 4 +--- src/Core/Utilities/BitPayClient.cs | 4 +--- src/Core/Utilities/ClaimsExtensions.cs | 5 +---- src/Core/Utilities/CoreHelpers.cs | 7 +------ src/Core/Utilities/CurrentContextMiddleware.cs | 3 +-- src/Core/Utilities/CustomIpRateLimitMiddleware.cs | 4 +--- src/Core/Utilities/DuoApi.cs | 3 --- src/Core/Utilities/DuoWeb.cs | 1 - src/Core/Utilities/EncryptedValueAttribute.cs | 3 +-- src/Core/Utilities/EpochDateTimeJsonConverter.cs | 3 +-- src/Core/Utilities/HandlebarsObjectJsonConverter.cs | 4 +--- src/Core/Utilities/HostBuilderExtensions.cs | 3 +-- src/Core/Utilities/JsonHelpers.cs | 4 +--- src/Core/Utilities/LoggerFactoryExtensions.cs | 3 +-- src/Core/Utilities/SecurityHeadersMiddleware.cs | 3 +-- src/Core/Utilities/StaticStore.cs | 4 +--- src/Core/Utilities/StrictEmailAddressListAttribute.cs | 4 +--- src/Events/Controllers/CollectController.cs | 6 +----- src/Events/Controllers/InfoController.cs | 3 +-- src/Events/Models/EventModel.cs | 3 +-- src/Events/Program.cs | 3 --- src/Events/Startup.cs | 5 ----- src/EventsProcessor/AzureQueueHostedService.cs | 10 +--------- src/EventsProcessor/Program.cs | 2 -- src/EventsProcessor/Startup.cs | 6 ------ src/Icons/Controllers/IconsController.cs | 5 +---- src/Icons/Controllers/InfoController.cs | 3 +-- src/Icons/Models/DomainName.cs | 6 +----- src/Icons/Models/IconResult.cs | 4 +--- src/Icons/Program.cs | 2 -- src/Icons/Services/DomainMappingService.cs | 4 +--- src/Icons/Services/IIconFetchingService.cs | 3 +-- src/Icons/Services/IconFetchingService.cs | 9 +-------- src/Icons/Startup.cs | 9 +-------- src/Identity/Controllers/AccountsController.cs | 5 +---- src/Identity/Controllers/InfoController.cs | 3 +-- src/Identity/Controllers/SsoController.cs | 9 +-------- src/Identity/Program.cs | 2 -- src/Identity/Startup.cs | 10 +--------- src/Identity/Utilities/DiscoveryResponseGenerator.cs | 5 +---- src/Identity/Utilities/ServiceCollectionExtensions.cs | 7 +------ src/Infrastructure.Dapper/DapperHelpers.cs | 4 +--- .../Repositories/BaseRepository.cs | 3 +-- .../Repositories/CipherRepository.cs | 6 +----- .../Repositories/CollectionCipherRepository.cs | 7 +------ .../Repositories/CollectionRepository.cs | 6 +----- .../Repositories/DateTimeHandler.cs | 3 +-- .../Repositories/DeviceRepository.cs | 6 +----- .../Repositories/EmergencyAccessRepository.cs | 6 +----- .../Repositories/EventRepository.cs | 6 +----- .../Repositories/FolderRepository.cs | 6 +----- .../Repositories/GrantRepository.cs | 5 +---- .../Repositories/GroupRepository.cs | 7 +------ .../Repositories/InstallationRepository.cs | 3 +-- .../Repositories/MaintenanceRepository.cs | 4 +--- .../Repositories/OrganizationApiKeyRepository.cs | 6 +----- .../Repositories/OrganizationConnectionRepository.cs | 6 +----- .../Repositories/OrganizationRepository.cs | 6 +----- .../Repositories/OrganizationSponsorshipRepository.cs | 6 +----- .../Repositories/OrganizationUserRepository.cs | 6 +----- .../Repositories/PolicyRepository.cs | 7 +------ .../Repositories/ProviderOrganizationRepository.cs | 6 +----- .../Repositories/ProviderRepository.cs | 6 +----- .../Repositories/ProviderUserRepository.cs | 7 +------ src/Infrastructure.Dapper/Repositories/Repository.cs | 5 +---- .../Repositories/SendRepository.cs | 6 +----- .../Repositories/SsoConfigRepository.cs | 6 +----- .../Repositories/SsoUserRepository.cs | 5 +---- .../Repositories/TaxRateRepository.cs | 5 +---- .../Repositories/TransactionRepository.cs | 6 +----- .../Repositories/UserRepository.cs | 7 +------ .../EntityFrameworkServiceCollectionExtensions.cs | 4 +--- src/Infrastructure.EntityFramework/Models/Cipher.cs | 3 +-- .../Models/Collection.cs | 3 +-- src/Infrastructure.EntityFramework/Models/Group.cs | 3 +-- .../Models/Organization.cs | 3 +-- .../Models/OrganizationUser.cs | 3 +-- src/Infrastructure.EntityFramework/Models/User.cs | 3 +-- .../Repositories/BaseEntityFrameworkRepository.cs | 6 +----- .../Repositories/CipherRepository.cs | 6 +----- .../Repositories/CollectionCipherRepository.cs | 6 +----- .../Repositories/CollectionRepository.cs | 6 +----- .../Repositories/DatabaseContext.cs | 4 +--- .../Repositories/DeviceRepository.cs | 6 +----- .../Repositories/EmergencyAccessRepository.cs | 6 +----- .../Repositories/EventRepository.cs | 6 +----- .../Repositories/FolderRepository.cs | 6 +----- .../Repositories/GrantRepository.cs | 5 +---- .../Repositories/GroupRepository.cs | 6 +----- .../Repositories/InstallationRepository.cs | 3 +-- .../Repositories/MaintenanceRepository.cs | 5 +---- .../Repositories/OrganizationApiKeyRepository.cs | 7 +------ .../Repositories/OrganizationConnectionRepository.cs | 6 +----- .../Repositories/OrganizationRepository.cs | 6 +----- .../Repositories/OrganizationSponsorshipRepository.cs | 6 +----- .../Repositories/OrganizationUserRepository.cs | 6 +----- .../Repositories/PolicyRepository.cs | 7 +------ .../Repositories/ProviderOrganizationRepository.cs | 6 +----- .../Repositories/ProviderRepository.cs | 6 +----- .../Repositories/ProviderUserRepository.cs | 6 +----- .../Repositories/Queries/CipherDetailsQuery.cs | 5 +---- .../Queries/CipherOrganizationDetailsReadByIdQuery.cs | 4 +--- ...ipherOrganizationDetailsReadByOrgizationIdQuery.cs | 4 +--- .../Queries/CipherReadCanEditByIdUserIdQuery.cs | 4 +--- .../Queries/CipherUpdateCollectionsQuery.cs | 5 +---- .../CollectionCipherReadByUserIdCipherIdQuery.cs | 4 +--- .../Queries/CollectionCipherReadByUserIdQuery.cs | 4 +--- .../CollectionReadCountByOrganizationIdQuery.cs | 4 +--- .../Queries/CollectionUserUpdateUsersQuery.cs | 6 +----- .../Queries/EmergencyAccessDetailsViewQuery.cs | 3 +-- .../EmergencyAccessReadCountByGrantorIdEmailQuery.cs | 4 +--- .../Queries/EventReadPageByCipherIdQuery.cs | 4 +--- .../EventReadPageByOrganizationIdActingUserIdQuery.cs | 4 +--- .../Queries/EventReadPageByOrganizationIdQuery.cs | 4 +--- .../EventReadPageByProviderIdActingUserIdQuery.cs | 4 +--- .../Queries/EventReadPageByProviderIdQuery.cs | 4 +--- .../Queries/EventReadPageByUserIdQuery.cs | 4 +--- .../Queries/GroupUserUpdateGroupsQuery.cs | 5 +---- .../Repositories/Queries/IQuery.cs | 4 +--- .../OrganizationUserOrganizationDetailsViewQuery.cs | 3 +-- ...onUserReadCountByFreeOrganizationAdminUserQuery.cs | 4 +--- .../OrganizationUserReadCountByOnlyOwnerQuery.cs | 4 +--- ...nizationUserReadCountByOrganizationIdEmailQuery.cs | 4 +--- .../OrganizationUserReadCountByOrganizationIdQuery.cs | 4 +--- .../OrganizationUserUpdateWithCollectionsQuery.cs | 4 +--- .../Queries/OrganizationUserUserViewQuery.cs | 3 +-- .../Queries/PolicyReadByTypeApplicableToUserQuery.cs | 4 +--- .../Repositories/Queries/PolicyReadByUserIdQuery.cs | 4 +--- ...izationOrganizationDetailsReadByProviderIdQuery.cs | 4 +--- .../ProviderUserOrganizationDetailsViewQuery.cs | 3 +-- ...viderUserProviderDetailsReadByUserIdStatusQuery.cs | 4 +--- .../Queries/ProviderUserReadCountByOnlyOwnerQuery.cs | 4 +--- .../UserBumpAccountRevisionDateByCipherIdQuery.cs | 3 +-- ...serBumpAccountRevisionDateByOrganizationIdQuery.cs | 4 +--- .../Repositories/Queries/UserCipherDetailsQuery.cs | 4 +--- .../Queries/UserCollectionDetailsQuery.cs | 4 +--- .../UserReadPublicKeysByProviderUserIdsQuery.cs | 5 +---- .../Repositories/Repository.cs | 6 +----- .../Repositories/SendRepository.cs | 6 +----- .../Repositories/SsoConfigRepository.cs | 6 +----- .../Repositories/SsoUserRepository.cs | 4 +--- .../Repositories/TaxRateRepository.cs | 5 +---- .../Repositories/TransactionRepository.cs | 6 +----- .../Repositories/UserRepository.cs | 6 +----- src/Notifications/AzureQueueHostedService.cs | 8 +------- src/Notifications/ConnectionCounter.cs | 4 +--- src/Notifications/Controllers/InfoController.cs | 3 +-- src/Notifications/Controllers/SendController.cs | 4 +--- src/Notifications/HeartbeatHostedService.cs | 7 +------ src/Notifications/HubHelpers.cs | 2 -- src/Notifications/Jobs/JobsHostedService.cs | 8 +------- src/Notifications/Jobs/LogConnectionCounterJob.cs | 5 +---- src/Notifications/NotificationsHub.cs | 4 +--- src/Notifications/Program.cs | 2 -- src/Notifications/Startup.cs | 8 +------- .../Utilities/ExceptionHandlerFilterAttribute.cs | 4 +--- .../Utilities/ModelStateValidationFilterAttribute.cs | 3 +-- .../Utilities/ServiceCollectionExtensions.cs | 6 +----- .../Attributes/ControllerCustomizeAttribute.cs | 3 +-- test/Api.Test/AutoFixture/ControllerCustomization.cs | 6 +----- test/Api.Test/Controllers/AccountsControllerTests.cs | 4 +--- .../Controllers/CollectionsControllerTests.cs | 6 +----- .../OrganizationConnectionsControllerTests.cs | 6 +----- .../OrganizationSponsorshipsControllerTests.cs | 6 +----- .../Controllers/OrganizationUsersControllerTests.cs | 4 +--- .../Controllers/OrganizationsControllerTests.cs | 4 +--- test/Api.Test/Controllers/SendsControllerTests.cs | 5 +---- .../Request/Accounts/PremiumRequestModelTests.cs | 7 +------ test/Api.Test/Models/Request/SendRequestModelTests.cs | 3 +-- test/Api.Test/Utilities/ApiHelpersTests.cs | 5 +---- .../Controllers/FreshsalesControllerTests.cs | 6 +----- .../AutoFixture/Attributes/BitAutoDataAttribute.cs | 4 +--- .../AutoFixture/Attributes/BitCustomizeAttribute.cs | 3 +-- .../Attributes/BitMemberAutoDataAttribute.cs | 4 +--- .../AutoFixture/Attributes/CustomAutoDataAttribute.cs | 4 +--- .../Attributes/EnvironmentDataAttribute.cs | 4 +--- .../Attributes/InlineCustomAutoDataAttribute.cs | 3 +-- .../Attributes/InlineSutAutoDataAttribute.cs | 4 +--- .../Attributes/RequiredEnvironmentTheoryAttribute.cs | 3 +-- .../AutoFixture/Attributes/SutAutoDataAttribute.cs | 4 +--- .../AutoFixture/BuilderWithoutAutoProperties.cs | 4 +--- test/Common/AutoFixture/GlobalSettingsFixtures.cs | 3 +-- test/Common/AutoFixture/ISutProvider.cs | 4 +--- test/Common/AutoFixture/JsonDocumentFixtures.cs | 3 +-- test/Common/AutoFixture/SutProvider.cs | 5 +---- test/Common/AutoFixture/SutProviderCustomization.cs | 3 +-- test/Common/Helpers/AssertHelper.cs | 5 +---- test/Common/Helpers/BitAutoDataAttributeHelpers.cs | 5 +---- test/Common/Helpers/TestCaseHelper.cs | 6 +----- test/Common/Test/TestCaseHelperTests.cs | 4 +--- .../AutoFixture/Attributes/CiSkippedTheory.cs | 4 +--- test/Core.Test/AutoFixture/CipherFixtures.cs | 5 +---- .../Core.Test/AutoFixture/CollectionCipherFixtures.cs | 3 +-- test/Core.Test/AutoFixture/CollectionFixtures.cs | 3 +-- test/Core.Test/AutoFixture/CurrentContextFixtures.cs | 4 +--- test/Core.Test/AutoFixture/DeviceFixtures.cs | 3 +-- test/Core.Test/AutoFixture/EmergencyAccessFixtures.cs | 3 +-- .../AutoFixture/EntityFrameworkRepositoryFixtures.cs | 4 +--- test/Core.Test/AutoFixture/EventFixtures.cs | 3 +-- test/Core.Test/AutoFixture/FolderFixtures.cs | 3 +-- test/Core.Test/AutoFixture/GrantFixtures.cs | 3 +-- test/Core.Test/AutoFixture/GroupFixtures.cs | 3 +-- test/Core.Test/AutoFixture/GroupUserFixtures.cs | 3 +-- test/Core.Test/AutoFixture/InstallationFixtures.cs | 3 +-- test/Core.Test/AutoFixture/OrganizationFixtures.cs | 5 +---- .../AutoFixture/OrganizationLicenseCustomization.cs | 3 +-- .../AutoFixture/OrganizationSponsorshipFixtures.cs | 3 +-- .../Core.Test/AutoFixture/OrganizationUserFixtures.cs | 4 +--- test/Core.Test/AutoFixture/PolicyFixtures.cs | 5 +---- .../AutoFixture/Relays/MaxLengthStringRelay.cs | 4 +--- test/Core.Test/AutoFixture/SendFixtures.cs | 3 +-- test/Core.Test/AutoFixture/SsoConfigFixtures.cs | 4 +--- test/Core.Test/AutoFixture/TaxRateFixtures.cs | 3 +-- test/Core.Test/AutoFixture/TransactionFixutres.cs | 3 +-- test/Core.Test/AutoFixture/UserFixtures.cs | 4 +--- test/Core.Test/Entities/OrganizationTests.cs | 3 +-- test/Core.Test/Entities/UserTests.cs | 3 +-- test/Core.Test/Helpers/Factories.cs | 3 +-- .../Identity/AuthenticationTokenProviderTests.cs | 4 +--- test/Core.Test/Identity/BaseTokenProviderTests.cs | 6 +----- test/Core.Test/Identity/EmailTokenProviderTests.cs | 4 +--- test/Core.Test/IdentityServer/TokenRetrievalTests.cs | 4 +--- test/Core.Test/Models/Business/TaxInfoTests.cs | 1 - .../Tokenables/EmergencyAccessInviteTokenableTests.cs | 3 +-- .../Business/Tokenables/HCaptchaTokenableTests.cs | 3 +-- .../OrganizationSponsorshipOfferTokenableTests.cs | 5 +---- .../Models/Business/Tokenables/SsoTokenableTests.cs | 3 +-- .../GetOrganizationApiKeyCommandTests.cs | 6 +----- .../RotateOrganizationApiKeyCommandTests.cs | 7 +------ .../CreateOrganizationConnectionCommandTests.cs | 4 +--- .../DeleteOrganizationConnectionCommandTests.cs | 5 +---- .../UpdateOrganizationConnectionCommandTests.cs | 4 +--- .../CancelSponsorshipCommandTestsBase.cs | 4 +--- .../Cloud/CloudRevokeSponsorshipCommandTests.cs | 3 +-- .../Cloud/CloudSyncSponsorshipsCommandTests.cs | 6 +----- .../Cloud/OrganizationSponsorshipRenewCommandTests.cs | 4 +--- .../Cloud/RemoveSponsorshipCommandTests.cs | 4 +--- .../Cloud/SendSponsorshipOfferCommandTests.cs | 3 +-- .../Cloud/SetUpSponsorshipCommandTests.cs | 4 +--- .../Cloud/ValidateBillingSyncKeyCommandTests.cs | 7 +------ .../Cloud/ValidateRedemptionTokenCommandTests.cs | 7 +------ .../Cloud/ValidateSponsorshipCommandTests.cs | 4 +--- .../CreateSponsorshipCommandTests.cs | 4 +--- .../FamiliesForEnterpriseTestsBase.cs | 5 +---- .../SelfHostedRevokeSponsorshipCommandTests.cs | 4 +--- .../SelfHostedSyncSponsorshipsCommandTests.cs | 8 +------- .../EntityFramework/CipherRepositoryTests.cs | 5 +---- .../EntityFramework/CollectionRepository.cs | 4 +--- .../EntityFramework/DeviceRepositoryTests.cs | 4 +--- .../EntityFramework/EmergencyAccessRepositoryTests.cs | 9 +-------- .../EqualityComparers/CipherCompare.cs | 3 +-- .../EqualityComparers/CollectionCompare.cs | 3 +-- .../EqualityComparers/DeviceCompare.cs | 3 +-- .../EqualityComparers/EmergencyAccessCompare.cs | 3 +-- .../EntityFramework/EqualityComparers/EventCompare.cs | 3 +-- .../EqualityComparers/FolderCompare.cs | 3 +-- .../EntityFramework/EqualityComparers/GrantCompare.cs | 3 +-- .../EntityFramework/EqualityComparers/GroupCompare.cs | 3 +-- .../EqualityComparers/InstallationCompare.cs | 3 +-- .../EqualityComparers/OrganizationCompare.cs | 3 +-- .../OrganizationSponsorshipCompare.cs | 3 +-- .../EqualityComparers/OrganizationUserCompare.cs | 3 +-- .../EqualityComparers/PolicyCompare.cs | 3 +-- .../EntityFramework/EqualityComparers/SendCompare.cs | 3 +-- .../EqualityComparers/SsoConfigCompare.cs | 3 +-- .../EqualityComparers/SsoUserCompare.cs | 3 +-- .../EqualityComparers/TaxRateCompare.cs | 3 +-- .../EqualityComparers/TransactionCompare.cs | 3 +-- .../EntityFramework/EqualityComparers/UserCompare.cs | 3 +-- .../EqualityComparers/UserKdfInformation.cs | 3 +-- .../EntityFramework/FolderRepositoryTests.cs | 5 +---- .../EntityFramework/InstallationRepositoryTests.cs | 4 +--- .../EntityFramework/OrganizationRepositoryTests.cs | 4 +--- .../OrganizationSponsorshipRepositoryTests.cs | 4 +--- .../OrganizationUserRepositoryTests.cs | 6 +----- .../EntityFramework/PolicyRepositoryTests.cs | 4 +--- .../EntityFramework/SendRepositoryTests.cs | 4 +--- .../EntityFramework/SsoConfigRepositoryTests.cs | 7 +------ .../EntityFramework/SsoUserRepositoryTests.cs | 6 +----- .../EntityFramework/TaxRateRepositoryTests.cs | 4 +--- .../EntityFramework/TransactionRepositoryTests.cs | 4 +--- .../EntityFramework/UserRepositoryTests.cs | 5 +---- test/Core.Test/Resources/VerifyResources.cs | 3 +-- .../Services/AmazonSesMailDeliveryServiceTests.cs | 6 +----- .../Services/AmazonSqsBlockIpServiceTests.cs | 4 +--- test/Core.Test/Services/AppleIapServiceTests.cs | 5 +---- .../Services/AzureAttachmentStorageServiceTests.cs | 3 +-- .../Services/AzureQueueBlockIpServiceTests.cs | 4 +--- .../Services/AzureQueueEventWriteServiceTests.cs | 3 +-- .../AzureQueuePushNotificationServiceTests.cs | 3 +-- test/Core.Test/Services/CipherServiceTests.cs | 6 +----- test/Core.Test/Services/CollectionServiceTests.cs | 5 +---- test/Core.Test/Services/DeviceServiceTests.cs | 4 +--- .../Core.Test/Services/EmergencyAccessServiceTests.cs | 7 +------ test/Core.Test/Services/EventServiceTests.cs | 6 +----- test/Core.Test/Services/GroupServiceTests.cs | 7 +------ test/Core.Test/Services/HandlebarsMailServiceTests.cs | 6 +----- .../Services/InMemoryApplicationCacheServiceTests.cs | 3 +-- .../InMemoryServiceBusApplicationCacheServiceTests.cs | 3 +-- test/Core.Test/Services/LicensingServiceTests.cs | 5 +---- .../Services/LocalAttachmentStorageServiceTests.cs | 5 +---- .../Services/MailKitSmtpMailDeliveryServiceTests.cs | 3 +-- .../MultiServicePushNotificationServiceTests.cs | 4 +--- .../NotificationHubPushNotificationServiceTests.cs | 3 +-- .../NotificationHubPushRegistrationServiceTests.cs | 3 +-- .../NotificationsApiPushNotificationServiceTests.cs | 4 +--- test/Core.Test/Services/OrganizationServiceTests.cs | 6 +----- test/Core.Test/Services/PolicyServiceTests.cs | 5 +---- .../Services/RelayPushNotificationServiceTests.cs | 4 +--- .../Services/RelayPushRegistrationServiceTests.cs | 4 +--- .../Services/RepositoryEventWriteServiceTests.cs | 3 +-- .../Services/SendGridMailDeliveryServiceTests.cs | 6 +----- test/Core.Test/Services/SendServiceTests.cs | 5 +---- test/Core.Test/Services/SsoConfigServiceTests.cs | 4 +--- test/Core.Test/Services/StripePaymentServiceTests.cs | 5 +---- test/Core.Test/Services/UserServiceTests.cs | 6 +----- test/Core.Test/TempDirectory.cs | 5 +---- test/Core.Test/Tokens/ExpiringTokenTests.cs | 3 +-- test/Core.Test/Utilities/ClaimsExtensionsTests.cs | 4 +--- test/Core.Test/Utilities/CoreHelpersTests.cs | 8 +------- .../Utilities/PermissiveStringConverterTests.cs | 4 +--- test/Core.Test/Utilities/SelfHostedAttributeTests.cs | 3 +-- .../Utilities/StrictEmailAddressListAttributeTests.cs | 3 +-- test/Icons.Test/Resources/VerifyResources.cs | 3 +-- test/Icons.Test/Services/IconFetchingServiceTests.cs | 4 +--- .../Controllers/AccountsControllerTests.cs | 4 +--- .../Endpoints/IdentityServerTests.cs | 11 +---------- .../Controllers/AccountsControllerTests.cs | 4 +--- .../Factories/IdentityApplicationFactory.cs | 5 +---- .../Factories/WebApplicationFactoryBase.cs | 4 +--- .../Factories/WebApplicationFactoryExtensions.cs | 7 +------ util/Migrator/DbMigrator.cs | 4 +--- util/MySqlMigrations/Factories.cs | 5 +---- .../MySqlMigrations/Migrations/20210617183900_Init.cs | 3 +-- ...09095522_RemoveProviderOrganizationProviderUser.cs | 3 +-- ...210921132418_AddMaxAutoscaleSeatsToOrganization.cs | 3 +-- ...211011144835_SplitManageCollectionsPermissions2.cs | 3 +-- ...21201150_SetMaxAutoscaleSeatsToCurrentSeatCount.cs | 3 +-- .../20211108225243_OrganizationSponsorship.cs | 3 +-- .../Migrations/20220121092546_RemoveU2F.cs | 3 +-- .../Migrations/20220301215315_FailedLoginCaptcha.cs | 3 +-- .../Migrations/20220322191314_SelfHostF4E.cs | 3 +-- .../20220411191518_SponsorshipBulkActions.cs | 3 +-- .../20220420170738_AddInstallationIdToEvents.cs | 3 +-- util/PostgresMigrations/Factories.cs | 5 +---- .../Migrations/20210708191531_Init.cs | 3 +-- ...09092227_RemoveProviderOrganizationProviderUser.cs | 3 +-- ...210920201829_AddMaxAutoscaleSeatsToOrganization.cs | 3 +-- ...211011145128_SplitManageCollectionsPermissions2.cs | 3 +-- ...21204521_SetMaxAutoscaleSeatsToCurrentSeatCount.cs | 3 +-- .../20211108225011_OrganizationSponsorship.cs | 3 +-- .../Migrations/20220121092321_RemoveU2F.cs | 3 +-- .../Migrations/20220301211818_FailedLoginCaptcha.cs | 3 +-- .../Migrations/20220322183505_SelfHostF4E.cs | 3 +-- .../20220411190525_SponsorshipBulkActions.cs | 3 +-- .../20220420171153_AddInstallationIdToEvents.cs | 3 +-- util/Server/Program.cs | 7 +------ util/Server/Startup.cs | 8 +------- util/Setup/AppIdBuilder.cs | 5 +---- util/Setup/CertBuilder.cs | 5 +---- util/Setup/Configuration.cs | 4 +--- util/Setup/Context.cs | 5 +---- util/Setup/DockerComposeBuilder.cs | 5 +---- util/Setup/EnvironmentFileBuilder.cs | 6 +----- util/Setup/Helpers.cs | 5 +---- util/Setup/NginxConfigBuilder.cs | 5 +---- util/Setup/Program.cs | 5 +---- util/Setup/YamlComments.cs | 5 +---- 906 files changed, 895 insertions(+), 3107 deletions(-) diff --git a/.editorconfig b/.editorconfig index 67dc70dff5..9c2beed95a 100644 --- a/.editorconfig +++ b/.editorconfig @@ -79,6 +79,9 @@ dotnet_diagnostic.CS0618.severity = suggestion # Obsolete warnings, this should be removed or changed to warning once we address some of the obsolete items. dotnet_diagnostic.CS0612.severity = suggestion +# Remove unnecessary using directives https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0005 +dotnet_diagnostic.IDE0005.severity = warning + # CSharp code style settings: [*.cs] # Prefer "var" everywhere diff --git a/Directory.Build.props b/Directory.Build.props index 2e4c0d642c..e37e45855a 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -1,12 +1,13 @@ - - net6.0 + + net6.0 - 2022.6.0 - Bit.$(MSBuildProjectName) + 2022.6.0 + Bit.$(MSBuildProjectName) true - + enable +