Refactor PendingSecurityTasks to RefreshSecurityTasks (#5903)

- Allows for more general use case of security task notifications

src/Core/Enums/PushType.cs

@@ -31,5 +31,5 @@ public enum PushType : byte
     Notification = 20,
     NotificationStatus = 21,
 
-    PendingSecurityTasks = 22
+    RefreshSecurityTasks = 22
 }

src/Core/Platform/Push/Services/IPushNotificationService.cs

@@ -389,10 +389,10 @@ public interface IPushNotificationService
             ExcludeCurrentContext = false,
         });
 
-    Task PushPendingSecurityTasksAsync(Guid userId)
+    Task PushRefreshSecurityTasksAsync(Guid userId)
         => PushAsync(new PushNotification<UserPushNotification>
         {
-            Type = PushType.PendingSecurityTasks,
+            Type = PushType.RefreshSecurityTasks,
             Target = NotificationTarget.User,
             TargetId = userId,
             Payload = new UserPushNotification

src/Core/Vault/Commands/CreateManyTaskNotificationsCommand.cs

@@ -89,7 +89,7 @@ public class CreateManyTaskNotificationsCommand : ICreateManyTaskNotificationsCo
             }
 
             // Notify the user that they have pending security tasks
-            await _pushNotificationService.PushPendingSecurityTasksAsync(userId);
+            await _pushNotificationService.PushRefreshSecurityTasksAsync(userId);
         }
     }
 }

src/Core/Vault/Commands/MarkNotificationsForTaskAsDeletedCommand.cs

@@ -26,7 +26,7 @@ public class MarkNotificationsForTaskAsDeletedCommand : IMarkNotificationsForTas
         var uniqueUserIds = userIds.Distinct();
         foreach (var id in uniqueUserIds)
         {
-            await _pushNotificationService.PushPendingSecurityTasksAsync(id);
+            await _pushNotificationService.PushRefreshSecurityTasksAsync(id);
         }
     }
 }

src/Notifications/HubHelpers.cs

@@ -135,7 +135,7 @@ public static class HubHelpers
                 }
 
                 break;
-            case PushType.PendingSecurityTasks:
+            case PushType.RefreshSecurityTasks:
                 var pendingTasksData = JsonSerializer.Deserialize<PushNotificationData<UserPushNotification>>(notificationJson, _deserializerOptions);
                 await hubContext.Clients.User(pendingTasksData.Payload.UserId.ToString())
                     .SendAsync(_receiveMessageMethod, pendingTasksData, cancellationToken);

test/Api.IntegrationTest/Platform/Controllers/PushControllerTests.cs

@@ -166,7 +166,7 @@ public class PushControllerTests
         yield return UserTyped(PushType.SyncOrgKeys);
         yield return UserTyped(PushType.SyncSettings);
         yield return UserTyped(PushType.LogOut);
-        yield return UserTyped(PushType.PendingSecurityTasks);
+        yield return UserTyped(PushType.RefreshSecurityTasks);
 
         yield return Typed(new PushSendRequestModel<AuthRequestPushNotification>
         {

test/Core.Test/Platform/Push/Services/AzureQueuePushNotificationServiceTests.cs

@@ -707,7 +707,7 @@ public class AzureQueuePushNotificationServiceTests
     }
 
     [Fact]
-    public async Task PushPendingSecurityTasksAsync_SendsExpectedResponse()
+    public async Task PushRefreshSecurityTasksAsync_SendsExpectedResponse()
     {
         var userId = Guid.NewGuid();
 
@@ -722,7 +722,7 @@ public class AzureQueuePushNotificationServiceTests
         };
 
         await VerifyNotificationAsync(
-            async sut => await sut.PushPendingSecurityTasksAsync(userId),
+            async sut => await sut.PushRefreshSecurityTasksAsync(userId),
             expectedPayload
         );
     }

test/Core.Test/Platform/Push/Services/NotificationsApiPushNotificationServiceTests.cs

@@ -368,7 +368,7 @@ public class NotificationsApiPushNotificationServiceTests : PushTestBase
         };
     }
 
-    protected override JsonNode GetPushPendingSecurityTasksResponsePayload(Guid userId)
+    protected override JsonNode GetPushRefreshSecurityTasksResponsePayload(Guid userId)
     {
         return new JsonObject
         {

test/Core.Test/Platform/Push/Services/PushTestBase.cs

@@ -93,7 +93,7 @@ public abstract class PushTestBase
     protected abstract JsonNode GetPushNotificationStatusResponsePayload(Notification notification, NotificationStatus notificationStatus, Guid? userId, Guid? organizationId);
     protected abstract JsonNode GetPushSyncOrganizationStatusResponsePayload(Organization organization);
     protected abstract JsonNode GetPushSyncOrganizationCollectionManagementSettingsResponsePayload(Organization organization);
-    protected abstract JsonNode GetPushPendingSecurityTasksResponsePayload(Guid userId);
+    protected abstract JsonNode GetPushRefreshSecurityTasksResponsePayload(Guid userId);
 
     [Fact]
     public async Task PushSyncCipherCreateAsync_SendsExpectedResponse()
@@ -444,13 +444,13 @@ public abstract class PushTestBase
     }
 
     [Fact]
-    public async Task PushPendingSecurityTasksAsync_SendsExpectedResponse()
+    public async Task PushRefreshSecurityTasksAsync_SendsExpectedResponse()
     {
         var userId = Guid.NewGuid();
 
         await VerifyNotificationAsync(
-            async sut => await sut.PushPendingSecurityTasksAsync(userId),
-            GetPushPendingSecurityTasksResponsePayload(userId)
+            async sut => await sut.PushRefreshSecurityTasksAsync(userId),
+            GetPushRefreshSecurityTasksResponsePayload(userId)
         );
     }
 

test/Core.Test/Platform/Push/Services/RelayPushNotificationServiceTests.cs

@@ -491,7 +491,7 @@ public class RelayPushNotificationServiceTests : PushTestBase
         };
     }
 
-    protected override JsonNode GetPushPendingSecurityTasksResponsePayload(Guid userId)
+    protected override JsonNode GetPushRefreshSecurityTasksResponsePayload(Guid userId)
     {
         return new JsonObject
         {