nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-04 01:22:50 -05:00
Code Activity

[AC-1669] Bug - Remove obsolete assignUserId from CollectionService.SaveAsync(...) (#3312)

Browse Source 
* fix: remove AssignUserId from CollectionService.SaveAsync, refs AC-1669

* fix: add manage access conditional before creating collection, refs AC-1669

* fix: move access logic for create/update, fix all tests, refs AC-1669

* fix: add CollectionAccessSelection fixture, update tests, update bad reqeuest message, refs AC-1669

* fix: format, refs AC-1669

* fix: update null params with specific arg.is null checks, refs Ac-1669

* fix: update attribute class name, refs AC-1669
This commit is contained in:
Vincent Salucci
2023-10-05 15:13:28 -05:00
committed by GitHub
parent fbb7aa1350
commit 279d0ccf62
6 changed files with 93 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Api/Controllers/CollectionsController.cs
View File

@ -161,7 +161,7 @@ public class CollectionsController : Controller
var groups = model.Groups?.Select(g => g.ToSelectionReadOnly());
var users = model.Users?.Select(g => g.ToSelectionReadOnly());
await _collectionService.SaveAsync(collection, groups, users, _currentContext.UserId);
await _collectionService.SaveAsync(collection, groups, users);
return new CollectionResponseModel(collection);
}