nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-06 05:28:15 -05:00
Code

[PM-7919] return exception if trying to overwrite keypair (#4052)

Browse Source 
* return exception if trying to overwrite keypair

* add feature flag
This commit is contained in:
Jake Fink 2024-05-06 08:49:18 -04:00 committed by GitHub
parent 90e065556e
commit 2a535ac835
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Api/Auth/Controllers/AccountsController.cs
View File

@ -618,6 +618,14 @@ public class AccountsController : Controller
throw new UnauthorizedAccessException(); throw new UnauthorizedAccessException();
} }
if (_featureService.IsEnabled(FeatureFlagKeys.ReturnErrorOnExistingKeypair))
{
if (!string.IsNullOrWhiteSpace(user.PrivateKey) || !string.IsNullOrWhiteSpace(user.PublicKey))
{
throw new BadRequestException("User has existing keypair");
}
}
await _userService.SaveUserAsync(model.ToUser(user)); await _userService.SaveUserAsync(model.ToUser(user));
return new KeysResponseModel(user); return new KeysResponseModel(user);
} }

2
src/Core/Constants.cs
View File

@ -109,6 +109,8 @@ public static class FeatureFlagKeys
public const string Fido2VaultCredentials = "fido2-vault-credentials"; public const string Fido2VaultCredentials = "fido2-vault-credentials";
public const string VaultOnboarding = "vault-onboarding"; public const string VaultOnboarding = "vault-onboarding";
public const string BrowserFilelessImport = "browser-fileless-import"; public const string BrowserFilelessImport = "browser-fileless-import";
public const string ReturnErrorOnExistingKeypair = "return-error-on-existing-keypair";
/// <summary> /// <summary>
/// Deprecated - never used, do not use. Will always default to false. Will be deleted as part of Flexible Collections cleanup /// Deprecated - never used, do not use. Will always default to false. Will be deleted as part of Flexible Collections cleanup
/// </summary> /// </summary>