[SG-1082]-Defect-Update stored procedure to properly determine is SSO is available (#2715)

* Fixed SsoAvailble bug by using the enabled column from SsoConfig table, updated the existing query for EF Core

* Added no tracking to ef query since it is read only

src/Core/Models/Data/Organizations/OrganizationDomainSsoDetailsData.cs

@@ -10,7 +10,7 @@ public class OrganizationDomainSsoDetailsData
     public bool SsoAvailable { get; set; }
     public string OrganizationIdentifier { get; set; }
     public bool SsoRequired { get; set; }
-    public PolicyType PolicyType { get; set; }
+    public PolicyType? PolicyType { get; set; }
     public DateTime? VerifiedDate { get; set; }
     public bool OrganizationEnabled { get; set; }
 }

src/Infrastructure.EntityFramework/Repositories/OrganizationDomainRepository.cs

@@ -74,32 +74,25 @@ public class OrganizationDomainRepository : Repository<Core.Entities.Organizatio
 
         using var scope = ServiceScopeFactory.CreateScope();
         var dbContext = GetDatabaseContext(scope);
-        var ssoDetails = await dbContext.Organizations
+        var ssoDetails = await (from o in dbContext.Organizations
-            .Join(dbContext.OrganizationDomains, o => o.Id, od => od.OrganizationId,
+                                from od in o.Domains
-                (organization, domain) => new { resOrganization = organization, resDomain = domain })
+                                join s in dbContext.SsoConfigs on o.Id equals s.OrganizationId into sJoin
-            .Join(dbContext.Policies, o => o.resOrganization.Id, p => p.OrganizationId,
+                                from s in sJoin.DefaultIfEmpty()
-                (combinedOrgDomain, policy)
+                                join p in dbContext.Policies.Where(p => p.Type == PolicyType.RequireSso) on o.Id
-                    => new
+                                    equals p.OrganizationId into pJoin
-                    {
+                                from p in pJoin.DefaultIfEmpty()
-                        Organization = combinedOrgDomain.resOrganization,
+                                where od.DomainName == domainName && o.Enabled
-                        Domain = combinedOrgDomain.resDomain,
+                                select new OrganizationDomainSsoDetailsData
-                        Policy = policy
+                                {
-                    })
+                                    OrganizationId = o.Id,
-            .Select(x => new OrganizationDomainSsoDetailsData
+                                    OrganizationName = o.Name,
-            {
+                                    SsoAvailable = o.SsoConfigs.Any(sc => sc.Enabled),
-                OrganizationId = x.Organization.Id,
+                                    SsoRequired = p != null && p.Enabled,
-                OrganizationName = x.Organization.Name,
+                                    OrganizationIdentifier = o.Identifier,
-                SsoAvailable = x.Organization.UseSso,
+                                    VerifiedDate = od.VerifiedDate,
-                OrganizationIdentifier = x.Organization.Identifier,
+                                    PolicyType = p.Type,
-                SsoRequired = x.Policy.Enabled,
+                                    DomainName = od.DomainName
-                VerifiedDate = x.Domain.VerifiedDate,
+                                })
-                PolicyType = x.Policy.Type,
-                DomainName = x.Domain.DomainName,
-                OrganizationEnabled = x.Organization.Enabled
-            })
-            .Where(y => y.DomainName == domainName
-                        && y.OrganizationEnabled == true
-                        && y.PolicyType.Equals(PolicyType.RequireSso))
             .AsNoTracking()
             .SingleOrDefaultAsync();
 

src/Sql/dbo/Stored Procedures/OrganizationDomainSsoDetails_ReadByEmail.sql

@@ -11,7 +11,7 @@ BEGIN
     SELECT
         O.Id AS OrganizationId,
         O.[Name] AS OrganizationName,
-        O.UseSso AS SsoAvailable,
+        S.Enabled AS SsoAvailable,
         P.Enabled AS SsoRequired,
         O.Identifier AS OrganizationIdentifier,
         OD.VerifiedDate,
@@ -23,6 +23,8 @@ BEGIN
         ON O.Id = OD.OrganizationId
     LEFT JOIN [dbo].[PolicyView] P
         ON O.Id = P.OrganizationId
+    LEFT JOIN [dbo].[Ssoconfig] S
+        ON O.Id = S.OrganizationId
     WHERE OD.DomainName = @Domain
     AND O.Enabled = 1
     AND (P.Id is NULL OR (P.Id IS NOT NULL AND P.[Type] = 4)) -- SSO Type

util/Migrator/DbScripts/2023-02-16_FixSsoAvailableOrganizationDomain.sql

@@ -0,0 +1,31 @@
+CREATE OR ALTER PROCEDURE [dbo].[OrganizationDomainSsoDetails_ReadByEmail]
+    @Email NVARCHAR(256)
+AS
+BEGIN
+    SET NOCOUNT ON
+        
+    DECLARE @Domain NVARCHAR(256)
+
+SELECT @Domain = SUBSTRING(@Email, CHARINDEX( '@', @Email) + 1, LEN(@Email))
+
+SELECT
+    O.Id AS OrganizationId,
+    O.[Name] AS OrganizationName,
+    S.Enabled AS SsoAvailable,
+    P.Enabled AS SsoRequired,
+    O.Identifier AS OrganizationIdentifier,
+    OD.VerifiedDate,
+    P.[Type] AS PolicyType,
+    OD.DomainName
+FROM
+    [dbo].[OrganizationView] O
+    INNER JOIN [dbo].[OrganizationDomainView] OD
+ON O.Id = OD.OrganizationId
+    LEFT JOIN [dbo].[PolicyView] P
+    ON O.Id = P.OrganizationId
+    LEFT JOIN [dbo].[Ssoconfig] S
+    ON O.Id = S.OrganizationId
+WHERE OD.DomainName = @Domain
+  AND O.Enabled = 1
+  AND (P.Id is NULL OR (P.Id IS NOT NULL AND P.[Type] = 4)) -- SSO Type
+END