nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-05 21:18:13 -05:00
Code

Add unit test coverage for AmazonSqsBlockIpService

Browse Source
This commit is contained in:
Mike Hanson 2020-06-18 10:16:04 -07:00
parent 398867a839
commit 4115b2e13e
1 changed files with 51 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
test/Core.Test/Services/AmazonSqsBlockIpServiceTests.cs
View File

@ -1,4 +1,6 @@
using System; using System;
using System.Threading.Tasks;
using Amazon.SQS;
using Bit.Core.Services; using Bit.Core.Services;
using NSubstitute; using NSubstitute;
using Xunit; using Xunit;
@ -10,12 +12,23 @@ namespace Bit.Core.Test.Services
private readonly AmazonSqsBlockIpService _sut; private readonly AmazonSqsBlockIpService _sut;
private readonly GlobalSettings _globalSettings; private readonly GlobalSettings _globalSettings;
private readonly IAmazonSQS _amazonSqs;
public AmazonSqsBlockIpServiceTests() public AmazonSqsBlockIpServiceTests()
{ {
_globalSettings = new GlobalSettings(); _globalSettings = new GlobalSettings
{
Amazon =
{
AccessKeyId = "AccessKeyId-AmazonSesMailDeliveryServiceTests",
AccessKeySecret = "AccessKeySecret-AmazonSesMailDeliveryServiceTests",
Region = "Region-AmazonSesMailDeliveryServiceTests"
}
};
_sut = new AmazonSqsBlockIpService(_globalSettings); _amazonSqs = Substitute.For<IAmazonSQS>();
_sut = new AmazonSqsBlockIpService(_globalSettings, _amazonSqs);
} }
public void Dispose() public void Dispose()
@ -23,12 +36,43 @@ namespace Bit.Core.Test.Services
_sut?.Dispose(); _sut?.Dispose();
} }
// Remove this test when we add actual tests. It only proves that [Fact]
// we've properly constructed the system under test. public async Task BlockIpAsync_UnblockCalled_WhenNotPermanent()
[Fact(Skip = "Needs additional work")]
public void ServiceExists()
{ {
Assert.NotNull(_sut); const string expectedIp = "ip";
await _sut.BlockIpAsync(expectedIp, false);
await _amazonSqs.Received(2).SendMessageAsync(
Arg.Any<string>(),
Arg.Is(expectedIp));
}
[Fact]
public async Task BlockIpAsync_UnblockNotCalled_WhenPermanent()
{
const string expectedIp = "ip";
await _sut.BlockIpAsync(expectedIp, true);
await _amazonSqs.Received(1).SendMessageAsync(
Arg.Any<string>(),
Arg.Is(expectedIp));
}
[Fact]
public async Task BlockIpAsync_NotBlocked_WhenAlreadyBlockedRecently()
{
const string expectedIp = "ip";
await _sut.BlockIpAsync(expectedIp, true);
// The second call should hit the already blocked guard clause
await _sut.BlockIpAsync(expectedIp, true);
await _amazonSqs.Received(1).SendMessageAsync(
Arg.Any<string>(),
Arg.Is(expectedIp));
} }
} }
} }