mirror of
https://github.com/bitwarden/server.git
synced 2025-07-03 09:02:48 -05:00
[PM-14381] Add POST /tasks/bulk-create endpoint (#5188)
* [PM-14378] Introduce GetCipherPermissionsForOrganization query for Dapper CipherRepository * [PM-14378] Introduce GetCipherPermissionsForOrganization method for Entity Framework * [PM-14378] Add integration tests for new repository method * [PM-14378] Introduce IGetCipherPermissionsForUserQuery CQRS query * [PM-14378] Introduce SecurityTaskOperationRequirement * [PM-14378] Introduce SecurityTaskAuthorizationHandler.cs * [PM-14378] Introduce SecurityTaskOrganizationAuthorizationHandler.cs * [PM-14378] Register new authorization handlers * [PM-14378] Formatting * [PM-14378] Add unit tests for GetCipherPermissionsForUserQuery * [PM-15378] Cleanup SecurityTaskAuthorizationHandler and add tests * [PM-14378] Add tests for SecurityTaskOrganizationAuthorizationHandler * [PM-14378] Formatting * [PM-14378] Update date in migration file * [PM-14378] Add missing awaits * Added bulk create request model * Created sproc to create bulk security tasks * Renamed tasks to SecurityTasksInput * Added create many implementation for sqlserver and ef core * removed trailing comma * created ef implementatin for create many and added integration test * Refactored request model * Refactored request model * created create many tasks command interface and class * added security authorization handler work temp * Added the implementation for the create manys tasks command * Added comment * Changed return to return list of created security tasks * Registered command * Completed bulk create action * Added unit tests for the command * removed hard coded table name * Fixed lint issue * Added JsonConverter attribute to allow enum value to be passed as string * Removed makshift security task operations * Fixed references * Removed old migration * Rebased * [PM-14378] Introduce GetCipherPermissionsForOrganization query for Dapper CipherRepository * [PM-14378] Introduce GetCipherPermissionsForOrganization method for Entity Framework * [PM-14378] Add unit tests for GetCipherPermissionsForUserQuery * Completed bulk create action * bumped migration version * Fixed lint issue * Removed complex sql data type in favour of json string * Register IGetTasksForOrganizationQuery * Fixed lint issue * Removed tasks grouping * Fixed linting * Removed unused code * Removed unused code * Aligned with client change * Fixed linting --------- Co-authored-by: Shane Melton <smelton@bitwarden.com>
This commit is contained in:
@ -1,16 +0,0 @@
|
||||
using Microsoft.AspNetCore.Authorization.Infrastructure;
|
||||
|
||||
namespace Bit.Core.Vault.Authorization;
|
||||
|
||||
public class SecurityTaskOperationRequirement : OperationAuthorizationRequirement
|
||||
{
|
||||
public SecurityTaskOperationRequirement(string name)
|
||||
{
|
||||
Name = name;
|
||||
}
|
||||
}
|
||||
|
||||
public static class SecurityTaskOperations
|
||||
{
|
||||
public static readonly SecurityTaskOperationRequirement Update = new(nameof(Update));
|
||||
}
|
65
src/Core/Vault/Commands/CreateManyTasksCommand.cs
Normal file
65
src/Core/Vault/Commands/CreateManyTasksCommand.cs
Normal file
@ -0,0 +1,65 @@
|
||||
using Bit.Core.Context;
|
||||
using Bit.Core.Exceptions;
|
||||
using Bit.Core.Utilities;
|
||||
using Bit.Core.Vault.Authorization.SecurityTasks;
|
||||
using Bit.Core.Vault.Commands.Interfaces;
|
||||
using Bit.Core.Vault.Entities;
|
||||
using Bit.Core.Vault.Enums;
|
||||
using Bit.Core.Vault.Models.Api;
|
||||
using Bit.Core.Vault.Repositories;
|
||||
using Microsoft.AspNetCore.Authorization;
|
||||
|
||||
namespace Bit.Core.Vault.Commands;
|
||||
|
||||
public class CreateManyTasksCommand : ICreateManyTasksCommand
|
||||
{
|
||||
private readonly IAuthorizationService _authorizationService;
|
||||
private readonly ICurrentContext _currentContext;
|
||||
private readonly ISecurityTaskRepository _securityTaskRepository;
|
||||
|
||||
public CreateManyTasksCommand(
|
||||
ISecurityTaskRepository securityTaskRepository,
|
||||
IAuthorizationService authorizationService,
|
||||
ICurrentContext currentContext)
|
||||
{
|
||||
_securityTaskRepository = securityTaskRepository;
|
||||
_authorizationService = authorizationService;
|
||||
_currentContext = currentContext;
|
||||
}
|
||||
|
||||
/// <inheritdoc />
|
||||
public async Task<ICollection<SecurityTask>> CreateAsync(Guid organizationId,
|
||||
IEnumerable<SecurityTaskCreateRequest> tasks)
|
||||
{
|
||||
if (!_currentContext.UserId.HasValue)
|
||||
{
|
||||
throw new NotFoundException();
|
||||
}
|
||||
|
||||
var tasksList = tasks?.ToList();
|
||||
|
||||
if (tasksList is null || tasksList.Count == 0)
|
||||
{
|
||||
throw new BadRequestException("No tasks provided.");
|
||||
}
|
||||
|
||||
var securityTasks = tasksList.Select(t => new SecurityTask
|
||||
{
|
||||
OrganizationId = organizationId,
|
||||
CipherId = t.CipherId,
|
||||
Type = t.Type,
|
||||
Status = SecurityTaskStatus.Pending
|
||||
}).ToList();
|
||||
|
||||
// Verify authorization for each task
|
||||
foreach (var task in securityTasks)
|
||||
{
|
||||
await _authorizationService.AuthorizeOrThrowAsync(
|
||||
_currentContext.HttpContext.User,
|
||||
task,
|
||||
SecurityTaskOperations.Create);
|
||||
}
|
||||
|
||||
return await _securityTaskRepository.CreateManyAsync(securityTasks);
|
||||
}
|
||||
}
|
@ -0,0 +1,17 @@
|
||||
using Bit.Core.Vault.Entities;
|
||||
using Bit.Core.Vault.Models.Api;
|
||||
|
||||
namespace Bit.Core.Vault.Commands.Interfaces;
|
||||
|
||||
public interface ICreateManyTasksCommand
|
||||
{
|
||||
/// <summary>
|
||||
/// Creates multiple security tasks for an organization.
|
||||
/// Each task must be authorized and the user must have the Create permission
|
||||
/// and associated ciphers must belong to the organization.
|
||||
/// </summary>
|
||||
/// <param name="organizationId">The </param>
|
||||
/// <param name="tasks"></param>
|
||||
/// <returns>Collection of created security tasks</returns>
|
||||
Task<ICollection<SecurityTask>> CreateAsync(Guid organizationId, IEnumerable<SecurityTaskCreateRequest> tasks);
|
||||
}
|
@ -1,7 +1,7 @@
|
||||
using Bit.Core.Context;
|
||||
using Bit.Core.Exceptions;
|
||||
using Bit.Core.Utilities;
|
||||
using Bit.Core.Vault.Authorization;
|
||||
using Bit.Core.Vault.Authorization.SecurityTasks;
|
||||
using Bit.Core.Vault.Commands.Interfaces;
|
||||
using Bit.Core.Vault.Enums;
|
||||
using Bit.Core.Vault.Repositories;
|
||||
|
9
src/Core/Vault/Models/Api/SecurityTaskCreateRequest.cs
Normal file
9
src/Core/Vault/Models/Api/SecurityTaskCreateRequest.cs
Normal file
@ -0,0 +1,9 @@
|
||||
using Bit.Core.Vault.Enums;
|
||||
|
||||
namespace Bit.Core.Vault.Models.Api;
|
||||
|
||||
public class SecurityTaskCreateRequest
|
||||
{
|
||||
public SecurityTaskType Type { get; set; }
|
||||
public Guid? CipherId { get; set; }
|
||||
}
|
@ -21,4 +21,11 @@ public interface ISecurityTaskRepository : IRepository<SecurityTask, Guid>
|
||||
/// <param name="status">Optional filter for task status. If not provided, returns tasks of all statuses</param>
|
||||
/// <returns></returns>
|
||||
Task<ICollection<SecurityTask>> GetManyByOrganizationIdStatusAsync(Guid organizationId, SecurityTaskStatus? status = null);
|
||||
|
||||
/// <summary>
|
||||
/// Creates bulk security tasks for an organization.
|
||||
/// </summary>
|
||||
/// <param name="tasks">Collection of tasks to create</param>
|
||||
/// <returns>Collection of created security tasks</returns>
|
||||
Task<ICollection<SecurityTask>> CreateManyAsync(IEnumerable<SecurityTask> tasks);
|
||||
}
|
||||
|
@ -21,5 +21,6 @@ public static class VaultServiceCollectionExtensions
|
||||
services.AddScoped<IMarkTaskAsCompleteCommand, MarkTaskAsCompletedCommand>();
|
||||
services.AddScoped<IGetCipherPermissionsForUserQuery, GetCipherPermissionsForUserQuery>();
|
||||
services.AddScoped<IGetTasksForOrganizationQuery, GetTasksForOrganizationQuery>();
|
||||
services.AddScoped<ICreateManyTasksCommand, CreateManyTasksCommand>();
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user