nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-06 21:48:12 -05:00
Code

catch errors when processing notification messages

Browse Source
This commit is contained in:
Kyle Spearrin 2019-05-07 22:06:05 -04:00
parent 1c38fcda85
commit 4e65275a2f
1 changed files with 28 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/Notifications/AzureQueueHostedService.cs
View File

@ -59,6 +59,8 @@ namespace Bit.Notifications
_queue = queueClient.GetQueueReference("notifications"); _queue = queueClient.GetQueueReference("notifications");
while(!cancellationToken.IsCancellationRequested) while(!cancellationToken.IsCancellationRequested)
{
try
{ {
var messages = await _queue.GetMessagesAsync(32, TimeSpan.FromMinutes(1), var messages = await _queue.GetMessagesAsync(32, TimeSpan.FromMinutes(1),
null, null, cancellationToken); null, null, cancellationToken);
@ -66,15 +68,33 @@ namespace Bit.Notifications
{ {
foreach(var message in messages) foreach(var message in messages)
{ {
await HubHelpers.SendNotificationToHubAsync(message.AsString, _hubContext, cancellationToken); try
{
await HubHelpers.SendNotificationToHubAsync(
message.AsString, _hubContext, cancellationToken);
await _queue.DeleteMessageAsync(message); await _queue.DeleteMessageAsync(message);
} }
catch(Exception e)
{
_logger.LogError("Error processing dequeued message: " +
$"{message.Id} x{message.DequeueCount}.", e);
if(message.DequeueCount > 2)
{
await _queue.DeleteMessageAsync(message);
}
}
}
} }
else else
{ {
await Task.Delay(TimeSpan.FromSeconds(5), cancellationToken); await Task.Delay(TimeSpan.FromSeconds(5), cancellationToken);
} }
} }
catch(Exception e)
{
_logger.LogError("Error processing messages.", e);
}
}
} }
} }
} }