From 594c9e9e3e3a856dd31c38d6498b228f5979b1e8 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Sat, 16 Feb 2019 09:15:24 -0500 Subject: [PATCH] blacklist of link rels to ignore --- src/Icons/Services/IconFetchingService.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Icons/Services/IconFetchingService.cs b/src/Icons/Services/IconFetchingService.cs index ed1cc0cb39..c234079039 100644 --- a/src/Icons/Services/IconFetchingService.cs +++ b/src/Icons/Services/IconFetchingService.cs @@ -17,6 +17,8 @@ namespace Bit.Icons.Services { private readonly HashSet _iconRels = new HashSet { "icon", "apple-touch-icon", "shortcut icon" }; + private readonly HashSet _blacklistedRels = + new HashSet { "preload", "image_src", "preconnect", "canonical", "alternate", "stylesheet" }; private readonly HashSet _iconExtensions = new HashSet { ".ico", ".png", ".jpg", ".jpeg" }; @@ -155,7 +157,7 @@ namespace Bit.Icons.Services { icons.Add(new IconResult(hrefAttr.Value, sizesAttr?.Value)); } - else + else if(relAttr == null || !_blacklistedRels.Contains(relAttr.Value.ToLower())) { try {