nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-06 05:28:15 -05:00
Code

Early return default on null user (#1645)

Browse Source 
Clearly, no known device exists for an unknown user.
This commit is contained in:
Matt Gibson 2021-10-19 09:48:23 -05:00 committed by GitHub
parent 18006591fc
commit 5b1d8c723a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Core/IdentityServer/BaseRequestValidator.cs
View File

@ -474,9 +474,15 @@ namespace Bit.Core.IdentityServer
protected async Task<bool> KnownDeviceAsync(User user, ValidatedTokenRequest request) => protected async Task<bool> KnownDeviceAsync(User user, ValidatedTokenRequest request) =>
(await GetKnownDeviceAsync(user, request)) != default; (await GetKnownDeviceAsync(user, request)) != default;
protected async Task<Device> GetKnownDeviceAsync(User user, ValidatedTokenRequest request) => protected async Task<Device> GetKnownDeviceAsync(User user, ValidatedTokenRequest request)
await _deviceRepository.GetByIdentifierAsync(GetDeviceFromRequest(request).Identifier, user.Id); {
if (user == null)
{
return default;
}
return await _deviceRepository.GetByIdentifierAsync(GetDeviceFromRequest(request).Identifier, user.Id);
}
private async Task<Device> SaveDeviceAsync(User user, ValidatedTokenRequest request) private async Task<Device> SaveDeviceAsync(User user, ValidatedTokenRequest request)
{ {
var device = GetDeviceFromRequest(request); var device = GetDeviceFromRequest(request);