nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-05-25 13:24:50 -05:00
Code

PM-20532 - Add TODOs

Browse Source
This commit is contained in:
Jared Snider 2025-05-15 22:55:21 -04:00
parent 1e6a721dca
commit 6b91396c89
No known key found for this signature in database
GPG Key ID: A149DDD612516286
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Core/Context/CurrentContext.cs
View File

@ -174,6 +174,9 @@ public class CurrentContext : ICurrentContext
ServiceAccountOrganizationId = new Guid(GetClaimValue(claimsDict, Claims.Organization)); ServiceAccountOrganizationId = new Guid(GetClaimValue(claimsDict, Claims.Organization));
} }
// TODO: IdentityClientType.Send should maybe be wired up here. Have further discussion with Justin
// Create an ExtensionMethod on HttpContext to get the send id from the subject claim
DeviceIdentifier = GetClaimValue(claimsDict, Claims.Device); DeviceIdentifier = GetClaimValue(claimsDict, Claims.Device);
if (Enum.TryParse(GetClaimValue(claimsDict, Claims.DeviceType), out DeviceType deviceType)) if (Enum.TryParse(GetClaimValue(claimsDict, Claims.DeviceType), out DeviceType deviceType))

2
src/Core/Tools/Services/Implementations/SendService.cs
View File

@ -203,6 +203,8 @@ public class SendService : ISendService
{ {
return (false, false, false); return (false, false, false);
} }
// TODO: this is what we will be using to validate password in SendAccessGrantValidator
if (!string.IsNullOrWhiteSpace(send.Password)) if (!string.IsNullOrWhiteSpace(send.Password))
{ {
if (string.IsNullOrWhiteSpace(password)) if (string.IsNullOrWhiteSpace(password))

1
test/Identity.IntegrationTest/Endpoints/IdentityServerTests.cs
View File

@ -352,6 +352,7 @@ public class IdentityServerTests : IClassFixture<IdentityApplicationFactory>
} }
// TODO: use this as example to call send token endpoint
[Theory, BitAutoData] [Theory, BitAutoData]
public async Task TokenEndpoint_GrantTypeClientCredentials_AsOrganization_Success(Organization organization, Bit.Core.Entities.OrganizationApiKey organizationApiKey) public async Task TokenEndpoint_GrantTypeClientCredentials_AsOrganization_Success(Organization organization, Bit.Core.Entities.OrganizationApiKey organizationApiKey)
{ {