nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-04 01:22:50 -05:00
Code Activity

Fix PayPal IPN Logging (#3768)

Browse Source 
* Remove request logging, fix txn_id correlation

* Respond 400 when txn_id is missing

* More cleanup
This commit is contained in:
Alex Morask
2024-02-08 10:37:41 -05:00
committed by GitHub
parent d29755de5a
commit 6cc53b4739
5 changed files with 39 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Billing/Controllers/PayPalController.cs
View File

@ -75,6 +75,14 @@ public class PayPalController : Controller
var transactionModel = new PayPalIPNTransactionModel(requestContent);
_logger.LogInformation("PayPal IPN: Transaction Type = {Type}", transactionModel.TransactionType);
if (string.IsNullOrEmpty(transactionModel.TransactionId))
{
_logger.LogError("PayPal IPN: Transaction ID is missing");
return Ok();
}
var entityId = transactionModel.UserId ?? transactionModel.OrganizationId;
if (!entityId.HasValue)
@ -83,7 +91,7 @@ public class PayPalController : Controller
return BadRequest();
}
var verified = await _payPalIPNClient.VerifyIPN(entityId.Value, requestContent);
var verified = await _payPalIPNClient.VerifyIPN(transactionModel.TransactionId, requestContent);
if (!verified)
{