nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-04 20:50:21 -05:00
Code

Use FrozenDictionary in StaticClientStore (#3833)

Browse Source 
* Add Benchmark

* Use FrozenDictionary

* Use TryGetValue

* Format
This commit is contained in:
Justin Baur 2024-02-21 10:29:59 -05:00 committed by GitHub
parent 0abd52b5be
commit 70fac808b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 33 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
perf/MicroBenchmarks/Identity/IdentityServer/StaticClientStoreTests.cs Normal file
View File

@ -0,0 +1,27 @@
using BenchmarkDotNet.Attributes;
using Bit.Core.Settings;
using Bit.Identity.IdentityServer;
using Duende.IdentityServer.Models;
namespace Bit.MicroBenchmarks.Identity.IdentityServer;
public class StaticClientStoreTests
{
private readonly StaticClientStore _store;
public StaticClientStoreTests()
{
_store = new StaticClientStore(new GlobalSettings());
}
[Params("mobile", "connector", "invalid", "a_much_longer_invalid_value_that_i_am_making_up", "WEB", "")]
public string? ClientId { get; set; }
[Benchmark]
public Client? TryGetValue()
{
return _store.ApiClients.TryGetValue(ClientId, out var client)
? client
: null;
}
}

4
src/Identity/IdentityServer/ClientStore.cs
View File

@ -80,9 +80,9 @@ public class ClientStore : IClientStore
return await CreateUserClientAsync(clientId);
}
if (_staticClientStore.ApiClients.ContainsKey(clientId))
if (_staticClientStore.ApiClients.TryGetValue(clientId, out var client))
{
return _staticClientStore.ApiClients[clientId];
return client;
}
return await CreateApiKeyClientAsync(clientId);

7
src/Identity/IdentityServer/StaticClientStore.cs
View File

@ -1,4 +1,5 @@
using Bit.Core.Enums;
using System.Collections.Frozen;
using Bit.Core.Enums;
using Bit.Core.Settings;
using Duende.IdentityServer.Models;
@ -16,8 +17,8 @@ public class StaticClientStore
new ApiClient(globalSettings, BitwardenClient.Desktop, 30, 1),
new ApiClient(globalSettings, BitwardenClient.Cli, 30, 1),
new ApiClient(globalSettings, BitwardenClient.DirectoryConnector, 30, 24)
}.ToDictionary(c => c.ClientId);
}.ToFrozenDictionary(c => c.ClientId);
}
public IDictionary<string, Client> ApiClients { get; private set; }
public FrozenDictionary<string, Client> ApiClients { get; }
}