1
0
mirror of https://github.com/bitwarden/server.git synced 2025-06-27 06:08:48 -05:00

PM-20574 formatted sql and updated as per PR comments

This commit is contained in:
voommen-livefront 2025-06-18 16:32:41 -05:00
parent 6356e94447
commit 76821788d7
12 changed files with 147 additions and 142 deletions

View File

@ -3,8 +3,7 @@ CREATE PROCEDURE [dbo].[OrganizationApplication_DeleteById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL DELETE FROM
THROW 50000, 'Id cannot be null', 1; [dbo].[OrganizationApplication]
WHERE
DELETE FROM [dbo].[OrganizationApplication] [Id] = @Id
WHERE [Id] = @Id

View File

@ -3,14 +3,11 @@ CREATE PROCEDURE [dbo].[OrganizationApplication_ReadById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
[Applications], [Applications],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationApplication] FROM [dbo].[OrganizationApplicationView]
WHERE [Id] = @Id; WHERE [Id] = @Id;

View File

@ -3,14 +3,11 @@ CREATE PROCEDURE [dbo].[OrganizationApplication_ReadByOrganizationId]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @OrganizationId IS NULL
THROW 50000, 'OrganizationId cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
[Applications], [Applications],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationApplication] FROM [dbo].[OrganizationApplicationView]
WHERE [OrganizationId] = @OrganizationId; WHERE [OrganizationId] = @OrganizationId;

View File

@ -8,5 +8,19 @@ CREATE PROCEDURE [dbo].[OrganizationReport_Create]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
INSERT INTO [dbo].[OrganizationReport]( [Id],[OrganizationId],[Date],[ReportData],[CreationDate],[RevisionDate] ) INSERT INTO [dbo].[OrganizationReport](
VALUES ( @Id,@OrganizationId,@Date,@ReportData,@CreationDate,@RevisionDate); [Id],
[OrganizationId],
[Date],
[ReportData],
[CreationDate],
[RevisionDate]
)
VALUES (
@Id,
@OrganizationId,
@Date,
@ReportData,
@CreationDate,
@RevisionDate
);

View File

@ -3,8 +3,5 @@ CREATE PROCEDURE [dbo].[OrganizationReport_DeleteById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
DELETE FROM [dbo].[OrganizationReport] DELETE FROM [dbo].[OrganizationReport]
WHERE [Id] = @Id WHERE [Id] = @Id

View File

@ -3,9 +3,6 @@ CREATE PROCEDURE [dbo].[OrganizationReport_ReadById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],

View File

@ -3,9 +3,6 @@ CREATE PROCEDURE [dbo].[OrganizationReport_ReadByOrganizationId]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @OrganizationId IS NULL
THROW 50000, 'OrganizationId cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],

View File

@ -7,6 +7,7 @@ CREATE PROCEDURE [dbo].[OrganizationReport_Update]
@RevisionDate DATETIME2(7) @RevisionDate DATETIME2(7)
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
UPDATE [dbo].[OrganizationReport] UPDATE [dbo].[OrganizationReport]
SET [OrganizationId] = @OrganizationId, SET [OrganizationId] = @OrganizationId,
[Date] = @Date, [Date] = @Date,

View File

@ -142,14 +142,14 @@ BEGIN
FROM FROM
[dbo].[OrganizationApplication] [dbo].[OrganizationApplication]
WHERE WHERE
[Id] = @Id [OrganizationId] = @Id
-- Delete Organization Report -- Delete Organization Report
DELETE DELETE
FROM FROM
[dbo].[OrganizationReport] [dbo].[OrganizationReport]
WHERE WHERE
[Id] = @Id [OrganizationId] = @Id
DELETE DELETE
FROM FROM

View File

@ -12,17 +12,19 @@ BEGIN
CONSTRAINT [FK_OrganizationReport_Organization] FOREIGN KEY ([OrganizationId]) REFERENCES [dbo].[Organization] ([Id]) CONSTRAINT [FK_OrganizationReport_Organization] FOREIGN KEY ([OrganizationId]) REFERENCES [dbo].[Organization] ([Id])
); );
CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId] CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId] ON [dbo].[OrganizationReport]([OrganizationId] ASC);
ON [dbo].[OrganizationReport]([OrganizationId] ASC);
CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId_Date] CREATE NONCLUSTERED INDEX [IX_OrganizationReport_OrganizationId_Date] ON [dbo].[OrganizationReport]([OrganizationId] ASC, [Date] DESC);
ON [dbo].[OrganizationReport]([OrganizationId] ASC, [Date] DESC);
END END
GO GO
CREATE OR ALTER VIEW [dbo].[OrganizationReportView] AS CREATE OR ALTER VIEW [dbo].[OrganizationReportView]
SELECT * FROM [dbo].[OrganizationReport]; AS
SELECT
*
FROM
[dbo].[OrganizationReport];
GO GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Create] CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Create]
@ -34,8 +36,27 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Create]
@RevisionDate DATETIME2(7) @RevisionDate DATETIME2(7)
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
INSERT INTO [dbo].[OrganizationReport]( [Id],[OrganizationId],[Date],[ReportData],[CreationDate],[RevisionDate] )
VALUES ( @Id,@OrganizationId,@Date,@ReportData,@CreationDate,@RevisionDate); INSERT INTO
[dbo].[OrganizationReport]
(
[Id],
[OrganizationId],
[Date],
[ReportData],
[CreationDate],
[RevisionDate]
)
VALUES
(
@Id,
@OrganizationId,
@Date,
@ReportData,
@CreationDate,
@RevisionDate
);
GO GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadByOrganizationId] CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadByOrganizationId]
@ -43,9 +64,6 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadByOrganizationId]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @OrganizationId IS NULL
THROW 50000, 'OrganizationId cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
@ -53,8 +71,11 @@ AS
[ReportData], [ReportData],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationReport] FROM
WHERE [OrganizationId] = @OrganizationId; [dbo].[OrganizationReportView]
WHERE
[OrganizationId] = @OrganizationId;
GO GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadById] CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadById]
@ -62,9 +83,6 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_ReadById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
@ -72,8 +90,11 @@ AS
[ReportData], [ReportData],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationReport] FROM
WHERE [Id] = @Id; [dbo].[OrganizationReportView]
WHERE
[Id] = @Id;
GO GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Update] CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Update]
@ -85,26 +106,26 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_Update]
@RevisionDate DATETIME2(7) @RevisionDate DATETIME2(7)
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
UPDATE [dbo].[OrganizationReport]
SET [OrganizationId] = @OrganizationId, UPDATE
[dbo].[OrganizationReport]
SET
[OrganizationId] = @OrganizationId,
[Date] = @Date, [Date] = @Date,
[ReportData] = @ReportData, [ReportData] = @ReportData,
[RevisionDate] = @RevisionDate [RevisionDate] = @RevisionDate
WHERE [Id] = @Id; WHERE
GO [Id] = @Id;
GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_DeleteById] CREATE OR ALTER PROCEDURE [dbo].[OrganizationReport_DeleteById]
@Id UNIQUEIDENTIFIER @Id UNIQUEIDENTIFIER
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL DELETE FROM
THROW 50000, 'Id cannot be null', 1; [dbo].[OrganizationReport]
WHERE
[Id] = @Id;
DELETE FROM [dbo].[OrganizationReport]
WHERE [Id] = @Id;
GO GO

View File

@ -1,6 +1,7 @@
IF OBJECT_ID('dbo.OrganizationApplication') IS NULL IF OBJECT_ID('dbo.OrganizationApplication') IS NULL
BEGIN BEGIN
CREATE TABLE [dbo].[OrganizationApplication] ( CREATE TABLE [dbo].[OrganizationApplication]
(
[Id] UNIQUEIDENTIFIER NOT NULL, [Id] UNIQUEIDENTIFIER NOT NULL,
[OrganizationId] UNIQUEIDENTIFIER NOT NULL, [OrganizationId] UNIQUEIDENTIFIER NOT NULL,
[Applications] NVARCHAR(MAX) NOT NULL, [Applications] NVARCHAR(MAX) NOT NULL,
@ -12,11 +13,14 @@ BEGIN
CREATE NONCLUSTERED INDEX [IX_OrganizationApplication_OrganizationId] CREATE NONCLUSTERED INDEX [IX_OrganizationApplication_OrganizationId]
ON [dbo].[OrganizationApplication]([OrganizationId] ASC); ON [dbo].[OrganizationApplication]([OrganizationId] ASC);
END END
GO GO
CREATE OR ALTER VIEW [dbo].[OrganizationApplicationView] AS CREATE OR ALTER VIEW [dbo].[OrganizationApplicationView]
SELECT * FROM [dbo].[OrganizationApplication]; AS
SELECT *
FROM [dbo].[OrganizationApplication];
GO GO
CREATE OR ALTER PROCEDURE [dbo].[OrganizationApplication_Create] CREATE OR ALTER PROCEDURE [dbo].[OrganizationApplication_Create]
@ -51,16 +55,13 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationApplication_ReadByOrganizationId]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @OrganizationId IS NULL
THROW 50000, 'OrganizationId cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
[Applications], [Applications],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationApplication] FROM [dbo].[OrganizationApplicationView]
WHERE [OrganizationId] = @OrganizationId; WHERE [OrganizationId] = @OrganizationId;
GO GO
@ -69,16 +70,13 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationApplication_ReadById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
SELECT SELECT
[Id], [Id],
[OrganizationId], [OrganizationId],
[Applications], [Applications],
[CreationDate], [CreationDate],
[RevisionDate] [RevisionDate]
FROM [dbo].[OrganizationApplication] FROM [dbo].[OrganizationApplicationView]
WHERE [Id] = @Id; WHERE [Id] = @Id;
GO GO
@ -103,19 +101,6 @@ CREATE OR ALTER PROCEDURE [dbo].[OrganizationApplication_DeleteById]
AS AS
SET NOCOUNT ON; SET NOCOUNT ON;
IF @Id IS NULL
THROW 50000, 'Id cannot be null', 1;
DELETE FROM [dbo].[OrganizationApplication] DELETE FROM [dbo].[OrganizationApplication]
WHERE [Id] = @Id; WHERE [Id] = @Id;
GO GO