nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-05 21:18:13 -05:00
Code

Fix org manager check on export (#1906)

Browse Source 
* Fix org manager check on export

* Fix filter typo from collection to cipher
This commit is contained in:
Chad Scharf 2022-03-14 15:34:22 -04:00 committed by GitHub
parent 72baf6deab
commit 76ddcfa2dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Api/Controllers/CiphersController.cs
View File

@ -224,12 +224,17 @@ namespace Bit.Api.Controllers
throw new NotFoundException(); throw new NotFoundException();
} }
var ciphers = await _cipherRepository.GetManyByOrganizationIdAsync(orgIdGuid); var ciphers = await _cipherRepository.GetManyByUserIdAsync(userId, true);
var orgCiphers = ciphers.Where(c => c.OrganizationId == orgIdGuid);
var orgCipherIds = orgCiphers.Select(c => c.Id);
var collectionCiphers = await _collectionCipherRepository.GetManyByOrganizationIdAsync(orgIdGuid); var collectionCiphers = await _collectionCipherRepository.GetManyByOrganizationIdAsync(orgIdGuid);
var collectionCiphersGroupDict = collectionCiphers.GroupBy(c => c.CipherId).ToDictionary(s => s.Key); var collectionCiphersGroupDict = collectionCiphers
.Where(c => orgCipherIds.Contains(c.CipherId))
.GroupBy(c => c.CipherId).ToDictionary(s => s.Key);
var responses = ciphers.Select(c => new CipherMiniDetailsResponseModel(c, _globalSettings,
var responses = orgCiphers.Select(c => new CipherMiniDetailsResponseModel(c, _globalSettings,
collectionCiphersGroupDict)); collectionCiphersGroupDict));
var providerId = await _currentContext.ProviderIdForOrg(orgIdGuid); var providerId = await _currentContext.ProviderIdForOrg(orgIdGuid);

5
src/Api/Controllers/CollectionsController.cs
View File

@ -87,8 +87,9 @@ namespace Bit.Api.Controllers
throw new NotFoundException(); throw new NotFoundException();
} }
var collections = await _collectionRepository.GetManyByOrganizationIdAsync(orgIdGuid); var collections = await _collectionRepository.GetManyByUserIdAsync(_currentContext.UserId.Value);
var responses = collections.Select(c => new CollectionResponseModel(c)); var orgCollections = collections.Where(c => c.OrganizationId == orgIdGuid);
var responses = orgCollections.Select(c => new CollectionResponseModel(c));
return new ListResponseModel<CollectionResponseModel>(responses); return new ListResponseModel<CollectionResponseModel>(responses);
} }