mirror of
https://github.com/bitwarden/server.git
synced 2025-06-26 05:38:47 -05:00
Merge branch 'main' into dirt/pm-20574/database_tables_and_scripts_riskinsights
This commit is contained in:
commit
7d9d14c9e8
@ -3,7 +3,7 @@
|
|||||||
<PropertyGroup>
|
<PropertyGroup>
|
||||||
<TargetFramework>net8.0</TargetFramework>
|
<TargetFramework>net8.0</TargetFramework>
|
||||||
|
|
||||||
<Version>2025.5.0</Version>
|
<Version>2025.5.1</Version>
|
||||||
|
|
||||||
<RootNamespace>Bit.$(MSBuildProjectName)</RootNamespace>
|
<RootNamespace>Bit.$(MSBuildProjectName)</RootNamespace>
|
||||||
<ImplicitUsings>enable</ImplicitUsings>
|
<ImplicitUsings>enable</ImplicitUsings>
|
||||||
|
@ -8,13 +8,10 @@ using Bit.Core.Billing.Constants;
|
|||||||
using Bit.Core.Billing.Extensions;
|
using Bit.Core.Billing.Extensions;
|
||||||
using Bit.Core.Billing.Pricing;
|
using Bit.Core.Billing.Pricing;
|
||||||
using Bit.Core.Billing.Services;
|
using Bit.Core.Billing.Services;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
|
||||||
using Bit.Core.Billing.Tax.Services.Implementations;
|
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Exceptions;
|
using Bit.Core.Exceptions;
|
||||||
using Bit.Core.Repositories;
|
using Bit.Core.Repositories;
|
||||||
using Bit.Core.Services;
|
using Bit.Core.Services;
|
||||||
using Microsoft.Extensions.DependencyInjection;
|
|
||||||
using Stripe;
|
using Stripe;
|
||||||
|
|
||||||
namespace Bit.Commercial.Core.AdminConsole.Providers;
|
namespace Bit.Commercial.Core.AdminConsole.Providers;
|
||||||
@ -24,7 +21,6 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
private readonly IEventService _eventService;
|
private readonly IEventService _eventService;
|
||||||
private readonly IMailService _mailService;
|
private readonly IMailService _mailService;
|
||||||
private readonly IOrganizationRepository _organizationRepository;
|
private readonly IOrganizationRepository _organizationRepository;
|
||||||
private readonly IOrganizationService _organizationService;
|
|
||||||
private readonly IProviderOrganizationRepository _providerOrganizationRepository;
|
private readonly IProviderOrganizationRepository _providerOrganizationRepository;
|
||||||
private readonly IStripeAdapter _stripeAdapter;
|
private readonly IStripeAdapter _stripeAdapter;
|
||||||
private readonly IFeatureService _featureService;
|
private readonly IFeatureService _featureService;
|
||||||
@ -32,26 +28,22 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
private readonly ISubscriberService _subscriberService;
|
private readonly ISubscriberService _subscriberService;
|
||||||
private readonly IHasConfirmedOwnersExceptQuery _hasConfirmedOwnersExceptQuery;
|
private readonly IHasConfirmedOwnersExceptQuery _hasConfirmedOwnersExceptQuery;
|
||||||
private readonly IPricingClient _pricingClient;
|
private readonly IPricingClient _pricingClient;
|
||||||
private readonly IAutomaticTaxStrategy _automaticTaxStrategy;
|
|
||||||
|
|
||||||
public RemoveOrganizationFromProviderCommand(
|
public RemoveOrganizationFromProviderCommand(
|
||||||
IEventService eventService,
|
IEventService eventService,
|
||||||
IMailService mailService,
|
IMailService mailService,
|
||||||
IOrganizationRepository organizationRepository,
|
IOrganizationRepository organizationRepository,
|
||||||
IOrganizationService organizationService,
|
|
||||||
IProviderOrganizationRepository providerOrganizationRepository,
|
IProviderOrganizationRepository providerOrganizationRepository,
|
||||||
IStripeAdapter stripeAdapter,
|
IStripeAdapter stripeAdapter,
|
||||||
IFeatureService featureService,
|
IFeatureService featureService,
|
||||||
IProviderBillingService providerBillingService,
|
IProviderBillingService providerBillingService,
|
||||||
ISubscriberService subscriberService,
|
ISubscriberService subscriberService,
|
||||||
IHasConfirmedOwnersExceptQuery hasConfirmedOwnersExceptQuery,
|
IHasConfirmedOwnersExceptQuery hasConfirmedOwnersExceptQuery,
|
||||||
IPricingClient pricingClient,
|
IPricingClient pricingClient)
|
||||||
[FromKeyedServices(AutomaticTaxFactory.BusinessUse)] IAutomaticTaxStrategy automaticTaxStrategy)
|
|
||||||
{
|
{
|
||||||
_eventService = eventService;
|
_eventService = eventService;
|
||||||
_mailService = mailService;
|
_mailService = mailService;
|
||||||
_organizationRepository = organizationRepository;
|
_organizationRepository = organizationRepository;
|
||||||
_organizationService = organizationService;
|
|
||||||
_providerOrganizationRepository = providerOrganizationRepository;
|
_providerOrganizationRepository = providerOrganizationRepository;
|
||||||
_stripeAdapter = stripeAdapter;
|
_stripeAdapter = stripeAdapter;
|
||||||
_featureService = featureService;
|
_featureService = featureService;
|
||||||
@ -59,7 +51,6 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
_subscriberService = subscriberService;
|
_subscriberService = subscriberService;
|
||||||
_hasConfirmedOwnersExceptQuery = hasConfirmedOwnersExceptQuery;
|
_hasConfirmedOwnersExceptQuery = hasConfirmedOwnersExceptQuery;
|
||||||
_pricingClient = pricingClient;
|
_pricingClient = pricingClient;
|
||||||
_automaticTaxStrategy = automaticTaxStrategy;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task RemoveOrganizationFromProvider(
|
public async Task RemoveOrganizationFromProvider(
|
||||||
@ -77,7 +68,7 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
|
|
||||||
if (!await _hasConfirmedOwnersExceptQuery.HasConfirmedOwnersExceptAsync(
|
if (!await _hasConfirmedOwnersExceptQuery.HasConfirmedOwnersExceptAsync(
|
||||||
providerOrganization.OrganizationId,
|
providerOrganization.OrganizationId,
|
||||||
Array.Empty<Guid>(),
|
[],
|
||||||
includeProvider: false))
|
includeProvider: false))
|
||||||
{
|
{
|
||||||
throw new BadRequestException("Organization must have at least one confirmed owner.");
|
throw new BadRequestException("Organization must have at least one confirmed owner.");
|
||||||
@ -102,7 +93,7 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
/// <summary>
|
/// <summary>
|
||||||
/// When a client organization is unlinked from a provider, we have to check if they're Stripe-enabled
|
/// When a client organization is unlinked from a provider, we have to check if they're Stripe-enabled
|
||||||
/// and, if they are, we remove their MSP discount and set their Subscription to `send_invoice`. This is because
|
/// and, if they are, we remove their MSP discount and set their Subscription to `send_invoice`. This is because
|
||||||
/// the provider's payment method will be removed from their Stripe customer causing ensuing charges to fail. Lastly,
|
/// the provider's payment method will be removed from their Stripe customer, causing ensuing charges to fail. Lastly,
|
||||||
/// we email the organization owners letting them know they need to add a new payment method.
|
/// we email the organization owners letting them know they need to add a new payment method.
|
||||||
/// </summary>
|
/// </summary>
|
||||||
private async Task ResetOrganizationBillingAsync(
|
private async Task ResetOrganizationBillingAsync(
|
||||||
@ -142,15 +133,18 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
Items = [new SubscriptionItemOptions { Price = plan.PasswordManager.StripeSeatPlanId, Quantity = organization.Seats }]
|
Items = [new SubscriptionItemOptions { Price = plan.PasswordManager.StripeSeatPlanId, Quantity = organization.Seats }]
|
||||||
};
|
};
|
||||||
|
|
||||||
if (_featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var setNonUSBusinessUseToReverseCharge = _featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
{
|
{
|
||||||
_automaticTaxStrategy.SetCreateOptions(subscriptionCreateOptions, customer);
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
}
|
}
|
||||||
else
|
else if (customer.HasRecognizedTaxLocation())
|
||||||
{
|
{
|
||||||
subscriptionCreateOptions.AutomaticTax ??= new SubscriptionAutomaticTaxOptions
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
{
|
{
|
||||||
Enabled = true
|
Enabled = customer.Address.Country == "US" ||
|
||||||
|
customer.TaxIds.Any()
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -187,7 +181,7 @@ public class RemoveOrganizationFromProviderCommand : IRemoveOrganizationFromProv
|
|||||||
await _mailService.SendProviderUpdatePaymentMethod(
|
await _mailService.SendProviderUpdatePaymentMethod(
|
||||||
organization.Id,
|
organization.Id,
|
||||||
organization.Name,
|
organization.Name,
|
||||||
provider.Name,
|
provider.Name!,
|
||||||
organizationOwnerEmails);
|
organizationOwnerEmails);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -67,6 +67,7 @@ public class BusinessUnitConverter(
|
|||||||
organization.MaxStorageGb = updatedPlan.PasswordManager.BaseStorageGb;
|
organization.MaxStorageGb = updatedPlan.PasswordManager.BaseStorageGb;
|
||||||
organization.UsePolicies = updatedPlan.HasPolicies;
|
organization.UsePolicies = updatedPlan.HasPolicies;
|
||||||
organization.UseSso = updatedPlan.HasSso;
|
organization.UseSso = updatedPlan.HasSso;
|
||||||
|
organization.UseOrganizationDomains = updatedPlan.HasOrganizationDomains;
|
||||||
organization.UseGroups = updatedPlan.HasGroups;
|
organization.UseGroups = updatedPlan.HasGroups;
|
||||||
organization.UseEvents = updatedPlan.HasEvents;
|
organization.UseEvents = updatedPlan.HasEvents;
|
||||||
organization.UseDirectory = updatedPlan.HasDirectory;
|
organization.UseDirectory = updatedPlan.HasDirectory;
|
||||||
|
@ -18,7 +18,6 @@ using Bit.Core.Billing.Services;
|
|||||||
using Bit.Core.Billing.Services.Contracts;
|
using Bit.Core.Billing.Services.Contracts;
|
||||||
using Bit.Core.Billing.Tax.Models;
|
using Bit.Core.Billing.Tax.Models;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
using Bit.Core.Billing.Tax.Services;
|
||||||
using Bit.Core.Billing.Tax.Services.Implementations;
|
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Exceptions;
|
using Bit.Core.Exceptions;
|
||||||
using Bit.Core.Models.Business;
|
using Bit.Core.Models.Business;
|
||||||
@ -27,7 +26,6 @@ using Bit.Core.Services;
|
|||||||
using Bit.Core.Settings;
|
using Bit.Core.Settings;
|
||||||
using Braintree;
|
using Braintree;
|
||||||
using CsvHelper;
|
using CsvHelper;
|
||||||
using Microsoft.Extensions.DependencyInjection;
|
|
||||||
using Microsoft.Extensions.Logging;
|
using Microsoft.Extensions.Logging;
|
||||||
using Stripe;
|
using Stripe;
|
||||||
|
|
||||||
@ -52,8 +50,7 @@ public class ProviderBillingService(
|
|||||||
ISetupIntentCache setupIntentCache,
|
ISetupIntentCache setupIntentCache,
|
||||||
IStripeAdapter stripeAdapter,
|
IStripeAdapter stripeAdapter,
|
||||||
ISubscriberService subscriberService,
|
ISubscriberService subscriberService,
|
||||||
ITaxService taxService,
|
ITaxService taxService)
|
||||||
[FromKeyedServices(AutomaticTaxFactory.BusinessUse)] IAutomaticTaxStrategy automaticTaxStrategy)
|
|
||||||
: IProviderBillingService
|
: IProviderBillingService
|
||||||
{
|
{
|
||||||
public async Task AddExistingOrganization(
|
public async Task AddExistingOrganization(
|
||||||
@ -99,6 +96,7 @@ public class ProviderBillingService(
|
|||||||
organization.MaxStorageGb = plan.PasswordManager.BaseStorageGb;
|
organization.MaxStorageGb = plan.PasswordManager.BaseStorageGb;
|
||||||
organization.UsePolicies = plan.HasPolicies;
|
organization.UsePolicies = plan.HasPolicies;
|
||||||
organization.UseSso = plan.HasSso;
|
organization.UseSso = plan.HasSso;
|
||||||
|
organization.UseOrganizationDomains = plan.HasOrganizationDomains;
|
||||||
organization.UseGroups = plan.HasGroups;
|
organization.UseGroups = plan.HasGroups;
|
||||||
organization.UseEvents = plan.HasEvents;
|
organization.UseEvents = plan.HasEvents;
|
||||||
organization.UseDirectory = plan.HasDirectory;
|
organization.UseDirectory = plan.HasDirectory;
|
||||||
@ -127,7 +125,7 @@ public class ProviderBillingService(
|
|||||||
|
|
||||||
/*
|
/*
|
||||||
* We have to scale the provider's seats before the ProviderOrganization
|
* We have to scale the provider's seats before the ProviderOrganization
|
||||||
* row is inserted so the added organization's seats don't get double counted.
|
* row is inserted so the added organization's seats don't get double-counted.
|
||||||
*/
|
*/
|
||||||
await ScaleSeats(provider, organization.PlanType, organization.Seats!.Value);
|
await ScaleSeats(provider, organization.PlanType, organization.Seats!.Value);
|
||||||
|
|
||||||
@ -235,7 +233,7 @@ public class ProviderBillingService(
|
|||||||
|
|
||||||
var providerCustomer = await subscriberService.GetCustomerOrThrow(provider, new CustomerGetOptions
|
var providerCustomer = await subscriberService.GetCustomerOrThrow(provider, new CustomerGetOptions
|
||||||
{
|
{
|
||||||
Expand = ["tax_ids"]
|
Expand = ["tax", "tax_ids"]
|
||||||
});
|
});
|
||||||
|
|
||||||
var providerTaxId = providerCustomer.TaxIds.FirstOrDefault();
|
var providerTaxId = providerCustomer.TaxIds.FirstOrDefault();
|
||||||
@ -283,6 +281,13 @@ public class ProviderBillingService(
|
|||||||
]
|
]
|
||||||
};
|
};
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge = featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge && providerCustomer.Address is not { Country: "US" })
|
||||||
|
{
|
||||||
|
customerCreateOptions.TaxExempt = StripeConstants.TaxExempt.Reverse;
|
||||||
|
}
|
||||||
|
|
||||||
var customer = await stripeAdapter.CustomerCreateAsync(customerCreateOptions);
|
var customer = await stripeAdapter.CustomerCreateAsync(customerCreateOptions);
|
||||||
|
|
||||||
organization.GatewayCustomerId = customer.Id;
|
organization.GatewayCustomerId = customer.Id;
|
||||||
@ -519,6 +524,13 @@ public class ProviderBillingService(
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge = featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge && taxInfo.BillingAddressCountry != "US")
|
||||||
|
{
|
||||||
|
options.TaxExempt = StripeConstants.TaxExempt.Reverse;
|
||||||
|
}
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(taxInfo.TaxIdNumber))
|
if (!string.IsNullOrEmpty(taxInfo.TaxIdNumber))
|
||||||
{
|
{
|
||||||
var taxIdType = taxService.GetStripeTaxCode(
|
var taxIdType = taxService.GetStripeTaxCode(
|
||||||
@ -530,6 +542,7 @@ public class ProviderBillingService(
|
|||||||
logger.LogWarning("Could not infer tax ID type in country '{Country}' with tax ID '{TaxID}'.",
|
logger.LogWarning("Could not infer tax ID type in country '{Country}' with tax ID '{TaxID}'.",
|
||||||
taxInfo.BillingAddressCountry,
|
taxInfo.BillingAddressCountry,
|
||||||
taxInfo.TaxIdNumber);
|
taxInfo.TaxIdNumber);
|
||||||
|
|
||||||
throw new BadRequestException("billingTaxIdTypeInferenceError");
|
throw new BadRequestException("billingTaxIdTypeInferenceError");
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -717,14 +730,21 @@ public class ProviderBillingService(
|
|||||||
TrialPeriodDays = trialPeriodDays
|
TrialPeriodDays = trialPeriodDays
|
||||||
};
|
};
|
||||||
|
|
||||||
if (featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var setNonUSBusinessUseToReverseCharge =
|
||||||
{
|
featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
automaticTaxStrategy.SetCreateOptions(subscriptionCreateOptions, customer);
|
|
||||||
}
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
else
|
|
||||||
{
|
{
|
||||||
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
}
|
}
|
||||||
|
else if (customer.HasRecognizedTaxLocation())
|
||||||
|
{
|
||||||
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
|
{
|
||||||
|
Enabled = customer.Address.Country == "US" ||
|
||||||
|
customer.TaxIds.Any()
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
|
@ -1,4 +1,5 @@
|
|||||||
using Bit.Commercial.Core.AdminConsole.Providers;
|
using Bit.Commercial.Core.AdminConsole.Providers;
|
||||||
|
using Bit.Core;
|
||||||
using Bit.Core.AdminConsole.Entities;
|
using Bit.Core.AdminConsole.Entities;
|
||||||
using Bit.Core.AdminConsole.Entities.Provider;
|
using Bit.Core.AdminConsole.Entities.Provider;
|
||||||
using Bit.Core.AdminConsole.Enums.Provider;
|
using Bit.Core.AdminConsole.Enums.Provider;
|
||||||
@ -8,7 +9,6 @@ using Bit.Core.Billing.Constants;
|
|||||||
using Bit.Core.Billing.Enums;
|
using Bit.Core.Billing.Enums;
|
||||||
using Bit.Core.Billing.Pricing;
|
using Bit.Core.Billing.Pricing;
|
||||||
using Bit.Core.Billing.Services;
|
using Bit.Core.Billing.Services;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Exceptions;
|
using Bit.Core.Exceptions;
|
||||||
using Bit.Core.Repositories;
|
using Bit.Core.Repositories;
|
||||||
@ -224,31 +224,115 @@ public class RemoveOrganizationFromProviderCommandTests
|
|||||||
|
|
||||||
var stripeAdapter = sutProvider.GetDependency<IStripeAdapter>();
|
var stripeAdapter = sutProvider.GetDependency<IStripeAdapter>();
|
||||||
|
|
||||||
|
stripeAdapter.CustomerUpdateAsync(organization.GatewayCustomerId, Arg.Is<CustomerUpdateOptions>(options =>
|
||||||
|
options.Description == string.Empty &&
|
||||||
|
options.Email == organization.BillingEmail &&
|
||||||
|
options.Expand[0] == "tax" &&
|
||||||
|
options.Expand[1] == "tax_ids")).Returns(new Customer
|
||||||
|
{
|
||||||
|
Id = "customer_id",
|
||||||
|
Address = new Address
|
||||||
|
{
|
||||||
|
Country = "US"
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
stripeAdapter.SubscriptionCreateAsync(Arg.Any<SubscriptionCreateOptions>()).Returns(new Subscription
|
stripeAdapter.SubscriptionCreateAsync(Arg.Any<SubscriptionCreateOptions>()).Returns(new Subscription
|
||||||
{
|
{
|
||||||
Id = "subscription_id"
|
Id = "subscription_id"
|
||||||
});
|
});
|
||||||
|
|
||||||
sutProvider.GetDependency<IAutomaticTaxStrategy>()
|
await sutProvider.Sut.RemoveOrganizationFromProvider(provider, providerOrganization, organization);
|
||||||
.When(x => x.SetCreateOptions(
|
|
||||||
Arg.Is<SubscriptionCreateOptions>(options =>
|
await stripeAdapter.Received(1).SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(options =>
|
||||||
options.Customer == organization.GatewayCustomerId &&
|
options.Customer == organization.GatewayCustomerId &&
|
||||||
options.CollectionMethod == StripeConstants.CollectionMethod.SendInvoice &&
|
options.CollectionMethod == StripeConstants.CollectionMethod.SendInvoice &&
|
||||||
options.DaysUntilDue == 30 &&
|
options.DaysUntilDue == 30 &&
|
||||||
options.Metadata["organizationId"] == organization.Id.ToString() &&
|
options.AutomaticTax.Enabled == true &&
|
||||||
options.OffSession == true &&
|
options.Metadata["organizationId"] == organization.Id.ToString() &&
|
||||||
options.ProrationBehavior == StripeConstants.ProrationBehavior.CreateProrations &&
|
options.OffSession == true &&
|
||||||
options.Items.First().Price == teamsMonthlyPlan.PasswordManager.StripeSeatPlanId &&
|
options.ProrationBehavior == StripeConstants.ProrationBehavior.CreateProrations &&
|
||||||
options.Items.First().Quantity == organization.Seats)
|
options.Items.First().Price == teamsMonthlyPlan.PasswordManager.StripeSeatPlanId &&
|
||||||
, Arg.Any<Customer>()))
|
options.Items.First().Quantity == organization.Seats));
|
||||||
.Do(x =>
|
|
||||||
|
await sutProvider.GetDependency<IProviderBillingService>().Received(1)
|
||||||
|
.ScaleSeats(provider, organization.PlanType, -organization.Seats ?? 0);
|
||||||
|
|
||||||
|
await organizationRepository.Received(1).ReplaceAsync(Arg.Is<Organization>(
|
||||||
|
org =>
|
||||||
|
org.BillingEmail == "a@example.com" &&
|
||||||
|
org.GatewaySubscriptionId == "subscription_id" &&
|
||||||
|
org.Status == OrganizationStatusType.Created));
|
||||||
|
|
||||||
|
await sutProvider.GetDependency<IProviderOrganizationRepository>().Received(1)
|
||||||
|
.DeleteAsync(providerOrganization);
|
||||||
|
|
||||||
|
await sutProvider.GetDependency<IEventService>().Received(1)
|
||||||
|
.LogProviderOrganizationEventAsync(providerOrganization, EventType.ProviderOrganization_Removed);
|
||||||
|
|
||||||
|
await sutProvider.GetDependency<IMailService>().Received(1)
|
||||||
|
.SendProviderUpdatePaymentMethod(
|
||||||
|
organization.Id,
|
||||||
|
organization.Name,
|
||||||
|
provider.Name,
|
||||||
|
Arg.Is<IEnumerable<string>>(emails => emails.FirstOrDefault() == "a@example.com"));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Theory, BitAutoData]
|
||||||
|
public async Task RemoveOrganizationFromProvider_OrganizationStripeEnabled_ConsolidatedBilling_ReverseCharge_MakesCorrectInvocations(
|
||||||
|
Provider provider,
|
||||||
|
ProviderOrganization providerOrganization,
|
||||||
|
Organization organization,
|
||||||
|
SutProvider<RemoveOrganizationFromProviderCommand> sutProvider)
|
||||||
|
{
|
||||||
|
provider.Status = ProviderStatusType.Billable;
|
||||||
|
|
||||||
|
providerOrganization.ProviderId = provider.Id;
|
||||||
|
|
||||||
|
organization.Status = OrganizationStatusType.Managed;
|
||||||
|
|
||||||
|
organization.PlanType = PlanType.TeamsMonthly;
|
||||||
|
|
||||||
|
var teamsMonthlyPlan = StaticStore.GetPlan(PlanType.TeamsMonthly);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IPricingClient>().GetPlanOrThrow(PlanType.TeamsMonthly).Returns(teamsMonthlyPlan);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IHasConfirmedOwnersExceptQuery>().HasConfirmedOwnersExceptAsync(
|
||||||
|
providerOrganization.OrganizationId,
|
||||||
|
[],
|
||||||
|
includeProvider: false)
|
||||||
|
.Returns(true);
|
||||||
|
|
||||||
|
var organizationRepository = sutProvider.GetDependency<IOrganizationRepository>();
|
||||||
|
|
||||||
|
organizationRepository.GetOwnerEmailAddressesById(organization.Id).Returns([
|
||||||
|
"a@example.com",
|
||||||
|
"b@example.com"
|
||||||
|
]);
|
||||||
|
|
||||||
|
var stripeAdapter = sutProvider.GetDependency<IStripeAdapter>();
|
||||||
|
|
||||||
|
stripeAdapter.CustomerUpdateAsync(organization.GatewayCustomerId, Arg.Is<CustomerUpdateOptions>(options =>
|
||||||
|
options.Description == string.Empty &&
|
||||||
|
options.Email == organization.BillingEmail &&
|
||||||
|
options.Expand[0] == "tax" &&
|
||||||
|
options.Expand[1] == "tax_ids")).Returns(new Customer
|
||||||
{
|
{
|
||||||
x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
|
Id = "customer_id",
|
||||||
|
Address = new Address
|
||||||
{
|
{
|
||||||
Enabled = true
|
Country = "US"
|
||||||
};
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
|
stripeAdapter.SubscriptionCreateAsync(Arg.Any<SubscriptionCreateOptions>()).Returns(new Subscription
|
||||||
|
{
|
||||||
|
Id = "subscription_id"
|
||||||
|
});
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge).Returns(true);
|
||||||
|
|
||||||
await sutProvider.Sut.RemoveOrganizationFromProvider(provider, providerOrganization, organization);
|
await sutProvider.Sut.RemoveOrganizationFromProvider(provider, providerOrganization, organization);
|
||||||
|
|
||||||
await stripeAdapter.Received(1).SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(options =>
|
await stripeAdapter.Received(1).SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(options =>
|
||||||
|
@ -262,7 +262,7 @@ public class ProviderBillingServiceTests
|
|||||||
};
|
};
|
||||||
|
|
||||||
sutProvider.GetDependency<ISubscriberService>().GetCustomerOrThrow(provider, Arg.Is<CustomerGetOptions>(
|
sutProvider.GetDependency<ISubscriberService>().GetCustomerOrThrow(provider, Arg.Is<CustomerGetOptions>(
|
||||||
options => options.Expand.FirstOrDefault() == "tax_ids"))
|
options => options.Expand.Contains("tax") && options.Expand.Contains("tax_ids")))
|
||||||
.Returns(providerCustomer);
|
.Returns(providerCustomer);
|
||||||
|
|
||||||
sutProvider.GetDependency<IGlobalSettings>().BaseServiceUri
|
sutProvider.GetDependency<IGlobalSettings>().BaseServiceUri
|
||||||
@ -312,6 +312,91 @@ public class ProviderBillingServiceTests
|
|||||||
org => org.GatewayCustomerId == "customer_id"));
|
org => org.GatewayCustomerId == "customer_id"));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Theory, BitAutoData]
|
||||||
|
public async Task CreateCustomer_ForClientOrg_ReverseCharge_Succeeds(
|
||||||
|
Provider provider,
|
||||||
|
Organization organization,
|
||||||
|
SutProvider<ProviderBillingService> sutProvider)
|
||||||
|
{
|
||||||
|
organization.GatewayCustomerId = null;
|
||||||
|
organization.Name = "Name";
|
||||||
|
organization.BusinessName = "BusinessName";
|
||||||
|
|
||||||
|
var providerCustomer = new Customer
|
||||||
|
{
|
||||||
|
Address = new Address
|
||||||
|
{
|
||||||
|
Country = "CA",
|
||||||
|
PostalCode = "12345",
|
||||||
|
Line1 = "123 Main St.",
|
||||||
|
Line2 = "Unit 4",
|
||||||
|
City = "Fake Town",
|
||||||
|
State = "Fake State"
|
||||||
|
},
|
||||||
|
TaxIds = new StripeList<TaxId>
|
||||||
|
{
|
||||||
|
Data =
|
||||||
|
[
|
||||||
|
new TaxId { Type = "TYPE", Value = "VALUE" }
|
||||||
|
]
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
sutProvider.GetDependency<ISubscriberService>().GetCustomerOrThrow(provider, Arg.Is<CustomerGetOptions>(
|
||||||
|
options => options.Expand.Contains("tax") && options.Expand.Contains("tax_ids")))
|
||||||
|
.Returns(providerCustomer);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IGlobalSettings>().BaseServiceUri
|
||||||
|
.Returns(new Bit.Core.Settings.GlobalSettings.BaseServiceUriSettings(new Bit.Core.Settings.GlobalSettings())
|
||||||
|
{
|
||||||
|
CloudRegion = "US"
|
||||||
|
});
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge).Returns(true);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IStripeAdapter>().CustomerCreateAsync(Arg.Is<CustomerCreateOptions>(
|
||||||
|
options =>
|
||||||
|
options.Address.Country == providerCustomer.Address.Country &&
|
||||||
|
options.Address.PostalCode == providerCustomer.Address.PostalCode &&
|
||||||
|
options.Address.Line1 == providerCustomer.Address.Line1 &&
|
||||||
|
options.Address.Line2 == providerCustomer.Address.Line2 &&
|
||||||
|
options.Address.City == providerCustomer.Address.City &&
|
||||||
|
options.Address.State == providerCustomer.Address.State &&
|
||||||
|
options.Name == organization.DisplayName() &&
|
||||||
|
options.Description == $"{provider.Name} Client Organization" &&
|
||||||
|
options.Email == provider.BillingEmail &&
|
||||||
|
options.InvoiceSettings.CustomFields.FirstOrDefault().Name == "Organization" &&
|
||||||
|
options.InvoiceSettings.CustomFields.FirstOrDefault().Value == "Name" &&
|
||||||
|
options.Metadata["region"] == "US" &&
|
||||||
|
options.TaxIdData.FirstOrDefault().Type == providerCustomer.TaxIds.FirstOrDefault().Type &&
|
||||||
|
options.TaxIdData.FirstOrDefault().Value == providerCustomer.TaxIds.FirstOrDefault().Value &&
|
||||||
|
options.TaxExempt == StripeConstants.TaxExempt.Reverse))
|
||||||
|
.Returns(new Customer { Id = "customer_id" });
|
||||||
|
|
||||||
|
await sutProvider.Sut.CreateCustomerForClientOrganization(provider, organization);
|
||||||
|
|
||||||
|
await sutProvider.GetDependency<IStripeAdapter>().Received(1).CustomerCreateAsync(Arg.Is<CustomerCreateOptions>(
|
||||||
|
options =>
|
||||||
|
options.Address.Country == providerCustomer.Address.Country &&
|
||||||
|
options.Address.PostalCode == providerCustomer.Address.PostalCode &&
|
||||||
|
options.Address.Line1 == providerCustomer.Address.Line1 &&
|
||||||
|
options.Address.Line2 == providerCustomer.Address.Line2 &&
|
||||||
|
options.Address.City == providerCustomer.Address.City &&
|
||||||
|
options.Address.State == providerCustomer.Address.State &&
|
||||||
|
options.Name == organization.DisplayName() &&
|
||||||
|
options.Description == $"{provider.Name} Client Organization" &&
|
||||||
|
options.Email == provider.BillingEmail &&
|
||||||
|
options.InvoiceSettings.CustomFields.FirstOrDefault().Name == "Organization" &&
|
||||||
|
options.InvoiceSettings.CustomFields.FirstOrDefault().Value == "Name" &&
|
||||||
|
options.Metadata["region"] == "US" &&
|
||||||
|
options.TaxIdData.FirstOrDefault().Type == providerCustomer.TaxIds.FirstOrDefault().Type &&
|
||||||
|
options.TaxIdData.FirstOrDefault().Value == providerCustomer.TaxIds.FirstOrDefault().Value));
|
||||||
|
|
||||||
|
await sutProvider.GetDependency<IOrganizationRepository>().Received(1).ReplaceAsync(Arg.Is<Organization>(
|
||||||
|
org => org.GatewayCustomerId == "customer_id"));
|
||||||
|
}
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
|
||||||
#region GenerateClientInvoiceReport
|
#region GenerateClientInvoiceReport
|
||||||
@ -1182,6 +1267,62 @@ public class ProviderBillingServiceTests
|
|||||||
Assert.Equivalent(expected, actual);
|
Assert.Equivalent(expected, actual);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Theory, BitAutoData]
|
||||||
|
public async Task SetupCustomer_WithCard_ReverseCharge_Success(
|
||||||
|
SutProvider<ProviderBillingService> sutProvider,
|
||||||
|
Provider provider,
|
||||||
|
TaxInfo taxInfo)
|
||||||
|
{
|
||||||
|
provider.Name = "MSP";
|
||||||
|
|
||||||
|
sutProvider.GetDependency<ITaxService>()
|
||||||
|
.GetStripeTaxCode(Arg.Is<string>(
|
||||||
|
p => p == taxInfo.BillingAddressCountry),
|
||||||
|
Arg.Is<string>(p => p == taxInfo.TaxIdNumber))
|
||||||
|
.Returns(taxInfo.TaxIdType);
|
||||||
|
|
||||||
|
taxInfo.BillingAddressCountry = "AD";
|
||||||
|
|
||||||
|
var stripeAdapter = sutProvider.GetDependency<IStripeAdapter>();
|
||||||
|
|
||||||
|
var expected = new Customer
|
||||||
|
{
|
||||||
|
Id = "customer_id",
|
||||||
|
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
||||||
|
};
|
||||||
|
|
||||||
|
var tokenizedPaymentSource = new TokenizedPaymentSource(PaymentMethodType.Card, "token");
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge).Returns(true);
|
||||||
|
|
||||||
|
stripeAdapter.CustomerCreateAsync(Arg.Is<CustomerCreateOptions>(o =>
|
||||||
|
o.Address.Country == taxInfo.BillingAddressCountry &&
|
||||||
|
o.Address.PostalCode == taxInfo.BillingAddressPostalCode &&
|
||||||
|
o.Address.Line1 == taxInfo.BillingAddressLine1 &&
|
||||||
|
o.Address.Line2 == taxInfo.BillingAddressLine2 &&
|
||||||
|
o.Address.City == taxInfo.BillingAddressCity &&
|
||||||
|
o.Address.State == taxInfo.BillingAddressState &&
|
||||||
|
o.Description == WebUtility.HtmlDecode(provider.BusinessName) &&
|
||||||
|
o.Email == provider.BillingEmail &&
|
||||||
|
o.PaymentMethod == tokenizedPaymentSource.Token &&
|
||||||
|
o.InvoiceSettings.DefaultPaymentMethod == tokenizedPaymentSource.Token &&
|
||||||
|
o.InvoiceSettings.CustomFields.FirstOrDefault().Name == "Provider" &&
|
||||||
|
o.InvoiceSettings.CustomFields.FirstOrDefault().Value == "MSP" &&
|
||||||
|
o.Metadata["region"] == "" &&
|
||||||
|
o.TaxIdData.FirstOrDefault().Type == taxInfo.TaxIdType &&
|
||||||
|
o.TaxIdData.FirstOrDefault().Value == taxInfo.TaxIdNumber &&
|
||||||
|
o.TaxExempt == StripeConstants.TaxExempt.Reverse))
|
||||||
|
.Returns(expected);
|
||||||
|
|
||||||
|
var actual = await sutProvider.Sut.SetupCustomer(provider, taxInfo, tokenizedPaymentSource);
|
||||||
|
|
||||||
|
Assert.Equivalent(expected, actual);
|
||||||
|
}
|
||||||
|
|
||||||
[Theory, BitAutoData]
|
[Theory, BitAutoData]
|
||||||
public async Task SetupCustomer_Throws_BadRequestException_WhenTaxIdIsInvalid(
|
public async Task SetupCustomer_Throws_BadRequestException_WhenTaxIdIsInvalid(
|
||||||
SutProvider<ProviderBillingService> sutProvider,
|
SutProvider<ProviderBillingService> sutProvider,
|
||||||
@ -1307,7 +1448,7 @@ public class ProviderBillingServiceTests
|
|||||||
.Returns(new Customer
|
.Returns(new Customer
|
||||||
{
|
{
|
||||||
Id = "customer_id",
|
Id = "customer_id",
|
||||||
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
Address = new Address { Country = "US" }
|
||||||
});
|
});
|
||||||
|
|
||||||
var providerPlans = new List<ProviderPlan>
|
var providerPlans = new List<ProviderPlan>
|
||||||
@ -1359,7 +1500,7 @@ public class ProviderBillingServiceTests
|
|||||||
var customer = new Customer
|
var customer = new Customer
|
||||||
{
|
{
|
||||||
Id = "customer_id",
|
Id = "customer_id",
|
||||||
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
Address = new Address { Country = "US" }
|
||||||
};
|
};
|
||||||
sutProvider.GetDependency<ISubscriberService>()
|
sutProvider.GetDependency<ISubscriberService>()
|
||||||
.GetCustomerOrThrow(
|
.GetCustomerOrThrow(
|
||||||
@ -1399,19 +1540,6 @@ public class ProviderBillingServiceTests
|
|||||||
|
|
||||||
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
||||||
|
|
||||||
sutProvider.GetDependency<IAutomaticTaxStrategy>()
|
|
||||||
.When(x => x.SetCreateOptions(
|
|
||||||
Arg.Is<SubscriptionCreateOptions>(options =>
|
|
||||||
options.Customer == "customer_id")
|
|
||||||
, Arg.Is<Customer>(p => p == customer)))
|
|
||||||
.Do(x =>
|
|
||||||
{
|
|
||||||
x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
|
|
||||||
{
|
|
||||||
Enabled = true
|
|
||||||
};
|
|
||||||
});
|
|
||||||
|
|
||||||
sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
|
sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
|
||||||
sub =>
|
sub =>
|
||||||
sub.AutomaticTax.Enabled == true &&
|
sub.AutomaticTax.Enabled == true &&
|
||||||
@ -1443,11 +1571,11 @@ public class ProviderBillingServiceTests
|
|||||||
var customer = new Customer
|
var customer = new Customer
|
||||||
{
|
{
|
||||||
Id = "customer_id",
|
Id = "customer_id",
|
||||||
|
Address = new Address { Country = "US" },
|
||||||
InvoiceSettings = new CustomerInvoiceSettings
|
InvoiceSettings = new CustomerInvoiceSettings
|
||||||
{
|
{
|
||||||
DefaultPaymentMethodId = "pm_123"
|
DefaultPaymentMethodId = "pm_123"
|
||||||
},
|
}
|
||||||
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
|
||||||
};
|
};
|
||||||
|
|
||||||
sutProvider.GetDependency<ISubscriberService>()
|
sutProvider.GetDependency<ISubscriberService>()
|
||||||
@ -1488,19 +1616,6 @@ public class ProviderBillingServiceTests
|
|||||||
|
|
||||||
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
||||||
|
|
||||||
sutProvider.GetDependency<IAutomaticTaxStrategy>()
|
|
||||||
.When(x => x.SetCreateOptions(
|
|
||||||
Arg.Is<SubscriptionCreateOptions>(options =>
|
|
||||||
options.Customer == "customer_id")
|
|
||||||
, Arg.Is<Customer>(p => p == customer)))
|
|
||||||
.Do(x =>
|
|
||||||
{
|
|
||||||
x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
|
|
||||||
{
|
|
||||||
Enabled = true
|
|
||||||
};
|
|
||||||
});
|
|
||||||
|
|
||||||
sutProvider.GetDependency<IFeatureService>()
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
||||||
|
|
||||||
@ -1536,9 +1651,9 @@ public class ProviderBillingServiceTests
|
|||||||
var customer = new Customer
|
var customer = new Customer
|
||||||
{
|
{
|
||||||
Id = "customer_id",
|
Id = "customer_id",
|
||||||
|
Address = new Address { Country = "US" },
|
||||||
InvoiceSettings = new CustomerInvoiceSettings(),
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
||||||
Metadata = new Dictionary<string, string>(),
|
Metadata = new Dictionary<string, string>()
|
||||||
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
|
||||||
};
|
};
|
||||||
|
|
||||||
sutProvider.GetDependency<ISubscriberService>()
|
sutProvider.GetDependency<ISubscriberService>()
|
||||||
@ -1579,19 +1694,6 @@ public class ProviderBillingServiceTests
|
|||||||
|
|
||||||
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
||||||
|
|
||||||
sutProvider.GetDependency<IAutomaticTaxStrategy>()
|
|
||||||
.When(x => x.SetCreateOptions(
|
|
||||||
Arg.Is<SubscriptionCreateOptions>(options =>
|
|
||||||
options.Customer == "customer_id")
|
|
||||||
, Arg.Is<Customer>(p => p == customer)))
|
|
||||||
.Do(x =>
|
|
||||||
{
|
|
||||||
x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
|
|
||||||
{
|
|
||||||
Enabled = true
|
|
||||||
};
|
|
||||||
});
|
|
||||||
|
|
||||||
sutProvider.GetDependency<IFeatureService>()
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
||||||
|
|
||||||
@ -1646,12 +1748,15 @@ public class ProviderBillingServiceTests
|
|||||||
var customer = new Customer
|
var customer = new Customer
|
||||||
{
|
{
|
||||||
Id = "customer_id",
|
Id = "customer_id",
|
||||||
|
Address = new Address
|
||||||
|
{
|
||||||
|
Country = "US"
|
||||||
|
},
|
||||||
InvoiceSettings = new CustomerInvoiceSettings(),
|
InvoiceSettings = new CustomerInvoiceSettings(),
|
||||||
Metadata = new Dictionary<string, string>
|
Metadata = new Dictionary<string, string>
|
||||||
{
|
{
|
||||||
["btCustomerId"] = "braintree_customer_id"
|
["btCustomerId"] = "braintree_customer_id"
|
||||||
},
|
}
|
||||||
Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
|
|
||||||
};
|
};
|
||||||
|
|
||||||
sutProvider.GetDependency<ISubscriberService>()
|
sutProvider.GetDependency<ISubscriberService>()
|
||||||
@ -1692,22 +1797,92 @@ public class ProviderBillingServiceTests
|
|||||||
|
|
||||||
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
||||||
|
|
||||||
sutProvider.GetDependency<IAutomaticTaxStrategy>()
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
.When(x => x.SetCreateOptions(
|
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
||||||
Arg.Is<SubscriptionCreateOptions>(options =>
|
|
||||||
options.Customer == "customer_id")
|
sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
|
||||||
, Arg.Is<Customer>(p => p == customer)))
|
sub =>
|
||||||
.Do(x =>
|
sub.AutomaticTax.Enabled == true &&
|
||||||
|
sub.CollectionMethod == StripeConstants.CollectionMethod.ChargeAutomatically &&
|
||||||
|
sub.Customer == "customer_id" &&
|
||||||
|
sub.DaysUntilDue == null &&
|
||||||
|
sub.Items.Count == 2 &&
|
||||||
|
sub.Items.ElementAt(0).Price == ProviderPriceAdapter.MSP.Active.Teams &&
|
||||||
|
sub.Items.ElementAt(0).Quantity == 100 &&
|
||||||
|
sub.Items.ElementAt(1).Price == ProviderPriceAdapter.MSP.Active.Enterprise &&
|
||||||
|
sub.Items.ElementAt(1).Quantity == 100 &&
|
||||||
|
sub.Metadata["providerId"] == provider.Id.ToString() &&
|
||||||
|
sub.OffSession == true &&
|
||||||
|
sub.ProrationBehavior == StripeConstants.ProrationBehavior.CreateProrations &&
|
||||||
|
sub.TrialPeriodDays == 14)).Returns(expected);
|
||||||
|
|
||||||
|
var actual = await sutProvider.Sut.SetupSubscription(provider);
|
||||||
|
|
||||||
|
Assert.Equivalent(expected, actual);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Theory, BitAutoData]
|
||||||
|
public async Task SetupSubscription_ReverseCharge_Succeeds(
|
||||||
|
SutProvider<ProviderBillingService> sutProvider,
|
||||||
|
Provider provider)
|
||||||
|
{
|
||||||
|
provider.Type = ProviderType.Msp;
|
||||||
|
provider.GatewaySubscriptionId = null;
|
||||||
|
|
||||||
|
var customer = new Customer
|
||||||
|
{
|
||||||
|
Id = "customer_id",
|
||||||
|
Address = new Address { Country = "CA" },
|
||||||
|
InvoiceSettings = new CustomerInvoiceSettings
|
||||||
{
|
{
|
||||||
x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
|
DefaultPaymentMethodId = "pm_123"
|
||||||
{
|
}
|
||||||
Enabled = true
|
};
|
||||||
};
|
|
||||||
});
|
sutProvider.GetDependency<ISubscriberService>()
|
||||||
|
.GetCustomerOrThrow(
|
||||||
|
provider,
|
||||||
|
Arg.Is<CustomerGetOptions>(p => p.Expand.Contains("tax") || p.Expand.Contains("tax_ids"))).Returns(customer);
|
||||||
|
|
||||||
|
var providerPlans = new List<ProviderPlan>
|
||||||
|
{
|
||||||
|
new()
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid(),
|
||||||
|
ProviderId = provider.Id,
|
||||||
|
PlanType = PlanType.TeamsMonthly,
|
||||||
|
SeatMinimum = 100,
|
||||||
|
PurchasedSeats = 0,
|
||||||
|
AllocatedSeats = 0
|
||||||
|
},
|
||||||
|
new()
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid(),
|
||||||
|
ProviderId = provider.Id,
|
||||||
|
PlanType = PlanType.EnterpriseMonthly,
|
||||||
|
SeatMinimum = 100,
|
||||||
|
PurchasedSeats = 0,
|
||||||
|
AllocatedSeats = 0
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
foreach (var plan in providerPlans)
|
||||||
|
{
|
||||||
|
sutProvider.GetDependency<IPricingClient>().GetPlanOrThrow(plan.PlanType)
|
||||||
|
.Returns(StaticStore.GetPlan(plan.PlanType));
|
||||||
|
}
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IProviderPlanRepository>().GetByProviderId(provider.Id)
|
||||||
|
.Returns(providerPlans);
|
||||||
|
|
||||||
|
var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
|
||||||
|
|
||||||
sutProvider.GetDependency<IFeatureService>()
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
.IsEnabled(FeatureFlagKeys.PM19956_RequireProviderPaymentMethodDuringSetup).Returns(true);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge).Returns(true);
|
||||||
|
|
||||||
sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
|
sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
|
||||||
sub =>
|
sub =>
|
||||||
sub.AutomaticTax.Enabled == true &&
|
sub.AutomaticTax.Enabled == true &&
|
||||||
|
@ -69,7 +69,7 @@
|
|||||||
document.getElementById('@(nameof(Model.UseGroups))').checked = plan.hasGroups;
|
document.getElementById('@(nameof(Model.UseGroups))').checked = plan.hasGroups;
|
||||||
document.getElementById('@(nameof(Model.UsePolicies))').checked = plan.hasPolicies;
|
document.getElementById('@(nameof(Model.UsePolicies))').checked = plan.hasPolicies;
|
||||||
document.getElementById('@(nameof(Model.UseSso))').checked = plan.hasSso;
|
document.getElementById('@(nameof(Model.UseSso))').checked = plan.hasSso;
|
||||||
document.getElementById('@(nameof(Model.UseOrganizationDomains))').checked = hasOrganizationDomains;
|
document.getElementById('@(nameof(Model.UseOrganizationDomains))').checked = plan.hasOrganizationDomains;
|
||||||
document.getElementById('@(nameof(Model.UseScim))').checked = plan.hasScim;
|
document.getElementById('@(nameof(Model.UseScim))').checked = plan.hasScim;
|
||||||
document.getElementById('@(nameof(Model.UseDirectory))').checked = plan.hasDirectory;
|
document.getElementById('@(nameof(Model.UseDirectory))').checked = plan.hasDirectory;
|
||||||
document.getElementById('@(nameof(Model.UseEvents))').checked = plan.hasEvents;
|
document.getElementById('@(nameof(Model.UseEvents))').checked = plan.hasEvents;
|
||||||
|
@ -292,15 +292,17 @@ public class OrganizationBillingController(
|
|||||||
sale.Organization.PlanType = plan.Type;
|
sale.Organization.PlanType = plan.Type;
|
||||||
sale.Organization.Plan = plan.Name;
|
sale.Organization.Plan = plan.Name;
|
||||||
sale.SubscriptionSetup.SkipTrial = true;
|
sale.SubscriptionSetup.SkipTrial = true;
|
||||||
await organizationBillingService.Finalize(sale);
|
|
||||||
|
if (organizationSignup.PaymentMethodType == null || string.IsNullOrEmpty(organizationSignup.PaymentToken))
|
||||||
|
{
|
||||||
|
return Error.BadRequest("A payment method is required to restart the subscription.");
|
||||||
|
}
|
||||||
var org = await organizationRepository.GetByIdAsync(organizationId);
|
var org = await organizationRepository.GetByIdAsync(organizationId);
|
||||||
Debug.Assert(org is not null, "This organization has already been found via this same ID, this should be fine.");
|
Debug.Assert(org is not null, "This organization has already been found via this same ID, this should be fine.");
|
||||||
if (organizationSignup.PaymentMethodType != null)
|
var paymentSource = new TokenizedPaymentSource(organizationSignup.PaymentMethodType.Value, organizationSignup.PaymentToken);
|
||||||
{
|
var taxInformation = TaxInformation.From(organizationSignup.TaxInfo);
|
||||||
var paymentSource = new TokenizedPaymentSource(organizationSignup.PaymentMethodType.Value, organizationSignup.PaymentToken);
|
await organizationBillingService.UpdatePaymentMethod(org, paymentSource, taxInformation);
|
||||||
var taxInformation = TaxInformation.From(organizationSignup.TaxInfo);
|
await organizationBillingService.Finalize(sale);
|
||||||
await organizationBillingService.UpdatePaymentMethod(org, paymentSource, taxInformation);
|
|
||||||
}
|
|
||||||
|
|
||||||
return TypedResults.Ok();
|
return TypedResults.Ok();
|
||||||
}
|
}
|
||||||
|
@ -109,28 +109,6 @@ public class OrganizationsController(
|
|||||||
return license;
|
return license;
|
||||||
}
|
}
|
||||||
|
|
||||||
[HttpPost("{id:guid}/payment")]
|
|
||||||
[SelfHosted(NotSelfHostedOnly = true)]
|
|
||||||
public async Task PostPayment(Guid id, [FromBody] PaymentRequestModel model)
|
|
||||||
{
|
|
||||||
if (!await currentContext.EditPaymentMethods(id))
|
|
||||||
{
|
|
||||||
throw new NotFoundException();
|
|
||||||
}
|
|
||||||
|
|
||||||
await organizationService.ReplacePaymentMethodAsync(id, model.PaymentToken,
|
|
||||||
model.PaymentMethodType.Value, new TaxInfo
|
|
||||||
{
|
|
||||||
BillingAddressLine1 = model.Line1,
|
|
||||||
BillingAddressLine2 = model.Line2,
|
|
||||||
BillingAddressState = model.State,
|
|
||||||
BillingAddressCity = model.City,
|
|
||||||
BillingAddressPostalCode = model.PostalCode,
|
|
||||||
BillingAddressCountry = model.Country,
|
|
||||||
TaxIdNumber = model.TaxId,
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
[HttpPost("{id:guid}/upgrade")]
|
[HttpPost("{id:guid}/upgrade")]
|
||||||
[SelfHosted(NotSelfHostedOnly = true)]
|
[SelfHosted(NotSelfHostedOnly = true)]
|
||||||
public async Task<PaymentResponseModel> PostUpgrade(Guid id, [FromBody] OrganizationUpgradeRequestModel model)
|
public async Task<PaymentResponseModel> PostUpgrade(Guid id, [FromBody] OrganizationUpgradeRequestModel model)
|
||||||
|
@ -1,11 +1,11 @@
|
|||||||
using Bit.Core;
|
using Bit.Core;
|
||||||
|
using Bit.Core.AdminConsole.Entities;
|
||||||
|
using Bit.Core.AdminConsole.Entities.Provider;
|
||||||
using Bit.Core.AdminConsole.Repositories;
|
using Bit.Core.AdminConsole.Repositories;
|
||||||
using Bit.Core.Billing.Constants;
|
using Bit.Core.Billing.Constants;
|
||||||
using Bit.Core.Billing.Enums;
|
using Bit.Core.Billing.Enums;
|
||||||
using Bit.Core.Billing.Extensions;
|
using Bit.Core.Billing.Extensions;
|
||||||
using Bit.Core.Billing.Pricing;
|
using Bit.Core.Billing.Pricing;
|
||||||
using Bit.Core.Billing.Services.Contracts;
|
|
||||||
using Bit.Core.Billing.Tax.Services;
|
|
||||||
using Bit.Core.OrganizationFeatures.OrganizationSponsorships.FamiliesForEnterprise.Interfaces;
|
using Bit.Core.OrganizationFeatures.OrganizationSponsorships.FamiliesForEnterprise.Interfaces;
|
||||||
using Bit.Core.Repositories;
|
using Bit.Core.Repositories;
|
||||||
using Bit.Core.Services;
|
using Bit.Core.Services;
|
||||||
@ -25,8 +25,7 @@ public class UpcomingInvoiceHandler(
|
|||||||
IStripeEventService stripeEventService,
|
IStripeEventService stripeEventService,
|
||||||
IStripeEventUtilityService stripeEventUtilityService,
|
IStripeEventUtilityService stripeEventUtilityService,
|
||||||
IUserRepository userRepository,
|
IUserRepository userRepository,
|
||||||
IValidateSponsorshipCommand validateSponsorshipCommand,
|
IValidateSponsorshipCommand validateSponsorshipCommand)
|
||||||
IAutomaticTaxFactory automaticTaxFactory)
|
|
||||||
: IUpcomingInvoiceHandler
|
: IUpcomingInvoiceHandler
|
||||||
{
|
{
|
||||||
public async Task HandleAsync(Event parsedEvent)
|
public async Task HandleAsync(Event parsedEvent)
|
||||||
@ -46,6 +45,8 @@ public class UpcomingInvoiceHandler(
|
|||||||
|
|
||||||
var (organizationId, userId, providerId) = stripeEventUtilityService.GetIdsFromMetadata(subscription.Metadata);
|
var (organizationId, userId, providerId) = stripeEventUtilityService.GetIdsFromMetadata(subscription.Metadata);
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge = featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
if (organizationId.HasValue)
|
if (organizationId.HasValue)
|
||||||
{
|
{
|
||||||
var organization = await organizationRepository.GetByIdAsync(organizationId.Value);
|
var organization = await organizationRepository.GetByIdAsync(organizationId.Value);
|
||||||
@ -55,7 +56,7 @@ public class UpcomingInvoiceHandler(
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
await TryEnableAutomaticTaxAsync(subscription);
|
await AlignOrganizationTaxConcernsAsync(organization, subscription, parsedEvent.Id, setNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
var plan = await pricingClient.GetPlanOrThrow(organization.PlanType);
|
var plan = await pricingClient.GetPlanOrThrow(organization.PlanType);
|
||||||
|
|
||||||
@ -100,7 +101,25 @@ public class UpcomingInvoiceHandler(
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
await TryEnableAutomaticTaxAsync(subscription);
|
if (!subscription.AutomaticTax.Enabled && subscription.Customer.HasRecognizedTaxLocation())
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await stripeFacade.UpdateSubscription(subscription.Id,
|
||||||
|
new SubscriptionUpdateOptions
|
||||||
|
{
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
||||||
|
});
|
||||||
|
}
|
||||||
|
catch (Exception exception)
|
||||||
|
{
|
||||||
|
logger.LogError(
|
||||||
|
exception,
|
||||||
|
"Failed to set user's ({UserID}) subscription to automatic tax while processing event with ID {EventID}",
|
||||||
|
user.Id,
|
||||||
|
parsedEvent.Id);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (user.Premium)
|
if (user.Premium)
|
||||||
{
|
{
|
||||||
@ -116,7 +135,7 @@ public class UpcomingInvoiceHandler(
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
await TryEnableAutomaticTaxAsync(subscription);
|
await AlignProviderTaxConcernsAsync(provider, subscription, parsedEvent.Id, setNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
await SendUpcomingInvoiceEmailsAsync(new List<string> { provider.BillingEmail }, invoice);
|
await SendUpcomingInvoiceEmailsAsync(new List<string> { provider.BillingEmail }, invoice);
|
||||||
}
|
}
|
||||||
@ -139,50 +158,123 @@ public class UpcomingInvoiceHandler(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
private async Task TryEnableAutomaticTaxAsync(Subscription subscription)
|
private async Task AlignOrganizationTaxConcernsAsync(
|
||||||
|
Organization organization,
|
||||||
|
Subscription subscription,
|
||||||
|
string eventId,
|
||||||
|
bool setNonUSBusinessUseToReverseCharge)
|
||||||
{
|
{
|
||||||
if (featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var nonUSBusinessUse =
|
||||||
{
|
organization.PlanType.GetProductTier() != ProductTierType.Families &&
|
||||||
var automaticTaxParameters = new AutomaticTaxFactoryParameters(subscription.Items.Select(x => x.Price.Id));
|
subscription.Customer.Address.Country != "US";
|
||||||
var automaticTaxStrategy = await automaticTaxFactory.CreateAsync(automaticTaxParameters);
|
|
||||||
var updateOptions = automaticTaxStrategy.GetUpdateOptions(subscription);
|
|
||||||
|
|
||||||
if (updateOptions == null)
|
bool setAutomaticTaxToEnabled;
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
|
{
|
||||||
|
if (nonUSBusinessUse && subscription.Customer.TaxExempt != StripeConstants.TaxExempt.Reverse)
|
||||||
{
|
{
|
||||||
return;
|
try
|
||||||
|
{
|
||||||
|
await stripeFacade.UpdateCustomer(subscription.CustomerId,
|
||||||
|
new CustomerUpdateOptions { TaxExempt = StripeConstants.TaxExempt.Reverse });
|
||||||
|
}
|
||||||
|
catch (Exception exception)
|
||||||
|
{
|
||||||
|
logger.LogError(
|
||||||
|
exception,
|
||||||
|
"Failed to set organization's ({OrganizationID}) to reverse tax exemption while processing event with ID {EventID}",
|
||||||
|
organization.Id,
|
||||||
|
eventId);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
await stripeFacade.UpdateSubscription(subscription.Id, updateOptions);
|
setAutomaticTaxToEnabled = true;
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
|
else
|
||||||
if (subscription.AutomaticTax.Enabled ||
|
|
||||||
!subscription.Customer.HasBillingLocation() ||
|
|
||||||
await IsNonTaxableNonUSBusinessUseSubscription(subscription))
|
|
||||||
{
|
{
|
||||||
return;
|
setAutomaticTaxToEnabled =
|
||||||
|
subscription.Customer.HasRecognizedTaxLocation() &&
|
||||||
|
(subscription.Customer.Address.Country == "US" ||
|
||||||
|
(nonUSBusinessUse && subscription.Customer.TaxIds.Any()));
|
||||||
}
|
}
|
||||||
|
|
||||||
await stripeFacade.UpdateSubscription(subscription.Id,
|
if (!subscription.AutomaticTax.Enabled && setAutomaticTaxToEnabled)
|
||||||
new SubscriptionUpdateOptions
|
{
|
||||||
|
try
|
||||||
{
|
{
|
||||||
DefaultTaxRates = [],
|
await stripeFacade.UpdateSubscription(subscription.Id,
|
||||||
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
new SubscriptionUpdateOptions
|
||||||
});
|
{
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
||||||
|
});
|
||||||
|
}
|
||||||
|
catch (Exception exception)
|
||||||
|
{
|
||||||
|
logger.LogError(
|
||||||
|
exception,
|
||||||
|
"Failed to set organization's ({OrganizationID}) subscription to automatic tax while processing event with ID {EventID}",
|
||||||
|
organization.Id,
|
||||||
|
eventId);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return;
|
private async Task AlignProviderTaxConcernsAsync(
|
||||||
|
Provider provider,
|
||||||
|
Subscription subscription,
|
||||||
|
string eventId,
|
||||||
|
bool setNonUSBusinessUseToReverseCharge)
|
||||||
|
{
|
||||||
|
bool setAutomaticTaxToEnabled;
|
||||||
|
|
||||||
async Task<bool> IsNonTaxableNonUSBusinessUseSubscription(Subscription localSubscription)
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
{
|
{
|
||||||
var familyPriceIds = (await Task.WhenAll(
|
if (subscription.Customer.Address.Country != "US" && subscription.Customer.TaxExempt != StripeConstants.TaxExempt.Reverse)
|
||||||
pricingClient.GetPlanOrThrow(PlanType.FamiliesAnnually2019),
|
{
|
||||||
pricingClient.GetPlanOrThrow(PlanType.FamiliesAnnually)))
|
try
|
||||||
.Select(plan => plan.PasswordManager.StripePlanId);
|
{
|
||||||
|
await stripeFacade.UpdateCustomer(subscription.CustomerId,
|
||||||
|
new CustomerUpdateOptions { TaxExempt = StripeConstants.TaxExempt.Reverse });
|
||||||
|
}
|
||||||
|
catch (Exception exception)
|
||||||
|
{
|
||||||
|
logger.LogError(
|
||||||
|
exception,
|
||||||
|
"Failed to set provider's ({ProviderID}) to reverse tax exemption while processing event with ID {EventID}",
|
||||||
|
provider.Id,
|
||||||
|
eventId);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
return localSubscription.Customer.Address.Country != "US" &&
|
setAutomaticTaxToEnabled = true;
|
||||||
localSubscription.Metadata.ContainsKey(StripeConstants.MetadataKeys.OrganizationId) &&
|
}
|
||||||
!localSubscription.Items.Select(item => item.Price.Id).Intersect(familyPriceIds).Any() &&
|
else
|
||||||
!localSubscription.Customer.TaxIds.Any();
|
{
|
||||||
|
setAutomaticTaxToEnabled =
|
||||||
|
subscription.Customer.HasRecognizedTaxLocation() &&
|
||||||
|
(subscription.Customer.Address.Country == "US" ||
|
||||||
|
subscription.Customer.TaxIds.Any());
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!subscription.AutomaticTax.Enabled && setAutomaticTaxToEnabled)
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await stripeFacade.UpdateSubscription(subscription.Id,
|
||||||
|
new SubscriptionUpdateOptions
|
||||||
|
{
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
||||||
|
});
|
||||||
|
}
|
||||||
|
catch (Exception exception)
|
||||||
|
{
|
||||||
|
logger.LogError(
|
||||||
|
exception,
|
||||||
|
"Failed to set provider's ({ProviderID}) subscription to automatic tax while processing event with ID {EventID}",
|
||||||
|
provider.Id,
|
||||||
|
eventId);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -24,9 +24,7 @@ public class GetOrganizationUsersClaimedStatusQuery : IGetOrganizationUsersClaim
|
|||||||
// Users can only be claimed by an Organization that is enabled and can have organization domains
|
// Users can only be claimed by an Organization that is enabled and can have organization domains
|
||||||
var organizationAbility = await _applicationCacheService.GetOrganizationAbilityAsync(organizationId);
|
var organizationAbility = await _applicationCacheService.GetOrganizationAbilityAsync(organizationId);
|
||||||
|
|
||||||
// TODO: Replace "UseSso" with a new organization ability like "UseOrganizationDomains" (PM-11622).
|
if (organizationAbility is { Enabled: true, UseOrganizationDomains: true })
|
||||||
// Verified domains were tied to SSO, so we currently check the "UseSso" organization ability.
|
|
||||||
if (organizationAbility is { Enabled: true, UseSso: true })
|
|
||||||
{
|
{
|
||||||
// Get all organization users with claimed domains by the organization
|
// Get all organization users with claimed domains by the organization
|
||||||
var organizationUsersWithClaimedDomain = await _organizationUserRepository.GetManyByOrganizationWithClaimedDomainsAsync(organizationId);
|
var organizationUsersWithClaimedDomain = await _organizationUserRepository.GetManyByOrganizationWithClaimedDomainsAsync(organizationId);
|
||||||
|
@ -11,8 +11,6 @@ namespace Bit.Core.Services;
|
|||||||
|
|
||||||
public interface IOrganizationService
|
public interface IOrganizationService
|
||||||
{
|
{
|
||||||
Task ReplacePaymentMethodAsync(Guid organizationId, string paymentToken, PaymentMethodType paymentMethodType,
|
|
||||||
TaxInfo taxInfo);
|
|
||||||
Task CancelSubscriptionAsync(Guid organizationId, bool? endOfPeriod = null);
|
Task CancelSubscriptionAsync(Guid organizationId, bool? endOfPeriod = null);
|
||||||
Task ReinstateSubscriptionAsync(Guid organizationId);
|
Task ReinstateSubscriptionAsync(Guid organizationId);
|
||||||
Task<string> AdjustStorageAsync(Guid organizationId, short storageAdjustmentGb);
|
Task<string> AdjustStorageAsync(Guid organizationId, short storageAdjustmentGb);
|
||||||
|
@ -144,27 +144,6 @@ public class OrganizationService : IOrganizationService
|
|||||||
_sendOrganizationInvitesCommand = sendOrganizationInvitesCommand;
|
_sendOrganizationInvitesCommand = sendOrganizationInvitesCommand;
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task ReplacePaymentMethodAsync(Guid organizationId, string paymentToken,
|
|
||||||
PaymentMethodType paymentMethodType, TaxInfo taxInfo)
|
|
||||||
{
|
|
||||||
var organization = await GetOrgById(organizationId);
|
|
||||||
if (organization == null)
|
|
||||||
{
|
|
||||||
throw new NotFoundException();
|
|
||||||
}
|
|
||||||
|
|
||||||
await _paymentService.SaveTaxInfoAsync(organization, taxInfo);
|
|
||||||
var updated = await _paymentService.UpdatePaymentMethodAsync(
|
|
||||||
organization,
|
|
||||||
paymentMethodType,
|
|
||||||
paymentToken,
|
|
||||||
taxInfo);
|
|
||||||
if (updated)
|
|
||||||
{
|
|
||||||
await ReplaceAndUpdateCacheAsync(organization);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
public async Task CancelSubscriptionAsync(Guid organizationId, bool? endOfPeriod = null)
|
public async Task CancelSubscriptionAsync(Guid organizationId, bool? endOfPeriod = null)
|
||||||
{
|
{
|
||||||
var organization = await GetOrgById(organizationId);
|
var organization = await GetOrgById(organizationId);
|
||||||
|
@ -2,9 +2,24 @@
|
|||||||
|
|
||||||
public enum EmergencyAccessStatusType : byte
|
public enum EmergencyAccessStatusType : byte
|
||||||
{
|
{
|
||||||
|
/// <summary>
|
||||||
|
/// The user has been invited to be an emergency contact.
|
||||||
|
/// </summary>
|
||||||
Invited = 0,
|
Invited = 0,
|
||||||
|
/// <summary>
|
||||||
|
/// The invited user, "grantee", has accepted the request to be an emergency contact.
|
||||||
|
/// </summary>
|
||||||
Accepted = 1,
|
Accepted = 1,
|
||||||
|
/// <summary>
|
||||||
|
/// The inviting user, "grantor", has approved the grantee's acceptance.
|
||||||
|
/// </summary>
|
||||||
Confirmed = 2,
|
Confirmed = 2,
|
||||||
|
/// <summary>
|
||||||
|
/// The grantee has initiated the recovery process.
|
||||||
|
/// </summary>
|
||||||
RecoveryInitiated = 3,
|
RecoveryInitiated = 3,
|
||||||
|
/// <summary>
|
||||||
|
/// The grantee has excercised their emergency access.
|
||||||
|
/// </summary>
|
||||||
RecoveryApproved = 4,
|
RecoveryApproved = 4,
|
||||||
}
|
}
|
||||||
|
@ -3,6 +3,7 @@ using Bit.Core.Auth.Entities;
|
|||||||
using Bit.Core.Auth.Enums;
|
using Bit.Core.Auth.Enums;
|
||||||
using Bit.Core.Auth.Models.Data;
|
using Bit.Core.Auth.Models.Data;
|
||||||
using Bit.Core.Entities;
|
using Bit.Core.Entities;
|
||||||
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Services;
|
using Bit.Core.Services;
|
||||||
using Bit.Core.Vault.Models.Data;
|
using Bit.Core.Vault.Models.Data;
|
||||||
|
|
||||||
@ -20,6 +21,15 @@ public interface IEmergencyAccessService
|
|||||||
Task InitiateAsync(Guid id, User initiatingUser);
|
Task InitiateAsync(Guid id, User initiatingUser);
|
||||||
Task ApproveAsync(Guid id, User approvingUser);
|
Task ApproveAsync(Guid id, User approvingUser);
|
||||||
Task RejectAsync(Guid id, User rejectingUser);
|
Task RejectAsync(Guid id, User rejectingUser);
|
||||||
|
/// <summary>
|
||||||
|
/// This request is made by the Grantee user to fetch the policies <see cref="Policy"/> for the Grantor User.
|
||||||
|
/// The Grantor User has to be the owner of the organization. <see cref="OrganizationUserType"/>
|
||||||
|
/// If the Grantor user has OrganizationUserType.Owner then the policies for the _Grantor_ user
|
||||||
|
/// are returned.
|
||||||
|
/// </summary>
|
||||||
|
/// <param name="id">EmergencyAccess.Id being acted on</param>
|
||||||
|
/// <param name="requestingUser">User making the request, this is the Grantee</param>
|
||||||
|
/// <returns>null if the GrantorUser is not an organization owner; A list of policies otherwise.</returns>
|
||||||
Task<ICollection<Policy>> GetPoliciesAsync(Guid id, User requestingUser);
|
Task<ICollection<Policy>> GetPoliciesAsync(Guid id, User requestingUser);
|
||||||
Task<(EmergencyAccess, User)> TakeoverAsync(Guid id, User initiatingUser);
|
Task<(EmergencyAccess, User)> TakeoverAsync(Guid id, User initiatingUser);
|
||||||
Task PasswordAsync(Guid id, User user, string newMasterPasswordHash, string key);
|
Task PasswordAsync(Guid id, User user, string newMasterPasswordHash, string key);
|
||||||
|
@ -3,7 +3,6 @@ using Bit.Core.AdminConsole.OrganizationFeatures.OrganizationUsers.Interfaces;
|
|||||||
using Bit.Core.AdminConsole.Repositories;
|
using Bit.Core.AdminConsole.Repositories;
|
||||||
using Bit.Core.Auth.Entities;
|
using Bit.Core.Auth.Entities;
|
||||||
using Bit.Core.Auth.Enums;
|
using Bit.Core.Auth.Enums;
|
||||||
using Bit.Core.Auth.Models;
|
|
||||||
using Bit.Core.Auth.Models.Business.Tokenables;
|
using Bit.Core.Auth.Models.Business.Tokenables;
|
||||||
using Bit.Core.Auth.Models.Data;
|
using Bit.Core.Auth.Models.Data;
|
||||||
using Bit.Core.Entities;
|
using Bit.Core.Entities;
|
||||||
@ -16,7 +15,6 @@ using Bit.Core.Tokens;
|
|||||||
using Bit.Core.Vault.Models.Data;
|
using Bit.Core.Vault.Models.Data;
|
||||||
using Bit.Core.Vault.Repositories;
|
using Bit.Core.Vault.Repositories;
|
||||||
using Bit.Core.Vault.Services;
|
using Bit.Core.Vault.Services;
|
||||||
using Microsoft.AspNetCore.Identity;
|
|
||||||
|
|
||||||
namespace Bit.Core.Auth.Services;
|
namespace Bit.Core.Auth.Services;
|
||||||
|
|
||||||
@ -31,8 +29,6 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
private readonly IMailService _mailService;
|
private readonly IMailService _mailService;
|
||||||
private readonly IUserService _userService;
|
private readonly IUserService _userService;
|
||||||
private readonly GlobalSettings _globalSettings;
|
private readonly GlobalSettings _globalSettings;
|
||||||
private readonly IPasswordHasher<User> _passwordHasher;
|
|
||||||
private readonly IOrganizationService _organizationService;
|
|
||||||
private readonly IDataProtectorTokenFactory<EmergencyAccessInviteTokenable> _dataProtectorTokenizer;
|
private readonly IDataProtectorTokenFactory<EmergencyAccessInviteTokenable> _dataProtectorTokenizer;
|
||||||
private readonly IRemoveOrganizationUserCommand _removeOrganizationUserCommand;
|
private readonly IRemoveOrganizationUserCommand _removeOrganizationUserCommand;
|
||||||
|
|
||||||
@ -45,9 +41,7 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
ICipherService cipherService,
|
ICipherService cipherService,
|
||||||
IMailService mailService,
|
IMailService mailService,
|
||||||
IUserService userService,
|
IUserService userService,
|
||||||
IPasswordHasher<User> passwordHasher,
|
|
||||||
GlobalSettings globalSettings,
|
GlobalSettings globalSettings,
|
||||||
IOrganizationService organizationService,
|
|
||||||
IDataProtectorTokenFactory<EmergencyAccessInviteTokenable> dataProtectorTokenizer,
|
IDataProtectorTokenFactory<EmergencyAccessInviteTokenable> dataProtectorTokenizer,
|
||||||
IRemoveOrganizationUserCommand removeOrganizationUserCommand)
|
IRemoveOrganizationUserCommand removeOrganizationUserCommand)
|
||||||
{
|
{
|
||||||
@ -59,9 +53,7 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
_cipherService = cipherService;
|
_cipherService = cipherService;
|
||||||
_mailService = mailService;
|
_mailService = mailService;
|
||||||
_userService = userService;
|
_userService = userService;
|
||||||
_passwordHasher = passwordHasher;
|
|
||||||
_globalSettings = globalSettings;
|
_globalSettings = globalSettings;
|
||||||
_organizationService = organizationService;
|
|
||||||
_dataProtectorTokenizer = dataProtectorTokenizer;
|
_dataProtectorTokenizer = dataProtectorTokenizer;
|
||||||
_removeOrganizationUserCommand = removeOrganizationUserCommand;
|
_removeOrganizationUserCommand = removeOrganizationUserCommand;
|
||||||
}
|
}
|
||||||
@ -126,7 +118,12 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
throw new BadRequestException("Emergency Access not valid.");
|
throw new BadRequestException("Emergency Access not valid.");
|
||||||
}
|
}
|
||||||
|
|
||||||
if (!_dataProtectorTokenizer.TryUnprotect(token, out var data) && data.IsValid(emergencyAccessId, user.Email))
|
if (!_dataProtectorTokenizer.TryUnprotect(token, out var data))
|
||||||
|
{
|
||||||
|
throw new BadRequestException("Invalid token.");
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!data.IsValid(emergencyAccessId, user.Email))
|
||||||
{
|
{
|
||||||
throw new BadRequestException("Invalid token.");
|
throw new BadRequestException("Invalid token.");
|
||||||
}
|
}
|
||||||
@ -140,6 +137,8 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
throw new BadRequestException("Invitation already accepted.");
|
throw new BadRequestException("Invitation already accepted.");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TODO PM-21687
|
||||||
|
// Might not be reachable since the Tokenable.IsValid() does an email comparison
|
||||||
if (string.IsNullOrWhiteSpace(emergencyAccess.Email) ||
|
if (string.IsNullOrWhiteSpace(emergencyAccess.Email) ||
|
||||||
!emergencyAccess.Email.Equals(user.Email, StringComparison.InvariantCultureIgnoreCase))
|
!emergencyAccess.Email.Equals(user.Email, StringComparison.InvariantCultureIgnoreCase))
|
||||||
{
|
{
|
||||||
@ -163,6 +162,8 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
public async Task DeleteAsync(Guid emergencyAccessId, Guid grantorId)
|
public async Task DeleteAsync(Guid emergencyAccessId, Guid grantorId)
|
||||||
{
|
{
|
||||||
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(emergencyAccessId);
|
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(emergencyAccessId);
|
||||||
|
// TODO PM-19438/PM-21687
|
||||||
|
// Not sure why the GrantorId and the GranteeId are supposed to be the same?
|
||||||
if (emergencyAccess == null || (emergencyAccess.GrantorId != grantorId && emergencyAccess.GranteeId != grantorId))
|
if (emergencyAccess == null || (emergencyAccess.GrantorId != grantorId && emergencyAccess.GranteeId != grantorId))
|
||||||
{
|
{
|
||||||
throw new BadRequestException("Emergency Access not valid.");
|
throw new BadRequestException("Emergency Access not valid.");
|
||||||
@ -171,9 +172,9 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
await _emergencyAccessRepository.DeleteAsync(emergencyAccess);
|
await _emergencyAccessRepository.DeleteAsync(emergencyAccess);
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task<EmergencyAccess> ConfirmUserAsync(Guid emergencyAcccessId, string key, Guid confirmingUserId)
|
public async Task<EmergencyAccess> ConfirmUserAsync(Guid emergencyAccessId, string key, Guid confirmingUserId)
|
||||||
{
|
{
|
||||||
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(emergencyAcccessId);
|
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(emergencyAccessId);
|
||||||
if (emergencyAccess == null || emergencyAccess.Status != EmergencyAccessStatusType.Accepted ||
|
if (emergencyAccess == null || emergencyAccess.Status != EmergencyAccessStatusType.Accepted ||
|
||||||
emergencyAccess.GrantorId != confirmingUserId)
|
emergencyAccess.GrantorId != confirmingUserId)
|
||||||
{
|
{
|
||||||
@ -224,7 +225,6 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
public async Task InitiateAsync(Guid id, User initiatingUser)
|
public async Task InitiateAsync(Guid id, User initiatingUser)
|
||||||
{
|
{
|
||||||
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(id);
|
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(id);
|
||||||
|
|
||||||
if (emergencyAccess == null || emergencyAccess.GranteeId != initiatingUser.Id ||
|
if (emergencyAccess == null || emergencyAccess.GranteeId != initiatingUser.Id ||
|
||||||
emergencyAccess.Status != EmergencyAccessStatusType.Confirmed)
|
emergencyAccess.Status != EmergencyAccessStatusType.Confirmed)
|
||||||
{
|
{
|
||||||
@ -285,6 +285,9 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
|
|
||||||
public async Task<ICollection<Policy>> GetPoliciesAsync(Guid id, User requestingUser)
|
public async Task<ICollection<Policy>> GetPoliciesAsync(Guid id, User requestingUser)
|
||||||
{
|
{
|
||||||
|
// TODO PM-21687
|
||||||
|
// Should we look up policies here or just verify the EmergencyAccess is correct
|
||||||
|
// and handle policy logic else where? Should this be a query/Command?
|
||||||
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(id);
|
var emergencyAccess = await _emergencyAccessRepository.GetByIdAsync(id);
|
||||||
|
|
||||||
if (!IsValidRequest(emergencyAccess, requestingUser, EmergencyAccessType.Takeover))
|
if (!IsValidRequest(emergencyAccess, requestingUser, EmergencyAccessType.Takeover))
|
||||||
@ -295,7 +298,9 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
var grantor = await _userRepository.GetByIdAsync(emergencyAccess.GrantorId);
|
var grantor = await _userRepository.GetByIdAsync(emergencyAccess.GrantorId);
|
||||||
|
|
||||||
var grantorOrganizations = await _organizationUserRepository.GetManyByUserAsync(grantor.Id);
|
var grantorOrganizations = await _organizationUserRepository.GetManyByUserAsync(grantor.Id);
|
||||||
var isOrganizationOwner = grantorOrganizations.Any<OrganizationUser>(organization => organization.Type == OrganizationUserType.Owner);
|
var isOrganizationOwner = grantorOrganizations
|
||||||
|
.Any(organization => organization.Type == OrganizationUserType.Owner);
|
||||||
|
|
||||||
var policies = isOrganizationOwner ? await _policyRepository.GetManyByUserIdAsync(grantor.Id) : null;
|
var policies = isOrganizationOwner ? await _policyRepository.GetManyByUserIdAsync(grantor.Id) : null;
|
||||||
|
|
||||||
return policies;
|
return policies;
|
||||||
@ -311,7 +316,8 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
}
|
}
|
||||||
|
|
||||||
var grantor = await _userRepository.GetByIdAsync(emergencyAccess.GrantorId);
|
var grantor = await _userRepository.GetByIdAsync(emergencyAccess.GrantorId);
|
||||||
|
// TODO PM-21687
|
||||||
|
// Redundant check of the EmergencyAccessType -> checked in IsValidRequest() ln 308
|
||||||
if (emergencyAccess.Type == EmergencyAccessType.Takeover && grantor.UsesKeyConnector)
|
if (emergencyAccess.Type == EmergencyAccessType.Takeover && grantor.UsesKeyConnector)
|
||||||
{
|
{
|
||||||
throw new BadRequestException("You cannot takeover an account that is using Key Connector.");
|
throw new BadRequestException("You cannot takeover an account that is using Key Connector.");
|
||||||
@ -336,7 +342,9 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
grantor.LastPasswordChangeDate = grantor.RevisionDate;
|
grantor.LastPasswordChangeDate = grantor.RevisionDate;
|
||||||
grantor.Key = key;
|
grantor.Key = key;
|
||||||
// Disable TwoFactor providers since they will otherwise block logins
|
// Disable TwoFactor providers since they will otherwise block logins
|
||||||
grantor.SetTwoFactorProviders(new Dictionary<TwoFactorProviderType, TwoFactorProvider>());
|
grantor.SetTwoFactorProviders([]);
|
||||||
|
// Disable New Device Verification since it will otherwise block logins
|
||||||
|
grantor.VerifyDevices = false;
|
||||||
await _userRepository.ReplaceAsync(grantor);
|
await _userRepository.ReplaceAsync(grantor);
|
||||||
|
|
||||||
// Remove grantor from all organizations unless Owner
|
// Remove grantor from all organizations unless Owner
|
||||||
@ -421,12 +429,22 @@ public class EmergencyAccessService : IEmergencyAccessService
|
|||||||
await _mailService.SendEmergencyAccessInviteEmailAsync(emergencyAccess, invitingUsersName, token);
|
await _mailService.SendEmergencyAccessInviteEmailAsync(emergencyAccess, invitingUsersName, token);
|
||||||
}
|
}
|
||||||
|
|
||||||
private string NameOrEmail(User user)
|
private static string NameOrEmail(User user)
|
||||||
{
|
{
|
||||||
return string.IsNullOrWhiteSpace(user.Name) ? user.Email : user.Name;
|
return string.IsNullOrWhiteSpace(user.Name) ? user.Email : user.Name;
|
||||||
}
|
}
|
||||||
|
|
||||||
private bool IsValidRequest(EmergencyAccess availableAccess, User requestingUser, EmergencyAccessType requestedAccessType)
|
|
||||||
|
/*
|
||||||
|
* Checks if EmergencyAccess Object is null
|
||||||
|
* Checks the requesting user is the same as the granteeUser (So we are checking for proper grantee action)
|
||||||
|
* Status _must_ equal RecoveryApproved (This means the grantor has invited, the grantee has accepted, and the grantor has approved so the shared key exists but hasn't been exercised yet)
|
||||||
|
* request type must equal the type of access requested (View or Takeover)
|
||||||
|
*/
|
||||||
|
private static bool IsValidRequest(
|
||||||
|
EmergencyAccess availableAccess,
|
||||||
|
User requestingUser,
|
||||||
|
EmergencyAccessType requestedAccessType)
|
||||||
{
|
{
|
||||||
return availableAccess != null &&
|
return availableAccess != null &&
|
||||||
availableAccess.GranteeId == requestingUser.Id &&
|
availableAccess.GranteeId == requestingUser.Id &&
|
||||||
|
@ -2,10 +2,6 @@
|
|||||||
|
|
||||||
public static class StripeConstants
|
public static class StripeConstants
|
||||||
{
|
{
|
||||||
public static class Prices
|
|
||||||
{
|
|
||||||
public const string StoragePlanPersonal = "personal-storage-gb-annually";
|
|
||||||
}
|
|
||||||
public static class AutomaticTaxStatus
|
public static class AutomaticTaxStatus
|
||||||
{
|
{
|
||||||
public const string Failed = "failed";
|
public const string Failed = "failed";
|
||||||
@ -69,6 +65,11 @@ public static class StripeConstants
|
|||||||
public const string USBankAccount = "us_bank_account";
|
public const string USBankAccount = "us_bank_account";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public static class Prices
|
||||||
|
{
|
||||||
|
public const string StoragePlanPersonal = "personal-storage-gb-annually";
|
||||||
|
}
|
||||||
|
|
||||||
public static class ProrationBehavior
|
public static class ProrationBehavior
|
||||||
{
|
{
|
||||||
public const string AlwaysInvoice = "always_invoice";
|
public const string AlwaysInvoice = "always_invoice";
|
||||||
@ -88,6 +89,13 @@ public static class StripeConstants
|
|||||||
public const string Paused = "paused";
|
public const string Paused = "paused";
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public static class TaxExempt
|
||||||
|
{
|
||||||
|
public const string Exempt = "exempt";
|
||||||
|
public const string None = "none";
|
||||||
|
public const string Reverse = "reverse";
|
||||||
|
}
|
||||||
|
|
||||||
public static class ValidateTaxLocationTiming
|
public static class ValidateTaxLocationTiming
|
||||||
{
|
{
|
||||||
public const string Deferred = "deferred";
|
public const string Deferred = "deferred";
|
||||||
|
@ -15,12 +15,7 @@ public static class CustomerExtensions
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
/// <summary>
|
public static bool HasRecognizedTaxLocation(this Customer customer) =>
|
||||||
/// Determines if a Stripe customer supports automatic tax
|
|
||||||
/// </summary>
|
|
||||||
/// <param name="customer"></param>
|
|
||||||
/// <returns></returns>
|
|
||||||
public static bool HasTaxLocationVerified(this Customer customer) =>
|
|
||||||
customer?.Tax?.AutomaticTax != StripeConstants.AutomaticTaxStatus.UnrecognizedLocation;
|
customer?.Tax?.AutomaticTax != StripeConstants.AutomaticTaxStatus.UnrecognizedLocation;
|
||||||
|
|
||||||
public static decimal GetBillingBalance(this Customer customer)
|
public static decimal GetBillingBalance(this Customer customer)
|
||||||
|
@ -22,7 +22,7 @@ public static class SubscriptionUpdateOptionsExtensions
|
|||||||
}
|
}
|
||||||
|
|
||||||
// We might only need to check the automatic tax status.
|
// We might only need to check the automatic tax status.
|
||||||
if (!customer.HasTaxLocationVerified() && string.IsNullOrWhiteSpace(customer.Address?.Country))
|
if (!customer.HasRecognizedTaxLocation() && string.IsNullOrWhiteSpace(customer.Address?.Country))
|
||||||
{
|
{
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
@ -22,7 +22,7 @@ public static class UpcomingInvoiceOptionsExtensions
|
|||||||
}
|
}
|
||||||
|
|
||||||
// We might only need to check the automatic tax status.
|
// We might only need to check the automatic tax status.
|
||||||
if (!customer.HasTaxLocationVerified() && string.IsNullOrWhiteSpace(customer.Address?.Country))
|
if (!customer.HasRecognizedTaxLocation() && string.IsNullOrWhiteSpace(customer.Address?.Country))
|
||||||
{
|
{
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
@ -309,6 +309,7 @@ public class OrganizationMigrator(
|
|||||||
organization.MaxStorageGb = plan.PasswordManager.BaseStorageGb;
|
organization.MaxStorageGb = plan.PasswordManager.BaseStorageGb;
|
||||||
organization.UsePolicies = plan.HasPolicies;
|
organization.UsePolicies = plan.HasPolicies;
|
||||||
organization.UseSso = plan.HasSso;
|
organization.UseSso = plan.HasSso;
|
||||||
|
organization.UseOrganizationDomains = plan.HasOrganizationDomains;
|
||||||
organization.UseGroups = plan.HasGroups;
|
organization.UseGroups = plan.HasGroups;
|
||||||
organization.UseEvents = plan.HasEvents;
|
organization.UseEvents = plan.HasEvents;
|
||||||
organization.UseDirectory = plan.HasDirectory;
|
organization.UseDirectory = plan.HasDirectory;
|
||||||
|
@ -26,6 +26,7 @@ public record Enterprise2019Plan : Plan
|
|||||||
Has2fa = true;
|
Has2fa = true;
|
||||||
HasApi = true;
|
HasApi = true;
|
||||||
HasSso = true;
|
HasSso = true;
|
||||||
|
HasOrganizationDomains = true;
|
||||||
HasKeyConnector = true;
|
HasKeyConnector = true;
|
||||||
HasScim = true;
|
HasScim = true;
|
||||||
HasResetPassword = true;
|
HasResetPassword = true;
|
||||||
|
@ -26,6 +26,7 @@ public record Enterprise2020Plan : Plan
|
|||||||
Has2fa = true;
|
Has2fa = true;
|
||||||
HasApi = true;
|
HasApi = true;
|
||||||
HasSso = true;
|
HasSso = true;
|
||||||
|
HasOrganizationDomains = true;
|
||||||
HasKeyConnector = true;
|
HasKeyConnector = true;
|
||||||
HasScim = true;
|
HasScim = true;
|
||||||
HasResetPassword = true;
|
HasResetPassword = true;
|
||||||
|
@ -26,6 +26,7 @@ public record EnterprisePlan : Plan
|
|||||||
Has2fa = true;
|
Has2fa = true;
|
||||||
HasApi = true;
|
HasApi = true;
|
||||||
HasSso = true;
|
HasSso = true;
|
||||||
|
HasOrganizationDomains = true;
|
||||||
HasKeyConnector = true;
|
HasKeyConnector = true;
|
||||||
HasScim = true;
|
HasScim = true;
|
||||||
HasResetPassword = true;
|
HasResetPassword = true;
|
||||||
|
@ -26,6 +26,7 @@ public record Enterprise2023Plan : Plan
|
|||||||
Has2fa = true;
|
Has2fa = true;
|
||||||
HasApi = true;
|
HasApi = true;
|
||||||
HasSso = true;
|
HasSso = true;
|
||||||
|
HasOrganizationDomains = true;
|
||||||
HasKeyConnector = true;
|
HasKeyConnector = true;
|
||||||
HasScim = true;
|
HasScim = true;
|
||||||
HasResetPassword = true;
|
HasResetPassword = true;
|
||||||
|
@ -26,6 +26,7 @@ public record PlanAdapter : Plan
|
|||||||
Has2fa = HasFeature("2fa");
|
Has2fa = HasFeature("2fa");
|
||||||
HasApi = HasFeature("api");
|
HasApi = HasFeature("api");
|
||||||
HasSso = HasFeature("sso");
|
HasSso = HasFeature("sso");
|
||||||
|
HasOrganizationDomains = HasFeature("organizationDomains");
|
||||||
HasKeyConnector = HasFeature("keyConnector");
|
HasKeyConnector = HasFeature("keyConnector");
|
||||||
HasScim = HasFeature("scim");
|
HasScim = HasFeature("scim");
|
||||||
HasResetPassword = HasFeature("resetPassword");
|
HasResetPassword = HasFeature("resetPassword");
|
||||||
|
@ -1,11 +1,11 @@
|
|||||||
using Bit.Core.AdminConsole.Entities;
|
using Bit.Core.AdminConsole.Entities;
|
||||||
using Bit.Core.Billing.Caches;
|
using Bit.Core.Billing.Caches;
|
||||||
using Bit.Core.Billing.Constants;
|
using Bit.Core.Billing.Constants;
|
||||||
|
using Bit.Core.Billing.Enums;
|
||||||
using Bit.Core.Billing.Extensions;
|
using Bit.Core.Billing.Extensions;
|
||||||
using Bit.Core.Billing.Models;
|
using Bit.Core.Billing.Models;
|
||||||
using Bit.Core.Billing.Models.Sales;
|
using Bit.Core.Billing.Models.Sales;
|
||||||
using Bit.Core.Billing.Pricing;
|
using Bit.Core.Billing.Pricing;
|
||||||
using Bit.Core.Billing.Services.Contracts;
|
|
||||||
using Bit.Core.Billing.Tax.Models;
|
using Bit.Core.Billing.Tax.Models;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
using Bit.Core.Billing.Tax.Services;
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
@ -35,16 +35,15 @@ public class OrganizationBillingService(
|
|||||||
ISetupIntentCache setupIntentCache,
|
ISetupIntentCache setupIntentCache,
|
||||||
IStripeAdapter stripeAdapter,
|
IStripeAdapter stripeAdapter,
|
||||||
ISubscriberService subscriberService,
|
ISubscriberService subscriberService,
|
||||||
ITaxService taxService,
|
ITaxService taxService) : IOrganizationBillingService
|
||||||
IAutomaticTaxFactory automaticTaxFactory) : IOrganizationBillingService
|
|
||||||
{
|
{
|
||||||
public async Task Finalize(OrganizationSale sale)
|
public async Task Finalize(OrganizationSale sale)
|
||||||
{
|
{
|
||||||
var (organization, customerSetup, subscriptionSetup) = sale;
|
var (organization, customerSetup, subscriptionSetup) = sale;
|
||||||
|
|
||||||
var customer = string.IsNullOrEmpty(organization.GatewayCustomerId) && customerSetup != null
|
var customer = string.IsNullOrEmpty(organization.GatewayCustomerId) && customerSetup != null
|
||||||
? await CreateCustomerAsync(organization, customerSetup)
|
? await CreateCustomerAsync(organization, customerSetup, subscriptionSetup.PlanType)
|
||||||
: await subscriberService.GetCustomerOrThrow(organization, new CustomerGetOptions { Expand = ["tax", "tax_ids"] });
|
: await GetCustomerWhileEnsuringCorrectTaxExemptionAsync(organization, subscriptionSetup);
|
||||||
|
|
||||||
var subscription = await CreateSubscriptionAsync(organization.Id, customer, subscriptionSetup);
|
var subscription = await CreateSubscriptionAsync(organization.Id, customer, subscriptionSetup);
|
||||||
|
|
||||||
@ -121,7 +120,8 @@ public class OrganizationBillingService(
|
|||||||
subscription.CurrentPeriodEnd);
|
subscription.CurrentPeriodEnd);
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task UpdatePaymentMethod(
|
public async Task
|
||||||
|
UpdatePaymentMethod(
|
||||||
Organization organization,
|
Organization organization,
|
||||||
TokenizedPaymentSource tokenizedPaymentSource,
|
TokenizedPaymentSource tokenizedPaymentSource,
|
||||||
TaxInformation taxInformation)
|
TaxInformation taxInformation)
|
||||||
@ -151,8 +151,11 @@ public class OrganizationBillingService(
|
|||||||
|
|
||||||
private async Task<Customer> CreateCustomerAsync(
|
private async Task<Customer> CreateCustomerAsync(
|
||||||
Organization organization,
|
Organization organization,
|
||||||
CustomerSetup customerSetup)
|
CustomerSetup customerSetup,
|
||||||
|
PlanType? updatedPlanType = null)
|
||||||
{
|
{
|
||||||
|
var planType = updatedPlanType ?? organization.PlanType;
|
||||||
|
|
||||||
var displayName = organization.DisplayName();
|
var displayName = organization.DisplayName();
|
||||||
|
|
||||||
var customerCreateOptions = new CustomerCreateOptions
|
var customerCreateOptions = new CustomerCreateOptions
|
||||||
@ -212,13 +215,24 @@ public class OrganizationBillingService(
|
|||||||
City = customerSetup.TaxInformation.City,
|
City = customerSetup.TaxInformation.City,
|
||||||
PostalCode = customerSetup.TaxInformation.PostalCode,
|
PostalCode = customerSetup.TaxInformation.PostalCode,
|
||||||
State = customerSetup.TaxInformation.State,
|
State = customerSetup.TaxInformation.State,
|
||||||
Country = customerSetup.TaxInformation.Country,
|
Country = customerSetup.TaxInformation.Country
|
||||||
};
|
};
|
||||||
|
|
||||||
customerCreateOptions.Tax = new CustomerTaxOptions
|
customerCreateOptions.Tax = new CustomerTaxOptions
|
||||||
{
|
{
|
||||||
ValidateLocation = StripeConstants.ValidateTaxLocationTiming.Immediately
|
ValidateLocation = StripeConstants.ValidateTaxLocationTiming.Immediately
|
||||||
};
|
};
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge =
|
||||||
|
featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge &&
|
||||||
|
planType.GetProductTier() is not ProductTierType.Free and not ProductTierType.Families &&
|
||||||
|
customerSetup.TaxInformation.Country != "US")
|
||||||
|
{
|
||||||
|
customerCreateOptions.TaxExempt = StripeConstants.TaxExempt.Reverse;
|
||||||
|
}
|
||||||
|
|
||||||
if (!string.IsNullOrEmpty(customerSetup.TaxInformation.TaxId))
|
if (!string.IsNullOrEmpty(customerSetup.TaxInformation.TaxId))
|
||||||
{
|
{
|
||||||
var taxIdType = taxService.GetStripeTaxCode(customerSetup.TaxInformation.Country,
|
var taxIdType = taxService.GetStripeTaxCode(customerSetup.TaxInformation.Country,
|
||||||
@ -399,21 +413,68 @@ public class OrganizationBillingService(
|
|||||||
TrialPeriodDays = subscriptionSetup.SkipTrial ? 0 : plan.TrialPeriodDays
|
TrialPeriodDays = subscriptionSetup.SkipTrial ? 0 : plan.TrialPeriodDays
|
||||||
};
|
};
|
||||||
|
|
||||||
if (featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var setNonUSBusinessUseToReverseCharge =
|
||||||
|
featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
{
|
{
|
||||||
var automaticTaxParameters = new AutomaticTaxFactoryParameters(subscriptionSetup.PlanType);
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
var automaticTaxStrategy = await automaticTaxFactory.CreateAsync(automaticTaxParameters);
|
|
||||||
automaticTaxStrategy.SetCreateOptions(subscriptionCreateOptions, customer);
|
|
||||||
}
|
}
|
||||||
else
|
else if (customer.HasRecognizedTaxLocation())
|
||||||
{
|
{
|
||||||
subscriptionCreateOptions.AutomaticTax ??= new SubscriptionAutomaticTaxOptions();
|
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
subscriptionCreateOptions.AutomaticTax.Enabled = customer.HasBillingLocation();
|
{
|
||||||
|
Enabled =
|
||||||
|
subscriptionSetup.PlanType.GetProductTier() == ProductTierType.Families ||
|
||||||
|
customer.Address.Country == "US" ||
|
||||||
|
customer.TaxIds.Any()
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
return await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
|
return await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private async Task<Customer> GetCustomerWhileEnsuringCorrectTaxExemptionAsync(
|
||||||
|
Organization organization,
|
||||||
|
SubscriptionSetup subscriptionSetup)
|
||||||
|
{
|
||||||
|
var customer = await subscriberService.GetCustomerOrThrow(organization,
|
||||||
|
new CustomerGetOptions { Expand = ["tax", "tax_ids"] });
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge = featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (!setNonUSBusinessUseToReverseCharge || subscriptionSetup.PlanType.GetProductTier() is
|
||||||
|
not (ProductTierType.Teams or
|
||||||
|
ProductTierType.TeamsStarter or
|
||||||
|
ProductTierType.Enterprise))
|
||||||
|
{
|
||||||
|
return customer;
|
||||||
|
}
|
||||||
|
|
||||||
|
List<string> expansions = ["tax", "tax_ids"];
|
||||||
|
|
||||||
|
customer = customer switch
|
||||||
|
{
|
||||||
|
{ Address.Country: not "US", TaxExempt: not StripeConstants.TaxExempt.Reverse } => await
|
||||||
|
stripeAdapter.CustomerUpdateAsync(customer.Id,
|
||||||
|
new CustomerUpdateOptions
|
||||||
|
{
|
||||||
|
Expand = expansions,
|
||||||
|
TaxExempt = StripeConstants.TaxExempt.Reverse
|
||||||
|
}),
|
||||||
|
{ Address.Country: "US", TaxExempt: StripeConstants.TaxExempt.Reverse } => await
|
||||||
|
stripeAdapter.CustomerUpdateAsync(customer.Id,
|
||||||
|
new CustomerUpdateOptions
|
||||||
|
{
|
||||||
|
Expand = expansions,
|
||||||
|
TaxExempt = StripeConstants.TaxExempt.None
|
||||||
|
}),
|
||||||
|
_ => customer
|
||||||
|
};
|
||||||
|
|
||||||
|
return customer;
|
||||||
|
}
|
||||||
|
|
||||||
private async Task<bool> IsEligibleForSelfHostAsync(
|
private async Task<bool> IsEligibleForSelfHostAsync(
|
||||||
Organization organization)
|
Organization organization)
|
||||||
{
|
{
|
||||||
|
@ -3,8 +3,6 @@ using Bit.Core.Billing.Constants;
|
|||||||
using Bit.Core.Billing.Models;
|
using Bit.Core.Billing.Models;
|
||||||
using Bit.Core.Billing.Models.Sales;
|
using Bit.Core.Billing.Models.Sales;
|
||||||
using Bit.Core.Billing.Tax.Models;
|
using Bit.Core.Billing.Tax.Models;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
|
||||||
using Bit.Core.Billing.Tax.Services.Implementations;
|
|
||||||
using Bit.Core.Entities;
|
using Bit.Core.Entities;
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Exceptions;
|
using Bit.Core.Exceptions;
|
||||||
@ -12,7 +10,6 @@ using Bit.Core.Repositories;
|
|||||||
using Bit.Core.Services;
|
using Bit.Core.Services;
|
||||||
using Bit.Core.Settings;
|
using Bit.Core.Settings;
|
||||||
using Braintree;
|
using Braintree;
|
||||||
using Microsoft.Extensions.DependencyInjection;
|
|
||||||
using Microsoft.Extensions.Logging;
|
using Microsoft.Extensions.Logging;
|
||||||
using Stripe;
|
using Stripe;
|
||||||
using Customer = Stripe.Customer;
|
using Customer = Stripe.Customer;
|
||||||
@ -24,20 +21,18 @@ using static Utilities;
|
|||||||
|
|
||||||
public class PremiumUserBillingService(
|
public class PremiumUserBillingService(
|
||||||
IBraintreeGateway braintreeGateway,
|
IBraintreeGateway braintreeGateway,
|
||||||
IFeatureService featureService,
|
|
||||||
IGlobalSettings globalSettings,
|
IGlobalSettings globalSettings,
|
||||||
ILogger<PremiumUserBillingService> logger,
|
ILogger<PremiumUserBillingService> logger,
|
||||||
ISetupIntentCache setupIntentCache,
|
ISetupIntentCache setupIntentCache,
|
||||||
IStripeAdapter stripeAdapter,
|
IStripeAdapter stripeAdapter,
|
||||||
ISubscriberService subscriberService,
|
ISubscriberService subscriberService,
|
||||||
IUserRepository userRepository,
|
IUserRepository userRepository) : IPremiumUserBillingService
|
||||||
[FromKeyedServices(AutomaticTaxFactory.PersonalUse)] IAutomaticTaxStrategy automaticTaxStrategy) : IPremiumUserBillingService
|
|
||||||
{
|
{
|
||||||
public async Task Credit(User user, decimal amount)
|
public async Task Credit(User user, decimal amount)
|
||||||
{
|
{
|
||||||
var customer = await subscriberService.GetCustomer(user);
|
var customer = await subscriberService.GetCustomer(user);
|
||||||
|
|
||||||
// Negative credit represents a balance and all Stripe denomination is in cents.
|
// Negative credit represents a balance, and all Stripe denomination is in cents.
|
||||||
var credit = (long)(amount * -100);
|
var credit = (long)(amount * -100);
|
||||||
|
|
||||||
if (customer == null)
|
if (customer == null)
|
||||||
@ -184,7 +179,7 @@ public class PremiumUserBillingService(
|
|||||||
City = customerSetup.TaxInformation.City,
|
City = customerSetup.TaxInformation.City,
|
||||||
PostalCode = customerSetup.TaxInformation.PostalCode,
|
PostalCode = customerSetup.TaxInformation.PostalCode,
|
||||||
State = customerSetup.TaxInformation.State,
|
State = customerSetup.TaxInformation.State,
|
||||||
Country = customerSetup.TaxInformation.Country,
|
Country = customerSetup.TaxInformation.Country
|
||||||
},
|
},
|
||||||
Description = user.Name,
|
Description = user.Name,
|
||||||
Email = user.Email,
|
Email = user.Email,
|
||||||
@ -324,6 +319,10 @@ public class PremiumUserBillingService(
|
|||||||
|
|
||||||
var subscriptionCreateOptions = new SubscriptionCreateOptions
|
var subscriptionCreateOptions = new SubscriptionCreateOptions
|
||||||
{
|
{
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
|
{
|
||||||
|
Enabled = true
|
||||||
|
},
|
||||||
CollectionMethod = StripeConstants.CollectionMethod.ChargeAutomatically,
|
CollectionMethod = StripeConstants.CollectionMethod.ChargeAutomatically,
|
||||||
Customer = customer.Id,
|
Customer = customer.Id,
|
||||||
Items = subscriptionItemOptionsList,
|
Items = subscriptionItemOptionsList,
|
||||||
@ -337,18 +336,6 @@ public class PremiumUserBillingService(
|
|||||||
OffSession = true
|
OffSession = true
|
||||||
};
|
};
|
||||||
|
|
||||||
if (featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
|
||||||
{
|
|
||||||
automaticTaxStrategy.SetCreateOptions(subscriptionCreateOptions, customer);
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
subscriptionCreateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
|
||||||
{
|
|
||||||
Enabled = customer.Tax?.AutomaticTax == StripeConstants.AutomaticTaxStatus.Supported,
|
|
||||||
};
|
|
||||||
}
|
|
||||||
|
|
||||||
var subscription = await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
|
var subscription = await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
|
||||||
|
|
||||||
if (usingPayPal)
|
if (usingPayPal)
|
||||||
@ -380,7 +367,7 @@ public class PremiumUserBillingService(
|
|||||||
City = taxInformation.City,
|
City = taxInformation.City,
|
||||||
PostalCode = taxInformation.PostalCode,
|
PostalCode = taxInformation.PostalCode,
|
||||||
State = taxInformation.State,
|
State = taxInformation.State,
|
||||||
Country = taxInformation.Country,
|
Country = taxInformation.Country
|
||||||
},
|
},
|
||||||
Expand = ["tax"],
|
Expand = ["tax"],
|
||||||
Tax = new CustomerTaxOptions
|
Tax = new CustomerTaxOptions
|
||||||
|
@ -1,7 +1,10 @@
|
|||||||
using Bit.Core.Billing.Caches;
|
using Bit.Core.AdminConsole.Entities;
|
||||||
|
using Bit.Core.AdminConsole.Entities.Provider;
|
||||||
|
using Bit.Core.Billing.Caches;
|
||||||
using Bit.Core.Billing.Constants;
|
using Bit.Core.Billing.Constants;
|
||||||
|
using Bit.Core.Billing.Enums;
|
||||||
|
using Bit.Core.Billing.Extensions;
|
||||||
using Bit.Core.Billing.Models;
|
using Bit.Core.Billing.Models;
|
||||||
using Bit.Core.Billing.Services.Contracts;
|
|
||||||
using Bit.Core.Billing.Tax.Models;
|
using Bit.Core.Billing.Tax.Models;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
using Bit.Core.Billing.Tax.Services;
|
||||||
using Bit.Core.Entities;
|
using Bit.Core.Entities;
|
||||||
@ -28,8 +31,7 @@ public class SubscriberService(
|
|||||||
ILogger<SubscriberService> logger,
|
ILogger<SubscriberService> logger,
|
||||||
ISetupIntentCache setupIntentCache,
|
ISetupIntentCache setupIntentCache,
|
||||||
IStripeAdapter stripeAdapter,
|
IStripeAdapter stripeAdapter,
|
||||||
ITaxService taxService,
|
ITaxService taxService) : ISubscriberService
|
||||||
IAutomaticTaxFactory automaticTaxFactory) : ISubscriberService
|
|
||||||
{
|
{
|
||||||
public async Task CancelSubscription(
|
public async Task CancelSubscription(
|
||||||
ISubscriber subscriber,
|
ISubscriber subscriber,
|
||||||
@ -128,7 +130,7 @@ public class SubscriberService(
|
|||||||
[subscriber.BraintreeCloudRegionField()] = globalSettings.BaseServiceUri.CloudRegion
|
[subscriber.BraintreeCloudRegionField()] = globalSettings.BaseServiceUri.CloudRegion
|
||||||
},
|
},
|
||||||
Email = subscriber.BillingEmailAddress(),
|
Email = subscriber.BillingEmailAddress(),
|
||||||
PaymentMethodNonce = paymentMethodNonce,
|
PaymentMethodNonce = paymentMethodNonce
|
||||||
});
|
});
|
||||||
|
|
||||||
if (customerResult.IsSuccess())
|
if (customerResult.IsSuccess())
|
||||||
@ -482,7 +484,7 @@ public class SubscriberService(
|
|||||||
|
|
||||||
var matchingSetupIntent = setupIntentsForUpdatedPaymentMethod.First();
|
var matchingSetupIntent = setupIntentsForUpdatedPaymentMethod.First();
|
||||||
|
|
||||||
// Find the customer's existing setup intents that should be cancelled.
|
// Find the customer's existing setup intents that should be canceled.
|
||||||
var existingSetupIntentsForCustomer = (await getExistingSetupIntentsForCustomer)
|
var existingSetupIntentsForCustomer = (await getExistingSetupIntentsForCustomer)
|
||||||
.Where(si =>
|
.Where(si =>
|
||||||
si.Status is "requires_payment_method" or "requires_confirmation" or "requires_action");
|
si.Status is "requires_payment_method" or "requires_confirmation" or "requires_action");
|
||||||
@ -519,7 +521,7 @@ public class SubscriberService(
|
|||||||
await stripeAdapter.PaymentMethodAttachAsync(token,
|
await stripeAdapter.PaymentMethodAttachAsync(token,
|
||||||
new PaymentMethodAttachOptions { Customer = subscriber.GatewayCustomerId });
|
new PaymentMethodAttachOptions { Customer = subscriber.GatewayCustomerId });
|
||||||
|
|
||||||
// Find the customer's existing setup intents that should be cancelled.
|
// Find the customer's existing setup intents that should be canceled.
|
||||||
var existingSetupIntentsForCustomer = (await getExistingSetupIntentsForCustomer)
|
var existingSetupIntentsForCustomer = (await getExistingSetupIntentsForCustomer)
|
||||||
.Where(si =>
|
.Where(si =>
|
||||||
si.Status is "requires_payment_method" or "requires_confirmation" or "requires_action");
|
si.Status is "requires_payment_method" or "requires_confirmation" or "requires_action");
|
||||||
@ -637,7 +639,8 @@ public class SubscriberService(
|
|||||||
logger.LogWarning("Could not infer tax ID type in country '{Country}' with tax ID '{TaxID}'.",
|
logger.LogWarning("Could not infer tax ID type in country '{Country}' with tax ID '{TaxID}'.",
|
||||||
taxInformation.Country,
|
taxInformation.Country,
|
||||||
taxInformation.TaxId);
|
taxInformation.TaxId);
|
||||||
throw new Exceptions.BadRequestException("billingTaxIdTypeInferenceError");
|
|
||||||
|
throw new BadRequestException("billingTaxIdTypeInferenceError");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -654,53 +657,84 @@ public class SubscriberService(
|
|||||||
logger.LogWarning("Invalid tax ID '{TaxID}' for country '{Country}'.",
|
logger.LogWarning("Invalid tax ID '{TaxID}' for country '{Country}'.",
|
||||||
taxInformation.TaxId,
|
taxInformation.TaxId,
|
||||||
taxInformation.Country);
|
taxInformation.Country);
|
||||||
throw new Exceptions.BadRequestException("billingInvalidTaxIdError");
|
|
||||||
|
throw new BadRequestException("billingInvalidTaxIdError");
|
||||||
|
|
||||||
default:
|
default:
|
||||||
logger.LogError(e,
|
logger.LogError(e,
|
||||||
"Error creating tax ID '{TaxId}' in country '{Country}' for customer '{CustomerID}'.",
|
"Error creating tax ID '{TaxId}' in country '{Country}' for customer '{CustomerID}'.",
|
||||||
taxInformation.TaxId,
|
taxInformation.TaxId,
|
||||||
taxInformation.Country,
|
taxInformation.Country,
|
||||||
customer.Id);
|
customer.Id);
|
||||||
throw new Exceptions.BadRequestException("billingTaxIdCreationError");
|
|
||||||
|
throw new BadRequestException("billingTaxIdCreationError");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var subscription =
|
||||||
|
customer.Subscriptions.First(subscription => subscription.Id == subscriber.GatewaySubscriptionId);
|
||||||
|
|
||||||
|
var isBusinessUseSubscriber = subscriber switch
|
||||||
{
|
{
|
||||||
if (!string.IsNullOrEmpty(subscriber.GatewaySubscriptionId))
|
Organization organization => organization.PlanType.GetProductTier() is not ProductTierType.Free and not ProductTierType.Families,
|
||||||
|
Provider => true,
|
||||||
|
_ => false
|
||||||
|
};
|
||||||
|
|
||||||
|
var setNonUSBusinessUseToReverseCharge =
|
||||||
|
featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge && isBusinessUseSubscriber)
|
||||||
|
{
|
||||||
|
switch (customer)
|
||||||
{
|
{
|
||||||
var subscriptionGetOptions = new SubscriptionGetOptions
|
case
|
||||||
{
|
{
|
||||||
Expand = ["customer.tax", "customer.tax_ids"]
|
Address.Country: not "US",
|
||||||
};
|
TaxExempt: not StripeConstants.TaxExempt.Reverse
|
||||||
var subscription = await stripeAdapter.SubscriptionGetAsync(subscriber.GatewaySubscriptionId, subscriptionGetOptions);
|
}:
|
||||||
var automaticTaxParameters = new AutomaticTaxFactoryParameters(subscriber, subscription.Items.Select(x => x.Price.Id));
|
await stripeAdapter.CustomerUpdateAsync(customer.Id,
|
||||||
var automaticTaxStrategy = await automaticTaxFactory.CreateAsync(automaticTaxParameters);
|
new CustomerUpdateOptions { TaxExempt = StripeConstants.TaxExempt.Reverse });
|
||||||
var automaticTaxOptions = automaticTaxStrategy.GetUpdateOptions(subscription);
|
break;
|
||||||
if (automaticTaxOptions?.AutomaticTax?.Enabled != null)
|
case
|
||||||
{
|
{
|
||||||
await stripeAdapter.SubscriptionUpdateAsync(subscriber.GatewaySubscriptionId, automaticTaxOptions);
|
Address.Country: "US",
|
||||||
}
|
TaxExempt: StripeConstants.TaxExempt.Reverse
|
||||||
|
}:
|
||||||
|
await stripeAdapter.CustomerUpdateAsync(customer.Id,
|
||||||
|
new CustomerUpdateOptions { TaxExempt = StripeConstants.TaxExempt.None });
|
||||||
|
break;
|
||||||
}
|
}
|
||||||
}
|
|
||||||
else
|
if (!subscription.AutomaticTax.Enabled)
|
||||||
{
|
|
||||||
if (SubscriberIsEligibleForAutomaticTax(subscriber, customer))
|
|
||||||
{
|
{
|
||||||
await stripeAdapter.SubscriptionUpdateAsync(subscriber.GatewaySubscriptionId,
|
await stripeAdapter.SubscriptionUpdateAsync(subscription.Id,
|
||||||
new SubscriptionUpdateOptions
|
new SubscriptionUpdateOptions
|
||||||
{
|
{
|
||||||
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
var automaticTaxShouldBeEnabled = subscriber switch
|
||||||
|
{
|
||||||
|
User => true,
|
||||||
|
Organization organization => organization.PlanType.GetProductTier() == ProductTierType.Families ||
|
||||||
|
customer.Address.Country == "US" || (customer.TaxIds?.Any() ?? false),
|
||||||
|
Provider => customer.Address.Country == "US" || (customer.TaxIds?.Any() ?? false),
|
||||||
|
_ => false
|
||||||
|
};
|
||||||
|
|
||||||
return;
|
if (automaticTaxShouldBeEnabled && !subscription.AutomaticTax.Enabled)
|
||||||
|
{
|
||||||
bool SubscriberIsEligibleForAutomaticTax(ISubscriber localSubscriber, Customer localCustomer)
|
await stripeAdapter.SubscriptionUpdateAsync(subscription.Id,
|
||||||
=> !string.IsNullOrEmpty(localSubscriber.GatewaySubscriptionId) &&
|
new SubscriptionUpdateOptions
|
||||||
(localCustomer.Subscriptions?.Any(sub => sub.Id == localSubscriber.GatewaySubscriptionId && !sub.AutomaticTax.Enabled) ?? false) &&
|
{
|
||||||
localCustomer.Tax?.AutomaticTax == StripeConstants.AutomaticTaxStatus.Supported;
|
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -76,7 +76,7 @@ public class BusinessUseAutomaticTaxStrategy(IFeatureService featureService) : I
|
|||||||
|
|
||||||
private bool ShouldBeEnabled(Customer customer)
|
private bool ShouldBeEnabled(Customer customer)
|
||||||
{
|
{
|
||||||
if (!customer.HasTaxLocationVerified())
|
if (!customer.HasRecognizedTaxLocation())
|
||||||
{
|
{
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
@ -59,6 +59,6 @@ public class PersonalUseAutomaticTaxStrategy(IFeatureService featureService) : I
|
|||||||
|
|
||||||
private static bool ShouldBeEnabled(Customer customer)
|
private static bool ShouldBeEnabled(Customer customer)
|
||||||
{
|
{
|
||||||
return customer.HasTaxLocationVerified();
|
return customer.HasRecognizedTaxLocation();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -143,13 +143,13 @@ public static class FeatureFlagKeys
|
|||||||
public const string UsePricingService = "use-pricing-service";
|
public const string UsePricingService = "use-pricing-service";
|
||||||
public const string PM12276Breadcrumbing = "pm-12276-breadcrumbing-for-business-features";
|
public const string PM12276Breadcrumbing = "pm-12276-breadcrumbing-for-business-features";
|
||||||
public const string PM18794_ProviderPaymentMethod = "pm-18794-provider-payment-method";
|
public const string PM18794_ProviderPaymentMethod = "pm-18794-provider-payment-method";
|
||||||
public const string PM19147_AutomaticTaxImprovements = "pm-19147-automatic-tax-improvements";
|
|
||||||
public const string PM19422_AllowAutomaticTaxUpdates = "pm-19422-allow-automatic-tax-updates";
|
public const string PM19422_AllowAutomaticTaxUpdates = "pm-19422-allow-automatic-tax-updates";
|
||||||
public const string PM18770_EnableOrganizationBusinessUnitConversion = "pm-18770-enable-organization-business-unit-conversion";
|
public const string PM18770_EnableOrganizationBusinessUnitConversion = "pm-18770-enable-organization-business-unit-conversion";
|
||||||
public const string PM199566_UpdateMSPToChargeAutomatically = "pm-199566-update-msp-to-charge-automatically";
|
public const string PM199566_UpdateMSPToChargeAutomatically = "pm-199566-update-msp-to-charge-automatically";
|
||||||
public const string PM19956_RequireProviderPaymentMethodDuringSetup = "pm-19956-require-provider-payment-method-during-setup";
|
public const string PM19956_RequireProviderPaymentMethodDuringSetup = "pm-19956-require-provider-payment-method-during-setup";
|
||||||
public const string UseOrganizationWarningsService = "use-organization-warnings-service";
|
public const string UseOrganizationWarningsService = "use-organization-warnings-service";
|
||||||
public const string PM20322_AllowTrialLength0 = "pm-20322-allow-trial-length-0";
|
public const string PM20322_AllowTrialLength0 = "pm-20322-allow-trial-length-0";
|
||||||
|
public const string PM21092_SetNonUSBusinessUseToReverseCharge = "pm-21092-set-non-us-business-use-to-reverse-charge";
|
||||||
|
|
||||||
/* Data Insights and Reporting Team */
|
/* Data Insights and Reporting Team */
|
||||||
public const string RiskInsightsCriticalApplication = "pm-14466-risk-insights-critical-application";
|
public const string RiskInsightsCriticalApplication = "pm-14466-risk-insights-critical-application";
|
||||||
|
@ -84,6 +84,7 @@ public class OrganizationLicense : ILicense
|
|||||||
SmSeats = org.SmSeats;
|
SmSeats = org.SmSeats;
|
||||||
SmServiceAccounts = org.SmServiceAccounts;
|
SmServiceAccounts = org.SmServiceAccounts;
|
||||||
UseRiskInsights = org.UseRiskInsights;
|
UseRiskInsights = org.UseRiskInsights;
|
||||||
|
UseOrganizationDomains = org.UseOrganizationDomains;
|
||||||
|
|
||||||
// Deprecated. Left for backwards compatibility with old license versions.
|
// Deprecated. Left for backwards compatibility with old license versions.
|
||||||
LimitCollectionCreationDeletion = org.LimitCollectionCreation || org.LimitCollectionDeletion;
|
LimitCollectionCreationDeletion = org.LimitCollectionCreation || org.LimitCollectionDeletion;
|
||||||
@ -195,10 +196,10 @@ public class OrganizationLicense : ILicense
|
|||||||
/// <remarks>Intentionally set one version behind to allow self hosted users some time to update before
|
/// <remarks>Intentionally set one version behind to allow self hosted users some time to update before
|
||||||
/// getting out of date license errors
|
/// getting out of date license errors
|
||||||
/// </remarks>
|
/// </remarks>
|
||||||
public const int CurrentLicenseFileVersion = 14;
|
public const int CurrentLicenseFileVersion = 15;
|
||||||
private bool ValidLicenseVersion
|
private bool ValidLicenseVersion
|
||||||
{
|
{
|
||||||
get => Version is >= 1 and <= 15;
|
get => Version is >= 1 and <= 16;
|
||||||
}
|
}
|
||||||
|
|
||||||
public byte[] GetDataBytes(bool forHash = false)
|
public byte[] GetDataBytes(bool forHash = false)
|
||||||
@ -244,6 +245,8 @@ public class OrganizationLicense : ILicense
|
|||||||
(Version >= 14 || !p.Name.Equals(nameof(LimitCollectionCreationDeletion))) &&
|
(Version >= 14 || !p.Name.Equals(nameof(LimitCollectionCreationDeletion))) &&
|
||||||
// AllowAdminAccessToAllCollectionItems was added in Version 15
|
// AllowAdminAccessToAllCollectionItems was added in Version 15
|
||||||
(Version >= 15 || !p.Name.Equals(nameof(AllowAdminAccessToAllCollectionItems))) &&
|
(Version >= 15 || !p.Name.Equals(nameof(AllowAdminAccessToAllCollectionItems))) &&
|
||||||
|
// UseOrganizationDomains was added in Version 16
|
||||||
|
(Version >= 16 || !p.Name.Equals(nameof(UseOrganizationDomains))) &&
|
||||||
(
|
(
|
||||||
!forHash ||
|
!forHash ||
|
||||||
(
|
(
|
||||||
@ -252,7 +255,10 @@ public class OrganizationLicense : ILicense
|
|||||||
!p.Name.Equals(nameof(Refresh))
|
!p.Name.Equals(nameof(Refresh))
|
||||||
)
|
)
|
||||||
) &&
|
) &&
|
||||||
!p.Name.Equals(nameof(UseRiskInsights)))
|
// any new fields added need to be added here so that they're ignored
|
||||||
|
!p.Name.Equals(nameof(UseRiskInsights)) &&
|
||||||
|
!p.Name.Equals(nameof(UseAdminSponsoredFamilies)) &&
|
||||||
|
!p.Name.Equals(nameof(UseOrganizationDomains)))
|
||||||
.OrderBy(p => p.Name)
|
.OrderBy(p => p.Name)
|
||||||
.Select(p => $"{p.Name}:{Utilities.CoreHelpers.FormatLicenseSignatureValue(p.GetValue(this, null))}")
|
.Select(p => $"{p.Name}:{Utilities.CoreHelpers.FormatLicenseSignatureValue(p.GetValue(this, null))}")
|
||||||
.Aggregate((c, n) => $"{c}|{n}");
|
.Aggregate((c, n) => $"{c}|{n}");
|
||||||
@ -583,6 +589,11 @@ public class OrganizationLicense : ILicense
|
|||||||
* validation.
|
* validation.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
|
if (valid && Version >= 16)
|
||||||
|
{
|
||||||
|
valid = organization.UseOrganizationDomains;
|
||||||
|
}
|
||||||
|
|
||||||
return valid;
|
return valid;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -4,7 +4,6 @@ using Bit.Core.Billing.Models;
|
|||||||
using Bit.Core.Billing.Tax.Requests;
|
using Bit.Core.Billing.Tax.Requests;
|
||||||
using Bit.Core.Billing.Tax.Responses;
|
using Bit.Core.Billing.Tax.Responses;
|
||||||
using Bit.Core.Entities;
|
using Bit.Core.Entities;
|
||||||
using Bit.Core.Enums;
|
|
||||||
using Bit.Core.Models.Business;
|
using Bit.Core.Models.Business;
|
||||||
using Bit.Core.Models.StaticStore;
|
using Bit.Core.Models.StaticStore;
|
||||||
|
|
||||||
@ -30,8 +29,6 @@ public interface IPaymentService
|
|||||||
Task<string> AdjustServiceAccountsAsync(Organization organization, Plan plan, int additionalServiceAccounts);
|
Task<string> AdjustServiceAccountsAsync(Organization organization, Plan plan, int additionalServiceAccounts);
|
||||||
Task CancelSubscriptionAsync(ISubscriber subscriber, bool endOfPeriod = false);
|
Task CancelSubscriptionAsync(ISubscriber subscriber, bool endOfPeriod = false);
|
||||||
Task ReinstateSubscriptionAsync(ISubscriber subscriber);
|
Task ReinstateSubscriptionAsync(ISubscriber subscriber);
|
||||||
Task<bool> UpdatePaymentMethodAsync(ISubscriber subscriber, PaymentMethodType paymentMethodType,
|
|
||||||
string paymentToken, TaxInfo taxInfo = null);
|
|
||||||
Task<bool> CreditAccountAsync(ISubscriber subscriber, decimal creditAmount);
|
Task<bool> CreditAccountAsync(ISubscriber subscriber, decimal creditAmount);
|
||||||
Task<BillingInfo> GetBillingAsync(ISubscriber subscriber);
|
Task<BillingInfo> GetBillingAsync(ISubscriber subscriber);
|
||||||
Task<BillingHistoryInfo> GetBillingHistoryAsync(ISubscriber subscriber);
|
Task<BillingHistoryInfo> GetBillingHistoryAsync(ISubscriber subscriber);
|
||||||
|
@ -1,13 +1,13 @@
|
|||||||
using Bit.Core.AdminConsole.Entities;
|
using Bit.Core.AdminConsole.Entities;
|
||||||
|
using Bit.Core.AdminConsole.Entities.Provider;
|
||||||
using Bit.Core.AdminConsole.Models.Business;
|
using Bit.Core.AdminConsole.Models.Business;
|
||||||
using Bit.Core.Billing.Constants;
|
using Bit.Core.Billing.Constants;
|
||||||
|
using Bit.Core.Billing.Enums;
|
||||||
using Bit.Core.Billing.Extensions;
|
using Bit.Core.Billing.Extensions;
|
||||||
using Bit.Core.Billing.Models;
|
using Bit.Core.Billing.Models;
|
||||||
using Bit.Core.Billing.Models.Business;
|
using Bit.Core.Billing.Models.Business;
|
||||||
using Bit.Core.Billing.Pricing;
|
using Bit.Core.Billing.Pricing;
|
||||||
using Bit.Core.Billing.Services;
|
|
||||||
using Bit.Core.Billing.Services.Contracts;
|
using Bit.Core.Billing.Services.Contracts;
|
||||||
using Bit.Core.Billing.Tax.Models;
|
|
||||||
using Bit.Core.Billing.Tax.Requests;
|
using Bit.Core.Billing.Tax.Requests;
|
||||||
using Bit.Core.Billing.Tax.Responses;
|
using Bit.Core.Billing.Tax.Responses;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
using Bit.Core.Billing.Tax.Services;
|
||||||
@ -38,7 +38,6 @@ public class StripePaymentService : IPaymentService
|
|||||||
private readonly IGlobalSettings _globalSettings;
|
private readonly IGlobalSettings _globalSettings;
|
||||||
private readonly IFeatureService _featureService;
|
private readonly IFeatureService _featureService;
|
||||||
private readonly ITaxService _taxService;
|
private readonly ITaxService _taxService;
|
||||||
private readonly ISubscriberService _subscriberService;
|
|
||||||
private readonly IPricingClient _pricingClient;
|
private readonly IPricingClient _pricingClient;
|
||||||
private readonly IAutomaticTaxFactory _automaticTaxFactory;
|
private readonly IAutomaticTaxFactory _automaticTaxFactory;
|
||||||
private readonly IAutomaticTaxStrategy _personalUseTaxStrategy;
|
private readonly IAutomaticTaxStrategy _personalUseTaxStrategy;
|
||||||
@ -51,7 +50,6 @@ public class StripePaymentService : IPaymentService
|
|||||||
IGlobalSettings globalSettings,
|
IGlobalSettings globalSettings,
|
||||||
IFeatureService featureService,
|
IFeatureService featureService,
|
||||||
ITaxService taxService,
|
ITaxService taxService,
|
||||||
ISubscriberService subscriberService,
|
|
||||||
IPricingClient pricingClient,
|
IPricingClient pricingClient,
|
||||||
IAutomaticTaxFactory automaticTaxFactory,
|
IAutomaticTaxFactory automaticTaxFactory,
|
||||||
[FromKeyedServices(AutomaticTaxFactory.PersonalUse)] IAutomaticTaxStrategy personalUseTaxStrategy)
|
[FromKeyedServices(AutomaticTaxFactory.PersonalUse)] IAutomaticTaxStrategy personalUseTaxStrategy)
|
||||||
@ -63,7 +61,6 @@ public class StripePaymentService : IPaymentService
|
|||||||
_globalSettings = globalSettings;
|
_globalSettings = globalSettings;
|
||||||
_featureService = featureService;
|
_featureService = featureService;
|
||||||
_taxService = taxService;
|
_taxService = taxService;
|
||||||
_subscriberService = subscriberService;
|
|
||||||
_pricingClient = pricingClient;
|
_pricingClient = pricingClient;
|
||||||
_automaticTaxFactory = automaticTaxFactory;
|
_automaticTaxFactory = automaticTaxFactory;
|
||||||
_personalUseTaxStrategy = personalUseTaxStrategy;
|
_personalUseTaxStrategy = personalUseTaxStrategy;
|
||||||
@ -136,15 +133,68 @@ public class StripePaymentService : IPaymentService
|
|||||||
|
|
||||||
if (subscriptionUpdate is CompleteSubscriptionUpdate)
|
if (subscriptionUpdate is CompleteSubscriptionUpdate)
|
||||||
{
|
{
|
||||||
if (_featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
var setNonUSBusinessUseToReverseCharge =
|
||||||
|
_featureService.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge);
|
||||||
|
|
||||||
|
if (setNonUSBusinessUseToReverseCharge)
|
||||||
{
|
{
|
||||||
var automaticTaxParameters = new AutomaticTaxFactoryParameters(subscriber, updatedItemOptions.Select(x => x.Plan ?? x.Price));
|
if (sub.Customer is
|
||||||
var automaticTaxStrategy = await _automaticTaxFactory.CreateAsync(automaticTaxParameters);
|
{
|
||||||
automaticTaxStrategy.SetUpdateOptions(subUpdateOptions, sub);
|
Address.Country: not "US",
|
||||||
|
TaxExempt: not StripeConstants.TaxExempt.Reverse
|
||||||
|
})
|
||||||
|
{
|
||||||
|
await _stripeAdapter.CustomerUpdateAsync(sub.CustomerId,
|
||||||
|
new CustomerUpdateOptions { TaxExempt = StripeConstants.TaxExempt.Reverse });
|
||||||
|
}
|
||||||
|
|
||||||
|
subUpdateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
}
|
}
|
||||||
else
|
else if (sub.Customer.HasRecognizedTaxLocation())
|
||||||
{
|
{
|
||||||
subUpdateOptions.EnableAutomaticTax(sub.Customer, sub);
|
switch (subscriber)
|
||||||
|
{
|
||||||
|
case User:
|
||||||
|
{
|
||||||
|
subUpdateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case Organization:
|
||||||
|
{
|
||||||
|
if (sub.Customer.Address.Country == "US")
|
||||||
|
{
|
||||||
|
subUpdateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true };
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
var familyPriceIds = (await Task.WhenAll(
|
||||||
|
_pricingClient.GetPlanOrThrow(PlanType.FamiliesAnnually2019),
|
||||||
|
_pricingClient.GetPlanOrThrow(PlanType.FamiliesAnnually)))
|
||||||
|
.Select(plan => plan.PasswordManager.StripePlanId);
|
||||||
|
|
||||||
|
var updateIsForPersonalUse = updatedItemOptions
|
||||||
|
.Select(option => option.Price)
|
||||||
|
.Intersect(familyPriceIds)
|
||||||
|
.Any();
|
||||||
|
|
||||||
|
subUpdateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
|
{
|
||||||
|
Enabled = updateIsForPersonalUse || sub.Customer.TaxIds.Any()
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
case Provider:
|
||||||
|
{
|
||||||
|
subUpdateOptions.AutomaticTax = new SubscriptionAutomaticTaxOptions
|
||||||
|
{
|
||||||
|
Enabled = sub.Customer.Address.Country == "US" ||
|
||||||
|
sub.Customer.TaxIds.Any()
|
||||||
|
};
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -202,7 +252,7 @@ public class StripePaymentService : IPaymentService
|
|||||||
}
|
}
|
||||||
else if (!invoice.Paid)
|
else if (!invoice.Paid)
|
||||||
{
|
{
|
||||||
// Pay invoice with no charge to customer this completes the invoice immediately without waiting the scheduled 1h
|
// Pay invoice with no charge to the customer this completes the invoice immediately without waiting the scheduled 1h
|
||||||
invoice = await _stripeAdapter.InvoicePayAsync(subResponse.LatestInvoiceId);
|
invoice = await _stripeAdapter.InvoicePayAsync(subResponse.LatestInvoiceId);
|
||||||
paymentIntentClientSecret = null;
|
paymentIntentClientSecret = null;
|
||||||
}
|
}
|
||||||
@ -585,309 +635,6 @@ public class StripePaymentService : IPaymentService
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
public async Task<bool> UpdatePaymentMethodAsync(ISubscriber subscriber, PaymentMethodType paymentMethodType,
|
|
||||||
string paymentToken, TaxInfo taxInfo = null)
|
|
||||||
{
|
|
||||||
if (subscriber == null)
|
|
||||||
{
|
|
||||||
throw new ArgumentNullException(nameof(subscriber));
|
|
||||||
}
|
|
||||||
|
|
||||||
if (subscriber.Gateway.HasValue && subscriber.Gateway.Value != GatewayType.Stripe)
|
|
||||||
{
|
|
||||||
throw new GatewayException("Switching from one payment type to another is not supported. " +
|
|
||||||
"Contact us for assistance.");
|
|
||||||
}
|
|
||||||
|
|
||||||
var createdCustomer = false;
|
|
||||||
Braintree.Customer braintreeCustomer = null;
|
|
||||||
string stipeCustomerSourceToken = null;
|
|
||||||
string stipeCustomerPaymentMethodId = null;
|
|
||||||
var stripeCustomerMetadata = new Dictionary<string, string>
|
|
||||||
{
|
|
||||||
{ "region", _globalSettings.BaseServiceUri.CloudRegion }
|
|
||||||
};
|
|
||||||
var stripePaymentMethod = paymentMethodType is PaymentMethodType.Card or PaymentMethodType.BankAccount;
|
|
||||||
|
|
||||||
Customer customer = null;
|
|
||||||
|
|
||||||
if (!string.IsNullOrWhiteSpace(subscriber.GatewayCustomerId))
|
|
||||||
{
|
|
||||||
var options = new CustomerGetOptions { Expand = ["sources", "tax", "subscriptions"] };
|
|
||||||
customer = await _stripeAdapter.CustomerGetAsync(subscriber.GatewayCustomerId, options);
|
|
||||||
if (customer.Metadata?.Any() ?? false)
|
|
||||||
{
|
|
||||||
stripeCustomerMetadata = customer.Metadata;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
var hadBtCustomer = stripeCustomerMetadata.ContainsKey("btCustomerId");
|
|
||||||
if (stripePaymentMethod)
|
|
||||||
{
|
|
||||||
if (paymentToken.StartsWith("pm_"))
|
|
||||||
{
|
|
||||||
stipeCustomerPaymentMethodId = paymentToken;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
stipeCustomerSourceToken = paymentToken;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else if (paymentMethodType == PaymentMethodType.PayPal)
|
|
||||||
{
|
|
||||||
if (hadBtCustomer)
|
|
||||||
{
|
|
||||||
var pmResult = await _btGateway.PaymentMethod.CreateAsync(new Braintree.PaymentMethodRequest
|
|
||||||
{
|
|
||||||
CustomerId = stripeCustomerMetadata["btCustomerId"],
|
|
||||||
PaymentMethodNonce = paymentToken
|
|
||||||
});
|
|
||||||
|
|
||||||
if (pmResult.IsSuccess())
|
|
||||||
{
|
|
||||||
var customerResult = await _btGateway.Customer.UpdateAsync(
|
|
||||||
stripeCustomerMetadata["btCustomerId"], new Braintree.CustomerRequest
|
|
||||||
{
|
|
||||||
DefaultPaymentMethodToken = pmResult.Target.Token
|
|
||||||
});
|
|
||||||
|
|
||||||
if (customerResult.IsSuccess() && customerResult.Target.PaymentMethods.Length > 0)
|
|
||||||
{
|
|
||||||
braintreeCustomer = customerResult.Target;
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
await _btGateway.PaymentMethod.DeleteAsync(pmResult.Target.Token);
|
|
||||||
hadBtCustomer = false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
hadBtCustomer = false;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!hadBtCustomer)
|
|
||||||
{
|
|
||||||
var customerResult = await _btGateway.Customer.CreateAsync(new Braintree.CustomerRequest
|
|
||||||
{
|
|
||||||
PaymentMethodNonce = paymentToken,
|
|
||||||
Email = subscriber.BillingEmailAddress(),
|
|
||||||
Id = subscriber.BraintreeCustomerIdPrefix() + subscriber.Id.ToString("N").ToLower() +
|
|
||||||
Utilities.CoreHelpers.RandomString(3, upper: false, numeric: false),
|
|
||||||
CustomFields = new Dictionary<string, string>
|
|
||||||
{
|
|
||||||
[subscriber.BraintreeIdField()] = subscriber.Id.ToString(),
|
|
||||||
[subscriber.BraintreeCloudRegionField()] = _globalSettings.BaseServiceUri.CloudRegion
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
if (!customerResult.IsSuccess() || customerResult.Target.PaymentMethods.Length == 0)
|
|
||||||
{
|
|
||||||
throw new GatewayException("Failed to create PayPal customer record.");
|
|
||||||
}
|
|
||||||
|
|
||||||
braintreeCustomer = customerResult.Target;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
throw new GatewayException("Payment method is not supported at this time.");
|
|
||||||
}
|
|
||||||
|
|
||||||
if (stripeCustomerMetadata.ContainsKey("btCustomerId"))
|
|
||||||
{
|
|
||||||
if (braintreeCustomer?.Id != stripeCustomerMetadata["btCustomerId"])
|
|
||||||
{
|
|
||||||
stripeCustomerMetadata["btCustomerId_old"] = stripeCustomerMetadata["btCustomerId"];
|
|
||||||
}
|
|
||||||
|
|
||||||
stripeCustomerMetadata["btCustomerId"] = braintreeCustomer?.Id;
|
|
||||||
}
|
|
||||||
else if (!string.IsNullOrWhiteSpace(braintreeCustomer?.Id))
|
|
||||||
{
|
|
||||||
stripeCustomerMetadata.Add("btCustomerId", braintreeCustomer.Id);
|
|
||||||
}
|
|
||||||
|
|
||||||
try
|
|
||||||
{
|
|
||||||
if (!string.IsNullOrWhiteSpace(taxInfo.TaxIdNumber))
|
|
||||||
{
|
|
||||||
taxInfo.TaxIdType = taxInfo.TaxIdType ??
|
|
||||||
_taxService.GetStripeTaxCode(taxInfo.BillingAddressCountry, taxInfo.TaxIdNumber);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (customer == null)
|
|
||||||
{
|
|
||||||
customer = await _stripeAdapter.CustomerCreateAsync(new CustomerCreateOptions
|
|
||||||
{
|
|
||||||
Description = subscriber.BillingName(),
|
|
||||||
Email = subscriber.BillingEmailAddress(),
|
|
||||||
Metadata = stripeCustomerMetadata,
|
|
||||||
Source = stipeCustomerSourceToken,
|
|
||||||
PaymentMethod = stipeCustomerPaymentMethodId,
|
|
||||||
InvoiceSettings = new CustomerInvoiceSettingsOptions
|
|
||||||
{
|
|
||||||
DefaultPaymentMethod = stipeCustomerPaymentMethodId,
|
|
||||||
CustomFields =
|
|
||||||
[
|
|
||||||
new CustomerInvoiceSettingsCustomFieldOptions()
|
|
||||||
{
|
|
||||||
Name = subscriber.SubscriberType(),
|
|
||||||
Value = subscriber.GetFormattedInvoiceName()
|
|
||||||
}
|
|
||||||
|
|
||||||
]
|
|
||||||
},
|
|
||||||
Address = taxInfo == null ? null : new AddressOptions
|
|
||||||
{
|
|
||||||
Country = taxInfo.BillingAddressCountry,
|
|
||||||
PostalCode = taxInfo.BillingAddressPostalCode,
|
|
||||||
Line1 = taxInfo.BillingAddressLine1 ?? string.Empty,
|
|
||||||
Line2 = taxInfo.BillingAddressLine2,
|
|
||||||
City = taxInfo.BillingAddressCity,
|
|
||||||
State = taxInfo.BillingAddressState
|
|
||||||
},
|
|
||||||
TaxIdData = string.IsNullOrWhiteSpace(taxInfo.TaxIdNumber)
|
|
||||||
? []
|
|
||||||
: [
|
|
||||||
new CustomerTaxIdDataOptions
|
|
||||||
{
|
|
||||||
Type = taxInfo.TaxIdType,
|
|
||||||
Value = taxInfo.TaxIdNumber
|
|
||||||
}
|
|
||||||
],
|
|
||||||
Expand = ["sources", "tax", "subscriptions"],
|
|
||||||
});
|
|
||||||
|
|
||||||
subscriber.Gateway = GatewayType.Stripe;
|
|
||||||
subscriber.GatewayCustomerId = customer.Id;
|
|
||||||
createdCustomer = true;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!createdCustomer)
|
|
||||||
{
|
|
||||||
string defaultSourceId = null;
|
|
||||||
string defaultPaymentMethodId = null;
|
|
||||||
if (stripePaymentMethod)
|
|
||||||
{
|
|
||||||
if (!string.IsNullOrWhiteSpace(stipeCustomerSourceToken) && paymentToken.StartsWith("btok_"))
|
|
||||||
{
|
|
||||||
var bankAccount = await _stripeAdapter.BankAccountCreateAsync(customer.Id, new BankAccountCreateOptions
|
|
||||||
{
|
|
||||||
Source = paymentToken
|
|
||||||
});
|
|
||||||
defaultSourceId = bankAccount.Id;
|
|
||||||
}
|
|
||||||
else if (!string.IsNullOrWhiteSpace(stipeCustomerPaymentMethodId))
|
|
||||||
{
|
|
||||||
await _stripeAdapter.PaymentMethodAttachAsync(stipeCustomerPaymentMethodId,
|
|
||||||
new PaymentMethodAttachOptions { Customer = customer.Id });
|
|
||||||
defaultPaymentMethodId = stipeCustomerPaymentMethodId;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (customer.Sources != null)
|
|
||||||
{
|
|
||||||
foreach (var source in customer.Sources.Where(s => s.Id != defaultSourceId))
|
|
||||||
{
|
|
||||||
if (source is BankAccount)
|
|
||||||
{
|
|
||||||
await _stripeAdapter.BankAccountDeleteAsync(customer.Id, source.Id);
|
|
||||||
}
|
|
||||||
else if (source is Card)
|
|
||||||
{
|
|
||||||
await _stripeAdapter.CardDeleteAsync(customer.Id, source.Id);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
var cardPaymentMethods = _stripeAdapter.PaymentMethodListAutoPaging(new PaymentMethodListOptions
|
|
||||||
{
|
|
||||||
Customer = customer.Id,
|
|
||||||
Type = "card"
|
|
||||||
});
|
|
||||||
foreach (var cardMethod in cardPaymentMethods.Where(m => m.Id != defaultPaymentMethodId))
|
|
||||||
{
|
|
||||||
await _stripeAdapter.PaymentMethodDetachAsync(cardMethod.Id, new PaymentMethodDetachOptions());
|
|
||||||
}
|
|
||||||
|
|
||||||
await _subscriberService.UpdateTaxInformation(subscriber, TaxInformation.From(taxInfo));
|
|
||||||
|
|
||||||
customer = await _stripeAdapter.CustomerUpdateAsync(customer.Id, new CustomerUpdateOptions
|
|
||||||
{
|
|
||||||
Metadata = stripeCustomerMetadata,
|
|
||||||
DefaultSource = defaultSourceId,
|
|
||||||
InvoiceSettings = new CustomerInvoiceSettingsOptions
|
|
||||||
{
|
|
||||||
DefaultPaymentMethod = defaultPaymentMethodId,
|
|
||||||
CustomFields =
|
|
||||||
[
|
|
||||||
new CustomerInvoiceSettingsCustomFieldOptions()
|
|
||||||
{
|
|
||||||
Name = subscriber.SubscriberType(),
|
|
||||||
Value = subscriber.GetFormattedInvoiceName()
|
|
||||||
}
|
|
||||||
]
|
|
||||||
},
|
|
||||||
Expand = ["tax", "subscriptions"]
|
|
||||||
});
|
|
||||||
}
|
|
||||||
|
|
||||||
if (_featureService.IsEnabled(FeatureFlagKeys.PM19147_AutomaticTaxImprovements))
|
|
||||||
{
|
|
||||||
if (!string.IsNullOrEmpty(subscriber.GatewaySubscriptionId))
|
|
||||||
{
|
|
||||||
var subscriptionGetOptions = new SubscriptionGetOptions
|
|
||||||
{
|
|
||||||
Expand = ["customer.tax", "customer.tax_ids"]
|
|
||||||
};
|
|
||||||
var subscription = await _stripeAdapter.SubscriptionGetAsync(subscriber.GatewaySubscriptionId, subscriptionGetOptions);
|
|
||||||
|
|
||||||
var automaticTaxParameters = new AutomaticTaxFactoryParameters(subscriber, subscription.Items.Select(x => x.Price.Id));
|
|
||||||
var automaticTaxStrategy = await _automaticTaxFactory.CreateAsync(automaticTaxParameters);
|
|
||||||
var subscriptionUpdateOptions = automaticTaxStrategy.GetUpdateOptions(subscription);
|
|
||||||
|
|
||||||
if (subscriptionUpdateOptions != null)
|
|
||||||
{
|
|
||||||
_ = await _stripeAdapter.SubscriptionUpdateAsync(
|
|
||||||
subscriber.GatewaySubscriptionId,
|
|
||||||
subscriptionUpdateOptions);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
else
|
|
||||||
{
|
|
||||||
if (!string.IsNullOrEmpty(subscriber.GatewaySubscriptionId) &&
|
|
||||||
customer.Subscriptions.Any(sub =>
|
|
||||||
sub.Id == subscriber.GatewaySubscriptionId &&
|
|
||||||
!sub.AutomaticTax.Enabled) &&
|
|
||||||
customer.HasTaxLocationVerified())
|
|
||||||
{
|
|
||||||
var subscriptionUpdateOptions = new SubscriptionUpdateOptions
|
|
||||||
{
|
|
||||||
AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true },
|
|
||||||
DefaultTaxRates = []
|
|
||||||
};
|
|
||||||
|
|
||||||
_ = await _stripeAdapter.SubscriptionUpdateAsync(
|
|
||||||
subscriber.GatewaySubscriptionId,
|
|
||||||
subscriptionUpdateOptions);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
catch
|
|
||||||
{
|
|
||||||
if (braintreeCustomer != null && !hadBtCustomer)
|
|
||||||
{
|
|
||||||
await _btGateway.Customer.DeleteAsync(braintreeCustomer.Id);
|
|
||||||
}
|
|
||||||
throw;
|
|
||||||
}
|
|
||||||
|
|
||||||
return createdCustomer;
|
|
||||||
}
|
|
||||||
|
|
||||||
public async Task<bool> CreditAccountAsync(ISubscriber subscriber, decimal creditAmount)
|
public async Task<bool> CreditAccountAsync(ISubscriber subscriber, decimal creditAmount)
|
||||||
{
|
{
|
||||||
Customer customer = null;
|
Customer customer = null;
|
||||||
@ -1018,7 +765,7 @@ public class StripePaymentService : IPaymentService
|
|||||||
var address = customer.Address;
|
var address = customer.Address;
|
||||||
var taxId = customer.TaxIds?.FirstOrDefault();
|
var taxId = customer.TaxIds?.FirstOrDefault();
|
||||||
|
|
||||||
// Line1 is required, so if missing we're using the subscriber name
|
// Line1 is required, so if missing we're using the subscriber name,
|
||||||
// see: https://stripe.com/docs/api/customers/create#create_customer-address-line1
|
// see: https://stripe.com/docs/api/customers/create#create_customer-address-line1
|
||||||
if (address != null && string.IsNullOrWhiteSpace(address.Line1))
|
if (address != null && string.IsNullOrWhiteSpace(address.Line1))
|
||||||
{
|
{
|
||||||
|
@ -1341,9 +1341,7 @@ public class UserService : UserManager<User>, IUserService, IDisposable
|
|||||||
var organizationsWithVerifiedUserEmailDomain = await _organizationRepository.GetByVerifiedUserEmailDomainAsync(userId);
|
var organizationsWithVerifiedUserEmailDomain = await _organizationRepository.GetByVerifiedUserEmailDomainAsync(userId);
|
||||||
|
|
||||||
// Organizations must be enabled and able to have verified domains.
|
// Organizations must be enabled and able to have verified domains.
|
||||||
// TODO: Replace "UseSso" with a new organization ability like "UseOrganizationDomains" (PM-11622).
|
return organizationsWithVerifiedUserEmailDomain.Where(organization => organization is { Enabled: true, UseOrganizationDomains: true });
|
||||||
// Verified domains were tied to SSO, so we currently check the "UseSso" organization ability.
|
|
||||||
return organizationsWithVerifiedUserEmailDomain.Where(organization => organization is { Enabled: true, UseSso: true });
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <inheritdoc cref="IsLegacyUser(string)"/>
|
/// <inheritdoc cref="IsLegacyUser(string)"/>
|
||||||
|
@ -6,5 +6,12 @@ public class RegisterFinishResponseModel : ResponseModel
|
|||||||
{
|
{
|
||||||
public RegisterFinishResponseModel()
|
public RegisterFinishResponseModel()
|
||||||
: base("registerFinish")
|
: base("registerFinish")
|
||||||
{ }
|
{
|
||||||
|
// We are setting this to an empty string so that old mobile clients don't break, as they reqiure a non-null value.
|
||||||
|
// This will be cleaned up in https://bitwarden.atlassian.net/browse/PM-21720.
|
||||||
|
CaptchaBypassToken = string.Empty;
|
||||||
|
}
|
||||||
|
|
||||||
|
public string CaptchaBypassToken { get; set; }
|
||||||
|
|
||||||
}
|
}
|
||||||
|
@ -25,13 +25,13 @@ public class GetOrganizationUsersClaimedStatusQueryTests
|
|||||||
}
|
}
|
||||||
|
|
||||||
[Theory, BitAutoData]
|
[Theory, BitAutoData]
|
||||||
public async Task GetUsersOrganizationManagementStatusAsync_WithUseSsoEnabled_Success(
|
public async Task GetUsersOrganizationManagementStatusAsync_WithUseOrganizationDomainsEnabled_Success(
|
||||||
Organization organization,
|
Organization organization,
|
||||||
ICollection<OrganizationUser> usersWithClaimedDomain,
|
ICollection<OrganizationUser> usersWithClaimedDomain,
|
||||||
SutProvider<GetOrganizationUsersClaimedStatusQuery> sutProvider)
|
SutProvider<GetOrganizationUsersClaimedStatusQuery> sutProvider)
|
||||||
{
|
{
|
||||||
organization.Enabled = true;
|
organization.Enabled = true;
|
||||||
organization.UseSso = true;
|
organization.UseOrganizationDomains = true;
|
||||||
|
|
||||||
var userIdWithoutClaimedDomain = Guid.NewGuid();
|
var userIdWithoutClaimedDomain = Guid.NewGuid();
|
||||||
var userIdsToCheck = usersWithClaimedDomain.Select(u => u.Id).Concat(new List<Guid> { userIdWithoutClaimedDomain }).ToList();
|
var userIdsToCheck = usersWithClaimedDomain.Select(u => u.Id).Concat(new List<Guid> { userIdWithoutClaimedDomain }).ToList();
|
||||||
@ -51,13 +51,13 @@ public class GetOrganizationUsersClaimedStatusQueryTests
|
|||||||
}
|
}
|
||||||
|
|
||||||
[Theory, BitAutoData]
|
[Theory, BitAutoData]
|
||||||
public async Task GetUsersOrganizationManagementStatusAsync_WithUseSsoDisabled_ReturnsAllFalse(
|
public async Task GetUsersOrganizationManagementStatusAsync_WithUseOrganizationDomainsDisabled_ReturnsAllFalse(
|
||||||
Organization organization,
|
Organization organization,
|
||||||
ICollection<OrganizationUser> usersWithClaimedDomain,
|
ICollection<OrganizationUser> usersWithClaimedDomain,
|
||||||
SutProvider<GetOrganizationUsersClaimedStatusQuery> sutProvider)
|
SutProvider<GetOrganizationUsersClaimedStatusQuery> sutProvider)
|
||||||
{
|
{
|
||||||
organization.Enabled = true;
|
organization.Enabled = true;
|
||||||
organization.UseSso = false;
|
organization.UseOrganizationDomains = false;
|
||||||
|
|
||||||
var userIdWithoutClaimedDomain = Guid.NewGuid();
|
var userIdWithoutClaimedDomain = Guid.NewGuid();
|
||||||
var userIdsToCheck = usersWithClaimedDomain.Select(u => u.Id).Concat(new List<Guid> { userIdWithoutClaimedDomain }).ToList();
|
var userIdsToCheck = usersWithClaimedDomain.Select(u => u.Id).Concat(new List<Guid> { userIdWithoutClaimedDomain }).ToList();
|
||||||
|
File diff suppressed because it is too large
Load Diff
@ -3,14 +3,11 @@ using Bit.Core.AdminConsole.Entities.Provider;
|
|||||||
using Bit.Core.Billing.Caches;
|
using Bit.Core.Billing.Caches;
|
||||||
using Bit.Core.Billing.Constants;
|
using Bit.Core.Billing.Constants;
|
||||||
using Bit.Core.Billing.Models;
|
using Bit.Core.Billing.Models;
|
||||||
using Bit.Core.Billing.Services.Contracts;
|
|
||||||
using Bit.Core.Billing.Services.Implementations;
|
using Bit.Core.Billing.Services.Implementations;
|
||||||
using Bit.Core.Billing.Tax.Models;
|
using Bit.Core.Billing.Tax.Models;
|
||||||
using Bit.Core.Billing.Tax.Services;
|
|
||||||
using Bit.Core.Enums;
|
using Bit.Core.Enums;
|
||||||
using Bit.Core.Services;
|
using Bit.Core.Services;
|
||||||
using Bit.Core.Settings;
|
using Bit.Core.Settings;
|
||||||
using Bit.Core.Test.Billing.Tax.Services;
|
|
||||||
using Bit.Test.Common.AutoFixture;
|
using Bit.Test.Common.AutoFixture;
|
||||||
using Bit.Test.Common.AutoFixture.Attributes;
|
using Bit.Test.Common.AutoFixture.Attributes;
|
||||||
using Braintree;
|
using Braintree;
|
||||||
@ -195,7 +192,7 @@ public class SubscriberServiceTests
|
|||||||
|
|
||||||
await stripeAdapter
|
await stripeAdapter
|
||||||
.DidNotReceiveWithAnyArgs()
|
.DidNotReceiveWithAnyArgs()
|
||||||
.SubscriptionCancelAsync(Arg.Any<string>(), Arg.Any<SubscriptionCancelOptions>()); ;
|
.SubscriptionCancelAsync(Arg.Any<string>(), Arg.Any<SubscriptionCancelOptions>());
|
||||||
}
|
}
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
@ -1029,7 +1026,7 @@ public class SubscriberServiceTests
|
|||||||
|
|
||||||
stripeAdapter
|
stripeAdapter
|
||||||
.PaymentMethodListAutoPagingAsync(Arg.Any<PaymentMethodListOptions>())
|
.PaymentMethodListAutoPagingAsync(Arg.Any<PaymentMethodListOptions>())
|
||||||
.Returns(GetPaymentMethodsAsync(new List<Stripe.PaymentMethod>()));
|
.Returns(GetPaymentMethodsAsync(new List<PaymentMethod>()));
|
||||||
|
|
||||||
await sutProvider.Sut.RemovePaymentSource(organization);
|
await sutProvider.Sut.RemovePaymentSource(organization);
|
||||||
|
|
||||||
@ -1061,7 +1058,7 @@ public class SubscriberServiceTests
|
|||||||
|
|
||||||
stripeAdapter
|
stripeAdapter
|
||||||
.PaymentMethodListAutoPagingAsync(Arg.Any<PaymentMethodListOptions>())
|
.PaymentMethodListAutoPagingAsync(Arg.Any<PaymentMethodListOptions>())
|
||||||
.Returns(GetPaymentMethodsAsync(new List<Stripe.PaymentMethod>
|
.Returns(GetPaymentMethodsAsync(new List<PaymentMethod>
|
||||||
{
|
{
|
||||||
new ()
|
new ()
|
||||||
{
|
{
|
||||||
@ -1086,8 +1083,8 @@ public class SubscriberServiceTests
|
|||||||
.PaymentMethodDetachAsync(cardId);
|
.PaymentMethodDetachAsync(cardId);
|
||||||
}
|
}
|
||||||
|
|
||||||
private static async IAsyncEnumerable<Stripe.PaymentMethod> GetPaymentMethodsAsync(
|
private static async IAsyncEnumerable<PaymentMethod> GetPaymentMethodsAsync(
|
||||||
IEnumerable<Stripe.PaymentMethod> paymentMethods)
|
IEnumerable<PaymentMethod> paymentMethods)
|
||||||
{
|
{
|
||||||
foreach (var paymentMethod in paymentMethods)
|
foreach (var paymentMethod in paymentMethods)
|
||||||
{
|
{
|
||||||
@ -1598,14 +1595,22 @@ public class SubscriberServiceTests
|
|||||||
City = "Example Town",
|
City = "Example Town",
|
||||||
State = "NY"
|
State = "NY"
|
||||||
},
|
},
|
||||||
TaxIds = new StripeList<TaxId> { Data = [new TaxId { Id = "tax_id_1", Type = "us_ein" }] }
|
TaxIds = new StripeList<TaxId> { Data = [new TaxId { Id = "tax_id_1", Type = "us_ein" }] },
|
||||||
|
Subscriptions = new StripeList<Subscription>
|
||||||
|
{
|
||||||
|
Data = [
|
||||||
|
new Subscription
|
||||||
|
{
|
||||||
|
Id = provider.GatewaySubscriptionId,
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTax { Enabled = false }
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
var subscription = new Subscription { Items = new StripeList<SubscriptionItem>() };
|
var subscription = new Subscription { Items = new StripeList<SubscriptionItem>() };
|
||||||
sutProvider.GetDependency<IStripeAdapter>().SubscriptionGetAsync(Arg.Any<string>())
|
sutProvider.GetDependency<IStripeAdapter>().SubscriptionGetAsync(Arg.Any<string>())
|
||||||
.Returns(subscription);
|
.Returns(subscription);
|
||||||
sutProvider.GetDependency<IAutomaticTaxFactory>().CreateAsync(Arg.Any<AutomaticTaxFactoryParameters>())
|
|
||||||
.Returns(new FakeAutomaticTaxStrategy(true));
|
|
||||||
|
|
||||||
await sutProvider.Sut.UpdateTaxInformation(provider, taxInformation);
|
await sutProvider.Sut.UpdateTaxInformation(provider, taxInformation);
|
||||||
|
|
||||||
@ -1623,6 +1628,98 @@ public class SubscriberServiceTests
|
|||||||
await stripeAdapter.Received(1).TaxIdCreateAsync(provider.GatewayCustomerId, Arg.Is<TaxIdCreateOptions>(
|
await stripeAdapter.Received(1).TaxIdCreateAsync(provider.GatewayCustomerId, Arg.Is<TaxIdCreateOptions>(
|
||||||
options => options.Type == "us_ein" &&
|
options => options.Type == "us_ein" &&
|
||||||
options.Value == taxInformation.TaxId));
|
options.Value == taxInformation.TaxId));
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).SubscriptionUpdateAsync(provider.GatewaySubscriptionId,
|
||||||
|
Arg.Is<SubscriptionUpdateOptions>(options => options.AutomaticTax.Enabled == true));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Theory, BitAutoData]
|
||||||
|
public async Task UpdateTaxInformation_NonUser_ReverseCharge_MakesCorrectInvocations(
|
||||||
|
Provider provider,
|
||||||
|
SutProvider<SubscriberService> sutProvider)
|
||||||
|
{
|
||||||
|
var stripeAdapter = sutProvider.GetDependency<IStripeAdapter>();
|
||||||
|
|
||||||
|
var customer = new Customer { Id = provider.GatewayCustomerId, TaxIds = new StripeList<TaxId> { Data = [new TaxId { Id = "tax_id_1", Type = "us_ein" }] } };
|
||||||
|
|
||||||
|
stripeAdapter.CustomerGetAsync(provider.GatewayCustomerId, Arg.Is<CustomerGetOptions>(
|
||||||
|
options => options.Expand.Contains("tax_ids"))).Returns(customer);
|
||||||
|
|
||||||
|
var taxInformation = new TaxInformation(
|
||||||
|
"CA",
|
||||||
|
"12345",
|
||||||
|
"123456789",
|
||||||
|
"us_ein",
|
||||||
|
"123 Example St.",
|
||||||
|
null,
|
||||||
|
"Example Town",
|
||||||
|
"NY");
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IStripeAdapter>()
|
||||||
|
.CustomerUpdateAsync(
|
||||||
|
Arg.Is<string>(p => p == provider.GatewayCustomerId),
|
||||||
|
Arg.Is<CustomerUpdateOptions>(options =>
|
||||||
|
options.Address.Country == "CA" &&
|
||||||
|
options.Address.PostalCode == "12345" &&
|
||||||
|
options.Address.Line1 == "123 Example St." &&
|
||||||
|
options.Address.Line2 == null &&
|
||||||
|
options.Address.City == "Example Town" &&
|
||||||
|
options.Address.State == "NY"))
|
||||||
|
.Returns(new Customer
|
||||||
|
{
|
||||||
|
Id = provider.GatewayCustomerId,
|
||||||
|
Address = new Address
|
||||||
|
{
|
||||||
|
Country = "CA",
|
||||||
|
PostalCode = "12345",
|
||||||
|
Line1 = "123 Example St.",
|
||||||
|
Line2 = null,
|
||||||
|
City = "Example Town",
|
||||||
|
State = "NY"
|
||||||
|
},
|
||||||
|
TaxIds = new StripeList<TaxId> { Data = [new TaxId { Id = "tax_id_1", Type = "us_ein" }] },
|
||||||
|
Subscriptions = new StripeList<Subscription>
|
||||||
|
{
|
||||||
|
Data = [
|
||||||
|
new Subscription
|
||||||
|
{
|
||||||
|
Id = provider.GatewaySubscriptionId,
|
||||||
|
CustomerId = provider.GatewayCustomerId,
|
||||||
|
AutomaticTax = new SubscriptionAutomaticTax { Enabled = false }
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
var subscription = new Subscription { Items = new StripeList<SubscriptionItem>() };
|
||||||
|
sutProvider.GetDependency<IStripeAdapter>().SubscriptionGetAsync(Arg.Any<string>())
|
||||||
|
.Returns(subscription);
|
||||||
|
|
||||||
|
sutProvider.GetDependency<IFeatureService>()
|
||||||
|
.IsEnabled(FeatureFlagKeys.PM21092_SetNonUSBusinessUseToReverseCharge).Returns(true);
|
||||||
|
|
||||||
|
await sutProvider.Sut.UpdateTaxInformation(provider, taxInformation);
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).CustomerUpdateAsync(provider.GatewayCustomerId, Arg.Is<CustomerUpdateOptions>(
|
||||||
|
options =>
|
||||||
|
options.Address.Country == taxInformation.Country &&
|
||||||
|
options.Address.PostalCode == taxInformation.PostalCode &&
|
||||||
|
options.Address.Line1 == taxInformation.Line1 &&
|
||||||
|
options.Address.Line2 == taxInformation.Line2 &&
|
||||||
|
options.Address.City == taxInformation.City &&
|
||||||
|
options.Address.State == taxInformation.State));
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).TaxIdDeleteAsync(provider.GatewayCustomerId, "tax_id_1");
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).TaxIdCreateAsync(provider.GatewayCustomerId, Arg.Is<TaxIdCreateOptions>(
|
||||||
|
options => options.Type == "us_ein" &&
|
||||||
|
options.Value == taxInformation.TaxId));
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).CustomerUpdateAsync(provider.GatewayCustomerId,
|
||||||
|
Arg.Is<CustomerUpdateOptions>(options => options.TaxExempt == StripeConstants.TaxExempt.Reverse));
|
||||||
|
|
||||||
|
await stripeAdapter.Received(1).SubscriptionUpdateAsync(provider.GatewaySubscriptionId,
|
||||||
|
Arg.Is<SubscriptionUpdateOptions>(options => options.AutomaticTax.Enabled == true));
|
||||||
}
|
}
|
||||||
|
|
||||||
#endregion
|
#endregion
|
||||||
|
@ -28,7 +28,10 @@ public static class OrganizationLicenseFileFixtures
|
|||||||
private const string Version15 =
|
private const string Version15 =
|
||||||
"{\n 'LicenseKey': 'myLicenseKey',\n 'InstallationId': '78900000-0000-0000-0000-000000000123',\n 'Id': '12300000-0000-0000-0000-000000000456',\n 'Name': 'myOrg',\n 'BillingEmail': 'myBillingEmail',\n 'BusinessName': 'myBusinessName',\n 'Enabled': true,\n 'Plan': 'myPlan',\n 'PlanType': 11,\n 'Seats': 10,\n 'MaxCollections': 2,\n 'UsePolicies': true,\n 'UseSso': true,\n 'UseKeyConnector': true,\n 'UseScim': true,\n 'UseGroups': true,\n 'UseEvents': true,\n 'UseDirectory': true,\n 'UseTotp': true,\n 'Use2fa': true,\n 'UseApi': true,\n 'UseResetPassword': true,\n 'MaxStorageGb': 100,\n 'SelfHost': true,\n 'UsersGetPremium': true,\n 'UseCustomPermissions': true,\n 'Version': 14,\n 'Issued': '2023-12-14T02:03:33.374297Z',\n 'Refresh': '2023-12-07T22:42:33.970597Z',\n 'Expires': '2023-12-21T02:03:33.374297Z',\n 'ExpirationWithoutGracePeriod': null,\n 'UsePasswordManager': true,\n 'UseSecretsManager': true,\n 'SmSeats': 5,\n 'SmServiceAccounts': 8,\n 'LimitCollectionCreationDeletion': true,\n 'AllowAdminAccessToAllCollectionItems': true,\n 'Trial': true,\n 'LicenseType': 1,\n 'Hash': 'EZl4IvJaa1E5mPmlfp4p5twAtlmaxlF1yoZzVYP4vog=',\n 'Signature': ''\n}";
|
"{\n 'LicenseKey': 'myLicenseKey',\n 'InstallationId': '78900000-0000-0000-0000-000000000123',\n 'Id': '12300000-0000-0000-0000-000000000456',\n 'Name': 'myOrg',\n 'BillingEmail': 'myBillingEmail',\n 'BusinessName': 'myBusinessName',\n 'Enabled': true,\n 'Plan': 'myPlan',\n 'PlanType': 11,\n 'Seats': 10,\n 'MaxCollections': 2,\n 'UsePolicies': true,\n 'UseSso': true,\n 'UseKeyConnector': true,\n 'UseScim': true,\n 'UseGroups': true,\n 'UseEvents': true,\n 'UseDirectory': true,\n 'UseTotp': true,\n 'Use2fa': true,\n 'UseApi': true,\n 'UseResetPassword': true,\n 'MaxStorageGb': 100,\n 'SelfHost': true,\n 'UsersGetPremium': true,\n 'UseCustomPermissions': true,\n 'Version': 14,\n 'Issued': '2023-12-14T02:03:33.374297Z',\n 'Refresh': '2023-12-07T22:42:33.970597Z',\n 'Expires': '2023-12-21T02:03:33.374297Z',\n 'ExpirationWithoutGracePeriod': null,\n 'UsePasswordManager': true,\n 'UseSecretsManager': true,\n 'SmSeats': 5,\n 'SmServiceAccounts': 8,\n 'LimitCollectionCreationDeletion': true,\n 'AllowAdminAccessToAllCollectionItems': true,\n 'Trial': true,\n 'LicenseType': 1,\n 'Hash': 'EZl4IvJaa1E5mPmlfp4p5twAtlmaxlF1yoZzVYP4vog=',\n 'Signature': ''\n}";
|
||||||
|
|
||||||
private static readonly Dictionary<int, string> LicenseVersions = new() { { 12, Version12 }, { 13, Version13 }, { 14, Version14 }, { 15, Version15 } };
|
private const string Version16 =
|
||||||
|
"{\n'LicenseKey': 'myLicenseKey',\n'InstallationId': '78900000-0000-0000-0000-000000000123',\n'Id': '12300000-0000-0000-0000-000000000456',\n'Name': 'myOrg',\n'BillingEmail': 'myBillingEmail',\n'BusinessName': 'myBusinessName',\n'Enabled': true,\n'Plan': 'myPlan',\n'PlanType': 11,\n'Seats': 10,\n'MaxCollections': 2,\n'UsePolicies': true,\n'UseSso': true,\n'UseKeyConnector': true,\n'UseScim': true,\n'UseGroups': true,\n'UseEvents': true,\n'UseDirectory': true,\n'UseTotp': true,\n'Use2fa': true,\n'UseApi': true,\n'UseResetPassword': true,\n'MaxStorageGb': 100,\n'SelfHost': true,\n'UsersGetPremium': true,\n'UseCustomPermissions': true,\n'Version': 15,\n'Issued': '2025-05-16T20:50:09.036931Z',\n'Refresh': '2025-05-23T20:50:09.036931Z',\n'Expires': '2025-05-23T20:50:09.036931Z',\n'ExpirationWithoutGracePeriod': null,\n'UsePasswordManager': true,\n'UseSecretsManager': true,\n'SmSeats': 5,\n'SmServiceAccounts': 8,\n'UseRiskInsights': false,\n'LimitCollectionCreationDeletion': true,\n'AllowAdminAccessToAllCollectionItems': true,\n'Trial': true,\n'LicenseType': 1,\n'UseOrganizationDomains': true,\n'UseAdminSponsoredFamilies': false,\n'Hash': 'k3M9SpHKUo0TmuSnNipeZleCHxgcEycKRXYl9BAg30Q=',\n'Signature': '',\n'Token': null\n}";
|
||||||
|
|
||||||
|
private static readonly Dictionary<int, string> LicenseVersions = new() { { 12, Version12 }, { 13, Version13 }, { 14, Version14 }, { 15, Version15 }, { 16, Version16 } };
|
||||||
|
|
||||||
public static OrganizationLicense GetVersion(int licenseVersion)
|
public static OrganizationLicense GetVersion(int licenseVersion)
|
||||||
{
|
{
|
||||||
|
@ -347,7 +347,7 @@ public class UserServiceTests
|
|||||||
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
||||||
{
|
{
|
||||||
organization.Enabled = true;
|
organization.Enabled = true;
|
||||||
organization.UseSso = true;
|
organization.UseOrganizationDomains = true;
|
||||||
|
|
||||||
sutProvider.GetDependency<IOrganizationRepository>()
|
sutProvider.GetDependency<IOrganizationRepository>()
|
||||||
.GetByVerifiedUserEmailDomainAsync(userId)
|
.GetByVerifiedUserEmailDomainAsync(userId)
|
||||||
@ -362,7 +362,7 @@ public class UserServiceTests
|
|||||||
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
||||||
{
|
{
|
||||||
organization.Enabled = false;
|
organization.Enabled = false;
|
||||||
organization.UseSso = true;
|
organization.UseOrganizationDomains = true;
|
||||||
|
|
||||||
sutProvider.GetDependency<IOrganizationRepository>()
|
sutProvider.GetDependency<IOrganizationRepository>()
|
||||||
.GetByVerifiedUserEmailDomainAsync(userId)
|
.GetByVerifiedUserEmailDomainAsync(userId)
|
||||||
@ -373,11 +373,11 @@ public class UserServiceTests
|
|||||||
}
|
}
|
||||||
|
|
||||||
[Theory, BitAutoData]
|
[Theory, BitAutoData]
|
||||||
public async Task IsClaimedByAnyOrganizationAsync_WithOrganizationUseSsoFalse_ReturnsFalse(
|
public async Task IsClaimedByAnyOrganizationAsync_WithOrganizationUseOrganizationDomaisFalse_ReturnsFalse(
|
||||||
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
SutProvider<UserService> sutProvider, Guid userId, Organization organization)
|
||||||
{
|
{
|
||||||
organization.Enabled = true;
|
organization.Enabled = true;
|
||||||
organization.UseSso = false;
|
organization.UseOrganizationDomains = false;
|
||||||
|
|
||||||
sutProvider.GetDependency<IOrganizationRepository>()
|
sutProvider.GetDependency<IOrganizationRepository>()
|
||||||
.GetByVerifiedUserEmailDomainAsync(userId)
|
.GetByVerifiedUserEmailDomainAsync(userId)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user