nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-01 16:12:49 -05:00
Code Activity

[Bug] Fix cipher clone yielding incorrect RevisionDate (#1031)

Browse Source 
* Fix cipher clone yielding incorrect RevisionDate

* PR fixes

Co-authored-by: Matt Gibson <mdgibson@Matts-MBP.lan>
This commit is contained in:
Matt Gibson
2020-12-07 19:35:34 -06:00
committed by GitHub
parent 8d9b1ff214
commit 7eaf7ab770
5 changed files with 50 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Core/Models/Table/Cipher.cs
View File

@ -6,7 +6,7 @@ using System.Collections.Generic;
namespace Bit.Core.Models.Table
{
public class Cipher : ITableObject<Guid>
public class Cipher : ITableObject<Guid>, ICloneable
{
private Dictionary<string, CipherAttachment.MetaData> _attachmentData;
@ -92,5 +92,15 @@ namespace Bit.Core.Models.Table
var attachments = GetAttachments();
return attachments?.ContainsKey(id) ?? false;
}
object ICloneable.Clone() => Clone();
public Cipher Clone()
{
var clone = CoreHelpers.CloneObject(this);
clone.CreationDate = CreationDate;
clone.RevisionDate = RevisionDate;
return clone;
}
}
}

5
src/Core/Utilities/CoreHelpers.cs
View File

@ -359,6 +359,11 @@ namespace Bit.Core.Utilities
return readable.ToString("0.## ") + suffix;
}
/// <summary>
/// Creates a clone of the given object through serializing to json and deserializing.
/// This method is subject to the limitations of Newstonsoft. For example, properties with
/// inaccessible setters will not be set.
/// </summary>
public static T CloneObject<T>(T obj)
{
return JsonConvert.DeserializeObject<T>(JsonConvert.SerializeObject(obj));