WIP

bitwarden_license/test/Commercial.Core.Test/AdminConsole/ProviderFeatures/RemoveOrganizationFromProviderCommandTests.cs

@@ -228,6 +228,26 @@ public class RemoveOrganizationFromProviderCommandTests
             Id = "subscription_id"
         });
 
+        sutProvider.GetDependency<IOrganizationAutomaticTaxStrategy>()
+            .When(x => x.SetCreateOptionsAsync(
+                Arg.Is<SubscriptionCreateOptions>(options =>
+                    options.Customer == organization.GatewayCustomerId &&
+                    options.CollectionMethod == StripeConstants.CollectionMethod.SendInvoice &&
+                    options.DaysUntilDue == 30 &&
+                    options.Metadata["organizationId"] == organization.Id.ToString() &&
+                    options.OffSession == true &&
+                    options.ProrationBehavior == StripeConstants.ProrationBehavior.CreateProrations &&
+                    options.Items.First().Price == teamsMonthlyPlan.PasswordManager.StripeSeatPlanId &&
+                    options.Items.First().Quantity == organization.Seats)
+                , Arg.Any<Customer>()))
+            .Do(x =>
+            {
+                x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
+                {
+                    Enabled = true
+                };
+            });
+
         await sutProvider.Sut.RemoveOrganizationFromProvider(provider, providerOrganization, organization);
 
         await stripeAdapter.Received(1).SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(options =>

bitwarden_license/test/Commercial.Core.Test/Billing/ProviderBillingServiceTests.cs

@@ -975,11 +975,12 @@ public class ProviderBillingServiceTests
     {
         provider.GatewaySubscriptionId = null;
 
-        sutProvider.GetDependency<ISubscriberService>().GetCustomerOrThrow(provider).Returns(new Customer
+        var customer = new Customer
         {
             Id = "customer_id",
             Tax = new CustomerTax { AutomaticTax = StripeConstants.AutomaticTaxStatus.Supported }
-        });
+        };
+        sutProvider.GetDependency<ISubscriberService>().GetCustomerOrThrow(provider).Returns(customer);
 
         var providerPlans = new List<ProviderPlan>
         {
@@ -1017,6 +1018,19 @@ public class ProviderBillingServiceTests
 
         var expected = new Subscription { Id = "subscription_id", Status = StripeConstants.SubscriptionStatus.Active };
 
+        sutProvider.GetDependency<IOrganizationAutomaticTaxStrategy>()
+            .When(x => x.SetCreateOptionsAsync(
+                Arg.Is<SubscriptionCreateOptions>(options =>
+                    options.Customer == "customer_id")
+                , Arg.Is<Customer>(p => p == customer)))
+            .Do(x =>
+            {
+                x.Arg<SubscriptionCreateOptions>().AutomaticTax = new SubscriptionAutomaticTaxOptions
+                {
+                    Enabled = true
+                };
+            });
+
         sutProvider.GetDependency<IStripeAdapter>().SubscriptionCreateAsync(Arg.Is<SubscriptionCreateOptions>(
             sub =>
                 sub.AutomaticTax.Enabled == true &&

src/Core/Billing/Migration/Services/Implementations/OrganizationMigrator.cs

@@ -5,6 +5,7 @@ using Bit.Core.Billing.Enums;
 using Bit.Core.Billing.Migration.Models;
 using Bit.Core.Billing.Pricing;
 using Bit.Core.Billing.Repositories;
+using Bit.Core.Billing.Services;
 using Bit.Core.Enums;
 using Bit.Core.Repositories;
 using Bit.Core.Services;
@@ -20,7 +21,8 @@ public class OrganizationMigrator(
     IMigrationTrackerCache migrationTrackerCache,
     IOrganizationRepository organizationRepository,
     IPricingClient pricingClient,
-    IStripeAdapter stripeAdapter) : IOrganizationMigrator
+    IStripeAdapter stripeAdapter,
+    IOrganizationAutomaticTaxStrategy automaticTaxStrategy) : IOrganizationMigrator
 {
     private const string _cancellationComment = "Cancelled as part of provider migration to Consolidated Billing";
 
@@ -231,10 +233,6 @@ public class OrganizationMigrator(
 
             var subscriptionCreateOptions = new SubscriptionCreateOptions
             {
-                AutomaticTax = new SubscriptionAutomaticTaxOptions
-                {
-                    Enabled = true
-                },
                 Customer = customer.Id,
                 CollectionMethod = collectionMethod,
                 DaysUntilDue = collectionMethod == StripeConstants.CollectionMethod.SendInvoice ? 30 : null,
@@ -248,6 +246,8 @@ public class OrganizationMigrator(
                 TrialPeriodDays = plan.TrialPeriodDays
             };
 
+            await automaticTaxStrategy.SetCreateOptionsAsync(subscriptionCreateOptions, customer);
+
             var subscription = await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
 
             organization.GatewaySubscriptionId = subscription.Id;

src/Core/Billing/Services/Implementations/AutomaticTax/OrganizationAutomaticTaxStrategy.cs

@@ -74,42 +74,33 @@ public class OrganizationAutomaticTaxStrategy(
 
     private async Task<bool?> IsEnabledAsync(Subscription subscription)
     {
-        if (subscription.AutomaticTax.Enabled ||
+        bool shouldBeEnabled;
-            !subscription.Customer.HasBillingLocation() ||
+        if (subscription.Customer.HasBillingLocation() && subscription.Customer.Address.Country == "US")
-            await IsNonTaxableNonUsBusinessUseSubscriptionAsync(subscription))
         {
-            return null;
+            shouldBeEnabled = true;
+        }
+        else
+        {
+            var familyPriceIds = await _familyPriceIdsTask.Value;
+            shouldBeEnabled = subscription.Items.Select(item => item.Price.Id).Intersect(familyPriceIds).Any();
         }
 
-        return !await IsNonTaxableNonUsBusinessUseSubscriptionAsync(subscription);
+        if (subscription.AutomaticTax.Enabled != shouldBeEnabled)
-    }
+        {
+            return shouldBeEnabled;
+        }
 
-    private async Task<bool> IsNonTaxableNonUsBusinessUseSubscriptionAsync(Subscription subscription)
+        return null;
-    {
-        var familyPriceIds = await _familyPriceIdsTask.Value;
-
-        return subscription.Customer.Address.Country != "US" &&
-               !subscription.Items.Select(item => item.Price.Id).Intersect(familyPriceIds).Any() &&
-               !subscription.Customer.TaxIds.Any();
     }
 
     private async Task<bool?> IsEnabledAsync(SubscriptionCreateOptions options, Customer customer)
     {
-        if (!customer.HasBillingLocation() ||
+        if (customer.HasBillingLocation() && customer.Address.Country == "US")
-            await IsNonTaxableNonUsBusinessUseSubscriptionAsync(options, customer))
         {
-            return null;
+            return true;
         }
 
-        return !await IsNonTaxableNonUsBusinessUseSubscriptionAsync(options, customer);
-    }
-
-    private async Task<bool> IsNonTaxableNonUsBusinessUseSubscriptionAsync(SubscriptionCreateOptions options, Customer customer)
-    {
         var familyPriceIds = await _familyPriceIdsTask.Value;
-
+        return options.Items.Select(item => item.Price).Intersect(familyPriceIds).Any();
-        return customer.Address.Country != "US" &&
-               !options.Items.Select(item => item.Price).Intersect(familyPriceIds).Any() &&
-               !customer.TaxIds.Any();
     }
 }

src/Core/Billing/Services/Implementations/OrganizationBillingService.cs

@@ -30,7 +30,8 @@ public class OrganizationBillingService(
     ISetupIntentCache setupIntentCache,
     IStripeAdapter stripeAdapter,
     ISubscriberService subscriberService,
-    ITaxService taxService) : IOrganizationBillingService
+    ITaxService taxService,
+    IOrganizationAutomaticTaxStrategy organizationAutomaticTaxStrategy) : IOrganizationBillingService
 {
     public async Task Finalize(OrganizationSale sale)
     {
@@ -380,10 +381,6 @@ public class OrganizationBillingService(
 
         var subscriptionCreateOptions = new SubscriptionCreateOptions
         {
-            AutomaticTax = new SubscriptionAutomaticTaxOptions
-            {
-                Enabled = customerHasTaxInfo
-            },
             CollectionMethod = StripeConstants.CollectionMethod.ChargeAutomatically,
             Customer = customer.Id,
             Items = subscriptionItemOptionsList,
@@ -395,6 +392,8 @@ public class OrganizationBillingService(
             TrialPeriodDays = subscriptionSetup.SkipTrial ? 0 : plan.TrialPeriodDays
         };
 
+        await organizationAutomaticTaxStrategy.SetCreateOptionsAsync(subscriptionCreateOptions, customer);
+
         return await stripeAdapter.SubscriptionCreateAsync(subscriptionCreateOptions);
     }
 

src/Core/Billing/Services/Implementations/SubscriberService.cs

@@ -24,7 +24,9 @@ public class SubscriberService(
     ILogger<SubscriberService> logger,
     ISetupIntentCache setupIntentCache,
     IStripeAdapter stripeAdapter,
-    ITaxService taxService) : ISubscriberService
+    ITaxService taxService,
+    IIndividualAutomaticTaxStrategy individualAutomaticTaxStrategy,
+    IOrganizationAutomaticTaxStrategy organizationAutomaticTaxStrategy) : ISubscriberService
 {
     public async Task CancelSubscription(
         ISubscriber subscriber,
@@ -597,7 +599,7 @@ public class SubscriberService(
             Expand = ["subscriptions", "tax", "tax_ids"]
         });
 
-        await stripeAdapter.CustomerUpdateAsync(customer.Id, new CustomerUpdateOptions
+        customer = await stripeAdapter.CustomerUpdateAsync(customer.Id, new CustomerUpdateOptions
         {
             Address = new AddressOptions
             {
@@ -661,21 +663,17 @@ public class SubscriberService(
             }
         }
 
-        if (SubscriberIsEligibleForAutomaticTax(subscriber, customer))
+        if (!string.IsNullOrEmpty(subscriber.GatewaySubscriptionId))
         {
-            await stripeAdapter.SubscriptionUpdateAsync(subscriber.GatewaySubscriptionId,
+            var subscription = await stripeAdapter.SubscriptionGetAsync(subscriber.GatewaySubscriptionId);
-                new SubscriptionUpdateOptions
+            var automaticTaxOptions = subscriber.IsUser()
-                {
+                ? await individualAutomaticTaxStrategy.GetUpdateOptionsAsync(subscription)
-                    AutomaticTax = new SubscriptionAutomaticTaxOptions { Enabled = true }
+                : await organizationAutomaticTaxStrategy.GetUpdateOptionsAsync(subscription);
-                });
+            if (automaticTaxOptions?.AutomaticTax?.Enabled != null)
+            {
+                await stripeAdapter.SubscriptionUpdateAsync(subscriber.GatewaySubscriptionId, automaticTaxOptions);
+            }
         }
-
-        return;
-
-        bool SubscriberIsEligibleForAutomaticTax(ISubscriber localSubscriber, Customer localCustomer)
-            => !string.IsNullOrEmpty(localSubscriber.GatewaySubscriptionId) &&
-               (localCustomer.Subscriptions?.Any(sub => sub.Id == localSubscriber.GatewaySubscriptionId && !sub.AutomaticTax.Enabled) ?? false) &&
-               localCustomer.Tax?.AutomaticTax == StripeConstants.AutomaticTaxStatus.Supported;
     }
 
     public async Task VerifyBankAccount(

test/Core.Test/Billing/Services/SubscriberServiceTests.cs

@@ -1561,6 +1561,31 @@ public class SubscriberServiceTests
             "Example Town",
             "NY");
 
+        sutProvider.GetDependency<IStripeAdapter>()
+            .CustomerUpdateAsync(
+                Arg.Is<string>(p => p == provider.GatewayCustomerId),
+                Arg.Is<CustomerUpdateOptions>(options =>
+                    options.Address.Country == "US" &&
+                    options.Address.PostalCode == "12345" &&
+                    options.Address.Line1 == "123 Example St." &&
+                    options.Address.Line2 == null &&
+                    options.Address.City == "Example Town" &&
+                    options.Address.State == "NY"))
+            .Returns(new Customer
+            {
+                Id = provider.GatewayCustomerId,
+                Address = new Address
+                {
+                    Country = "US",
+                    PostalCode = "12345",
+                    Line1 = "123 Example St.",
+                    Line2 = null,
+                    City = "Example Town",
+                    State = "NY"
+                },
+                TaxIds = new StripeList<TaxId> { Data = [new TaxId { Id = "tax_id_1", Type = "us_ein" }] }
+            });
+
         await sutProvider.Sut.UpdateTaxInformation(provider, taxInformation);
 
         await stripeAdapter.Received(1).CustomerUpdateAsync(provider.GatewayCustomerId, Arg.Is<CustomerUpdateOptions>(