From 99b0953acdbc36d52daedc58f335085b084f33c0 Mon Sep 17 00:00:00 2001 From: Matt Bishop Date: Thu, 11 May 2023 10:27:58 -0400 Subject: [PATCH] Remove Secrets Manager LaunchDarkly feature flag (#2925) --- src/Core/Constants.cs | 1 - .../Core.Test/Services/LaunchDarklyFeatureServiceTests.cs | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/Core/Constants.cs b/src/Core/Constants.cs index 6e905ef7fe..8ae79084d6 100644 --- a/src/Core/Constants.cs +++ b/src/Core/Constants.cs @@ -27,7 +27,6 @@ public static class AuthenticationSchemes public static class FeatureFlagKeys { - public const string SecretsManager = "secrets-manager"; public const string DisplayEuEnvironment = "display-eu-environment"; public const string DisplayLowKdfIterationWarning = "display-kdf-iteration-warning"; public const string TrustedDeviceEncryption = "trusted-device-encryption"; diff --git a/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs b/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs index 84055cd929..3644dc805b 100644 --- a/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs +++ b/test/Core.Test/Services/LaunchDarklyFeatureServiceTests.cs @@ -47,7 +47,7 @@ public class LaunchDarklyFeatureServiceTests var currentContext = Substitute.For(); currentContext.UserId.Returns(Guid.NewGuid()); - Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext)); + Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext)); } [Fact(Skip = "For local development")] @@ -61,7 +61,7 @@ public class LaunchDarklyFeatureServiceTests var currentContext = Substitute.For(); currentContext.UserId.Returns(Guid.NewGuid()); - Assert.False(sutProvider.Sut.IsEnabled(FeatureFlagKeys.SecretsManager, currentContext)); + Assert.False(sutProvider.Sut.IsEnabled("somekey", currentContext)); } [Fact(Skip = "For local development")] @@ -75,7 +75,7 @@ public class LaunchDarklyFeatureServiceTests var currentContext = Substitute.For(); currentContext.UserId.Returns(Guid.NewGuid()); - Assert.Equal(0, sutProvider.Sut.GetIntVariation(FeatureFlagKeys.SecretsManager, currentContext)); + Assert.Equal(0, sutProvider.Sut.GetIntVariation("somekey", currentContext)); } [Fact(Skip = "For local development")] @@ -89,7 +89,7 @@ public class LaunchDarklyFeatureServiceTests var currentContext = Substitute.For(); currentContext.UserId.Returns(Guid.NewGuid()); - Assert.Null(sutProvider.Sut.GetStringVariation(FeatureFlagKeys.SecretsManager, currentContext)); + Assert.Null(sutProvider.Sut.GetStringVariation("somekey", currentContext)); } [Fact(Skip = "For local development")]