nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-05 21:18:13 -05:00
Code

Update SlackOAuth tests to new signatures

Browse Source
This commit is contained in:
Brant DeBow 2025-03-31 10:34:50 -04:00
parent 99f57362e4
commit 99bd6d3eba
No known key found for this signature in database
GPG Key ID: 94411BB25947C72B
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
test/Api.Test/AdminConsole/Controllers/SlackOAuthControllerTests.cs
View File

@ -1,8 +1,7 @@
using Bit.Api.AdminConsole.Controllers; using Bit.Api.AdminConsole.Controllers;
using Bit.Core.AdminConsole.Entities;
using Bit.Core.Context; using Bit.Core.Context;
using Bit.Core.Enums;
using Bit.Core.Exceptions; using Bit.Core.Exceptions;
using Bit.Core.Models.Data.Integrations;
using Bit.Core.Repositories; using Bit.Core.Repositories;
using Bit.Core.Services; using Bit.Core.Services;
using Bit.Test.Common.AutoFixture; using Bit.Test.Common.AutoFixture;
@ -29,10 +28,10 @@ public class SlackOAuthControllerTests
.ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>()) .ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>())
.Returns(token); .Returns(token);
var requestAction = await sutProvider.Sut.OAuthCallback(organizationId.ToString(), "A_test_code"); var requestAction = await sutProvider.Sut.OAuthCallback(organizationId, "A_test_code");
await sutProvider.GetDependency<IOrganizationIntegrationConfigurationRepository>().Received(1) await sutProvider.GetDependency<IOrganizationIntegrationRepository>().Received(1)
.CreateOrganizationIntegrationAsync(organizationId, IntegrationType.Slack, new SlackIntegration(token)); .CreateAsync(Arg.Any<OrganizationIntegration>());
Assert.IsType<OkObjectResult>(requestAction); Assert.IsType<OkObjectResult>(requestAction);
} }
@ -44,7 +43,7 @@ public class SlackOAuthControllerTests
.OrganizationOwner(organizationId) .OrganizationOwner(organizationId)
.Returns(true); .Returns(true);
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.OAuthCallback(organizationId.ToString(), string.Empty)); await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.OAuthCallback(organizationId, string.Empty));
} }
[Theory, BitAutoData] [Theory, BitAutoData]
@ -58,7 +57,7 @@ public class SlackOAuthControllerTests
.ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>()) .ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>())
.Returns(string.Empty); .Returns(string.Empty);
await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.OAuthCallback(organizationId.ToString(), "A_test_code")); await Assert.ThrowsAsync<BadRequestException>(async () => await sutProvider.Sut.OAuthCallback(organizationId, "A_test_code"));
} }
[Theory, BitAutoData] [Theory, BitAutoData]
@ -73,13 +72,13 @@ public class SlackOAuthControllerTests
.ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>()) .ObtainTokenViaOAuth(Arg.Any<string>(), Arg.Any<string>())
.Returns(token); .Returns(token);
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.OAuthCallback(organizationId.ToString(), "A_test_code")); await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.OAuthCallback(organizationId, "A_test_code"));
} }
[Theory, BitAutoData] [Theory, BitAutoData]
public async Task Redirect_ShouldRedirectToSlack(SutProvider<SlackOAuthController> sutProvider, Guid organizationId) public async Task Redirect_ShouldRedirectToSlack(SutProvider<SlackOAuthController> sutProvider, Guid organizationId)
{ {
var expectedUrl = $"https://localhost/{organizationId.ToString()}"; var expectedUrl = $"https://localhost/{organizationId}";
sutProvider.Sut.Url = Substitute.For<IUrlHelper>(); sutProvider.Sut.Url = Substitute.For<IUrlHelper>();
sutProvider.GetDependency<ISlackService>().GetRedirectUrl(Arg.Any<string>()).Returns(expectedUrl); sutProvider.GetDependency<ISlackService>().GetRedirectUrl(Arg.Any<string>()).Returns(expectedUrl);
@ -90,7 +89,7 @@ public class SlackOAuthControllerTests
.HttpContext.Request.Scheme .HttpContext.Request.Scheme
.Returns("https"); .Returns("https");
var requestAction = await sutProvider.Sut.RedirectToSlack(organizationId.ToString()); var requestAction = await sutProvider.Sut.RedirectToSlack(organizationId);
var redirectResult = Assert.IsType<RedirectResult>(requestAction); var redirectResult = Assert.IsType<RedirectResult>(requestAction);
Assert.Equal(expectedUrl, redirectResult.Url); Assert.Equal(expectedUrl, redirectResult.Url);
@ -108,7 +107,7 @@ public class SlackOAuthControllerTests
.HttpContext.Request.Scheme .HttpContext.Request.Scheme
.Returns("https"); .Returns("https");
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.RedirectToSlack(organizationId.ToString())); await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.RedirectToSlack(organizationId));
} }
[Theory, BitAutoData] [Theory, BitAutoData]
@ -124,6 +123,6 @@ public class SlackOAuthControllerTests
.HttpContext.Request.Scheme .HttpContext.Request.Scheme
.Returns("https"); .Returns("https");
await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.RedirectToSlack(organizationId.ToString())); await Assert.ThrowsAsync<NotFoundException>(async () => await sutProvider.Sut.RedirectToSlack(organizationId));
} }
} }