From 9de9be8f20355903695e80fe963f206b188c571a Mon Sep 17 00:00:00 2001 From: Matt Gibson Date: Tue, 28 Sep 2021 16:18:44 -0400 Subject: [PATCH] Only test canScale is an org needs to scale for an invite (#1608) --- .../Implementations/OrganizationService.cs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/Core/Services/Implementations/OrganizationService.cs b/src/Core/Services/Implementations/OrganizationService.cs index bbbd65239a..2fe7646b6e 100644 --- a/src/Core/Services/Implementations/OrganizationService.cs +++ b/src/Core/Services/Implementations/OrganizationService.cs @@ -1072,10 +1072,13 @@ namespace Bit.Core.Services newSeatsRequired = invites.Sum(i => i.invite.Emails.Count()) - existingEmails.Count() - availableSeats; } - var (canScale, failureReason) = await CanScaleAsync(organization, newSeatsRequired); - if (!canScale) + if (newSeatsRequired > 0) { - throw new BadRequestException(failureReason); + var (canScale, failureReason) = await CanScaleAsync(organization, newSeatsRequired); + if (!canScale) + { + throw new BadRequestException(failureReason); + } } var invitedAreAllOwners = invites.All(i => i.invite.Type == OrganizationUserType.Owner); @@ -1465,11 +1468,6 @@ namespace Bit.Core.Services failureReason = "Cannot manage organization users."; return (false, failureReason); } - // if (!await _currentContext.OrganizationOwner(organization.Id)) - // { - // failureReason = "Only organization owners can autoscale seats."; - // return (false, failureReason); - // } if (seatsToAdd < 1) {