1
0
mirror of https://github.com/bitwarden/server.git synced 2025-05-23 20:41:04 -05:00

address feedback

This commit is contained in:
✨ Audrey ✨ 2025-05-23 10:39:41 -04:00
parent ffd5629766
commit a2e50d03e5
No known key found for this signature in database
3 changed files with 18 additions and 9 deletions

View File

@ -6,9 +6,6 @@
@Data VARCHAR(MAX), @Data VARCHAR(MAX),
@Key VARCHAR(MAX), @Key VARCHAR(MAX),
@Password NVARCHAR(300), @Password NVARCHAR(300),
-- FIXME: remove null default value once this argument has been
-- in 2 server releases
@Emails NVARCHAR(1024) = NULL,
@MaxAccessCount INT, @MaxAccessCount INT,
@AccessCount INT, @AccessCount INT,
@CreationDate DATETIME2(7), @CreationDate DATETIME2(7),
@ -17,7 +14,10 @@
@DeletionDate DATETIME2(7), @DeletionDate DATETIME2(7),
@Disabled BIT, @Disabled BIT,
@HideEmail BIT, @HideEmail BIT,
@CipherId UNIQUEIDENTIFIER = NULL @CipherId UNIQUEIDENTIFIER = NULL,
-- FIXME: remove null default value once this argument has been
-- in 2 server releases
@Emails NVARCHAR(1024) = NULL,
AS AS
BEGIN BEGIN
SET NOCOUNT ON SET NOCOUNT ON

View File

@ -6,7 +6,6 @@
@Data VARCHAR(MAX), @Data VARCHAR(MAX),
@Key VARCHAR(MAX), @Key VARCHAR(MAX),
@Password NVARCHAR(300), @Password NVARCHAR(300),
@Emails NVARCHAR(1024) = NULL,
@MaxAccessCount INT, @MaxAccessCount INT,
@AccessCount INT, @AccessCount INT,
@CreationDate DATETIME2(7), @CreationDate DATETIME2(7),
@ -15,7 +14,8 @@
@DeletionDate DATETIME2(7), @DeletionDate DATETIME2(7),
@Disabled BIT, @Disabled BIT,
@HideEmail BIT, @HideEmail BIT,
@CipherId UNIQUEIDENTIFIER = NULL @CipherId UNIQUEIDENTIFIER = NULL,
@Emails NVARCHAR(1024) = NULL
AS AS
BEGIN BEGIN
SET NOCOUNT ON SET NOCOUNT ON

View File

@ -1,10 +1,17 @@
-- Add `Emails` field that stores a comma-separated list of email addresses for -- Add `Emails` field that stores a comma-separated list of email addresses for
-- email/OTP authentication to table and write methods. The read methods -- email/OTP authentication to table and write methods. The read methods
-- don't need to be updated because they all use `*`. -- don't need to be updated because they all use `*`.
ALTER TABLE [dbo].[Organization] ADD [Emails] NVARCHAR(1024) NULL;
IF (EXISTS (SELECT *
FROM INFORMATION_SCHEMA.TABLES
WHERE TABLE_SCHEMA = 'dbo'
AND TABLE_NAME = 'Send'))
BEGIN
ALTER TABLE [dbo].[Send] ADD [Emails] NVARCHAR(1024) NULL;
END
GO GO
CREATE OR ALTER PROCEDURE [dbo].[Send_Update] CREATE OR ALTER PROCEDURE [dbo].[Send_Update]
@Id UNIQUEIDENTIFIER, @Id UNIQUEIDENTIFIER,
@UserId UNIQUEIDENTIFIER, @UserId UNIQUEIDENTIFIER,
@OrganizationId UNIQUEIDENTIFIER, @OrganizationId UNIQUEIDENTIFIER,
@ -54,8 +61,9 @@ BEGIN
END END
-- TODO: OrganizationId bump? -- TODO: OrganizationId bump?
END END
GO
CREATE OR ALTER PROCEDURE [dbo].[Send_Create] CREATE OR ALTER PROCEDURE [dbo].[Send_Create]
@Id UNIQUEIDENTIFIER OUTPUT, @Id UNIQUEIDENTIFIER OUTPUT,
@UserId UNIQUEIDENTIFIER, @UserId UNIQUEIDENTIFIER,
@OrganizationId UNIQUEIDENTIFIER, @OrganizationId UNIQUEIDENTIFIER,
@ -126,3 +134,4 @@ BEGIN
END END
-- TODO: OrganizationId bump? -- TODO: OrganizationId bump?
END END
GO