From a5b809f477fc0b6df01d64d7103b35b990e5d0a5 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Mon, 25 Nov 2019 11:40:04 -0500 Subject: [PATCH] update rolling file settings for LogRollBySizeLimit --- src/Core/IdentityServer/ResourceOwnerPasswordValidator.cs | 5 +++-- src/Core/Utilities/LoggerFactoryExtensions.cs | 5 ++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Core/IdentityServer/ResourceOwnerPasswordValidator.cs b/src/Core/IdentityServer/ResourceOwnerPasswordValidator.cs index cb206d0e7c..1b8667eeaa 100644 --- a/src/Core/IdentityServer/ResourceOwnerPasswordValidator.cs +++ b/src/Core/IdentityServer/ResourceOwnerPasswordValidator.cs @@ -222,8 +222,9 @@ namespace Bit.Core.IdentityServer if(_globalSettings.SelfHosted) { - _logger.LogWarning(Constants.BypassFiltersEventId, "Failed login attempt{0}{1}", - twoFactorRequest ? ", 2FA invalid." : ".", $" {_currentContext.IpAddress}"); + _logger.LogWarning(Constants.BypassFiltersEventId, + string.Format("Failed login attempt{0}{1}", twoFactorRequest ? ", 2FA invalid." : ".", + $" {_currentContext.IpAddress}")); } await Task.Delay(2000); // Delay for brute force. context.Result = new GrantValidationResult(TokenRequestErrors.InvalidGrant, diff --git a/src/Core/Utilities/LoggerFactoryExtensions.cs b/src/Core/Utilities/LoggerFactoryExtensions.cs index b1fe9cb733..f207d23bb8 100644 --- a/src/Core/Utilities/LoggerFactoryExtensions.cs +++ b/src/Core/Utilities/LoggerFactoryExtensions.cs @@ -79,9 +79,8 @@ namespace Bit.Core.Utilities { if(globalSettings.LogRollBySizeLimit.HasValue) { - config.WriteTo - .RollingFile($"{globalSettings.LogDirectory}/{globalSettings.ProjectName}/log.txt", - fileSizeLimitBytes: globalSettings.LogRollBySizeLimit); + config.WriteTo.File($"{globalSettings.LogDirectory}/{globalSettings.ProjectName}/log.txt", + rollOnFileSizeLimit: true, fileSizeLimitBytes: globalSettings.LogRollBySizeLimit); } else {