nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-05 05:00:19 -05:00
Code

Families for enterprise/fix new org sponsorship after deleted sponsored org (#1740)

Browse Source 
* Sponsorship exists only if sponsored org is not null

* Replace existing sponsorship if necessary

* Update src/Core/Services/Implementations/OrganizationSponsorshipService.cs

Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com>

* Fix tests

Co-authored-by: Robyn MacCallum <nickersthecat@gmail.com>
This commit is contained in:
Matt Gibson 2021-12-02 10:27:41 -06:00 committed by GitHub
parent dc3d70cf3a
commit a70564cea8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Core/Services/Implementations/OrganizationSponsorshipService.cs
View File

@ -98,7 +98,7 @@ namespace Bit.Core.Services
var existingOrgSponsorship = await _organizationSponsorshipRepository var existingOrgSponsorship = await _organizationSponsorshipRepository
.GetBySponsoringOrganizationUserIdAsync(sponsoringOrgUser.Id); .GetBySponsoringOrganizationUserIdAsync(sponsoringOrgUser.Id);
if (existingOrgSponsorship != null) if (existingOrgSponsorship?.SponsoredOrganizationId != null)
{ {
throw new BadRequestException("Can only sponsor one organization per Organization User."); throw new BadRequestException("Can only sponsor one organization per Organization User.");
} }
@ -113,9 +113,15 @@ namespace Bit.Core.Services
CloudSponsor = true, CloudSponsor = true,
}; };
if (existingOrgSponsorship != null)
{
// Replace existing invalid offer with our new sponsorship offer
sponsorship.Id = existingOrgSponsorship.Id;
}
try try
{ {
sponsorship = await _organizationSponsorshipRepository.CreateAsync(sponsorship); await _organizationSponsorshipRepository.UpsertAsync(sponsorship);
await SendSponsorshipOfferAsync(sponsorship, sponsoringUserEmail); await SendSponsorshipOfferAsync(sponsorship, sponsoringUserEmail);
} }

4
test/Core.Test/Services/OrganizationSponsorshipServiceTests.cs
View File

@ -139,7 +139,7 @@ namespace Bit.Core.Test.Services
}; };
await sutProvider.GetDependency<IOrganizationSponsorshipRepository>().Received(1) await sutProvider.GetDependency<IOrganizationSponsorshipRepository>().Received(1)
.CreateAsync(Arg.Is<OrganizationSponsorship>(s => SponsorshipValidator(s, expectedSponsorship))); .UpsertAsync(Arg.Is<OrganizationSponsorship>(s => SponsorshipValidator(s, expectedSponsorship)));
await sutProvider.GetDependency<IMailService>().Received(1). await sutProvider.GetDependency<IMailService>().Received(1).
SendFamiliesForEnterpriseOfferEmailAsync(sponsoredEmail, email, SendFamiliesForEnterpriseOfferEmailAsync(sponsoredEmail, email,
@ -156,7 +156,7 @@ namespace Bit.Core.Test.Services
var expectedException = new Exception(); var expectedException = new Exception();
OrganizationSponsorship createdSponsorship = null; OrganizationSponsorship createdSponsorship = null;
sutProvider.GetDependency<IOrganizationSponsorshipRepository>().CreateAsync(default).ThrowsForAnyArgs(callInfo => sutProvider.GetDependency<IOrganizationSponsorshipRepository>().UpsertAsync(default).ThrowsForAnyArgs(callInfo =>
{ {
createdSponsorship = callInfo.ArgAt<OrganizationSponsorship>(0); createdSponsorship = callInfo.ArgAt<OrganizationSponsorship>(0);
createdSponsorship.Id = Guid.NewGuid(); createdSponsorship.Id = Guid.NewGuid();