Fix #2

src/Infrastructure.EntityFramework/Vault/Repositories/CipherRepository.cs

@@ -16,6 +16,7 @@ using LinqToDB.EntityFrameworkCore;
 using Microsoft.Data.SqlClient;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.Extensions.DependencyInjection;
+using NSec.Cryptography;
 using NS = Newtonsoft.Json;
 using NSL = Newtonsoft.Json.Linq;
 
@@ -863,11 +864,30 @@ public class CipherRepository : Repository<Core.Vault.Entities.Cipher, Cipher, G
         using (var scope = ServiceScopeFactory.CreateScope())
         {
             var dbContext = GetDatabaseContext(scope);
-            var entities = Mapper.Map<List<Cipher>>(ciphers);
+            var ciphersToUpdate = ciphers.ToDictionary(c => c.Id);
-            foreach (var cipher in entities)
+
+            var existingCiphers = await dbContext.Ciphers
+                .Where(c => c.UserId == userId && ciphersToUpdate.Keys.Contains(c.Id))
+                .ToDictionaryAsync(c => c.Id);
+
+            foreach (var (cipherId, cipher) in ciphersToUpdate)
             {
-                dbContext.Ciphers.Attach(cipher);
+                if (!existingCiphers.TryGetValue(cipherId, out var existingCipher))
+                {
+                    // The Dapper version does not validate that the same amount of items given where updated.
+                    continue;
+                }
+
+                existingCipher.UserId = cipher.UserId;
+                existingCipher.OrganizationId = cipher.OrganizationId;
+                existingCipher.Type = cipher.Type;
+                existingCipher.Data = cipher.Data;
+                existingCipher.Attachments = cipher.Attachments;
+                existingCipher.RevisionDate = cipher.RevisionDate;
+                existingCipher.DeletedDate = cipher.DeletedDate;
+                existingCipher.Key = cipher.Key;
             }
+
             await dbContext.UserBumpAccountRevisionDateAsync(userId);
             await dbContext.SaveChangesAsync();
         }

test/Infrastructure.IntegrationTest/Vault/Repositories/CipherRepositoryTests.cs

@@ -1,5 +1,4 @@
 using System.Text.Json;
-using System.Text.Json.Nodes;
 using Bit.Core.AdminConsole.Entities;
 using Bit.Core.AdminConsole.Repositories;
 using Bit.Core.Entities;
@@ -899,11 +898,8 @@ public class CipherRepositoryTests
         var cipher1 = await CreatePersonalCipher(user, cipherRepository);
         var cipher2 = await CreatePersonalCipher(user, cipherRepository);
 
-        cipher1.Reprompt = CipherRepromptType.Password;
+        cipher1.Type = CipherType.SecureNote;
-        cipher2.Favorites = new JsonObject
+        cipher2.Attachments = "new_attachments";
-        {
-            [user.Id.ToString()] = true,
-        }.ToJsonString();
 
         await cipherRepository.UpdateCiphersAsync(user.Id, [cipher1, cipher2]);
 
@@ -913,6 +909,7 @@ public class CipherRepositoryTests
         Assert.NotNull(updatedCipher1);
         Assert.NotNull(updatedCipher2);
 
-        Assert.Equal(CipherRepromptType.Password, updatedCipher1.Reprompt);
+        Assert.Equal(CipherType.SecureNote, updatedCipher1.Type);
+        Assert.Equal("new_attachments", updatedCipher2.Attachments);
     }
 }