From bd3d66ab60c4a5ae389b75140288c15b5703f43f Mon Sep 17 00:00:00 2001
From: Rui Tome <rtome@bitwarden.com>
Date: Mon, 30 Oct 2023 14:52:37 +0000
Subject: [PATCH] [AC-1139] Created new CollectionOperation ReadAccess and
 changed GetUsers_vNext to use it

---
 src/Api/Controllers/CollectionsController.cs                    | 2 +-
 .../Collections/BulkCollectionAuthorizationHandler.cs           | 1 +
 .../AuthorizationHandlers/Collections/CollectionOperations.cs   | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Api/Controllers/CollectionsController.cs b/src/Api/Controllers/CollectionsController.cs
index 695bb3959e..b89c029205 100644
--- a/src/Api/Controllers/CollectionsController.cs
+++ b/src/Api/Controllers/CollectionsController.cs
@@ -566,7 +566,7 @@ public class CollectionsController : Controller
     private async Task<IEnumerable<SelectionReadOnlyResponseModel>> GetUsers_vNext(Guid id)
     {
         var collection = await _collectionRepository.GetByIdAsync(id);
-        var authorized = (await _authorizationService.AuthorizeAsync(User, collection, CollectionOperations.Read)).Succeeded;
+        var authorized = (await _authorizationService.AuthorizeAsync(User, collection, CollectionOperations.ReadAccess)).Succeeded;
         if (!authorized)
         {
             throw new NotFoundException();
diff --git a/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs b/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
index 2c1941a39a..253eb3feaf 100644
--- a/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
+++ b/src/Api/Vault/AuthorizationHandlers/Collections/BulkCollectionAuthorizationHandler.cs
@@ -84,6 +84,7 @@ public class BulkCollectionAuthorizationHandler : BulkAuthorizationHandler<Colle
                 break;
 
             case not null when requirement == CollectionOperations.Read:
+            case not null when requirement == CollectionOperations.ReadAccess:
                 await CanReadAsync(context, requirement, resources, org);
                 break;
 
diff --git a/src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs b/src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs
index 960addfa6d..b845ea816b 100644
--- a/src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs
+++ b/src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs
@@ -19,6 +19,7 @@ public static class CollectionOperations
 {
     public static readonly CollectionOperationRequirement Create = new() { Name = nameof(Create) };
     public static readonly CollectionOperationRequirement Read = new() { Name = nameof(Read) };
+    public static readonly CollectionOperationRequirement ReadAccess = new() { Name = nameof(ReadAccess) };
     public static CollectionOperationRequirement ReadAll(Guid organizationId)
     {
         return new CollectionOperationRequirement(nameof(ReadAll), organizationId);