From bd66f06bd99856985e4587e6cd8094e4bb9ae392 Mon Sep 17 00:00:00 2001
From: Matt Gibson <mgibson@bitwarden.com>
Date: Wed, 26 Feb 2025 14:41:24 -0800
Subject: [PATCH] Prefer record to implementing IEquatable (#5449)

---
 .../NotificationHub/PushRegistrationData.cs   | 23 ++-----------------
 .../Push/Controllers/PushControllerTests.cs   |  2 +-
 2 files changed, 3 insertions(+), 22 deletions(-)

diff --git a/src/Core/NotificationHub/PushRegistrationData.cs b/src/Core/NotificationHub/PushRegistrationData.cs
index 0cdf981ee2..20e1cf0936 100644
--- a/src/Core/NotificationHub/PushRegistrationData.cs
+++ b/src/Core/NotificationHub/PushRegistrationData.cs
@@ -1,23 +1,13 @@
 namespace Bit.Core.NotificationHub;
 
-public struct WebPushRegistrationData : IEquatable<WebPushRegistrationData>
+public record struct WebPushRegistrationData
 {
     public string Endpoint { get; init; }
     public string P256dh { get; init; }
     public string Auth { get; init; }
-
-    public bool Equals(WebPushRegistrationData other)
-    {
-        return Endpoint == other.Endpoint && P256dh == other.P256dh && Auth == other.Auth;
-    }
-
-    public override int GetHashCode()
-    {
-        return HashCode.Combine(Endpoint, P256dh, Auth);
-    }
 }
 
-public class PushRegistrationData : IEquatable<PushRegistrationData>
+public record class PushRegistrationData
 {
     public string Token { get; set; }
     public WebPushRegistrationData? WebPush { get; set; }
@@ -38,13 +28,4 @@ public class PushRegistrationData : IEquatable<PushRegistrationData>
     {
         WebPush = webPush;
     }
-    public bool Equals(PushRegistrationData other)
-    {
-        return Token == other.Token && WebPush.Equals(other.WebPush);
-    }
-
-    public override int GetHashCode()
-    {
-        return HashCode.Combine(Token, WebPush.GetHashCode());
-    }
 }
diff --git a/test/Api.Test/Platform/Push/Controllers/PushControllerTests.cs b/test/Api.Test/Platform/Push/Controllers/PushControllerTests.cs
index b796a445ae..399913a0c4 100644
--- a/test/Api.Test/Platform/Push/Controllers/PushControllerTests.cs
+++ b/test/Api.Test/Platform/Push/Controllers/PushControllerTests.cs
@@ -280,7 +280,7 @@ public class PushControllerTests
         await sutProvider.Sut.RegisterAsync(model);
 
         await sutProvider.GetDependency<IPushRegistrationService>().Received(1)
-            .CreateOrUpdateRegistrationAsync(Arg.Is<PushRegistrationData>(data => data.Equals(new PushRegistrationData(model.PushToken))), expectedDeviceId, expectedUserId,
+            .CreateOrUpdateRegistrationAsync(Arg.Is<PushRegistrationData>(data => data == new PushRegistrationData(model.PushToken)), expectedDeviceId, expectedUserId,
                 expectedIdentifier, DeviceType.Android, Arg.Do<IEnumerable<string>>(organizationIds =>
                 {
                     var organizationIdsList = organizationIds.ToList();