nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-07-04 01:22:50 -05:00
Code Activity

Refactor error handling in ProviderClientOrganizationSignUpCommand to use constants for error messages

Browse Source
This commit is contained in:
Rui Tome
2025-05-02 15:24:08 +01:00
parent b62e97f601
commit bec9c555c6
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/Core/AdminConsole/OrganizationFeatures/Organizations/ProviderClientOrganizationSignUpCommand.cs
View File

@ -31,6 +31,10 @@ public interface IProviderClientOrganizationSignUpCommand
public class ProviderClientOrganizationSignUpCommand : IProviderClientOrganizationSignUpCommand
{
public const string PlanNullErrorMessage = "Password Manager Plan was null.";
public const string PlanDisabledErrorMessage = "Password Manager Plan is disabled.";
public const string AdditionalSeatsNegativeErrorMessage = "You can't subtract Password Manager seats!";
private readonly ICurrentContext _currentContext;
private readonly IPricingClient _pricingClient;
private readonly IReferenceEventService _referenceEventService;
@ -120,17 +124,17 @@ public class ProviderClientOrganizationSignUpCommand : IProviderClientOrganizati
{
if (plan is null)
{
throw new BadRequestException("Password Manager Plan was null.");
throw new BadRequestException(PlanNullErrorMessage);
}
if (plan.Disabled)
{
throw new BadRequestException("Password Manager Plan is disabled.");
throw new BadRequestException(PlanDisabledErrorMessage);
}
if (additionalSeats < 0)
{
throw new BadRequestException("You can't subtract Password Manager seats!");
throw new BadRequestException(AdditionalSeatsNegativeErrorMessage);
}
}