[SM-220] Move identity specific files to identity (#2279)

bitwarden_license/src/Sso/IdentityServer/OidcIdentityClient.cs

@@ -2,7 +2,7 @@
 using IdentityServer4;
 using IdentityServer4.Models;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Sso.IdentityServer;
 
 public class OidcIdentityClient : Client
 {
@@ -11,8 +11,8 @@ public class OidcIdentityClient : Client
         ClientId = "oidc-identity";
         RequireClientSecret = true;
         RequirePkce = true;
-        ClientSecrets = new List<Secret> { new Secret(globalSettings.OidcIdentityClientKey.Sha256()) };
-        AllowedScopes = new string[]
+        ClientSecrets = new List<Secret> { new(globalSettings.OidcIdentityClientKey.Sha256()) };
+        AllowedScopes = new[]
         {
             IdentityServerConstants.StandardScopes.OpenId,
             IdentityServerConstants.StandardScopes.Profile

bitwarden_license/src/Sso/Utilities/ServiceCollectionExtensions.cs

@@ -1,8 +1,8 @@
 using Bit.Core.Business.Sso;
-using Bit.Core.IdentityServer;
 using Bit.Core.Settings;
 using Bit.Core.Utilities;
 using Bit.SharedWeb.Utilities;
+using Bit.Sso.IdentityServer;
 using Bit.Sso.Models;
 using IdentityServer4.Models;
 using IdentityServer4.ResponseHandling;

src/Admin/Controllers/LoginController.cs

@@ -1,5 +1,5 @@
-using Bit.Admin.Models;
-using Bit.Core.Identity;
+using Bit.Admin.IdentityServer;
+using Bit.Admin.Models;
 using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.Mvc;
 

src/Admin/IdentityServer/PasswordlessSignInManager.cs

@@ -1,11 +1,9 @@
 using Bit.Core.Services;
 using Microsoft.AspNetCore.Authentication;
-using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Identity;
-using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
-namespace Bit.Core.Identity;
+namespace Bit.Admin.IdentityServer;
 
 public class PasswordlessSignInManager<TUser> : SignInManager<TUser> where TUser : class
 {

src/Admin/IdentityServer/ReadOnlyEnvIdentityUserStore.cs

@@ -1,8 +1,7 @@
 using Bit.Core.Utilities;
 using Microsoft.AspNetCore.Identity;
-using Microsoft.Extensions.Configuration;
 
-namespace Bit.Core.Identity;
+namespace Bit.Admin.IdentityServer;
 
 public class ReadOnlyEnvIdentityUserStore : ReadOnlyIdentityUserStore
 {
@@ -14,7 +13,7 @@ public class ReadOnlyEnvIdentityUserStore : ReadOnlyIdentityUserStore
     }
 
     public override Task<IdentityUser> FindByEmailAsync(string normalizedEmail,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         var usersCsv = _configuration["adminSettings:admins"];
         if (!CoreHelpers.SettingHasValue(usersCsv))
@@ -59,7 +58,7 @@ public class ReadOnlyEnvIdentityUserStore : ReadOnlyIdentityUserStore
     }
 
     public override Task<IdentityUser> FindByIdAsync(string userId,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return FindByEmailAsync(userId, cancellationToken);
     }

src/Admin/IdentityServer/ReadOnlyIdentityUserStore.cs

@@ -1,108 +1,107 @@
 using Microsoft.AspNetCore.Identity;
 
-namespace Bit.Core.Identity;
+namespace Bit.Admin.IdentityServer;
 
 public abstract class ReadOnlyIdentityUserStore :
-    IUserStore<IdentityUser>,
     IUserEmailStore<IdentityUser>,
     IUserSecurityStampStore<IdentityUser>
 {
     public void Dispose() { }
 
     public Task<IdentityResult> CreateAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         throw new NotImplementedException();
     }
 
     public Task<IdentityResult> DeleteAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         throw new NotImplementedException();
     }
 
     public abstract Task<IdentityUser> FindByEmailAsync(string normalizedEmail,
-        CancellationToken cancellationToken = default(CancellationToken));
+        CancellationToken cancellationToken = default);
 
     public abstract Task<IdentityUser> FindByIdAsync(string userId,
-        CancellationToken cancellationToken = default(CancellationToken));
+        CancellationToken cancellationToken = default);
 
     public async Task<IdentityUser> FindByNameAsync(string normalizedUserName,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return await FindByEmailAsync(normalizedUserName, cancellationToken);
     }
 
     public Task<string> GetEmailAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.Email);
     }
 
     public Task<bool> GetEmailConfirmedAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.EmailConfirmed);
     }
 
     public Task<string> GetNormalizedEmailAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.Email);
     }
 
     public Task<string> GetNormalizedUserNameAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.Email);
     }
 
     public Task<string> GetUserIdAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.Id);
     }
 
     public Task<string> GetUserNameAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(user.Email);
     }
 
     public Task SetEmailAsync(IdentityUser user, string email,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         throw new NotImplementedException();
     }
 
     public Task SetEmailConfirmedAsync(IdentityUser user, bool confirmed,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         throw new NotImplementedException();
     }
 
     public Task SetNormalizedEmailAsync(IdentityUser user, string normalizedEmail,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         user.NormalizedEmail = normalizedEmail;
         return Task.FromResult(0);
     }
 
     public Task SetNormalizedUserNameAsync(IdentityUser user, string normalizedName,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         user.NormalizedUserName = normalizedName;
         return Task.FromResult(0);
     }
 
     public Task SetUserNameAsync(IdentityUser user, string userName,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         throw new NotImplementedException();
     }
 
     public Task<IdentityResult> UpdateAsync(IdentityUser user,
-        CancellationToken cancellationToken = default(CancellationToken))
+        CancellationToken cancellationToken = default)
     {
         return Task.FromResult(IdentityResult.Success);
     }

src/Admin/IdentityServer/ServiceCollectionExtensions.cs

@@ -0,0 +1,44 @@
+using Bit.Core.Entities;
+using Bit.Core.Identity;
+using Bit.Core.Settings;
+using Microsoft.AspNetCore.Identity;
+using Microsoft.Extensions.DependencyInjection.Extensions;
+
+namespace Bit.Admin.IdentityServer;
+
+public static class ServiceCollectionExtensions
+{
+    public static Tuple<IdentityBuilder, IdentityBuilder> AddPasswordlessIdentityServices<TUserStore>(
+        this IServiceCollection services, GlobalSettings globalSettings) where TUserStore : class
+    {
+        services.TryAddTransient<ILookupNormalizer, LowerInvariantLookupNormalizer>();
+        services.Configure<DataProtectionTokenProviderOptions>(options =>
+        {
+            options.TokenLifespan = TimeSpan.FromMinutes(15);
+        });
+
+        var passwordlessIdentityBuilder = services.AddIdentity<IdentityUser, Role>()
+            .AddUserStore<TUserStore>()
+            .AddRoleStore<RoleStore>()
+            .AddDefaultTokenProviders();
+
+        var regularIdentityBuilder = services.AddIdentityCore<User>()
+            .AddUserStore<UserStore>();
+
+        services.TryAddScoped<PasswordlessSignInManager<IdentityUser>, PasswordlessSignInManager<IdentityUser>>();
+
+        services.ConfigureApplicationCookie(options =>
+        {
+            options.LoginPath = "/login";
+            options.LogoutPath = "/";
+            options.AccessDeniedPath = "/login?accessDenied=true";
+            options.Cookie.Name = $"Bitwarden_{globalSettings.ProjectName}";
+            options.Cookie.HttpOnly = true;
+            options.ExpireTimeSpan = TimeSpan.FromDays(2);
+            options.ReturnUrlParameter = "returnUrl";
+            options.SlidingExpiration = true;
+        });
+
+        return new Tuple<IdentityBuilder, IdentityBuilder>(passwordlessIdentityBuilder, regularIdentityBuilder);
+    }
+}

src/Admin/Startup.cs

@@ -1,6 +1,6 @@
 using System.Globalization;
+using Bit.Admin.IdentityServer;
 using Bit.Core.Context;
-using Bit.Core.Identity;
 using Bit.Core.Settings;
 using Bit.Core.Utilities;
 using Bit.SharedWeb.Utilities;

src/Core/Identity/ReadOnlyDatabaseIdentityUserStore.cs

@@ -1,38 +0,0 @@
-using Bit.Core.Repositories;
-using Bit.Core.Services;
-using Microsoft.AspNetCore.Identity;
-
-namespace Bit.Core.Identity;
-
-public class ReadOnlyDatabaseIdentityUserStore : ReadOnlyIdentityUserStore
-{
-    private readonly IUserService _userService;
-    private readonly IUserRepository _userRepository;
-
-    public ReadOnlyDatabaseIdentityUserStore(
-        IUserService userService,
-        IUserRepository userRepository)
-    {
-        _userService = userService;
-        _userRepository = userRepository;
-    }
-
-    public override async Task<IdentityUser> FindByEmailAsync(string normalizedEmail,
-        CancellationToken cancellationToken = default(CancellationToken))
-    {
-        var user = await _userRepository.GetByEmailAsync(normalizedEmail);
-        return user?.ToIdentityUser(await _userService.TwoFactorIsEnabledAsync(user));
-    }
-
-    public override async Task<IdentityUser> FindByIdAsync(string userId,
-        CancellationToken cancellationToken = default(CancellationToken))
-    {
-        if (!Guid.TryParse(userId, out var userIdGuid))
-        {
-            return null;
-        }
-
-        var user = await _userRepository.GetByIdAsync(userIdGuid);
-        return user?.ToIdentityUser(await _userService.TwoFactorIsEnabledAsync(user));
-    }
-}

src/Identity/IdentityServer/ApiClient.cs

@@ -1,7 +1,7 @@
 using Bit.Core.Settings;
 using IdentityServer4.Models;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ApiClient : Client
 {

src/Identity/IdentityServer/ApiResources.cs

@@ -1,7 +1,7 @@
 using IdentityModel;
 using IdentityServer4.Models;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ApiResources
 {

src/Identity/IdentityServer/ApiScopes.cs

@@ -1,6 +1,6 @@
 using IdentityServer4.Models;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ApiScopes
 {

src/Identity/IdentityServer/AuthorizationCodeStore.cs

@@ -4,9 +4,8 @@ using IdentityServer4.Models;
 using IdentityServer4.Services;
 using IdentityServer4.Stores;
 using IdentityServer4.Stores.Serialization;
-using Microsoft.Extensions.Logging;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 // ref: https://raw.githubusercontent.com/IdentityServer/IdentityServer4/3.1.3/src/IdentityServer4/src/Stores/Default/DefaultAuthorizationCodeStore.cs
 public class AuthorizationCodeStore : DefaultGrantStore<AuthorizationCode>, IAuthorizationCodeStore

src/Identity/IdentityServer/BaseRequestValidator.cs

@@ -2,6 +2,7 @@
 using System.Reflection;
 using System.Security.Claims;
 using System.Text.Json;
+using Bit.Core;
 using Bit.Core.Context;
 using Bit.Core.Entities;
 using Bit.Core.Enums;
@@ -15,9 +16,8 @@ using Bit.Core.Settings;
 using Bit.Core.Utilities;
 using IdentityServer4.Validation;
 using Microsoft.AspNetCore.Identity;
-using Microsoft.Extensions.Logging;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public abstract class BaseRequestValidator<T> where T : class
 {

src/Identity/IdentityServer/ClientStore.cs

@@ -10,7 +10,7 @@ using IdentityModel;
 using IdentityServer4.Models;
 using IdentityServer4.Stores;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ClientStore : IClientStore
 {

src/Identity/IdentityServer/CustomTokenRequestValidator.cs

@@ -9,9 +9,8 @@ using IdentityModel;
 using IdentityServer4.Extensions;
 using IdentityServer4.Validation;
 using Microsoft.AspNetCore.Identity;
-using Microsoft.Extensions.Logging;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class CustomTokenRequestValidator : BaseRequestValidator<CustomTokenRequestValidationContext>,
     ICustomTokenRequestValidator

src/Identity/IdentityServer/CustomValidatorRequestContext.cs

@@ -1,7 +1,7 @@
 using Bit.Core.Entities;
 using Bit.Core.Models.Business;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class CustomValidatorRequestContext
 {

src/Identity/IdentityServer/PersistedGrantStore.cs

@@ -3,7 +3,7 @@ using IdentityServer4.Models;
 using IdentityServer4.Stores;
 using Grant = Bit.Core.Entities.Grant;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class PersistedGrantStore : IPersistedGrantStore
 {

src/Identity/IdentityServer/ProfileService.cs

@@ -6,7 +6,7 @@ using Bit.Core.Utilities;
 using IdentityServer4.Models;
 using IdentityServer4.Services;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ProfileService : IProfileService
 {

src/Identity/IdentityServer/ResourceOwnerPasswordValidator.cs

@@ -9,9 +9,8 @@ using Bit.Core.Utilities;
 using IdentityServer4.Models;
 using IdentityServer4.Validation;
 using Microsoft.AspNetCore.Identity;
-using Microsoft.Extensions.Logging;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class ResourceOwnerPasswordValidator : BaseRequestValidator<ResourceOwnerPasswordValidationContext>,
     IResourceOwnerPasswordValidator

src/Identity/IdentityServer/StaticClientStore.cs

@@ -2,7 +2,7 @@
 using Bit.Core.Settings;
 using IdentityServer4.Models;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class StaticClientStore
 {

src/Identity/IdentityServer/VaultCorsPolicyService.cs

@@ -2,7 +2,7 @@
 using Bit.Core.Utilities;
 using IdentityServer4.Services;
 
-namespace Bit.Core.IdentityServer;
+namespace Bit.Identity.IdentityServer;
 
 public class CustomCorsPolicyService : ICorsPolicyService
 {

src/Identity/Utilities/ServiceCollectionExtensions.cs

@@ -1,5 +1,5 @@
-using Bit.Core.IdentityServer;
-using Bit.Core.Settings;
+using Bit.Core.Settings;
+using Bit.Identity.IdentityServer;
 using Bit.SharedWeb.Utilities;
 using IdentityServer4.ResponseHandling;
 using IdentityServer4.Services;

src/SharedWeb/Utilities/ServiceCollectionExtensions.cs

@@ -33,7 +33,6 @@ using Microsoft.Extensions.Caching.Distributed;
 using Microsoft.Extensions.Caching.StackExchangeRedis;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
-using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
@@ -358,39 +357,7 @@ public static class ServiceCollectionExtensions
         return identityBuilder;
     }
 
-    public static Tuple<IdentityBuilder, IdentityBuilder> AddPasswordlessIdentityServices<TUserStore>(
-        this IServiceCollection services, GlobalSettings globalSettings) where TUserStore : class
-    {
-        services.TryAddTransient<ILookupNormalizer, LowerInvariantLookupNormalizer>();
-        services.Configure<DataProtectionTokenProviderOptions>(options =>
-        {
-            options.TokenLifespan = TimeSpan.FromMinutes(15);
-        });
 
-        var passwordlessIdentityBuilder = services.AddIdentity<IdentityUser, Role>()
-            .AddUserStore<TUserStore>()
-            .AddRoleStore<RoleStore>()
-            .AddDefaultTokenProviders();
-
-        var regularIdentityBuilder = services.AddIdentityCore<User>()
-            .AddUserStore<UserStore>();
-
-        services.TryAddScoped<PasswordlessSignInManager<IdentityUser>, PasswordlessSignInManager<IdentityUser>>();
-
-        services.ConfigureApplicationCookie(options =>
-        {
-            options.LoginPath = "/login";
-            options.LogoutPath = "/";
-            options.AccessDeniedPath = "/login?accessDenied=true";
-            options.Cookie.Name = $"Bitwarden_{globalSettings.ProjectName}";
-            options.Cookie.HttpOnly = true;
-            options.ExpireTimeSpan = TimeSpan.FromDays(2);
-            options.ReturnUrlParameter = "returnUrl";
-            options.SlidingExpiration = true;
-        });
-
-        return new Tuple<IdentityBuilder, IdentityBuilder>(passwordlessIdentityBuilder, regularIdentityBuilder);
-    }
 
     public static void AddIdentityAuthenticationServices(
         this IServiceCollection services, GlobalSettings globalSettings, IWebHostEnvironment environment,

test/Identity.IntegrationTest/Endpoints/IdentityServerTests.cs

@@ -3,6 +3,7 @@ using Bit.Core.Entities;
 using Bit.Core.Enums;
 using Bit.Core.Models.Api.Request.Accounts;
 using Bit.Core.Repositories;
+using Bit.Identity.IdentityServer;
 using Bit.IntegrationTestCommon.Factories;
 using Bit.Test.Common.AutoFixture.Attributes;
 using Bit.Test.Common.Helpers;
@@ -279,7 +280,7 @@ public class IdentityServerTests : IClassFixture<IdentityApplicationFactory>
 
     /// <summary>
     /// This test currently does not test any code that is not covered by other tests but 
-    /// it shows that we probably have some dead code in <see cref="Core.IdentityServer.ClientStore"/>
+    /// it shows that we probably have some dead code in <see cref="ClientStore"/>
     /// for installation, organization, and user they split on a <c>'.'</c> but have already checked that at least one
     /// <c>'.'</c> exists in the <c>client_id</c> by checking it with <see cref="string.StartsWith(string)"/> 
     /// I believe that idParts.Length > 1 will ALWAYS return true