Make AC Repos Nullable (#4610)

src/Core/AdminConsole/Repositories/IGroupRepository.cs

@@ -2,11 +2,13 @@
 using Bit.Core.Models.Data;
 using Bit.Core.Repositories;
 
+#nullable enable
+
 namespace Bit.Core.AdminConsole.Repositories;
 
 public interface IGroupRepository : IRepository<Group, Guid>
 {
-    Task<Tuple<Group, ICollection<CollectionAccessSelection>>> GetByIdWithCollectionsAsync(Guid id);
+    Task<Tuple<Group?, ICollection<CollectionAccessSelection>>> GetByIdWithCollectionsAsync(Guid id);
     Task<ICollection<Group>> GetManyByOrganizationIdAsync(Guid organizationId);
     Task<ICollection<Tuple<Group, ICollection<CollectionAccessSelection>>>> GetManyWithCollectionsByOrganizationIdAsync(
         Guid organizationId);

src/Core/AdminConsole/Repositories/IOrganizationRepository.cs

@@ -1,18 +1,20 @@
 using Bit.Core.AdminConsole.Entities;
 using Bit.Core.Models.Data.Organizations;
 
+#nullable enable
+
 namespace Bit.Core.Repositories;
 
 public interface IOrganizationRepository : IRepository<Organization, Guid>
 {
-    Task<Organization> GetByIdentifierAsync(string identifier);
+    Task<Organization?> GetByIdentifierAsync(string identifier);
     Task<ICollection<Organization>> GetManyByEnabledAsync();
     Task<ICollection<Organization>> GetManyByUserIdAsync(Guid userId);
     Task<ICollection<Organization>> SearchAsync(string name, string userEmail, bool? paid, int skip, int take);
     Task UpdateStorageAsync(Guid id);
     Task<ICollection<OrganizationAbility>> GetManyAbilitiesAsync();
-    Task<Organization> GetByLicenseKeyAsync(string licenseKey);
-    Task<SelfHostedOrganizationDetails> GetSelfHostedOrganizationDetailsById(Guid id);
+    Task<Organization?> GetByLicenseKeyAsync(string licenseKey);
+    Task<SelfHostedOrganizationDetails?> GetSelfHostedOrganizationDetailsById(Guid id);
     Task<ICollection<Organization>> SearchUnassignedToProviderAsync(string name, string ownerEmail, int skip, int take);
     Task<IEnumerable<string>> GetOwnerEmailAddressesById(Guid organizationId);
 }

src/Core/AdminConsole/Repositories/IOrganizationUserRepository.cs

@@ -5,6 +5,8 @@ using Bit.Core.Enums;
 using Bit.Core.Models.Data;
 using Bit.Core.Models.Data.Organizations.OrganizationUsers;
 
+#nullable enable
+
 namespace Bit.Core.Repositories;
 
 public interface IOrganizationUserRepository : IRepository<OrganizationUser, Guid>
@@ -17,26 +19,26 @@ public interface IOrganizationUserRepository : IRepository<OrganizationUser, Gui
     Task<int> GetCountByOrganizationAsync(Guid organizationId, string email, bool onlyRegisteredUsers);
     Task<int> GetOccupiedSeatCountByOrganizationIdAsync(Guid organizationId);
     Task<ICollection<string>> SelectKnownEmailsAsync(Guid organizationId, IEnumerable<string> emails, bool onlyRegisteredUsers);
-    Task<OrganizationUser> GetByOrganizationAsync(Guid organizationId, Guid userId);
-    Task<Tuple<OrganizationUser, ICollection<CollectionAccessSelection>>> GetByIdWithCollectionsAsync(Guid id);
-    Task<OrganizationUserUserDetails> GetDetailsByIdAsync(Guid id);
-    Task<Tuple<OrganizationUserUserDetails, ICollection<CollectionAccessSelection>>>
+    Task<OrganizationUser?> GetByOrganizationAsync(Guid organizationId, Guid userId);
+    Task<Tuple<OrganizationUser?, ICollection<CollectionAccessSelection>>> GetByIdWithCollectionsAsync(Guid id);
+    Task<OrganizationUserUserDetails?> GetDetailsByIdAsync(Guid id);
+    Task<Tuple<OrganizationUserUserDetails?, ICollection<CollectionAccessSelection>>>
         GetDetailsByIdWithCollectionsAsync(Guid id);
     Task<ICollection<OrganizationUserUserDetails>> GetManyDetailsByOrganizationAsync(Guid organizationId, bool includeGroups = false, bool includeCollections = false);
     Task<ICollection<OrganizationUserOrganizationDetails>> GetManyDetailsByUserAsync(Guid userId,
         OrganizationUserStatusType? status = null);
-    Task<OrganizationUserOrganizationDetails> GetDetailsByUserAsync(Guid userId, Guid organizationId,
+    Task<OrganizationUserOrganizationDetails?> GetDetailsByUserAsync(Guid userId, Guid organizationId,
         OrganizationUserStatusType? status = null);
     Task UpdateGroupsAsync(Guid orgUserId, IEnumerable<Guid> groupIds);
     Task UpsertManyAsync(IEnumerable<OrganizationUser> organizationUsers);
     Task<Guid> CreateAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections);
-    Task<ICollection<Guid>> CreateManyAsync(IEnumerable<OrganizationUser> organizationIdUsers);
+    Task<ICollection<Guid>?> CreateManyAsync(IEnumerable<OrganizationUser> organizationIdUsers);
     Task ReplaceAsync(OrganizationUser obj, IEnumerable<CollectionAccessSelection> collections);
     Task ReplaceManyAsync(IEnumerable<OrganizationUser> organizationUsers);
     Task<ICollection<OrganizationUser>> GetManyByManyUsersAsync(IEnumerable<Guid> userIds);
     Task<ICollection<OrganizationUser>> GetManyAsync(IEnumerable<Guid> Ids);
     Task DeleteManyAsync(IEnumerable<Guid> userIds);
-    Task<OrganizationUser> GetByOrganizationEmailAsync(Guid organizationId, string email);
+    Task<OrganizationUser?> GetByOrganizationEmailAsync(Guid organizationId, string email);
     Task<IEnumerable<OrganizationUserPublicKey>> GetManyPublicKeysByOrganizationUserAsync(Guid organizationId, IEnumerable<Guid> Ids);
     Task<IEnumerable<OrganizationUserUserDetails>> GetManyByMinimumRoleAsync(Guid organizationId, OrganizationUserType minRole);
     Task RevokeAsync(Guid id);

src/Core/AdminConsole/Repositories/IPolicyRepository.cs

@@ -2,11 +2,13 @@
 using Bit.Core.AdminConsole.Enums;
 using Bit.Core.Repositories;
 
+#nullable enable
+
 namespace Bit.Core.AdminConsole.Repositories;
 
 public interface IPolicyRepository : IRepository<Policy, Guid>
 {
-    Task<Policy> GetByOrganizationIdTypeAsync(Guid organizationId, PolicyType type);
+    Task<Policy?> GetByOrganizationIdTypeAsync(Guid organizationId, PolicyType type);
     Task<ICollection<Policy>> GetManyByOrganizationIdAsync(Guid organizationId);
     Task<ICollection<Policy>> GetManyByUserIdAsync(Guid userId);
 }

src/Core/AdminConsole/Repositories/IProviderOrganizationRepository.cs

@@ -2,13 +2,15 @@
 using Bit.Core.AdminConsole.Models.Data.Provider;
 using Bit.Core.Repositories;
 
+#nullable enable
+
 namespace Bit.Core.AdminConsole.Repositories;
 
 public interface IProviderOrganizationRepository : IRepository<ProviderOrganization, Guid>
 {
-    Task<ICollection<ProviderOrganization>> CreateManyAsync(IEnumerable<ProviderOrganization> providerOrganizations);
+    Task<ICollection<ProviderOrganization>?> CreateManyAsync(IEnumerable<ProviderOrganization> providerOrganizations);
     Task<ICollection<ProviderOrganizationOrganizationDetails>> GetManyDetailsByProviderAsync(Guid providerId);
-    Task<ProviderOrganization> GetByOrganizationId(Guid organizationId);
+    Task<ProviderOrganization?> GetByOrganizationId(Guid organizationId);
     Task<IEnumerable<ProviderOrganizationProviderDetails>> GetManyByUserAsync(Guid userId);
     Task<int> GetCountByOrganizationIdsAsync(IEnumerable<Guid> organizationIds);
 }

src/Core/AdminConsole/Repositories/IProviderRepository.cs

@@ -2,11 +2,13 @@
 using Bit.Core.AdminConsole.Models.Data.Provider;
 using Bit.Core.Repositories;
 
+#nullable enable
+
 namespace Bit.Core.AdminConsole.Repositories;
 
 public interface IProviderRepository : IRepository<Provider, Guid>
 {
-    Task<Provider> GetByOrganizationIdAsync(Guid organizationId);
+    Task<Provider?> GetByOrganizationIdAsync(Guid organizationId);
     Task<ICollection<Provider>> SearchAsync(string name, string userEmail, int skip, int take);
     Task<ICollection<ProviderAbility>> GetManyAbilitiesAsync();
 }

src/Core/AdminConsole/Repositories/IProviderUserRepository.cs

@@ -3,6 +3,8 @@ using Bit.Core.AdminConsole.Enums.Provider;
 using Bit.Core.AdminConsole.Models.Data.Provider;
 using Bit.Core.Repositories;
 
+#nullable enable
+
 namespace Bit.Core.AdminConsole.Repositories;
 
 public interface IProviderUserRepository : IRepository<ProviderUser, Guid>
@@ -10,7 +12,7 @@ public interface IProviderUserRepository : IRepository<ProviderUser, Guid>
     Task<int> GetCountByProviderAsync(Guid providerId, string email, bool onlyRegisteredUsers);
     Task<ICollection<ProviderUser>> GetManyAsync(IEnumerable<Guid> ids);
     Task<ICollection<ProviderUser>> GetManyByUserAsync(Guid userId);
-    Task<ProviderUser> GetByProviderUserAsync(Guid providerId, Guid userId);
+    Task<ProviderUser?> GetByProviderUserAsync(Guid providerId, Guid userId);
     Task<ICollection<ProviderUser>> GetManyByProviderAsync(Guid providerId, ProviderUserType? type = null);
     Task<ICollection<ProviderUserUserDetails>> GetManyDetailsByProviderAsync(Guid providerId, ProviderUserStatusType? status = null);
     Task<ICollection<ProviderUserProviderDetails>> GetManyDetailsByUserAsync(Guid userId,