[AC-2679] Adding a revoked, invited member with Can Manage access does not resolve unmanaged collections (#4397)

* Added check for revoked users

* removed check for users as any user status with can manage access should hide the add access badge

* updated comments

src/Infrastructure.EntityFramework/Repositories/Queries/CollectionAdminDetailsQuery.cs

@@ -1,5 +1,4 @@
-using Bit.Core.Enums;
-using Bit.Core.Models.Data;
+using Bit.Core.Models.Data;
 
 namespace Bit.Infrastructure.EntityFramework.Repositories.Queries;
 
@@ -47,11 +46,11 @@ public class CollectionAdminDetailsQuery : IQuery<CollectionAdminDetails>
                                   from cg in cg_g.DefaultIfEmpty()
                                   select new { c, cu, cg };
 
-        // Subqueries to determine if a colection is managed by an active user or group.
+        // Subqueries to determine if a collection is managed by a user or group.
         var activeUserManageRights = from cu in dbContext.CollectionUsers
                                      join ou in dbContext.OrganizationUsers
                                          on cu.OrganizationUserId equals ou.Id
-                                     where ou.Status == OrganizationUserStatusType.Confirmed && cu.Manage
+                                     where cu.Manage
                                      select cu.CollectionId;
 
         var activeGroupManageRights = from cg in dbContext.CollectionGroups

src/Sql/Vault/dbo/Stored Procedures/Collections/Collection_ReadByIdWithPermissions.sql

@@ -34,14 +34,13 @@ BEGIN
 	    END) AS [Assigned],
 	    CASE
             WHEN
-                -- No active user or group has manage rights
+                -- No user or group has manage rights
                  NOT EXISTS(
                     SELECT 1
                     FROM [dbo].[CollectionUser] CU2
                              JOIN [dbo].[OrganizationUser] OU2 ON CU2.[OrganizationUserId] = OU2.[Id]
                     WHERE
                         CU2.[CollectionId] = C.[Id] AND
-                        OU2.[Status] = 2 AND
                         CU2.[Manage] = 1
                 )
                     AND NOT EXISTS (

src/Sql/Vault/dbo/Stored Procedures/Collections/Collection_ReadByOrganizationIdWithPermissions.sql

@@ -34,14 +34,13 @@ BEGIN
 	    END) AS [Assigned],
 	    CASE
 	        WHEN
-	            -- No active user or group has manage rights
+	            -- No user or group has manage rights
 	            NOT EXISTS(
 	                SELECT 1
 	                FROM [dbo].[CollectionUser] CU2
 	                JOIN [dbo].[OrganizationUser] OU2 ON CU2.[OrganizationUserId] = OU2.[Id]
                     WHERE
                         CU2.[CollectionId] = C.[Id] AND
-                        OU2.[Status] = 2 AND
                         CU2.[Manage] = 1
 	            )
 	            AND NOT EXISTS (