From c88f4064f14140c0acca058ae3d32b161eef674d Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Mon, 9 Oct 2017 14:25:59 -0400 Subject: [PATCH] allow custom size to be passed in --- src/Icons/Controllers/IconsController.cs | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Icons/Controllers/IconsController.cs b/src/Icons/Controllers/IconsController.cs index 1f1ec55144..76f35a1be8 100644 --- a/src/Icons/Controllers/IconsController.cs +++ b/src/Icons/Controllers/IconsController.cs @@ -28,7 +28,7 @@ namespace Bit.Icons.Controllers } [HttpGet("")] - public async Task Get([FromQuery] string domain) + public async Task Get([FromQuery]string domain, [FromQuery]string size = "16..24..200") { if(!domain.StartsWith("http://") || !domain.StartsWith("https://")) { @@ -41,11 +41,12 @@ namespace Bit.Icons.Controllers } var mappedDomain = _domainMappingService.MapDomain(uri.Host); - var icon = await _memoryCache.GetOrCreateAsync(mappedDomain, async entry => + var cacheKey = $"{mappedDomain}_{size}"; + var icon = await _memoryCache.GetOrCreateAsync(cacheKey, async entry => { entry.AbsoluteExpiration = DateTime.UtcNow.AddHours(_iconsSettings.CacheHours); - var iconUrl = $"{_iconsSettings.BestIconBaseUrl}/icon?url={mappedDomain}&size=16..24..200"; + var iconUrl = $"{_iconsSettings.BestIconBaseUrl}/icon?url={mappedDomain}&size={size}"; var response = await _httpClient.GetAsync(iconUrl); if(!response.IsSuccessStatusCode) {