nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-06-30 15:42:48 -05:00
Code Activity

Address Analyzer Warnings (#2078)

Browse Source 
* Address potential errors

* Add tests

* Add clarity

* Run formatting
This commit is contained in:
Justin Baur
2022-06-28 12:17:14 -04:00
committed by GitHub
parent 9ff071e926
commit cc21a04801
5 changed files with 141 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Core/Models/Business/BillingInfo.cs
View File

@ -139,7 +139,6 @@ namespace Bit.Core.Models.Business
{
public BillingInvoice(Invoice inv)
{
Amount = inv.AmountDue / 100M;
Date = inv.Created;
Url = inv.HostedInvoiceUrl;
PdfUrl = inv.InvoicePdf;

7
src/Core/Services/Implementations/AppleIapService.cs
View File

@ -85,15 +85,16 @@ namespace Bit.Core.Services
receipt.ContainsKey("UserId") ? new Guid(receipt["UserId"]) : (Guid?)null);
}
private async Task<AppleReceiptStatus> GetReceiptStatusAsync(string receiptData, bool prod = true,
// Internal for testing
internal async Task<AppleReceiptStatus> GetReceiptStatusAsync(string receiptData, bool prod = true,
int attempt = 0, AppleReceiptStatus lastReceiptStatus = null)
{
try
{
if (attempt > 4)
{
throw new Exception("Failed verifying Apple IAP after too many attempts. Last attempt status: " +
lastReceiptStatus?.Status ?? "null");
throw new Exception(
$"Failed verifying Apple IAP after too many attempts. Last attempt status: {lastReceiptStatus?.Status.ToString() ?? "null"}");
}
var url = string.Format("https://{0}.itunes.apple.com/verifyReceipt", prod ? "buy" : "sandbox");