1
0
mirror of https://github.com/bitwarden/server.git synced 2025-07-01 08:02:49 -05:00

user checks on read procs

This commit is contained in:
Kyle Spearrin
2017-03-21 21:13:20 -04:00
parent ed8d5d69a4
commit d266da1084
8 changed files with 50 additions and 20 deletions

View File

@ -103,12 +103,6 @@ namespace Bit.Core.Services
throw new BadRequestException(nameof(cipher.OrganizationId));
}
var existingCipher = await _cipherRepository.GetByIdAsync(cipher.Id);
if(existingCipher == null || (existingCipher.UserId.HasValue && existingCipher.UserId != userId))
{
throw new NotFoundException();
}
var subvaultUserDetails = await _subvaultUserRepository.GetPermissionsByUserIdAsync(userId, subvaultIds,
cipher.OrganizationId.Value);
@ -117,7 +111,7 @@ namespace Bit.Core.Services
await _cipherRepository.ReplaceAsync(cipher, subvaultUserDetails.Where(s => s.Admin).Select(s => s.SubvaultId));
// push
await _pushService.PushSyncCipherUpdateAsync(cipher);
//await _pushService.PushSyncCipherUpdateAsync(cipher);
}
public async Task ImportCiphersAsync(