nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-04-06 13:38:13 -05:00
Code

Check for ascii-only in entire local part of emails (#2072)

Browse Source
This commit is contained in:
Matt Gibson 2022-06-22 17:51:16 -05:00 committed by GitHub
parent f2a02e040c
commit d918f5aae3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/Utilities/StrictEmailAddressAttribute.cs
View File

@ -41,7 +41,7 @@ namespace Bit.Core.Utilities
* Must end in a letter (including unicode) * Must end in a letter (including unicode)
See the unit tests for examples of what is allowed. See the unit tests for examples of what is allowed.
**/ **/
var emailFormat = @"[\x00-\x7F]+@.+\.\p{L}+$"; var emailFormat = @"^[\x00-\x7F]+@.+\.\p{L}+$";
if (!Regex.IsMatch(emailAddress, emailFormat)) if (!Regex.IsMatch(emailAddress, emailFormat))
{ {
return false; return false;

3
test/Core.Test/Utilities/StrictEmailAddressAttributeTests.cs
View File

@ -45,7 +45,8 @@ namespace Bit.Core.Test.Utilities
[InlineData("hellothere@.worldcom")] // domain beginning with dot [InlineData("hellothere@.worldcom")] // domain beginning with dot
[InlineData("hellothere@worldcom.")] // domain ending in dot [InlineData("hellothere@worldcom.")] // domain ending in dot
[InlineData("hellothere@world.com-")] // domain ending in hyphen [InlineData("hellothere@world.com-")] // domain ending in hyphen
[InlineData("héllö@world.com")] // unicode in local-part [InlineData("hellö@world.com")] // unicode at end of local-part
[InlineData("héllo@world.com")] // unicode in middle of local-part
public void IsValid_ReturnsFalseWhenInvalid(string email) public void IsValid_ReturnsFalseWhenInvalid(string email)
{ {
var sut = new StrictEmailAddressAttribute(); var sut = new StrictEmailAddressAttribute();