nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-05-23 04:21:05 -05:00
Code

use temp tables for better execution plans

Browse Source
This commit is contained in:
Kyle Spearrin 2018-06-12 13:24:13 -04:00
parent 74874a1c38
commit ebb1f9e1a8
3 changed files with 157 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/Sql/dbo/Stored Procedures/Organization_UpdateStorage.sql
View File

@ -6,6 +6,22 @@ BEGIN
DECLARE @Storage BIGINT DECLARE @Storage BIGINT
CREATE TABLE #Temp
(
[Id] UNIQUEIDENTIFIER NOT NULL,
[Attachments] VARCHAR(MAX) NULL
)
INSERT INTO #Temp
SELECT
[Id],
[Attachments]
FROM
[dbo].[Cipher]
WHERE
[UserId] IS NULL
AND [OrganizationId] = @Id
;WITH [CTE] AS ( ;WITH [CTE] AS (
SELECT SELECT
[Id], [Id],
@ -16,17 +32,14 @@ BEGIN
OPENJSON([Attachments]) OPENJSON([Attachments])
) [Size] ) [Size]
FROM FROM
[dbo].[Cipher] #Temp
) )
SELECT SELECT
@Storage = SUM([CTE].[Size]) @Storage = SUM([Size])
FROM FROM
[dbo].[Cipher] C [CTE]
LEFT JOIN
[CTE] ON C.[Id] = [CTE].[Id] DROP TABLE #Temp
WHERE
C.[UserId] IS NULL
AND C.[OrganizationId] = @Id
UPDATE UPDATE
[dbo].[Organization] [dbo].[Organization]

25
src/Sql/dbo/Stored Procedures/User_UpdateStorage.sql
View File

@ -6,6 +6,21 @@ BEGIN
DECLARE @Storage BIGINT DECLARE @Storage BIGINT
CREATE TABLE #Temp
(
[Id] UNIQUEIDENTIFIER NOT NULL,
[Attachments] VARCHAR(MAX) NULL
)
INSERT INTO #Temp
SELECT
[Id],
[Attachments]
FROM
[dbo].[Cipher]
WHERE
[UserId] = @Id
;WITH [CTE] AS ( ;WITH [CTE] AS (
SELECT SELECT
[Id], [Id],
@ -16,16 +31,14 @@ BEGIN
OPENJSON([Attachments]) OPENJSON([Attachments])
) [Size] ) [Size]
FROM FROM
[dbo].[Cipher] #Temp
) )
SELECT SELECT
@Storage = SUM([CTE].[Size]) @Storage = SUM([CTE].[Size])
FROM FROM
[dbo].[Cipher] C [CTE]
LEFT JOIN
[CTE] ON C.[Id] = [CTE].[Id] DROP TABLE #Temp
WHERE
C.[UserId] = @Id
UPDATE UPDATE
[dbo].[User] [dbo].[User]

117
util/Setup/DbScripts/2018-06-11_00_WebVaultUpdates.sql
View File

@ -47,3 +47,120 @@ BEGIN
) )
END END
GO GO
IF OBJECT_ID('[dbo].[Organization_UpdateStorage]') IS NOT NULL
BEGIN
DROP PROCEDURE [dbo].[Organization_UpdateStorage]
END
GO
CREATE PROCEDURE [dbo].[Organization_UpdateStorage]
@Id UNIQUEIDENTIFIER
AS
BEGIN
SET NOCOUNT ON
DECLARE @Storage BIGINT
CREATE TABLE #Temp
(
[Id] UNIQUEIDENTIFIER NOT NULL,
[Attachments] VARCHAR(MAX) NULL
)
INSERT INTO #Temp
SELECT
[Id],
[Attachments]
FROM
[dbo].[Cipher]
WHERE
[UserId] IS NULL
AND [OrganizationId] = @Id
;WITH [CTE] AS (
SELECT
[Id],
(
SELECT
SUM(CAST(JSON_VALUE(value,'$.Size') AS BIGINT))
FROM
OPENJSON([Attachments])
) [Size]
FROM
#Temp
)
SELECT
@Storage = SUM([Size])
FROM
[CTE]
DROP TABLE #Temp
UPDATE
[dbo].[Organization]
SET
[Storage] = @Storage,
[RevisionDate] = GETUTCDATE()
WHERE
[Id] = @Id
END
GO
IF OBJECT_ID('[dbo].[User_UpdateStorage]') IS NOT NULL
BEGIN
DROP PROCEDURE [dbo].[User_UpdateStorage]
END
GO
CREATE PROCEDURE [dbo].[User_UpdateStorage]
@Id UNIQUEIDENTIFIER
AS
BEGIN
SET NOCOUNT ON
DECLARE @Storage BIGINT
CREATE TABLE #Temp
(
[Id] UNIQUEIDENTIFIER NOT NULL,
[Attachments] VARCHAR(MAX) NULL
)
INSERT INTO #Temp
SELECT
[Id],
[Attachments]
FROM
[dbo].[Cipher]
WHERE
[UserId] = @Id
;WITH [CTE] AS (
SELECT
[Id],
(
SELECT
SUM(CAST(JSON_VALUE(value,'$.Size') AS BIGINT))
FROM
OPENJSON([Attachments])
) [Size]
FROM
#Temp
)
SELECT
@Storage = SUM([CTE].[Size])
FROM
[CTE]
DROP TABLE #Temp
UPDATE
[dbo].[User]
SET
[Storage] = @Storage,
[RevisionDate] = GETUTCDATE()
WHERE
[Id] = @Id
END
GO