nhyatt/bitwarden
1
0
Fork 0
mirror of https://github.com/bitwarden/server.git synced 2025-06-29 15:16:15 -05:00
Code

docs: fixing spelling and docs for GetManyPendingAuthRequest

Browse Source
This commit is contained in:
Ike Kottlowski 2025-06-26 18:00:30 -04:00
parent 093157324e
commit eeeaefe220
No known key found for this signature in database
GPG Key ID: C86308E3DCA6D76F
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/Auth/Repositories/IAuthRequestRepository.cs
View File

@ -14,7 +14,7 @@ public interface IAuthRequestRepository : IRepository<AuthRequest, Guid>
/// device. It will be the most current request for the device. /// device. It will be the most current request for the device.
/// </summary> /// </summary>
/// <param name="userId">UserId of the owner of the AuthRequests</param> /// <param name="userId">UserId of the owner of the AuthRequests</param>
/// <returns>a collection Auth request details or null</returns> /// <returns>a collection Auth request details or empty</returns>
Task<IEnumerable<PendingAuthRequestDetails>> GetManyPendingAuthRequestByUserId(Guid userId); Task<IEnumerable<PendingAuthRequestDetails>> GetManyPendingAuthRequestByUserId(Guid userId);
Task<ICollection<OrganizationAdminAuthRequest>> GetManyPendingByOrganizationIdAsync(Guid organizationId); Task<ICollection<OrganizationAdminAuthRequest>> GetManyPendingByOrganizationIdAsync(Guid organizationId);
Task<ICollection<OrganizationAdminAuthRequest>> GetManyAdminApprovalRequestsByManyIdsAsync(Guid organizationId, IEnumerable<Guid> ids); Task<ICollection<OrganizationAdminAuthRequest>> GetManyAdminApprovalRequestsByManyIdsAsync(Guid organizationId, IEnumerable<Guid> ids);

6
test/Infrastructure.IntegrationTest/Auth/Repositories/AuthRequestRepositoryTests.cs
View File

@ -184,7 +184,7 @@ public class AuthRequestRepositoryTests
/// Test to determine that when no valid authRequest exists in the database the return value is null. /// Test to determine that when no valid authRequest exists in the database the return value is null.
/// </summary> /// </summary>
[DatabaseTheory, DatabaseData] [DatabaseTheory, DatabaseData]
public async Task GetManyPendingAuthRequestByUserId_AuthRequstsInvalid_ReturnsEmptyEnumerable_Success( public async Task GetManyPendingAuthRequestByUserId_AuthRequestsInvalid_ReturnsEmptyEnumerable_Success(
IAuthRequestRepository authRequestRepository, IAuthRequestRepository authRequestRepository,
IUserRepository userRepository) IUserRepository userRepository)
{ {
@ -227,7 +227,7 @@ public class AuthRequestRepositoryTests
Assert.NotNull(result); Assert.NotNull(result);
Assert.Empty(result); Assert.Empty(result);
// Verify that there are authrequest associated with the user. // Verify that there are authRequests associated with the user.
Assert.NotEmpty(await authRequestRepository.GetManyByUserIdAsync(user.Id)); Assert.NotEmpty(await authRequestRepository.GetManyByUserIdAsync(user.Id));
await CleanupTestAsync(authRequests, authRequestRepository); await CleanupTestAsync(authRequests, authRequestRepository);
@ -269,7 +269,7 @@ public class AuthRequestRepositoryTests
var result = await authRequestRepository.GetManyPendingAuthRequestByUserId(user.Id); var result = await authRequestRepository.GetManyPendingAuthRequestByUserId(user.Id);
Assert.NotNull(result); Assert.NotNull(result);
// since we group by device there should only be a sinlge return since the device Id is the same // since we group by device there should only be a single return since the device Id is the same
Assert.Single(result); Assert.Single(result);
var resultAuthRequest = result.First(); var resultAuthRequest = result.First();
Assert.Equal(oneMinuteOldAuthRequest.Id, resultAuthRequest.Id); Assert.Equal(oneMinuteOldAuthRequest.Id, resultAuthRequest.Id);