1
0
mirror of https://github.com/bitwarden/server.git synced 2025-07-02 16:42:50 -05:00

Script best practices

This commit is contained in:
Matt Bishop
2024-01-04 15:18:33 -05:00
parent 49a645318c
commit fac2a06b3d

View File

@ -7,19 +7,8 @@ BEGIN
END END
GO GO
-- Recreate View -- Refresh View
IF OBJECT_ID('[dbo].[SendView]') IS NOT NULL EXECUTE sp_refreshview N'[dbo].[{SendView}]'
BEGIN
DROP VIEW [dbo].[SendView]
END
GO
CREATE VIEW [dbo].[SendView]
AS
SELECT
*
FROM
[dbo].[Send]
GO GO
CREATE OR ALTER PROCEDURE [dbo].[Send_Create] CREATE OR ALTER PROCEDURE [dbo].[Send_Create]
@ -44,7 +33,7 @@ BEGIN
SET NOCOUNT ON SET NOCOUNT ON
INSERT INTO [dbo].[Send] INSERT INTO [dbo].[Send]
( (
[Id], [Id],
[UserId], [UserId],
[OrganizationId], [OrganizationId],
@ -61,25 +50,25 @@ BEGIN
[Disabled], [Disabled],
[HideEmail], [HideEmail],
[CipherId] [CipherId]
) )
VALUES VALUES
( (
@Id, @Id,
@UserId, @UserId,
@OrganizationId, @OrganizationId,
@Type, @Type,
@Data, @Data,
@Key, @Key,
@Password, @Password,
@MaxAccessCount, @MaxAccessCount,
@AccessCount, @AccessCount,
@CreationDate, @CreationDate,
@RevisionDate, @RevisionDate,
@ExpirationDate, @ExpirationDate,
@DeletionDate, @DeletionDate,
@Disabled, @Disabled,
@HideEmail, @HideEmail,
@CipherId @CipherId
) )
IF @UserId IS NOT NULL IF @UserId IS NOT NULL
@ -90,7 +79,7 @@ BEGIN
END END
EXEC [dbo].[User_BumpAccountRevisionDate] @UserId EXEC [dbo].[User_BumpAccountRevisionDate] @UserId
END END
-- TODO: OrganizationId bump? -- TODO: OrganizationId bump?
END END
GO GO
@ -140,6 +129,6 @@ BEGIN
BEGIN BEGIN
EXEC [dbo].[User_BumpAccountRevisionDate] @UserId EXEC [dbo].[User_BumpAccountRevisionDate] @UserId
END END
-- TODO: OrganizationId bump? -- TODO: OrganizationId bump?
END END
GO GO