From fcdac6415abf12ceadccc50cab3b55e5c55163f9 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Thu, 25 Jul 2019 16:29:34 -0400
Subject: [PATCH] cache ciphers on events lookup

---
 src/Events/Controllers/CollectController.cs | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/Events/Controllers/CollectController.cs b/src/Events/Controllers/CollectController.cs
index 211efcf359..06ceaaaa80 100644
--- a/src/Events/Controllers/CollectController.cs
+++ b/src/Events/Controllers/CollectController.cs
@@ -40,6 +40,7 @@ namespace Bit.Events.Controllers
                 return new BadRequestResult();
             }
             var cipherEvents = new List<Tuple<Cipher, EventType, DateTime?>>();
+            var ciphersCache = new Dictionary<Guid, Cipher>();
             foreach(var eventModel in model)
             {
                 switch(eventModel.Type)
@@ -61,12 +62,24 @@ namespace Bit.Events.Controllers
                         {
                             continue;
                         }
-                        var cipher = await _cipherRepository.GetByIdAsync(eventModel.CipherId.Value,
-                            _currentContext.UserId.Value);
+                        Cipher cipher = null;
+                        if(ciphersCache.ContainsKey(eventModel.CipherId.Value))
+                        {
+                            cipher = ciphersCache[eventModel.CipherId.Value];
+                        }
+                        else
+                        {
+                            cipher = await _cipherRepository.GetByIdAsync(eventModel.CipherId.Value,
+                               _currentContext.UserId.Value);
+                        }
                         if(cipher == null)
                         {
                             continue;
                         }
+                        if(!ciphersCache.ContainsKey(eventModel.CipherId.Value))
+                        {
+                            ciphersCache.Add(eventModel.CipherId.Value, cipher);
+                        }
                         cipherEvents.Add(new Tuple<Cipher, EventType, DateTime?>(cipher, eventModel.Type, eventModel.Date));
                         break;
                     default: