1
0
mirror of https://github.com/bitwarden/server.git synced 2025-06-19 18:38:03 -05:00

982 Commits

Author SHA1 Message Date
Bernd Schoolmann
ee26bc55dc
Add test 2025-06-19 16:58:58 +02:00
Bernd Schoolmann
51dcc1f02a
Attempt to fix tests 2025-06-19 16:42:52 +02:00
Bernd Schoolmann
129e29150f
Fix build of integration tests 2025-06-19 16:25:04 +02:00
Bernd Schoolmann
91d68f1481
Merge branch 'km/signing-api-changes' into km/signing-upgrade-rotation 2025-06-19 16:21:31 +02:00
Bernd Schoolmann
4925baf41b
Fix tests 2025-06-19 16:03:31 +02:00
Bernd Schoolmann
55fa54c7b4
Fix tests 2025-06-19 16:00:20 +02:00
Bernd Schoolmann
49c130f91f
Merge branch 'km/feature-signing-keys' into km/signing-api-changes 2025-06-18 20:07:01 +02:00
Bernd Schoolmann
2b3d92b789
[PM-21034] Database changes for signature keypairs (#5906)
* Add signing key repositories, models, and sql migration scripts

* Rename UserSigningKeys table to UserSigningKey

* Rename signedpublickeyownershipclaim to signedpublickey

* Move signedPublicKey to last parameter

* Add newline at end of file

* Rename to signature key pair

* Further rename to signaturekeypair

* Rename to UserSignatureKeyPairRepository

* Add newline

* Rename more instances to UserSignatureKeyPair

* Update parameter order

* Fix order

* Add more renames

* Cleanup

* Fix sql

* Add ef migrations

* Fix difference in SQL SP compared to migration SP

* Fix difference in SQL SP vs migration

* Fix difference in SQL SP vs migration

* Attempt to fix sql

* Rename migration to start later

* Address feedback

* Move UserSignatureKeyPair to KM codeownership

* Fix build

* Fix build

* Fix build

* Move out entitytypeconfiguration

* Use view for reading usersignaturekeypairs

* Fix migration script

* Fix migration script

* Drop view if exists

* Enable nullable

* Replace with create or alter view

* Switch go generatecomb

* Switch to generatecomb

* Move signature algorithm

* Move useresignaturekeypairentitytypeconfiguration to km ownership

* Move userSignatureKeyPair model

* Unswap file names

* Move sql files to km ownership

* Add index on userid for signature keys

* Fix wrong filename

* Remove string length limit

* Regenerate EF migrations

* Undo changes to program.cs

* Update util/Migrator/DbScripts/2025-06-01_00_AddSignatureKeyPairTable.sql

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update util/Migrator/DbScripts/2025-06-01_00_AddSignatureKeyPairTable.sql

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update util/Migrator/DbScripts/2025-06-01_00_AddSignatureKeyPairTable.sql

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Update util/Migrator/DbScripts/2025-06-01_00_AddSignatureKeyPairTable.sql

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

* Rename dbset to plural

* Update src/Infrastructure.EntityFramework/KeyManagement/Repositories/UserSignatureKeyPairRepository.cs

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>

---------

Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com>
2025-06-18 20:02:55 +02:00
Brant DeBow
502ab4b645
[PM-17562] Fix flickering unit test - WebhookIntegrationHandlerTests (#5973)
* [PM-17562] Fix flickering unit test - WebhookIntegrationHandlerTests

* Adjust to using TimeProvider and exact time matches

* Refactored RabittMqIntegrationListenerService and Tests to align on TimeProvider. Cleaned up tests that do not need to use DateTime.UtcNow
2025-06-18 10:09:47 -04:00
Justin Baur
6800bc57f3
[PM-18555] Main part of notifications refactor (#5757)
* More tests

* More  tests

* Add non-guid tests

* Introduce slimmer services

* Implement IPushEngine on services

* Implement IPushEngine

* Fix tests

* Format

* Switch to `Guid` on `PushSendRequestModel`

* Remove TODOs
2025-06-17 13:30:56 -04:00
✨ Audrey ✨
a3c5741164
[PM-22610] validate file within max length; log deletion of invalid uploads (#5960) 2025-06-17 15:07:26 +00:00
Alexey Zilber
17507446a4
Added SendGridApiHost to Globals (#5961)
* Added SendGridApiHost to Globals

* Added SendGridApiHost for test coverage
2025-06-17 21:35:38 +08:00
Brant DeBow
a529492d1d
[PM-17562] Update documentation for event integrations (#5924)
* [PM-17562] Update documentation for event integrations

* Fix SonarQube suggestion, bring ASB event listener in line with integration listener

* Apply suggestions from code review

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>

* Updates to README - PR fixes, additional context, tense alignment

* Fix the formatting for inlined code snippets

* Add links to different sections; remove inline code formatting in favor of single bacticks for JSON

---------

Co-authored-by: Matt Bishop <mbishop@bitwarden.com>
2025-06-17 08:38:16 -04:00
Rui Tomé
5ffa937914
[PM-22098] Create default collection when organization member is confirmed (#5944)
* Add RequiresDefaultCollection method to PersonalOwnershipPolicyRequirement

* Add CreateDefaultLocation feature flag to Constants.cs

* Add DefaultUserCollectionName property to OrganizationUserConfirmRequestModel with encryption attributes

* Update PersonalOwnershipPolicyRequirement instantiation in tests to use constructor with parameters instead of property assignment

* Enhance ConfirmOrganizationUserCommand to support default user collection creation. Added logic to check if a default collection is required based on organization policies and feature flags. Updated ConfirmUserAsync method signature to include an optional defaultUserCollectionName parameter. Added corresponding tests to validate the new functionality.

* Refactor Confirm method in OrganizationUsersController to use Guid parameters directly, simplifying the code. Updated ConfirmUserAsync call to include DefaultUserCollectionName from the input model.

* Move logic for handling confirmation side effects into a separate method

* Refactor PersonalOwnershipPolicyRequirement to use enum for ownership state

- Introduced PersonalOwnershipState enum to represent allowed and restricted states.
- Updated PersonalOwnershipPolicyRequirement constructor and properties to utilize the new enum.
- Modified related classes and tests to reflect changes in ownership state handling.
2025-06-17 12:20:22 +01:00
Bernd Schoolmann
66333061a2
Fix namespace 2025-06-16 11:17:13 +02:00
Bernd Schoolmann
16f69887ad
Merge branch 'km/signing-api-changes' into km/signing-upgrade-rotation 2025-06-16 11:05:23 +02:00
Bernd Schoolmann
e0a6fd7af6
Merge branch 'km/db-signing-keys' into km/signing-api-changes 2025-06-16 09:43:02 +02:00
Bernd Schoolmann
35b6816888
Merge branch 'main' into km/db-signing-keys 2025-06-16 09:41:25 +02:00
Jimmy Vo
4a12120950
[PM-19703] Fix admin count logic to exclude current organization (#5918) 2025-06-13 16:27:48 -04:00
Bernd Schoolmann
a3b9bfc9ea
Add test 2025-06-12 21:32:39 +02:00
Bernd Schoolmann
6f3471e658
Fix tests 2025-06-12 16:42:04 +02:00
Bernd Schoolmann
22888a5928
Fix build 2025-06-12 16:01:30 +02:00
Bernd Schoolmann
12636bfb35
Fix test 2025-06-12 15:53:35 +02:00
Jared McCannon
66a89245f9
[PM-20590] Correcting error provided when scaling provider org (#5951)
* Moved provider org check above organization stripe id checks.
2025-06-12 08:48:15 -05:00
Thomas Rittson
64b288035c
Chore: document SutProvider and clean up UserServiceTests (#5879)
* UserServiceTests - use builder pattern for SutProvider to reduce boilerplate
* SutProvider - add xmldoc
2025-06-12 10:21:05 +01:00
Jimmy Vo
821f66e99f
[PM-22205] Fix logic for sending out revoked email (#5933) 2025-06-11 16:55:42 -04:00
cyprain-okeke
a618f97234
[PM 20621]Update error message when lowering seat count (#5836)
* implement the seat decrease error message

* Resolve the comment regarding abstraction

* Resolved the database failure

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing upgrade test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Removed the unused method

* Remove the total calculation from the stored procedure

* Refactoring base on pr feedback

* Refactoring base on pr feedback

* Resolve the fauiling database

* Resolve the failing database test

* Resolve the database test

* Remove duplicate migrations

* resolve the failing test

* Removed the unneeded change

* remove this file

* Reverted Deleted migration

* revert the added space

* resolve the stored procedure name

* Rename the migration name

* Updated the stored procedure name

* Revert the changes on the sproc

* Revert unrelated changes

* Remove the unused method

* improved the xmldoc

* Add an integration testing

* Add the use of helper test class

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* Resolve the failing test

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

* remove object look up

* Resolve message rollback

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>

---------

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
2025-06-11 14:03:45 +01:00
Graham Walker
4277f435ab
PM-22564 Fix Namespaces from Tools to Dirt (#5947)
* PM-22564 fixing namespaces

* PM-22564 fixing namespace in integration test

* PM-22564 fixing .sqlproj file
2025-06-10 12:36:49 -05:00
Rui Tomé
021e69bc5d
[PM-17154] Limit item deletion feature flag logic removal (#5925)
* Refactor CiphersController and related tests by removing unused IFeatureService dependency and associated feature flag checks. Cleaned up tests to reflect these changes, ensuring they focus on manage permissions without reliance on feature flags.

* Refactor CipherService and related tests by removing feature flag checks for item deletion permissions. Updated tests to focus on user manage permissions without reliance on feature flags, ensuring cleaner and more maintainable code.

* Enhance CiphersControllerTests by adding user retrieval and organization ability checks. Updated test cases to ensure proper handling of item deletion permissions based on user roles and organization settings, improving test coverage and reliability.
2025-06-10 09:57:29 +01:00
renovate[bot]
88ffc91b99
[deps] Billing: Update coverlet.collector to 6.0.4 (#5720)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-06-09 10:49:41 -05:00
Bernd Schoolmann
599918096d
Fix tests and errors 2025-06-09 15:04:00 +02:00
Bernd Schoolmann
ac06fe7c75
Add test 2025-06-09 14:54:30 +02:00
Bernd Schoolmann
06d8de67c5
Fix test 2025-06-09 14:48:14 +02:00
Bernd Schoolmann
18c562db6f
Fix tests 2025-06-09 14:41:04 +02:00
Bernd Schoolmann
ee857ed0e5
Fix tests 2025-06-09 14:35:15 +02:00
Bernd Schoolmann
c305af7ed6
Add error message validation 2025-06-09 14:27:58 +02:00
Bernd Schoolmann
0675505f3c
Add tests 2025-06-09 14:25:05 +02:00
Bernd Schoolmann
8bbdd7fe30
Improve tests 2025-06-09 14:14:09 +02:00
Bernd Schoolmann
cc68b91188
Fix tests 2025-06-09 12:36:02 +02:00
Bernd Schoolmann
3c0ca482a9
Apply fixes 2025-06-09 11:55:52 +02:00
Bernd Schoolmann
c1db8d0c1f
Fix test 2025-06-09 11:28:32 +02:00
Bernd Schoolmann
b19dc19db9
Fix test 2025-06-09 10:52:18 +02:00
Bernd Schoolmann
477053f78b
Cleanup 2025-06-09 10:29:50 +02:00
Bernd Schoolmann
1cf8c7865e
Fix build 2025-06-06 17:39:21 +02:00
Bernd Schoolmann
7900bcbfb3
Merge branch 'km/db-signing-keys' into km/signing-api-changes 2025-06-06 14:46:49 +02:00
Bernd Schoolmann
7b16459a83
Merge branch 'main' into km/db-signing-keys 2025-06-06 14:15:20 +02:00
Ben Bryant
20d3911b80
[PM-22380] Enable NRT for some Core project files (#5912)
* Enable NRT for Core/Jobs files

* Enable NRT for Core/HostedServices files

* Enable NRT for Core/Exceptions files

* Enable NRT for Core/NotificationHub files

---------

Co-authored-by: Bernd Schoolmann <mail@quexten.com>
2025-06-06 13:59:57 +02:00
Bernd Schoolmann
f7c85b2aa4
Fix test 2025-06-06 00:37:26 +02:00
Bernd Schoolmann
aa12012746
Fix tests 2025-06-06 00:21:59 +02:00
Bernd Schoolmann
5ff9f856a2
Attempt to fix tests 2025-06-05 19:37:03 +02:00