52ae10fd50
[AC-1139] Unit tests refactors and added tests
2023-11-01 16:03:08 +00:00
db19d143ed
Merge branch 'master' into flexible-collections/deprecate-custom-collection-perm
...
# Conflicts:
# src/Api/Controllers/CollectionsController.cs
# src/Api/Utilities/ServiceCollectionExtensions.cs
# src/Api/Vault/AuthorizationHandlers/Collections/CollectionAuthorizationHandler.cs
# src/Api/Vault/AuthorizationHandlers/Collections/CollectionOperations.cs
# src/Core/Context/CurrentContext.cs
# src/Core/Services/Implementations/CollectionService.cs
# src/Core/Services/Implementations/OrganizationService.cs
# test/Api.Test/Controllers/CollectionsControllerTests.cs
# test/Api.Test/Vault/AuthorizationHandlers/CollectionAuthorizationHandlerTests.cs
# test/Core.Test/Services/CollectionServiceTests.cs
2023-11-01 12:05:19 +00:00
da4a86c643
[AC-1373] Flexible Collections ( #3245 )
...
* [AC-1117] Add manage permission (#3126 )
* Update sql files to add Manage permission
* Add migration script
* Rename collection manage migration file to remove duplicate migration date
* Migrations
* Add manage to models
* Add manage to repository
* Add constraint to Manage columns
* Migration lint fixes
* Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
* Add missing manage fields
* Add 'Manage' to UserCollectionDetails
* Use CREATE OR ALTER where possible
* [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145 )
* feat: update org table with new column, write migration, refs AC-1374
* feat: update views with new column, refs AC-1374
* feat: Alter sprocs (org create/update) to include new column, refs AC-1374
* feat: update entity/data/request/response models to handle new column, refs AC-1374
* feat: update necessary Provider related views during migration, refs AC-1374
* fix: update org create to default new column to false, refs AC-1374
* feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
* fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: add ef migrations to reflect mssql changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
* fix: merge conflict resolution
* [AC-1174] CollectionUser and CollectionGroup authorization handlers (#3194 )
* [AC-1174] Introduce BulkAuthorizationHandler.cs
* [AC-1174] Introduce CollectionUserAuthorizationHandler
* [AC-1174] Add CreateForNewCollection CollectionUser requirement
* [AC-1174] Add some more details to CollectionCustomization
* [AC-1174] Formatting
* [AC-1174] Add CollectionGroupOperation.cs
* [AC-1174] Introduce CollectionGroupAuthorizationHandler.cs
* [AC-1174] Cleanup CollectionFixture customization
Implement and use re-usable extension method to support seeded Guids
* [AC-1174] Introduce WithValueFromList AutoFixtureExtensions
Modify CollectionCustomization to use multiple organization Ids for auto generated test data
* [AC-1174] Simplify CollectionUserAuthorizationHandler.cs
Modify the authorization handler to only perform authorization logic. Validation logic will need to be handled by any calling commands/controllers instead.
* [AC-1174] Introduce shared CollectionAccessAuthorizationHandlerBase
A shared base authorization handler was created for both CollectionUser and CollectionGroup resources, as they share the same underlying management authorization logic.
* [AC-1174] Update CollectionUserAuthorizationHandler and CollectionGroupAuthorizationHandler to use the new CollectionAccessAuthorizationHandlerBase class
* [AC-1174] Formatting
* [AC-1174] Cleanup typo and redundant ToList() call
* [AC-1174] Add check for provider users
* [AC-1174] Reduce nested loops
* [AC-1174] Introduce ICollectionAccess.cs
* [AC-1174] Remove individual CollectionGroup and CollectionUser auth handlers and use base class instead
* [AC-1174] Tweak unit test to fail minimally
* [AC-1174] Reorganize authorization handlers in Core project
* [AC-1174] Introduce new AddCoreAuthorizationHandlers() extension method
* [AC-1174] Move CollectionAccessAuthorizationHandler into Api project
* [AC-1174] Move CollectionFixture to Vault folder
* [AC-1174] Rename operation to CreateUpdateDelete
* [AC-1174] Require single organization for collection access authorization handler
- Add requirement that all target collections must belong to the same organization
- Simplify logic related to multiple organizations
- Update tests and helpers
- Use ToHashSet to improve lookup time
* [AC-1174] Fix null reference exception
* [AC-1174] Throw bad request exception when collections belong to different organizations
* [AC-1174] Switch to CollectionAuthorizationHandler instead of CollectionAccessAuthorizationHandler to reduce complexity
* Fix improper merge conflict resolution
* fix: add permission check for collection management api, refs AC-1647 (#3252 )
* [AC-1125] Enforce org setting for creating/deleting collections (#3241 )
* [AC-1117] Add manage permission (#3126 )
* Update sql files to add Manage permission
* Add migration script
* Rename collection manage migration file to remove duplicate migration date
* Migrations
* Add manage to models
* Add manage to repository
* Add constraint to Manage columns
* Migration lint fixes
* Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
* Add missing manage fields
* Add 'Manage' to UserCollectionDetails
* Use CREATE OR ALTER where possible
* [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145 )
* feat: update org table with new column, write migration, refs AC-1374
* feat: update views with new column, refs AC-1374
* feat: Alter sprocs (org create/update) to include new column, refs AC-1374
* feat: update entity/data/request/response models to handle new column, refs AC-1374
* feat: update necessary Provider related views during migration, refs AC-1374
* fix: update org create to default new column to false, refs AC-1374
* feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
* fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: add ef migrations to reflect mssql changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
* feat: created collection auth handler/operations, added LimitCollectionCdOwnerAdmin to CurrentContentOrganization, refs AC-1125
* feat: create vault service collection extensions and register with base services, refs AC-1125
* feat: deprecated CurrentContext.CreateNewCollections, refs AC-1125
* feat: deprecate DeleteAnyCollection for single resource usages, refs AC-1125
* feat: move service registration to api, update references, refs AC-1125
* feat: add bulk delete authorization handler, refs AC-1125
* feat: always assign user and give manage access on create, refs AC-1125
* fix: updated CurrentContextOrganization type, refs AC-1125
* feat: combined existing collection authorization handlers/operations, refs AC-1125
* fix: OrganizationServiceTests -> CurrentContentOrganization typo, refs AC-1125
* fix: format, refs AC-1125
* fix: update collection controller tests, refs AC-1125
* fix: dotnet format, refs AC-1125
* feat: removed extra BulkAuthorizationHandler, refs AC-1125
* fix: dotnet format, refs AC-1125
* fix: change string to guid for org id, update bulk delete request model, refs AC-1125
* fix: remove delete many collection check, refs AC-1125
* fix: clean up collection auth handler, refs AC-1125
* fix: format fix for CollectionOperations, refs AC-1125
* fix: removed unnecessary owner check, add org null check to custom permission validation, refs AC-1125
* fix: remove unused methods in CurrentContext, refs AC-1125
* fix: removed obsolete test, fixed failling delete many test, refs AC-1125
* fix: CollectionAuthorizationHandlerTests fixes, refs AC-1125
* fix: OrganizationServiceTests fix broken test by mocking GetOrganization, refs AC-1125
* fix: CollectionAuthorizationHandler - remove unused repository, refs AC-1125
* feat: moved UserId null check to common method, refs AC-1125
* fix: updated auth handler tests to remove dependency on requirement for common code checks, refs AC-1125
* feat: updated conditionals/comments for create/delete methods within colleciton auth handler, refs AC-1125
* feat: added create/delete collection auth handler success methods, refs AC-1125
* fix: new up permissions to prevent excessive null checks, refs AC-1125
* fix: remove old reference to CreateNewCollections, refs AC-1125
* fix: typo within ViewAssignedCollections method, refs AC-1125
---------
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com >
* refactor: remove organizationId from CollectionBulkDeleteRequestModel, refs AC-1649 (#3282 )
* [AC-1174] Bulk Collection Management (#3229 )
* [AC-1174] Update SelectionReadOnlyRequestModel to use Guid for Id property
* [AC-1174] Introduce initial bulk-access collection endpoint
* [AC-1174] Introduce BulkAddCollectionAccessCommand and validation logic/tests
* [AC-1174] Add CreateOrUpdateAccessMany method to CollectionRepository
* [AC-1174] Add event logs for bulk add collection access command
* [AC-1174] Add User_BumpAccountRevisionDateByCollectionIds and database migration script
* [AC-1174] Implement EF repository method
* [AC-1174] Improve null checks
* [AC-1174] Remove unnecessary BulkCollectionAccessRequestModel helpers
* [AC-1174] Add unit tests for new controller endpoint
* [AC-1174] Fix formatting
* [AC-1174] Remove comment
* [AC-1174] Remove redundant organizationId parameter
* [AC-1174] Ensure user and group Ids are distinct
* [AC-1174] Cleanup tests based on PR feedback
* [AC-1174] Formatting
* [AC-1174] Update CollectionGroup alias in the sproc
* [AC-1174] Add some additional comments to SQL sproc
* [AC-1174] Add comment explaining additional SaveChangesAsync call
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com >
* [AC-1646] Rename LimitCollectionCdOwnerAdmin column (#3300 )
* Rename LimitCollectionCdOwnerAdmin -> LimitCollectionCreationDeletion
* Rename and bump migration script
* [AC-1666] Removed EditAnyCollection from Create/Delete permission checks (#3301 )
* fix: remove EditAnyCollection from Create/Delete permission check, refs AC-1666
* fix: updated comment, refs AC-1666
* [AC-1669] Bug - Remove obsolete assignUserId from CollectionService.SaveAsync(...) (#3312 )
* fix: remove AssignUserId from CollectionService.SaveAsync, refs AC-1669
* fix: add manage access conditional before creating collection, refs AC-1669
* fix: move access logic for create/update, fix all tests, refs AC-1669
* fix: add CollectionAccessSelection fixture, update tests, update bad reqeuest message, refs AC-1669
* fix: format, refs AC-1669
* fix: update null params with specific arg.is null checks, refs Ac-1669
* fix: update attribute class name, refs AC-1669
* [AC-1713] [Flexible collections] Add feature flags to server (#3334 )
* Add feature flags for FlexibleCollections and BulkCollectionAccess
* Flag new routes and behaviour
---------
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com >
* Add joint codeownership for auth handlers (#3346 )
* [AC-1717] Update default values for LimitCollectionCreationDeletion (#3365 )
* Change default value in organization create sproc to 1
* Drop old column name still present in some QA instances
* Set LimitCollectionCreationDeletion value in code based on feature flag
* Fix: add missing namespace after merging in master
* Fix: add missing namespace after merging in master
* [AC-1683] Fix DB migrations for new Manage permission (#3307 )
* [AC-1683] Update migration script and introduce V2 procedures and types
* [AC-1683] Update repository calls to use new V2 procedures / types
* [AC-1684] Update bulk add collection migration script to use new V2 type
* [AC-1683] Undo Manage changes to more original procedures
* [AC-1683] Restore whitespace changes
* [AC-1683] Clarify comments regarding explicit column lists
* [AC-1683] Update migration script dates
* [AC-1683] Split the migration script for readability
* [AC-1683] Re-name SelectReadOnlyArray_V2 to CollectionAccessSelectionType
* [AC-1648] [Flexible Collections] Bump migration scripts before feature branch merge (#3371 )
* Bump dates on sql migration scripts
* Bump date on ef migrations
---------
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com >
Co-authored-by: Vincent Salucci <26154748+vincentsalucci@users.noreply.github.com >
Co-authored-by: Vincent Salucci <vincesalucci21@gmail.com >
Co-authored-by: Shane Melton <smelton@bitwarden.com >
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com >
2023-11-01 09:30:52 +00:00
080d1088c4
[AC-1139] Addressing PR suggestions
2023-10-31 16:35:01 +00:00
b2e4a39ef0
Merge branch 'feature/flexible-collections' into flexible-collections/deprecate-custom-collection-perm
2023-10-31 14:55:19 +00:00
1800e6ffd3
Bumped version to 2023.10.0 ( #3396 )
...
Co-authored-by: bitwarden-devops-bot <106330231+bitwarden-devops-bot@users.noreply.github.com >
2023-10-31 09:32:34 -04:00
96ed67ac3f
Merge branch 'master' into feature/flexible-collections
2023-10-31 07:55:38 +10:00
c62922842f
[AC-1139] Created new CollectionOperationRequirement ReadAllWithAccess
2023-10-30 15:27:24 +00:00
44c559c723
Support for passkey registration ( #2885 )
...
* support for fido2 auth
* stub out registration implementations
* stub out assertion steps and token issuance
* verify token
* webauthn tokenable
* remove duplicate expiration set
* revert sqlproj changes
* update sqlproj target framework
* update new validator signature
* [PM-2014] Passkey registration (#2915 )
* [PM-2014] chore: rename `IWebAuthnRespository` to `IWebAuthnCredentialRepository`
* [PM-2014] fix: add missing service registration
* [PM-2014] feat: add user verification when fetching options
* [PM-2014] feat: create migration script for mssql
* [PM-2014] chore: append to todo comment
* [PM-2014] feat: add support for creation token
* [PM-2014] feat: implement credential saving
* [PM-2014] chore: add resident key TODO comment
* [PM-2014] feat: implement passkey listing
* [PM-2014] feat: implement deletion without user verification
* [PM-2014] feat: add user verification to delete
* [PM-2014] feat: implement passkey limit
* [PM-2014] chore: clean up todo comments
* [PM-2014] fix: add missing sql scripts
Missed staging them when commiting
* [PM-2014] feat: include options response model in swagger docs
* [PM-2014] chore: move properties after ctor
* [PM-2014] feat: use `Guid` directly as input paramter
* [PM-2014] feat: use nullable guid in token
* [PM-2014] chore: add new-line
* [PM-2014] feat: add support for feature flag
* [PM-2014] feat: start adding controller tests
* [PM-2014] feat: add user verification test
* [PM-2014] feat: add controller tests for token interaction
* [PM-2014] feat: add tokenable tests
* [PM-2014] chore: clean up commented premium check
* [PM-2014] feat: add user service test for credential limit
* [PM-2014] fix: run `dotnet format`
* [PM-2014] chore: remove trailing comma
* [PM-2014] chore: add `Async` suffix
* [PM-2014] chore: move delay to constant
* [PM-2014] chore: change `default` to `null`
* [PM-2014] chore: remove autogenerated weirdness
* [PM-2014] fix: lint
* Added check for PasswordlessLogin feature flag on new controller and methods. (#3284 )
* Added check for PasswordlessLogin feature flag on new controller and methods.
* fix: build error from missing constructor argument
---------
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com >
* [PM-4171] Update DB to support PRF (#3321 )
* [PM-4171] feat: update database to support PRF
* [PM-4171] feat: rename `DescriptorId` to `CredentialId`
* [PM-4171] feat: add PRF felds to domain object
* [PM-4171] feat: add `SupportsPrf` column
* [PM-4171] fix: add missing comma
* [PM-4171] fix: add comma
* [PM-3263] fix identity server tests for passkey registration (#3331 )
* Added WebAuthnRepo to EF DI
* updated config to match current grant types
* Remove ExtensionGrantValidator (#3363 )
* Linting
---------
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com >
Co-authored-by: Andreas Coroiu <andreas.coroiu@gmail.com >
Co-authored-by: Todd Martin <106564991+trmartin4@users.noreply.github.com >
Co-authored-by: Ike <137194738+ike-kottlowski@users.noreply.github.com >
Co-authored-by: Todd Martin <tmartin@bitwarden.com >
2023-10-30 09:40:06 -04:00
1053f49fb1
[SM-943] [BEEEP] Swap to SQLite in-memory for integration tests ( #3292 )
...
* Swap to sqlite in-memory for integration tests
* Fix integration tests
* Remove EF Core in-memory dependency
2023-10-27 11:13:52 -05:00
9c5f580035
Merge branch 'feature/flexible-collections' into flexible-collections/deprecate-custom-collection-perm
...
# Conflicts:
# src/Api/AdminConsole/Controllers/OrganizationUsersController.cs
# src/Core/Context/CurrentContext.cs
2023-10-27 15:06:13 +01:00
8c78fc27c2
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-10-27 13:23:55 +10:00
ad230fb6a5
[AC-1200] Admin Console code ownership - move OrganizationFeatures ( #3369 )
2023-10-26 16:47:44 -05:00
26dd8b0e47
[AC-1284] AC Team code ownership moves - Provider ( #3359 )
2023-10-26 13:38:29 -04:00
5f3d35076a
[AC-1139] Reverted changes on OrganizationService
2023-10-26 16:12:59 +01:00
c47ebedcfc
[AC-1139] Added unit tests for OrganizationService InviteUser and SaveUser with EditAssignedCollections = true
2023-10-26 14:54:36 +01:00
021eaa444c
[AC-1139] Added unit test to test setting users with EditAssignedCollections with Manage permission when saving a collection
2023-10-26 12:22:56 +01:00
9d8f6ac2c9
[AC-1139] Added unit tests for GroupAuthorizationHandler and OrganizationUserAuthorizationHandler
2023-10-26 11:24:35 +01:00
57d3abb994
[AC-1139] Fixed CollectionAuthorizationHandler unit tests
2023-10-25 21:05:54 +01:00
18592e4f0a
Merge branch 'feature/flexible-collections' into flexible-collections/deprecate-custom-collection-perm
...
# Conflicts:
# src/Api/AdminConsole/Controllers/GroupsController.cs
# src/Api/AdminConsole/Controllers/OrganizationUsersController.cs
# src/Core/Services/Implementations/OrganizationService.cs
2023-10-25 16:29:21 +01:00
e57469859c
[AC-1139] Renamed existing CollectionAuthorizationHandler to BulkCollectionAuthorizationHandler for collections and created CollectionAuthorizationHandler for single item access. Fixed unit tests and created more
2023-10-25 16:19:25 +01:00
c11ba103a2
Merge branch 'master' into feature/flexible-collections
2023-10-24 11:14:36 -07:00
9007aa6556
Fix broken test ( #3374 )
2023-10-24 08:44:37 -04:00
596e0df961
Fix: add missing namespace after merging in master
2023-10-24 11:42:04 +10:00
d91eb23b46
Merge branch 'master' into feature/flexible-collections
2023-10-24 11:23:23 +10:00
c442bae2bc
[AC-1693] Send InvoiceUpcoming Notification to Client Owners ( #3319 )
...
* Add Organization_ReadOwnerEmailAddresses SPROC
* Add IOrganizationRepository.GetOwnerEmailAddressesById
* Add SendInvoiceUpcoming overload for multiple emails
* Update InvoiceUpcoming handler to send multiple emails
* Cy's feedback
* Updates from testing
Hardened against missing entity IDs in Stripe events in the StripeEventService. Updated ValidateCloudRegion to not use a refresh/expansion for the customer because the invoice.upcoming event does not have an invoice.Id. Updated the StripeController's handling of invoice.upcoming to not use a refresh/expansion for the subscription because the invoice does not have an ID.
* Fix broken test
2023-10-23 13:46:29 -04:00
d7c544a116
[AC 1536] Breakdown The SubscriptionUpdate.cs into multiple files ( #3356 )
...
* Move sub-subscription classes to a separate files
* Refactor the sub-class to a separate files
* format whitespace
* remove directive that is unnecessary
* Remove the baseSeat class
2023-10-23 11:28:13 +01:00
cd376bee7f
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-10-23 08:47:11 +10:00
728cd1c0b5
[SM-949] Add endpoint to fetch events by service account ( #3336 )
...
* Add ability to fetch events by service account
* Extract GetDateRange into ApiHelpers util
* Add dapper implementation
* Add EF repo implementation
* Add authz handler case
* unit + integration tests for controller
* swap to read check
* Adding comments
* Fix integration tests from merge
* Enabled SM events controller for self-hosting
2023-10-19 16:57:14 -05:00
c1cf07d764
[AC-1750] AC Team code ownership moves - Groups ( #3358 )
2023-10-20 06:37:46 +10:00
37e9d70bee
AC Team code ownership moves - Api project ( #3351 )
2023-10-18 11:27:56 -04:00
d230b10f82
Fix flaky UpdateSecretsManagerSubscriptionCommandTests ( #3355 )
...
Fix flaky UpdateSubscriptionAsync_ThrowsBadRequestException_WhenOccupiedSeatsExceedNewSeatTotal
test by expressly setting SmSeat value instead of relying on autodata.
This ensures that the new smSeat value is actually different.
2023-10-18 10:00:55 -05:00
21219262a2
[PM-3779] idor allow the attacker to delete the victim domain ( #3308 )
...
* [PM-3779] Added IOrganizationDomainRepository.GetDomainByIdAndOrganizationIdAsync and SQL stored procedure
* [PM-3779] Changed GetOrganizationDomainByIdQuery to also take OrgId as a parameter. Updated existing unit tests and added new. Updated controller to match command changes
* [PM-3779] Removed type from url routes
* [PM-3779] Renamed IGetOrganizationDomainByIdAndOrganizationIdQuery to IGetOrganizationDomainByIdOrganizationIdQuery
* [PM-3779] Renamed GetOrganizationDomainByIdOrganizationIdQueryTests file and added more tests
2023-10-18 11:57:59 +01:00
cb73056c42
[AC-1654] idor allow the attacker to disable any one scim provising ( #3325 )
...
* [AC-1654] Added IOrganizationConnectionRepository.GetByIdOrganizationIdAsync and modified OrganizationConnectionsController to use it to get a connection matching both Id and OrganizationId
* [AC-1654] Fixed unit tests
2023-10-18 11:39:00 +01:00
ae18e76442
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-10-18 10:07:08 +10:00
3b049a64b8
[AC-1713] [Flexible collections] Add feature flags to server ( #3334 )
...
* Add feature flags for FlexibleCollections and BulkCollectionAccess
* Flag new routes and behaviour
---------
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com >
2023-10-18 07:16:01 +10:00
8177821e8b
[AC 1451] Refactor staticstore plans and consuming logic ( #3164 )
...
* refactor the plan and create new objects
* initial commit
* Add new plan types
* continue the refactoring by adding new plantypes
* changes for plans
* Refactoring continues
* making changes for plan
* Fixing the failing test
* Fixing whitespace
* Fix some in correct values
* Resolve the plan data
* rearranging the plan
* Make the plan more immutable
* Resolve the lint errors
* Fix the failing test
* Add custom plan
* Fix the failing test
* Fix the failing test
* resolve the failing addons after refactoring
* Refactoring
* Merge branch 'master' into ac-1451/refactor-staticstore-plans-and-consuming-logic
* merge from master
* Merge branch 'master' into ac-1451/refactor-staticstore-plans-and-consuming-logic
* format whitespace
* resolve the conflict
* Fix some pr comments
* Fixing some of the pr comments
* fixing some of the pr comments
* Resolve some pr comments
* Resolve pr comments
* Resolves some pr comments
* Resolving some or comments
* Resolve a failing test
* fix the failing test
* Resolving some pr comments
* Fix the failing test
* resolve pr comment
* add a using statement fir a failing test
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com >
2023-10-17 15:56:35 +01:00
b772784af3
[SM-896] restricting access to disabled orgs ( #3287 )
...
* restricting access to disabled orgs
* Unit Test Updates
* Update test/Api.IntegrationTest/SecretsManager/Controllers/AccessPoliciesControllerTests.cs
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com >
* Covering all test cases
* making organization enabled NOT default
---------
Co-authored-by: Thomas Avery <43214426+Thomas-Avery@users.noreply.github.com >
2023-10-16 14:29:02 +00:00
27314ac375
Add identity tests to test solution ( #3342 )
2023-10-13 14:15:11 +02:00
6bc38ac3d1
Merge branch 'master' into feature/flexible-collections
2023-10-13 15:51:44 +10:00
53f5eee215
[AC-1638] Disallow Secrets Manager for MSP-managed organizations ( #3297 )
...
* Block MSPs from creating orgs with SM
* Block MSPs from adding SM to a managed org
* Prevent manually adding SM to an MSP-managed org
* Revert "Prevent manually adding SM to an MSP-managed org"
This change is no longer required
This reverts commit 51b086243b
.
* Block provider from adding org with SM
* Update error message when adding existing org with SM to provider
* Update check to match client
* Revert "Update check to match client"
This reverts commit f195c1c1f6
.
2023-10-12 15:56:50 +01:00
79648b311e
[PM-3555] Remove ClearTracker()
( #3213 )
...
* Remove ClearTracker
* Remove from CipherRepositoryTests
2023-10-12 11:15:02 +02:00
b2af73f00f
[PM-212] Sync Organization Billing Email from Stripe Webhook ( #3305 )
...
* Add StripeFacade and StripeEventService
* Add StripeEventServiceTests
* Handle customer.updated event in StripeController
2023-10-11 15:57:51 -04:00
279d0ccf62
[AC-1669] Bug - Remove obsolete assignUserId from CollectionService.SaveAsync(...) ( #3312 )
...
* fix: remove AssignUserId from CollectionService.SaveAsync, refs AC-1669
* fix: add manage access conditional before creating collection, refs AC-1669
* fix: move access logic for create/update, fix all tests, refs AC-1669
* fix: add CollectionAccessSelection fixture, update tests, update bad reqeuest message, refs AC-1669
* fix: format, refs AC-1669
* fix: update null params with specific arg.is null checks, refs Ac-1669
* fix: update attribute class name, refs AC-1669
2023-10-05 15:13:28 -05:00
a3f554a34e
[AC-1646] Rename LimitCollectionCdOwnerAdmin column ( #3300 )
...
* Rename LimitCollectionCdOwnerAdmin -> LimitCollectionCreationDeletion
* Rename and bump migration script
2023-09-27 07:37:34 +10:00
5d431adbd4
[AC-1174] Bulk Collection Management ( #3229 )
...
* [AC-1174] Update SelectionReadOnlyRequestModel to use Guid for Id property
* [AC-1174] Introduce initial bulk-access collection endpoint
* [AC-1174] Introduce BulkAddCollectionAccessCommand and validation logic/tests
* [AC-1174] Add CreateOrUpdateAccessMany method to CollectionRepository
* [AC-1174] Add event logs for bulk add collection access command
* [AC-1174] Add User_BumpAccountRevisionDateByCollectionIds and database migration script
* [AC-1174] Implement EF repository method
* [AC-1174] Improve null checks
* [AC-1174] Remove unnecessary BulkCollectionAccessRequestModel helpers
* [AC-1174] Add unit tests for new controller endpoint
* [AC-1174] Fix formatting
* [AC-1174] Remove comment
* [AC-1174] Remove redundant organizationId parameter
* [AC-1174] Ensure user and group Ids are distinct
* [AC-1174] Cleanup tests based on PR feedback
* [AC-1174] Formatting
* [AC-1174] Update CollectionGroup alias in the sproc
* [AC-1174] Add some additional comments to SQL sproc
* [AC-1174] Add comment explaining additional SaveChangesAsync call
---------
Co-authored-by: Thomas Rittson <trittson@bitwarden.com >
2023-09-26 09:30:07 -07:00
2c7d02dcbb
Merge branch 'master' into feature/flexible-collections
2023-09-26 10:40:26 +10:00
90d600db9d
[PM-2961] Upgrade Braintree ( #3206 )
...
* Upgraded Braintree to 5.19.0
* Force evaluate of nuget packages
---------
Co-authored-by: cyprain-okeke <108260115+cyprain-okeke@users.noreply.github.com >
2023-09-20 14:11:29 -04:00
9f5fec67a0
Merge remote-tracking branch 'origin/master' into feature/flexible-collections
2023-09-19 13:12:59 +10:00
34dfdc53aa
[AC-1125] Enforce org setting for creating/deleting collections ( #3241 )
...
* [AC-1117] Add manage permission (#3126 )
* Update sql files to add Manage permission
* Add migration script
* Rename collection manage migration file to remove duplicate migration date
* Migrations
* Add manage to models
* Add manage to repository
* Add constraint to Manage columns
* Migration lint fixes
* Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
* Add missing manage fields
* Add 'Manage' to UserCollectionDetails
* Use CREATE OR ALTER where possible
* [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145 )
* feat: update org table with new column, write migration, refs AC-1374
* feat: update views with new column, refs AC-1374
* feat: Alter sprocs (org create/update) to include new column, refs AC-1374
* feat: update entity/data/request/response models to handle new column, refs AC-1374
* feat: update necessary Provider related views during migration, refs AC-1374
* fix: update org create to default new column to false, refs AC-1374
* feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
* fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: add ef migrations to reflect mssql changes, refs AC-1374
* fix: dotnet format, refs AC-1374
* feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
* feat: created collection auth handler/operations, added LimitCollectionCdOwnerAdmin to CurrentContentOrganization, refs AC-1125
* feat: create vault service collection extensions and register with base services, refs AC-1125
* feat: deprecated CurrentContext.CreateNewCollections, refs AC-1125
* feat: deprecate DeleteAnyCollection for single resource usages, refs AC-1125
* feat: move service registration to api, update references, refs AC-1125
* feat: add bulk delete authorization handler, refs AC-1125
* feat: always assign user and give manage access on create, refs AC-1125
* fix: updated CurrentContextOrganization type, refs AC-1125
* feat: combined existing collection authorization handlers/operations, refs AC-1125
* fix: OrganizationServiceTests -> CurrentContentOrganization typo, refs AC-1125
* fix: format, refs AC-1125
* fix: update collection controller tests, refs AC-1125
* fix: dotnet format, refs AC-1125
* feat: removed extra BulkAuthorizationHandler, refs AC-1125
* fix: dotnet format, refs AC-1125
* fix: change string to guid for org id, update bulk delete request model, refs AC-1125
* fix: remove delete many collection check, refs AC-1125
* fix: clean up collection auth handler, refs AC-1125
* fix: format fix for CollectionOperations, refs AC-1125
* fix: removed unnecessary owner check, add org null check to custom permission validation, refs AC-1125
* fix: remove unused methods in CurrentContext, refs AC-1125
* fix: removed obsolete test, fixed failling delete many test, refs AC-1125
* fix: CollectionAuthorizationHandlerTests fixes, refs AC-1125
* fix: OrganizationServiceTests fix broken test by mocking GetOrganization, refs AC-1125
* fix: CollectionAuthorizationHandler - remove unused repository, refs AC-1125
* feat: moved UserId null check to common method, refs AC-1125
* fix: updated auth handler tests to remove dependency on requirement for common code checks, refs AC-1125
* feat: updated conditionals/comments for create/delete methods within colleciton auth handler, refs AC-1125
* feat: added create/delete collection auth handler success methods, refs AC-1125
* fix: new up permissions to prevent excessive null checks, refs AC-1125
* fix: remove old reference to CreateNewCollections, refs AC-1125
* fix: typo within ViewAssignedCollections method, refs AC-1125
---------
Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com >
2023-09-18 17:02:53 -05:00