using System.Security.Claims; using Bit.Api.Vault.AuthorizationHandlers.Collections; using Bit.Core; using Bit.Core.Context; using Bit.Core.Entities; using Bit.Core.Enums; using Bit.Core.Exceptions; using Bit.Core.Models.Data; using Bit.Core.Repositories; using Bit.Core.Test.AutoFixture; using Bit.Core.Test.Vault.AutoFixture; using Bit.Test.Common.AutoFixture; using Bit.Test.Common.AutoFixture.Attributes; using Microsoft.AspNetCore.Authorization; using NSubstitute; using Xunit; namespace Bit.Api.Test.Vault.AuthorizationHandlers; [SutProviderCustomize] [FeatureServiceCustomize(FeatureFlagKeys.FlexibleCollections)] public class CollectionAuthorizationHandlerTests { [Theory, CollectionCustomization] [BitAutoData(OrganizationUserType.User, false, true)] [BitAutoData(OrganizationUserType.Admin, false, false)] [BitAutoData(OrganizationUserType.Owner, false, false)] [BitAutoData(OrganizationUserType.Custom, true, false)] [BitAutoData(OrganizationUserType.Owner, true, true)] public async Task CanManageCollectionAccessAsync_Success( OrganizationUserType userType, bool editAnyCollection, bool manageCollections, SutProvider sutProvider, ICollection collections, ICollection collectionDetails, CurrentContextOrganization organization) { var actingUserId = Guid.NewGuid(); foreach (var collectionDetail in collectionDetails) { collectionDetail.Manage = manageCollections; } organization.Type = userType; organization.Permissions.EditAnyCollection = editAnyCollection; var context = new AuthorizationHandlerContext( new[] { CollectionOperations.ModifyAccess }, new ClaimsPrincipal(), collections); sutProvider.GetDependency().UserId.Returns(actingUserId); sutProvider.GetDependency().GetOrganization(organization.Id).Returns(organization); sutProvider.GetDependency().GetManyByUserIdAsync(actingUserId).Returns(collectionDetails); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasSucceeded); } [Theory, CollectionCustomization] [BitAutoData(OrganizationUserType.User, false, false)] [BitAutoData(OrganizationUserType.Admin, false, true)] [BitAutoData(OrganizationUserType.Owner, false, true)] [BitAutoData(OrganizationUserType.Custom, true, true)] public async Task CanCreateAsync_Success( OrganizationUserType userType, bool createNewCollection, bool limitCollectionCreateDelete, SutProvider sutProvider, ICollection collections, CurrentContextOrganization organization) { var actingUserId = Guid.NewGuid(); organization.Type = userType; organization.Permissions.CreateNewCollections = createNewCollection; organization.LimitCollectionCreationDeletion = limitCollectionCreateDelete; var context = new AuthorizationHandlerContext( new[] { CollectionOperations.Create }, new ClaimsPrincipal(), collections); sutProvider.GetDependency().UserId.Returns(actingUserId); sutProvider.GetDependency().GetOrganization(organization.Id).Returns(organization); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasSucceeded); } [Theory, CollectionCustomization] [BitAutoData(OrganizationUserType.User, false, false, true)] [BitAutoData(OrganizationUserType.Admin, false, true, false)] [BitAutoData(OrganizationUserType.Owner, false, true, false)] [BitAutoData(OrganizationUserType.Custom, true, true, false)] public async Task CanDeleteAsync_Success( OrganizationUserType userType, bool deleteAnyCollection, bool limitCollectionCreateDelete, bool manageCollections, SutProvider sutProvider, ICollection collections, ICollection collectionDetails, CurrentContextOrganization organization) { var actingUserId = Guid.NewGuid(); foreach (var collectionDetail in collectionDetails) { collectionDetail.Manage = manageCollections; } organization.Type = userType; organization.Permissions.DeleteAnyCollection = deleteAnyCollection; organization.LimitCollectionCreationDeletion = limitCollectionCreateDelete; var context = new AuthorizationHandlerContext( new[] { CollectionOperations.Delete }, new ClaimsPrincipal(), collections); sutProvider.GetDependency().UserId.Returns(actingUserId); sutProvider.GetDependency().GetOrganization(organization.Id).Returns(organization); sutProvider.GetDependency().GetManyByUserIdAsync(actingUserId).Returns(collectionDetails); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasSucceeded); } [Theory, BitAutoData, CollectionCustomization] public async Task HandleRequirementAsync_MissingUserId_Failure( SutProvider sutProvider, ICollection collections) { var context = new AuthorizationHandlerContext( new[] { CollectionOperations.Create }, new ClaimsPrincipal(), collections ); // Simulate missing user id sutProvider.GetDependency().UserId.Returns((Guid?)null); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasFailed); sutProvider.GetDependency().DidNotReceiveWithAnyArgs(); } [Theory, BitAutoData, CollectionCustomization] public async Task HandleRequirementAsync_TargetCollectionsMultipleOrgs_Failure( SutProvider sutProvider, IList collections) { var actingUserId = Guid.NewGuid(); // Simulate a collection in a different organization collections.First().OrganizationId = Guid.NewGuid(); var context = new AuthorizationHandlerContext( new[] { CollectionOperations.Create }, new ClaimsPrincipal(), collections ); sutProvider.GetDependency().UserId.Returns(actingUserId); var exception = await Assert.ThrowsAsync(() => sutProvider.Sut.HandleAsync(context)); Assert.Equal("Requested collections must belong to the same organization.", exception.Message); sutProvider.GetDependency().DidNotReceiveWithAnyArgs().GetOrganization(default); } [Theory, BitAutoData, CollectionCustomization] public async Task HandleRequirementAsync_MissingOrg_Failure( SutProvider sutProvider, ICollection collections) { var actingUserId = Guid.NewGuid(); var context = new AuthorizationHandlerContext( new[] { CollectionOperations.Create }, new ClaimsPrincipal(), collections ); sutProvider.GetDependency().UserId.Returns(actingUserId); sutProvider.GetDependency().GetOrganization(Arg.Any()).Returns((CurrentContextOrganization)null); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasFailed); } [Theory, BitAutoData, CollectionCustomization] public async Task CanManageCollectionAccessAsync_MissingManageCollectionPermission_Failure( SutProvider sutProvider, ICollection collections, ICollection collectionDetails, CurrentContextOrganization organization) { var actingUserId = Guid.NewGuid(); foreach (var collectionDetail in collectionDetails) { collectionDetail.Manage = true; } // Simulate one collection missing the manage permission collectionDetails.First().Manage = false; // Ensure the user is not an owner/admin and does not have edit any collection permission organization.Type = OrganizationUserType.User; organization.Permissions.EditAnyCollection = false; var context = new AuthorizationHandlerContext( new[] { CollectionOperations.ModifyAccess }, new ClaimsPrincipal(), collections ); sutProvider.GetDependency().UserId.Returns(actingUserId); sutProvider.GetDependency().GetOrganization(Arg.Any()).Returns(organization); sutProvider.GetDependency().GetManyByUserIdAsync(actingUserId).Returns(collectionDetails); await sutProvider.Sut.HandleAsync(context); Assert.True(context.HasFailed); sutProvider.GetDependency().ReceivedWithAnyArgs().GetOrganization(default); await sutProvider.GetDependency().ReceivedWithAnyArgs() .GetManyByUserIdAsync(default); } }